Kurt
e5943e3c92
Clamp generation fetch for battleversion
2021-01-29 09:56:31 -08:00
Kurt
3a6bff11c9
Fix relearn move check for gen6+
...
Probably should rewrite some sections of the current move verifier; lots of old code with illogical paths
2021-01-28 18:08:13 -08:00
Kurt
e8fa28794c
Make PIDIV lighter weight, readonly
2021-01-27 16:52:04 -08:00
Kurt
6c1b6a269d
Pass gender when creating static entry
2021-01-27 12:29:49 -08:00
Kurt
7497e08f9b
Template fields with species for save file
...
Fix PP since gen8 has pound at 35 rather than 40
2021-01-27 08:40:37 -08:00
CanoeHope
8144a5add2
Add HGSS Blue Card Points Event Constant ( #3135 )
...
* Update const_hgss_en.txt
* Update const_hgss_es.txt
* Update const_hgss_ko.txt
* Update const_hgss_zh.txt
2021-01-26 22:13:30 -08:00
Kurt
4bbe9dec96
Update FormVerifier.cs
2021-01-26 16:23:26 -08:00
sora10pls
1be20be877
Fix GO Shiny permissions
2021-01-26 13:35:57 -05:00
Kurt
511797c1f9
Fix gen4 hm indexing
2021-01-25 20:58:56 -08:00
CanoeHope
94d6ce42bd
Add and update some Gen III and IV Event Flags ( #3134 )
...
* Update const_frlg_en.txt
* Update const_frlg_es.txt
* Update flags_dp_en.txt
* Update flags_dp_es.txt
* Update flags_dp_ja.txt
* Update flags_dp_ko.txt
* Update flags_dp_zh.txt
* Update flags_pt_en.txt
* Update flags_pt_es.txt
* Update flags_pt_ja.txt
* Update flags_pt_ko.txt
* Update flags_pt_zh.txt
* Update flags_hgss_en.txt
* Update flags_hgss_es.txt
* Update flags_hgss_ja.txt
* Update flags_hgss_ko.txt
* Update flags_hgss_zh.txt
* Update const_hgss_en.txt
* Update const_hgss_es.txt
* Update const_hgss_ko.txt
2021-01-23 16:52:55 -08:00
Kurt
b1c3526618
Update WC8.cs
2021-01-23 11:43:56 -08:00
Kurt
f8c8a1b0e0
Trim out inaccessible headbutt tables
...
57.1KB => 53.6KB (-3.5KB)
Refer to dumper project for filtering logic
3642bfaf9d
2021-01-23 11:33:43 -08:00
Kurt
edfb8fc2ff
Add TID/SID fetch for Battle Revolution
...
Can unlock boxes by setting a nonzero TID/SID
https://projectpokemon.org/home/forums/topic/36582-pok%C3%A9mon-battle-revolution-save-research-thread/?do=findComment&comment=221812
ty Akunoko
2021-01-22 22:55:55 -08:00
Kurt
68673cf671
Flag all marks, unlike prior commit
...
oops, unnecessary simplification
2021-01-22 21:17:41 -08:00
Kurt
acfbef6cfa
Disallow raids matching if has mark
...
Closes #3133
not an ideal solution, but the encounter matching API is kinda limited in deferred-invalid vs deferred-notIdeal.
probably need to unify the match logic and generators so they can cache one secondary-check invalid
2021-01-22 20:28:54 -08:00
Kurt
5f8e2b13c5
Simplify headbutt tree pivot check
...
See the EncounterSlotDumper with the memoization logic & json tree listing.
Simplifies things a lot, and improves checking speed. Unreachable trees are now treated the same as no-trees maps.
ez 1.5KB reduction in file size :P
2021-01-22 19:20:18 -08:00
Kurt
5abd61816f
Add gamesync interface for gen7
...
oops; gamesync ID now shows up as intended
2021-01-22 19:04:54 -08:00
Kurt
6d0da504d5
Fix Tree Area list from Whirl Islands (0x1F) to Route 42 (0x22)
...
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=264118
Thanks Tlili !
2021-01-21 22:21:13 -08:00
Kurt
944ff107b0
Add new distribution raids
2021-01-21 16:30:07 -08:00
Kurt
8546ecaf46
Fix suggested moveset
2021-01-21 09:27:33 -08:00
Kurt
06e6242944
Update SAV4BR.cs
...
Uses Big Endian unicode for savefile strings, but pkm strings are big-endian-g4
2021-01-20 22:13:59 -08:00
Kurt
ceb14c8468
Add consistent ctrl/alt modifiers for IV/EV/AV
...
Closes #3132
2021-01-20 22:09:25 -08:00
Kurt
803b8675fe
Rework batrev current slot handling
...
Show all slots even if they're uninitialized. Empty first slots but present second slots caused errors on init.
2021-01-20 20:29:26 -08:00
Kurt
4c49d489a8
Update SAV_Inventory.cs
2021-01-20 20:01:59 -08:00
Kurt
46b988b6fa
Remove unused checkbox
2021-01-20 17:06:37 -08:00
Kurt
fbc089e7eb
Minor tweaks
...
Remove gen3 egg location hashset; only paths that reach it are for hatched eggs or current breed-eggs. Check breed eggs with the singular met location.
Simplify some logic flow
2021-01-20 12:37:51 -08:00
Kurt
9964c91dc6
Remove static init of yancy/curtis names
...
static constructor ran after the initializer; flip it and remove the unnecessary all-set
2021-01-20 12:36:46 -08:00
CanoeHope
121ae9b611
Rename SWSH blocks and update Chinese HGSS Event Constant ( #3131 )
...
* Update TrainerCard8.cs
* Update SaveBlockAccessor8SWSH.cs
* Update const_hgss_zh.txt
2021-01-19 12:46:54 -08:00
Kurt
d805167e7c
Save battle version value on value change
2021-01-18 18:18:42 -08:00
CanoeHope
b117c269fe
Add some HGSS Event Flags and update existing ones ( #3129 )
...
* Update const_hgss_en.txt
* Update const_hgss_ko.txt
* Update const_hgss_es.txt
* Update const_hgss_zh.txt
* Update flags_hgss_en.txt
* Update flags_hgss_es.txt
* Update flags_hgss_ja.txt
* Update flags_hgss_ko.txt
* Update flags_hgss_zh.txt
* Update const_hgss_ko.txt
2021-01-18 09:04:03 -08:00
Kurt
680e8b711d
Add some code analysis for try-return with nullable out
2021-01-17 00:05:07 -08:00
Kurt
bfd948ee2b
Update pget binaries, check gender
...
yay single gender availability! (frillish/jellicent being male only)
2021-01-16 18:29:27 -08:00
Kurt
b5c30193fa
Set initial capacity for stringbuilder to reduce reallocation
...
Default capacity is 16 so it's rarely an issue, but sometimes we don't need that much.
Update xmldoc for more clarity
2021-01-16 17:31:05 -08:00
Kurt
c31285fd6d
Dump csv async
...
Skip Sprite column completely
2021-01-16 17:25:55 -08:00
Kurt
03ae3d470c
Simplify value passing
...
buffers are fixed size matching the StringLength anyways; don't bother with confusing max length passing when the buffer is obvious
2021-01-16 13:56:37 -08:00
Kurt
3c42978afa
Use IndexOf instead of FindIndex when possible
2021-01-16 12:47:02 -08:00
Kurt
de418e8db2
Simplify string termination handling
...
If 0x50,00.. terminated, treat differently than 0x50.. terminated buffer
2021-01-16 12:43:17 -08:00
Kurt
bb1d23e112
Minor clean
...
Use some enums, save a few virtual/static fetches
2021-01-16 12:01:40 -08:00
Lusamine
15da92f9bc
Document weather for static encounters ( #3127 )
...
This only matches the weather table with the Pokemon and does not fully
account for whether a location can spawn a particular weather.
Additional minor changes:
- Adds ScriptedNoMarks to Regis and Glimwood Tangle static encounters
- Corrects a few version-specific Pokemon such as Ludicolo/Shiftry
- Removes erroneous encounters such as Milotic in East/West Lake Axewell
- Removes an unused Motostoke Stadium encounter
2021-01-16 09:31:21 -08:00
Kurt
8eb499c4d0
Update EncounterStatic5.cs
...
Use base deferral method which only checks fateful flag.
2021-01-14 22:51:01 -08:00
Kurt
613e6db744
Use StringConverter api consistently; use stringbuilder when possible
...
Retain a stringbuilder to mutate the string rather than finalizing temporary strings
yields some speed improvements (less gen0 string objects allocated)
2021-01-14 22:50:13 -08:00
Kurt
3816d25f7b
Condense some expressions
...
Simplify legal held item array creation, reduce linq usage in startup
Discard unreleased item array references; no need to retain after startup
2021-01-12 22:38:18 -08:00
Kurt
c32b38a53c
Minor annotation tweaks
...
no functional change
2021-01-12 22:26:08 -08:00
Kurt
890ce9ea4e
Simplify some expressions
...
Search array for index rather than loop and check; gives early-break too -- was O(n) now is O(<~n)
2021-01-12 22:25:30 -08:00
Kurt
e62ea685c3
Make SpeciesConverter methods visible (class)
...
4 public methods; shouldn't need these except for fringe scenarios.
2021-01-11 17:52:02 -08:00
Kurt
2d3d6b49da
Force bad vc1 (should be vc2) to be vc2 templates
2021-01-11 17:47:25 -08:00
Kurt
621e708d23
Minor clean
2021-01-10 18:15:33 -08:00
CanoeHope
291ec5b073
Added 4 FRLG flags ( #3124 )
...
* Update flags_frlg_en.txt
* Update flags_frlg_es.txt
* Update flags_frlg_zh.txt
2021-01-10 17:17:21 -08:00
Kurt
6566b0ed1f
Add Pokedex flag properties
...
Closes #2954 ; can set directly from propertygrid already, but might as well clean things up a little bit to match the disassembly logic.
Open the simple editor center parent rather than next-form-position
2021-01-09 23:27:22 -08:00
Kurt
76ae6b2b3d
Minor tweaks
...
Disallow OT handling when originated gen is 1/2
Cast the input not the const
Hide HighestGameID (Use the method instead)
2021-01-09 21:25:28 -08:00