Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 00:13:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
7359 commits 3 branches 76 tags 119 MiB
Commit graph

3440 commits

Author SHA1 Message Date
Kurt
3b5bcc9dad Update comments with context/clarification 
No functional change, the order of switch case won't matter
 2020-10-24 23:08:39 -07:00
Kurt
5326067c8d Return old Chinese species name for Gen7 fetch 
Add documentation comments, because changing species names is so weird.

ty anubis for confirming the game resets the old-nickname to new-nickname even without transferring to HOME.

Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
 2020-10-24 22:28:39 -07:00
Kurt
b492d93f39 Re-add unavailable split evolution cases 
Diff to compare binaries for split evo cases, diff output below:
025: Pikachu
08 00 53 00 1A 00 00 00 08 00 53 00 1A 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
08 00 53 00 1A 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
102: Exeggcute
08 00 55 00 67 00 00 00 08 00 55 00 67 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
08 00 55 00 67 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
104: Cubone
04 00 00 00 69 00 00 1C 04 00 00 00 69 00 01 1C 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
04 00 00 00 69 00 00 1C 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
109: Koffing
04 00 00 00 6E 00 01 23 04 00 00 00 6E 00 00 23 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
04 00 00 00 6E 00 01 23 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
439: MimeJr
15 00 66 00 7A 00 00 00 15 00 66 00 7A 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
15 00 66 00 7A 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 2020-10-24 21:32:48 -07:00
Kurt
90b760b9bf Unban porygon capture-breed ball for eggs 
Shows up in dynamax adventures for capture

Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-24 20:46:43 -07:00
Kurt
babf5a48ca Bounds check species name on report summary 2020-10-24 20:22:08 -07:00
Kurt
6079f53d9a Handle unfused Calyrex with fused-TR flags 
Thanks CC6174 # 4880 (Discord) !
 2020-10-24 19:10:59 -07:00
Kurt
7e8a1a58d1 Set gender on pokdex registration 
Closes #3045 , ty @xXAquaNightXx !
 2020-10-24 15:42:17 -07:00
Kurt
3e1bc1f59d Show extra slots in the "Other" tab 2020-10-24 14:57:53 -07:00
Kurt
919f3f2893 Update RaidSpawnList8.cs 
Co-Authored-By: Leanny <1884062+Leanny@users.noreply.github.com>
 2020-10-24 12:38:33 -07:00
ReignOfComputer
29408e3ada
Static Encounter Updates (#3043) 2020-10-24 12:33:14 -07:00
Kurt
1d596225e5 Update 20.10.24 - Crown Tundra 
Update mgdb with latest from the Events Gallery.

Handle nullable warnings for release build.
 2020-10-24 11:59:35 -07:00
Kurt
5cdf8db912 Update GUI localization files with latest available strings 2020-10-24 11:42:29 -07:00
Kurt
0c8966796e Add wild area strong encounters for Crown Tundra 
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com>
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-10-24 11:24:01 -07:00
Kurt
2e4af1afc5 Update legality comparisons for Crown Tundra 
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-24 11:16:01 -07:00
Kurt
0741c8c035 Handle Calyrex TR bug 
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
 2020-10-24 11:12:25 -07:00
Kurt
9b2d7c0341 Minor tweak 
no functional change, just use Generation instead of recomputing
 2020-10-24 11:11:53 -07:00
Kurt
5fa4ddd4a2 Update internal data sources for Crown Tundra 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
 2020-10-24 11:11:05 -07:00
Kurt
8a2a25fde1 Update data structures for Crown Tundra 
Adds a wild area Raid den detail editor like mainland/armor raids.
 2020-10-24 11:09:29 -07:00
Kurt
799dbde1a2 Add Nest Data for Crown Tundra 
Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
 2020-10-24 11:06:05 -07:00
Kurt
fe433f3859 Update Legality Binaries for Crown Tundra 
Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
 2020-10-24 10:54:19 -07:00
Kurt
24bd796302 Fix erroneous legality message with 0IV 
Revised string now uses string format, will be in the new localization text update.
 2020-10-24 10:52:22 -07:00
Kurt
c29f5fe28b Update Game Localizations for Crown Tundra 2020-10-24 10:49:03 -07:00
Kurt
8c4b7e9060 Prefer form match for suggested encounters 
Closes #3038
 2020-10-19 11:54:59 -07:00
Kurt
3dd47dc898 Check ability bit for gen3 based on PID 2020-10-19 11:36:57 -07:00
Kurt
d35766649b Fix initial blank sav language load 
(uint)-1 <= max now returns false, causing it to fall back to english.
 2020-10-18 19:59:22 -07:00
Kurt
14a678b57d Revise save detect logic flow 
Double-Clicking SAV tab no longer hides any error message; now shows it like the auto-detect would.

Move high-level detection method to Core
 2020-10-18 19:49:46 -07:00
Kurt
83171ab133 Change shininess check 
Encounter definitions should be marked as Never Shiny or not in their definition, rather than assuming
 2020-10-18 16:05:01 -07:00
Kurt
cce4707604
Enable nullable for winforms csproj (#3037) 
Handle all warnings
obviously the usage of null! could potentially be avoided if the object init wasn't such garbage, but here we are with years of old junk and lack of abstraction in the GUI project
 2020-10-18 11:02:39 -07:00
Kurt
a4baec9939 Check shiny state for GB Era events 2020-10-18 10:57:18 -07:00
ShadowMario3
f6476a4737
Add Gen 1 North American Mew Events (#3036) 2020-10-18 10:01:55 -07:00
Kurt
bfb9815782 Add PID generating loop for criteria nature 2020-10-18 10:00:44 -07:00
Kurt
7a01b1249c Minor clean 
Handle more messages, add more xmldoc
 2020-10-18 09:43:41 -07:00
Kurt
6239f59b9d Inline checksum logic for gen3, simplify else case 2020-10-18 09:16:52 -07:00
Kurt
c09fb9a0ec Simplify "Flag" field in move source tracking 2020-10-17 13:40:12 -07:00
XxPhoenix1996xX
6f683ba618
Update LegalityCheckStrings_es.txt (#3033) 2020-10-17 07:58:07 -07:00
Kurt
38b03a42b6 Fix hide flag get/set 
Closes #3030
 2020-10-16 16:12:42 -07:00
Kurt
1bd3ec79cf Misc tweaks for suggesting moves when IsEgg 
Closes #3032

Don't suggest tutor moves for current moves if it is an egg
 2020-10-14 18:55:30 -07:00
Kurt
e984f71d82 Fix PID mutation for VC shiny transfers 2020-10-13 22:43:43 -07:00
Kurt
2e8586f364 Read swarm slots correctly 2020-10-13 15:37:18 -07:00
Kurt
367859c536 Make MoveEgg / MoveTM internal methods public 
Closes #3031
 2020-10-13 11:22:13 -07:00
Kurt
7b6f30b779 Handle overflow case 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-12 14:37:08 -07:00
Kurt
a71940bf75 Update CaptureRecords.cs 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-12 14:34:44 -07:00
Kurt
0a6534a208 Extend individual transfer count to 999mil 
Closes #3028
Thanks @CarlosofKalos !

Setting 9999 for both on Rattata; capturing the 10,000th didn't increment, but transferring the 10,000th did.

Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-12 14:16:55 -07:00
Kurt
1524093099 Revise g5 pid bit check for forced PID statics 
Closes #3027

Roamers: Get PID generated externally
NPokemon: Get PID from a fixed value
Forced (Anti)Shiny: Get PID altered

Thanks @LegoFigure11 && Princess Emily (discord 4650) !
 2020-10-12 11:04:29 -07:00
Kurt
3b4fd49af9 Catch any exception, show message in result 2020-10-12 10:42:26 -07:00
Kurt
d66c406751 Update SAV1StadiumJ.cs 2020-10-10 15:28:34 -07:00
Kurt
f821d698fe Update SAV1StadiumJ.cs 2020-10-10 15:11:02 -07:00
Kurt
2e82636f1e Fix slot writes 2020-10-10 14:59:51 -07:00
Kurt
dabdb31c74 Placeholder empty items 2020-10-10 14:18:08 -07:00
Kurt
ea81bb2c1e Add swsh items based on DLC1 metadata 2020-10-10 14:14:02 -07:00
Kurt
7132750c9b Placeholder crown tundra logic 
To be updated:
- Tables8: magic numbers for maximums
- IGigantamax: any new gigantamax forms?
- FormConverter: any new forms? (calyrex)
 2020-10-10 13:14:32 -07:00
Kurt
078322f146 Fix logic to fix a broken raid test 2020-10-10 12:59:31 -07:00
Kurt
b97bee4412 Use correct filesize reference 2020-10-10 12:50:57 -07:00
Kurt
a0a8dd0f91
Handle Ability Patch changed abilities (#3024) 
Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability.

Per the description, it goes 1/2=>H, not the other way around.

Verify ability bit first, as mystery gift case handling skips the bit check logic :P
 2020-10-10 12:30:57 -07:00
Lusamine
e6e3166f13
Add Comfey from Honeycalm Island (#3023) 2020-10-10 10:07:17 -07:00
ShadowMario3
ba4eadfde9
Add location for Stadium 2 Events (#3022) 
* Fix game version for International Gen 2 events

* Add Stadium 2 Event location
 2020-10-10 08:13:54 -07:00
Kurt
7bb51f4da2 Update 20.10.10 
Update event database with latest from the event gallery repo :)

This is the last release prior to any release for Crown Tundra.
 2020-10-10 00:30:21 -07:00
Kurt
944c47326e Exclude unobtainable SOS encounters 
Rather than do backtracking logic to see if the slot can be yielded, don't acknowledge the slot exists if it can't be yielded.
See pk3DS commit where we check EscapeRate for the base wild slot prior to adding it to the exported slot list.
 2020-10-10 00:29:53 -07:00
Kurt
79f60d2236
Update SAV1Stadium.cs 2020-10-09 22:11:32 -07:00
Kurt
bb65f2d2c2 Show trainer name&id for registered Stadium teams in dropdown 2020-10-09 20:31:13 -07:00
Kurt
6b1fff05bd Revise gen6/7 HA banlist to account for altforms 2020-10-09 20:04:09 -07:00
Kurt
20bb2c6a49 Add some species to HA banlists (same as regular) 
Gen6/7 have some species that can't be obtained with A4. Kinda flew under the radar due to their HA being the same as the other abilities.
 2020-10-09 17:09:07 -07:00
Kurt
dfbafee506 Add call rate check for SOS hidden ability 
Probably could just yeet the encounter data for these impossible-to-reach SOS's since they're duplicate with the non-SOS slots, but whatever.
 2020-10-09 15:38:23 -07:00
Kurt
945ef24142 Add SK2 to batch editor supported types 
Could do it via reflection but ehh
 2020-10-09 14:44:12 -07:00
Kurt
706618d331 Force Hidden Power IVs for format2 imports 
Closes #3019
 2020-10-09 09:52:29 -07:00
Matt
a0d97f6f89
Unban GO Shiny Vulpix (#3020) 
Autumn Event 2020
 2020-10-09 08:27:48 -07:00
Kurt
9d21e5acdd Add GUI for Capture Records 
Accessible from Pokedex window
ur welcome matt
 2020-10-08 18:06:29 -07:00
ShadowMario3
559ec76812
Fix game version for International Gen 2 events (#3018) 2020-10-08 15:57:19 -07:00
Kurt
7cb484834c Handle max possible level for transferred & evolved-to-new-species 
A Gen3 level 26 sylveon with a met level of 25 in Generation 8:
Transferred as Eevee at level 25, and leveled up to 26=>Sylveon
If we use met_level (25), we need to decrease 1 as we evolve. No, use Current Level and ensure the max isn't above the bare minimum (met level)
 2020-10-08 15:35:50 -07:00
Kurt
804b85ea33 Add CaptureRecord block interaction 
No GUI

Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
 2020-10-08 15:28:25 -07:00
Kurt
3686ee9ec4 Set suggested Encounter Type on Met Location click too 
Closes #3010
 2020-10-08 15:01:23 -07:00
Kurt
ea9076ad4c Account for revised evolution conditions for gen4 new-evos in gen8+ 2020-10-08 14:28:34 -07:00
Kurt
9e4ec32e94 Revise nickname check; language-source retained in gen8+ 2020-10-08 14:14:59 -07:00
Kurt
b4eeaf847c Disallow lang-traded eggs mismatching nickname on gen8+ 
Starting in Generation 8, hatched language-traded eggs will take the Language from the trainer that hatched it.
Transferring from Gen7->Gen8 realigns the Nickname string to the Language, if not nicknamed.
 2020-10-08 14:01:36 -07:00
Kurt
6efe279ffe Refresh nickname on transfer 
Mimics official behavior

Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
 2020-10-08 14:00:17 -07:00
Kurt
478cb33788 Unshorten parameter names 
lang->language
nick->nickname
 2020-10-08 13:59:58 -07:00
Kurt
0de76b57b1 Handle incorrect bred stunfisk local form value 
The game uses 0x5E if 0x5A+everstone, otherwise it uses 0x58
For determining the seed species-form, we want to use everstone breeds as that resolves to the correct species-form values.

Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Marty-D <1645989+Marty-D@users.noreply.github.com>
 2020-10-08 13:12:25 -07:00
ShadowMario3
482dbf0b17
Update Encounters2.cs (#3017) 
Fix OT for PCNY eggs
 2020-10-08 08:32:18 -07:00
ShadowMario3
9516458491
Changed es1e to allow multi-OT (#3016) 
* es1e allows multi-OT, merged Stadium Psyduck OTs, added Yoshira Mew

* fixed spacing on Gen 1 event OTs
 2020-10-08 07:10:10 -07:00
ShadowMario3
7aac80769b
Update Encounters2.cs (#3015) 
Met + Current level data for non-Egg PCNY Pokémon and Egg legality for PCNY Pokémon fixed.
 2020-10-07 18:42:14 -07:00
Kurt
e3ef9bbbff Add current level property for met:X current:Y 2020-10-07 15:35:12 -07:00
Kurt
dad01cb522 Check egg state, reduce verbosity for language type 2020-10-07 15:28:58 -07:00
ShadowMario3
a81e675d26
Update Encounters2.cs (#3014) 
Added the remaining PCNY events. Still need to fix shiny Pokemon where Met Level is 5 but current level is 40, 50, or 70 depending on Pokemon).
 2020-10-07 11:43:34 -07:00
Kurt
5d40009a0c Add multi-OT for es2e, apply special details on enc->pkm 2020-10-07 10:36:28 -07:00
Kurt
61dc9a45ae Revise Shadow state detection 
Closes #3012
 2020-10-06 22:36:27 -07:00
ShadowMario3
4bae0e823a
Update Encounters2.cs (#3013) 
Started to add some Gen 2 PCNY Event Pokemon and fixed Stadium 2 events.
 2020-10-06 22:12:05 -07:00
Kurt
6616996905 Relocate N OT logic 
Make Legal.cs not care about encounter data :)
 2020-10-06 20:09:14 -07:00
Kurt
fe7a4df17e Clean out some gb era version flagging 2020-10-06 20:05:38 -07:00
Kurt
6e1cbfcfe5 Split GB event types and segregate per VC/GB 
Handle yielding in the moveset generator as well

Future commits will trim down unused values/abstractions; probably can get all the stadium stuff handled innately
 2020-10-06 19:35:03 -07:00
Kurt
3ab824d306 Refactoring 
Condense some logic
 2020-10-06 17:54:17 -07:00
ShadowMario3
1681fc776b
Update Encounters2.cs (#3011) 
Fix Sing Pichu index number.
 2020-10-06 10:59:18 -07:00
Kurt
d2fed0d66c Set party stats on pkm create 
Party stats are stored in box format
 2020-10-05 09:04:32 -07:00
Kurt
aa43904869 Add stad2 boxnames, registered flag handling 2020-10-05 08:29:17 -07:00
Kurt
978305b45e Fix pp up offset reads 2020-10-04 15:45:21 -07:00
Kurt
d4452ce3af SK2 coerce to load to a hint language 
This format won't be supported cleanly, so let's just try to allow language detection to work as best as it can without storing metadata in the SK2 bytes.
 2020-10-04 14:42:48 -07:00
Kurt
f4f25da986 Add IsEgg for SK2 
Stored at 0x1E
 2020-10-04 14:15:29 -07:00
Kurt
6938d2f94d Split VivillonTables into two classes 
Indicate that the content is for 3DS specific logic
Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin
 2020-10-04 14:15:13 -07:00
Kurt
36827f795d Remove gen1 flagged moves if they can originate from egg 
Revises the tradeback status to remove any index that could have been sourced from egg moves instead.

really should refactor this TradebackStatus away, but Move validation still remains one of the un-refined parts of the legality checks :P
 2020-10-04 12:21:05 -07:00
Kurt
757456bf06 Move reset action to class 2020-10-04 12:08:16 -07:00
Kurt
09c6359e3a Add flexibility for SK2 imports 
Check language character table for English vs Japanese when loading for a destination
 2020-10-04 10:25:34 -07:00
Kurt
f8de9fe1bf Minor tweaks 
now that stadium saves all expose registered teams, can just call from the parent class
rental sk2's have no TID; add that to the requirement to not get flagged for missing OT
 2020-10-04 09:26:15 -07:00
Kurt
3fd6817a42 Refactoring: Finalize Stadium savefile logic 
Extract common abstract class for shared logic
Clean up property/field/method ordering to be consistent and logical (roughly: attributes, constructors, state management, retrievable values, static methods)
Apply default language OT name
 2020-10-04 09:23:16 -07:00
Kurt
d13b893351 Use ＰＫＨｅＸ as blanksav language 
Closes #3009

Make QRPK7 implement IEncounterable and remove hardcoded PKHeX strings
Let force hatching for WC3 eggs try to hatch from the savefile's language, then revert to english if failed to set an OT.
 2020-10-04 08:59:33 -07:00
Kurt
8a7ed99689 Fix s1 team export 
oops
Add a tostring override to help visually debug
 2020-10-04 08:06:44 -07:00
Kurt
fbc4c5038a Set box metadata on write 
Fix group export for 1U to exclude the right set of teams
0J now shows the correct amount of boxes & teams (halved)
 2020-10-04 07:51:55 -07:00
Kurt
5853888020 Minor Stadium behavior enhancements 
Use underscores for enum for ToString replacing with spaces
Don't flag empty-OT as SK2; Stadium0/1 use the "TRAINER" as rental, but leave it blank for SK2.
Don't set any terminators for an OT string if the string is empty; just wipe the buffer.
 2020-10-03 21:56:57 -07:00
Kurt
262561d5d1 Fix stad1 missing team types 
off by 1 (8=>9, and EN has unused interstitial teams).
Fix last-viewed-slot indication color tracking
 2020-10-03 19:48:56 -07:00
Kurt
7efaa5ab71 Minor clean 
collapse some expressions
handle some compiler messages
 2020-10-03 18:59:36 -07:00
Kurt
816f24e3db Add Misc pkm array viewer for Stadium saves 
Readonly slots

Things could be expanded on to use interfaces and wrappers for a "SlotReference" and properties for readonly.

But that's kinda unnecessary
 2020-10-03 18:22:29 -07:00
Kurt
bca8a80b39 Minor clean 2020-10-03 17:09:22 -07:00
Kurt
b242aed429 Add ability to load blank japanese/korean save files 
Detects the language of the currently loaded save file, and passes that info to the blank sav creator

Use a trainer name of "1337" instead of PKHeX for any Japanese save file, because Gen1/2(/3?) character tables don't have regular ascii chars.
 2020-10-03 11:22:06 -07:00
Kurt
97f5f8d362 Add blank sav fetch for stad0/1/2 2020-10-03 10:53:52 -07:00
Kurt
8cb6e15f3e Add team fetch api for stad1/2 2020-10-03 10:53:35 -07:00
Kurt
a17bc52982 Fix nick/ot set for pk1/2 
Reverts the logic back to pre-Stadium2 support
 2020-10-03 10:01:22 -07:00
Kurt
833789b1b9 Fix cxd antishiny method detection 
Closes #3008 ty @Sephirona !

Do the tsv-psv compare as uint to remove the need for later casts to int
 2020-10-03 09:29:26 -07:00
Kurt
2f04ef7a32 Check PK4.EncounterType for BK4 format 2020-10-02 18:09:00 -07:00
Kurt
52a67f2425 Add Stadium2 Support 
Introducing a new PKM format: SK2
Split ICaughtData2 off of PK2 so it can be shared with SK2 when type-checks occur
Add conversion for PK2<->SK2
Split the split-buffer handling for GBPKM to GBPKML (what a name), so that I can reuse shared accessor logic for SK2.
 2020-10-02 18:08:40 -07:00
Kurt
2c8e0bc8f7 Add automatic byteswap 2020-09-30 22:46:07 -07:00
Kurt
ee207a3fda Revise Stadium savefile logic to read from boxes 
Add a helper to spit out teams
Alias hard-coded numbers to something to easy names.
Make them exportable, update checksums for box data
 2020-09-30 18:00:25 -07:00
Kurt
af4fa8078e Add 10/1 raids 
spooky
 2020-09-30 17:08:04 -07:00
Kurt
af357587f9 Add Pocket Monsters Stadium support 
https://projectpokemon.org/home/forums/topic/38108-gen-1-pokemon-stadium-save-file-structure/

untested, need to find a save file somewhere??
 2020-09-30 12:45:41 -07:00
Kurt
769d5d8689 Allow SaveFile constructor to specify exportable state 
Useful for partially-supported savefiles that can't be exported yet (Stadium)
 2020-09-30 12:44:50 -07:00
Kurt
eb6c570695 Add TSV=0 checks for WC8 home gifts 
Don't match if TSV == 0
Don't assign at TSV of 0, randomize TID7 if it happens to be so.

Closes #3007
 2020-09-29 23:10:48 -07:00
Kurt
cc3a807fa9 Add default met location for gen3 roamers 
Closes #3004
 2020-09-29 23:07:42 -07:00
Matt
4888d2368a
Restrict Isle of Armor Raichu-1 Ability (#3006) 
Only allows Ability 1 (all slots are Surge Surfer).
 2020-09-28 12:13:15 -07:00
soopercool101
cc5a950784
Add property to get a PK1's converted Gen 2 item (#3005) 2020-09-28 11:17:34 -07:00
Kurt
22f37910f0 Remove unnecessary single-member interfaces 2020-09-27 18:19:28 -07:00
Kurt
cafcd3df2e Change affixed ribbon-mark check to also consider ribbons 2020-09-27 18:19:10 -07:00
Kurt
fb4734472b Add notation for language-specific save types 2020-09-26 13:30:17 -07:00
Kurt
a34434f7cb Make pkm.Data a readonly field rather than property 2020-09-26 12:09:02 -07:00
Kurt
82afefa335 Make GP1 expose IEncounterable for metadata 
Make the main loader handle IEncounterable objects
 2020-09-26 11:33:21 -07:00
Kurt
060b0bf7fe Reduce linq/allocation 
don't fetch IVs/EVs array, just scan and apply
 2020-09-26 11:30:30 -07:00
Kurt
6243135f28 Minor clean 
Move Home8 location to Locations.cs for documentation
Move FestaFacility to correct folder
Remove unnecessary public modifier on interface method
Pass the program's Version to any loaded plugins, if they wanted to check compatibility...?
 2020-09-25 23:55:31 -07:00
Kurt
efc17a1271 Add interface for revised savefile types (patches) 
SWSH is the first common savefile type that has different revisions after official patches. We want to indicate in the Program Title which revision we're currently editing, because people still are not editing latest-format saves and complaining y no urshifu.

Use short descriptions to indicate revision (Base, IoA, CT), rather than magic numbers (v0/v1) or 1.X or 1.X.Y+, because GameFreak can't follow semver rules.

go away ranch platinum update, i might handle you another time
 2020-09-25 23:41:20 -07:00
Kurt
8aab4a2d8e Show affixed ribbon byte in extrabytes 
#3001
Since there's no GUI display of it, might as well hide it here for people to mess with.
 2020-09-25 19:40:31 -07:00
Kurt
7b19e3fb7f Add affixed ribbon legality check 
https://github.com/kwsch/PKHeX/issues/3001#issuecomment-698749761
 2020-09-25 19:37:38 -07:00
Kurt
6ed60fd35d Flag suspicious PIDs for shiny VC transfers 
Configurable setting

Closes #3002
 2020-09-25 18:04:44 -07:00
Kurt
cb0bbe889e Make pk1/2 => pk7 PID transfer mimic official mechanism 
Hardcode 0 xors to indicate SID and end result ShinyXor=0.

#3002
 2020-09-25 18:00:10 -07:00
Kurt
f10f1fef65 Add metadata for possible version range 
Closes #2995
 2020-09-25 17:15:02 -07:00
Kurt
fbf7a3658a Check species for static enc match 
like all other IEncounterable types, before calling the match method, check species directly
 2020-09-24 19:44:48 -07:00
Kurt
af99e0b37c Revise fixed PID checks 
Closes #3000
Thanks @CScorpion-h & @SciresM !
 2020-09-24 19:29:01 -07:00
Kurt
136ef0f6ae Add shiny state check 2020-09-24 19:26:21 -07:00
Kurt
fd5e38fdda Remove artist ribbon restriction requiring master ribbon 
Closes #2997 ty @sarahlicity for an interesting bypass mechanic :P
 2020-09-23 20:47:48 -07:00
Lusamine
87ee1b63c0
Fix CHT species names (#2998) 2020-09-23 20:06:23 -07:00
Lusamine
b915f3c363
Tower of Waters / Tower of Darkness are valid Met Locations (#2996) 2020-09-23 09:15:49 -07:00
Matt
185c499bff
Unban GO Shiny Doduo (#2994) 
Mega Buddy Challenge
 2020-09-22 09:23:58 -07:00
Matt
150ff88235
Unban GO Shiny Porygon (#2993) 
September 2020 Community Day
 2020-09-19 17:27:25 -07:00
Kurt
9f4b18119e Propagate ability1 to empty ability slots 
now matches all other personal table formats

var data = File.ReadAllBytes(path);
for (int i = 0; i < data.Length; i += PersonalInfoBW.SIZE)
{
	if (data[i + 0x19] == 0) // Ability2
		data[i + 0x19] = data[i + 0x18];
	if (data[i + 0x1A] == 0) // AbilityH
		data[i + 0x1A] = data[i + 0x18];
}
File.WriteAllBytes(path, data);
 2020-09-19 07:53:25 -07:00
Kurt
b039dd28b6 Use reference to personal info rather than fetching again 2020-09-19 07:52:50 -07:00
Kurt
76b704cfe1 Fix g1 yellow personal table in binary rather than while running 2020-09-19 07:52:35 -07:00