Commit graph

4997 commits

Author SHA1 Message Date
Kurt
aeb90d262c Cleanup 2017-05-12 09:33:12 -07:00
Kurt
6af17352c9 Update HGSS valid hatch location list
Closes #1119
2017-05-12 08:55:24 -07:00
Kurt
3594d1af5c Merge pull request #1118 from kwsch/f/dotnet-core
Convert PKHeX.Core to .Net Standard 1.3
2017-05-11 22:36:36 -07:00
Kurt
48eec82abe Merge pull request #1120 from kwsch/revert-1117-master
Temporarily Revert "Fix HGSS met location typo"
2017-05-11 22:35:45 -07:00
Kurt
4afa4c25bc Revert "Fix HGSS met location typo" 2017-05-11 22:35:21 -07:00
Kurt
cd74c7edb7 Merge pull request #1117 from sora10pls/master
Fix HGSS met location typo
2017-05-11 22:08:08 -07:00
Evan Dixon
3fa2c98407 Cleanup 2017-05-11 23:58:44 -05:00
Evan Dixon
97afb43abc Added packages to test project 2017-05-11 23:58:24 -05:00
Evan Dixon
916c352fba Added packages required by .Net Standard 2017-05-11 23:41:18 -05:00
Evan Dixon
96e315c035 Fixed missing resource references 2017-05-11 23:40:57 -05:00
Evan Dixon
145dc3615e Update gitignore to hide nuget packages 2017-05-11 23:40:41 -05:00
sora10pls
033d4d0f1b Fix HGSS met location typo 2017-05-12 00:38:31 -04:00
Evan Dixon
52c4fbbe97 Converted PKHeX.Core to .Net Standard
Refactored and rearranged things as needed to allow the change
2017-05-11 23:34:18 -05:00
Kurt
3e47e1e138 Merge pull request #1115 from sora10pls/master
Unban Pikashunium Z
2017-05-11 10:55:21 -07:00
sora10pls
5e29a08df7 Unban Pikashunium Z 2017-05-11 13:20:33 -04:00
Kurt
4aeb3ce818 Add cxd starter TID/SID correlation check 2017-05-11 00:32:31 -07:00
Kurt
a01e164e2e Misc fixes
Add a few more locations for cxd, restrict balls for gift pkm, fix cxd
fateful gifts (loc 254 not first entry in combobox), add special gift
pkm moves (bite for umbreon/eevee), add xd mt battle starters

probably needs more work for fateful determination (obedience flag vs
254 met loc).
2017-05-11 00:15:17 -07:00
Kurt
83962419db Simplify trash editing load
Gen5 allows editing of the final terminator; just use the raw length as
the amount of trash byte entries to show.
2017-05-10 22:52:14 -07:00
Kurt
d874092e58 Add missing parenthesis 2017-05-10 21:37:54 -07:00
Kurt
1b7e0e630c Add template loading when sav loaded
Closes #1114
Loads a template file (if it exists) instead of applying default
template info when a new save is loaded. No formats are hardcoded, as
ck3!=xk3!=pk3!=bk4
2017-05-10 19:24:58 -07:00
Kurt
71b9141962 Split Dream World special move entries
The structure of the downloaded dw pkm only allocates one move; thus,
only 1 special move can be obtained (not 2+). Ends up creating extra
entries.

Eg: Wobbuffet can't have Charm and Encore at the same time in gen6 if
originated from Entree/Black.
2017-05-10 19:01:01 -07:00
Kurt
6d9cbaaec0 Add IOException type write protection check
per recent forum thread
2017-05-10 19:01:01 -07:00
Kurt
5a96169cc2 4->5/6 transfer encountertype preference fix
Add a preference check when appropriate so that invalid encounter types
are not preferred over the wild encounters that may follow.

Closes #1095
2017-05-10 19:01:00 -07:00
Matt
753d18b751 change more Forme displays (#1113)
Xerneas-Normal => Xerneas-Neutral
Zygarde-Normal => Zygarde-50%
Mimikyu-Normal => Mimikyu-Disguised
2017-05-10 12:30:52 -07:00
Kurt
8ff762ce91 Update readme
Updates Hoopa-Normal to Hoopa-Confined
Updates preview image to better reflect current gen7 appearance

Closes #1110, unused as the proposed readme image was boring and hoopa
change copied
2017-05-09 21:36:30 -07:00
Kurt
a4565d71f6 Handle gen4 egg nickname edge case
Egg is not saved as "EGG", it is "Egg". Nice job gf.
Instead of ignoring the nickname flag, detect if it should be used or
not.
Gen4 never uses it. Gen7 doesn't use it when it's a gift, but uses it
for daycare eggs (...).
Closes #1100
2017-05-09 21:11:13 -07:00
Kurt
9eae35ba34 Add uncapturable edge case beast ball
can't catch these in a beast ball as the only encounter is a gift
(porygon & evos, and aerodactyl)

#1100
2017-05-09 19:27:30 -07:00
Kurt
8154af64c3 Fix gen1/2 evo move edge case
Closes #1112
Encounter matched was set to an egg (err 1, core.cs), and the GB
encounter info was not set (err 2, checks.cs).

Fix by preventing eggs if Gen2 is disallowed (reuse allowg1tradeback),
and set the species if it is an egg (future case).

switch pidiv return to null, as it should always be null (not whatever
is returned by the last pidiv finder).
2017-05-09 19:07:21 -07:00
Kurt
d0e2b7784a Fix g4 ingame trade exception
Resolves the Internal Error exception where the EncounterMatch was not
overwritten; in the case of some encounters, an encounterslot[] was
provided -> invalid cast
#1095
2017-05-09 17:55:58 -07:00
Kurt
95eefb45ff Add hidden ability mismatch check for fixed abils
minor refactoring
remove GameVersion.Pt unreachable code for eggmoves
2017-05-08 20:35:06 -07:00
Kurt
cfc99f064f Clean up g7 encounter info
Remove uncapturable static encounters. Location = -1 was never matched;
was a leftover from initial support where encounters were assigned a
location if captured. pk3DS now serves as the raw info view.

Remove ability forcing for Zygarde core encounter
2017-05-08 20:33:42 -07:00
Kurt
f0dcf2b6b2 fix vivillon evo tree branch duplication
doesnt branch per form, formstatsindex is 0.
2017-05-08 20:20:52 -07:00
Kurt
d05d6c44f4 Misc ec/pid tweaks
use the encryption constant (pk3-5 return PID on get), fix gen4 using
gen5 correlation
2017-05-03 23:14:34 -07:00
Kurt
99b243b4fa Handle CXD egg encounters
There are none. But the detection routine for gen3 can assign cxd pkm as
egg if no other possible encounter is matched, thus we'll flag if the
failure case occurs.

add missing spacing formatting, simplify break->return for egg game
retrieval
2017-05-02 19:08:16 -07:00
Kurt
a5cfaed574 Fix typeinfo exception when loading gen2 saves 2017-05-02 18:03:42 -07:00
Kurt
848c10f096 fix unown bade check
! =
2017-05-02 08:59:55 -07:00
Kurt
24b55b7b79 Add gen3 roamer pidiv detection
add shiny lock for spiky eared pichu
fix wurmple ECPID comparison (only continue if ALL are wurmple)
slightly speed up comparison of LCRNG spreads, may be worth applying
same approach to others.
2017-05-01 23:41:19 -07:00
Kurt
f1db88026b Add frlg unown PIDIV type
The modified form-finding routine generates the PID gen halves in the
reverse order like events. Due to possible collisions with event PIDIVs,
only run it for unown (since that's all it applies to); the analyzing of
PIDIVs to find incorrect usages isn't really feasible (collision) for
this one.
#1103
2017-05-01 08:37:23 -07:00
Kurt
f19d85002b slight tweaks
reduce nesting, formatting; no functional change
2017-05-01 08:25:20 -07:00
javierhimura
758adf2cff Encounter Type fix and detection of pokemon that should have evolve on trade (#1105)
* Detect encounter trades that evolve on trade and have not been evolved
Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium
Detect generation 1 pokemon that evolve on trade and have been traded but not evolved
Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback
Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback

* Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters

Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles.

Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles

* Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095)

* Fixes and typos

* Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 08:07:20 -07:00
Kurt
ad6a48b7f1 Add gen3 force shiny event PIDIV detection
matches for berry fix zigzagoon

use correct type comparison for checking if national ribbon is to be set
or not; change XDC to CXD for parity with other references
2017-04-30 22:11:51 -07:00
Kurt
527a830bae Add moon ball for gen4 captures
Closes #1102, Moon Ball is id 23 (0x17)

also:
fix spacing of previous commit
2017-04-30 18:28:29 -07:00
Kurt
a2972b6939 Add EncounterType for E-Speed Dratini
#1095
2017-04-30 17:01:47 -07:00
Kurt
0bad6738d4 Add C/XD specific checks
Pokespot: a given PID will satisfy ~37% of the time, flag pokespot
encounters
I can see hatching eggs being a problem, no idea how this would work
2017-04-30 16:53:54 -07:00
Kurt
1ff2a0fdfa Add preliminary CXD checking
quite a few shadow pkm are obtainable in multiple locations, feeling
like duplicating the entries with different location IDs is the way to
go
2017-04-30 12:17:27 -07:00
Kurt
2a28019ef3 Add gen3 event pidiv detection
includes antishiny mechanism detection, needed 2 new enum values to tag
those.
handle overflow case
2017-04-29 23:18:36 -07:00
Kurt
f613960cdc Fix viewing legality as ck3/xk3
ChecksumValid was returning false
2017-04-29 23:13:21 -07:00
Kurt
e814e7291f Add chain shiny and shinyPGF pidiv detection
delete incorrect legality message entry (used a few lines up for super
training flags), is unused.
fix for transferred 8<=xor<16 PIDs in which case the encryption constant
is used (as it is the unmodified PID)
2017-04-29 20:04:54 -07:00
Kurt
6685ae6228 Sync remaining changes
yay
2017-04-29 16:35:32 -07:00
Kurt
82375ca464 Add PIDIV matching
Includes 1 test for each pkm pidiv type, haven't added absolutely every
method possible but it's enough for now
2017-04-29 16:22:32 -07:00