830 commits

Author	SHA1	Message	Date
Kurt	6b387f9037	Handle alolan species transfer form check ... https://projectpokemon.org/home/forums/topic/44718-bugabout-xd-alola-form/?do=findComment&comment=229735	2018-04-13 18:44:16 -07:00
Kurt	78f533605c	Handle untranslated Italian LeafGreen Jynx trade ... lul nice translating team u got there, would be a shame if they forget to translate something ;) /s Thanks cicciochiave!	2018-04-12 21:22:04 -07:00
Kurt	b8a5ccdf7d	Simplify shedinja evo move check ... Closes #1895 , re-verified with pkm provided in #1805 there's no shedinja gift, always is an evolution seal some forms to remove virt call in constructor warning	2018-04-10 17:00:28 -07:00
Kurt	be285917b9	Update ingame trade data ... https://projectpokemon.org/home/forums/topic/44726-bug-in-game-trader-pokemon-flagged-illegal/ Thanks Jimmy Cerno!	2018-04-07 12:34:06 -07:00
Kurt	caa32c1516	Add alolan evo species check ... can't change to a local variant form if it was originally obtained as a non-variant form (no evolutions!)	2018-04-06 21:46:27 -07:00
Kurt	547c799eeb	Handle gen1/2 static encounters ... levelup starts after initial moves	2018-04-02 17:51:37 -07:00
Kurt	39f1805940	Fix gen2 met data setting	2018-04-01 20:25:40 -07:00
Kurt	d4e38dded0	Refactor time of day check/validate ... Fixes time of day flitering property reference (met_day is always 0, so it never reached)	2018-04-01 20:22:10 -07:00
Kurt	867c705597	Fix broken gen2 tests ... add oddish to the mix	2018-04-01 15:51:55 -07:00
Kurt	d42eb4372f	Fix 4 egg move gen2 oddish ... egg moves also can be taught in gen1, which causes the learn source to be locked to a tradeback (removing egg moves that have IDs greater than RBY's moves). Simplify gen<=2 parse preference ordering with this addition to force egg moves to be acknowledged.	2018-04-01 15:04:53 -07:00
Kurt	07b2568b1f	Fix g2 caterpie generating ... has no egg moves -> no moves generated!	2018-04-01 15:02:27 -07:00
Kurt	5e55b916fa	Handle fixed gender statics ... Seems like a PID/Nature/Gender/Ability smart-setter is necessary for other encounters	2018-03-31 21:55:59 -07:00
Kurt	ba4c911566	Refactoring & finish eevee test case ... generates a legal pk* for every possible encounter; there's likely other scenarios and more roughness to smooth out, but seems legit for now	2018-03-31 20:37:36 -07:00
Kurt	32f9f806db	Add other iencounterable->pkm generators ... not tested	2018-03-31 00:43:41 -07:00
Kurt	0b4adf9763	Sync missing content ... fixes tests	2018-03-30 22:11:24 -07:00
Kurt	0597833899	Track version of slots/static/trades ... I think I set the version at the appropriate times to get all encounter objects	2018-03-30 21:38:57 -07:00
Kurt	a89c0c3312	Rename egg game->version ... add more gameversions (soon)	2018-03-30 21:37:01 -07:00
Kurt	b38abc22e2	Refactoring ... add IVersion interface with common interactions	2018-03-30 16:31:40 -07:00
Kurt	537ad33229	Add encounterlink gen ... not tested	2018-03-30 01:02:37 -07:00
Kurt	214e684ff8	Add GetEncounterMoves method ... dictionary mapping common gameversions to their associated obj	2018-03-30 01:02:22 -07:00
Kurt	d03ff147d4	Add template -> pkm method ... fix signature if no versions are provided (empty params is [0], not null)	2018-03-29 21:04:05 -07:00
Kurt	2ea1fea5f5	Refactoring ... add GameVersion to generation fix generating pk2 eggs relocate some logic	2018-03-29 21:00:38 -07:00
Kurt	e74e7878cd	Lower dragonair encounter level req for trade ... https://projectpokemon.org/home/forums/topic/44555-gen2-legality-issue-with-in-game-trade/ Thanks Bumidek !	2018-03-29 08:50:23 -07:00
Kurt	e5ccae906a	misc quality of life improvements ... set egg friendship allow SetRandomIVs to use a minimum fixed IV count	2018-03-28 20:56:58 -07:00
Kurt	76b4db1477	Add egg converter & test ... only tested for gen7 egg->pkm (not to eventual set) pretty sure a good chunk of the egg generation logic can be pulled out for reuse in other IEncounterable generators (IEncounterable extensions?)	2018-03-28 20:40:07 -07:00
Kurt	6333c42cf1	Add more suggestions for eggs	2018-03-28 20:38:21 -07:00
Kurt	1e13220e6e	Add IEncounterable -> pkm interface method ... egg,slot,static,link,trade need to be implemented later remove IEncounterable from PL6	2018-03-28 20:38:07 -07:00
Kurt	314a92b67b	Extend core api ... add copy/fetch new	2018-03-28 20:34:58 -07:00
Kurt	e026a8ab49	Add default trainer info ... use in pkmeditor and utilize	2018-03-28 18:52:50 -07:00
Kurt	d794e71175	Extend contest-affection check to pre-gen6 transfer ... Closes #1881 Thanks @ijuintekka ! Thanks @sora10pls !	2018-03-28 16:07:03 -07:00
Kurt	a0eb658ef2	Extract minimum trainer information requirements ... If one wanted to extend ConvertToPKM to other IEncounterables, this would be the provided obj containing the receiver's info allows pkm gen without a savefile, which is nice?	2018-03-28 15:55:19 -07:00
Kurt	78616e1ad5	Add showdownset -> pkm encounter fetch test case ... Test parsing glaceon, input must equal output Test generating encounters for a specific version (exists only on Moon) Test generating encounters for the same version (add handling trainer data to permit Tutors) fixes error in VC generations-present fetch which allowed movesets from generations 3-6 lul exclude negative/invalid gameversions	2018-03-27 19:45:22 -07:00
Kurt	5b4b6e4158	fix ability comparison ... a==a obviously, need to check against the current ability	2018-03-27 09:02:56 -07:00
Kurt	a25425a277	Add pcd ability mismatch edge case ... yay set PID but nah lets force an ability that doesn't agree with the PID https://projectpokemon.org/home/forums/topic/43724-gen-4-events-flagged-as-illegal/	2018-03-26 23:23:27 -07:00
Kurt	1ca69965bf	store encountertrade nick/ot within object ... allows for ot/nick fetch for a given language	2018-03-26 22:23:11 -07:00
Kurt	6abd2a22a4	Add oras contest master ribbon affection check ... Each contest victory requires a contest participation; each participation gives 20 OT affection (not current trainer!) Thanks @WyrXIII , @JusLi, @Cresceda !	2018-03-26 16:42:18 -07:00
Matt	ff675ed6e5	Detect event contest affection boost (#1880) ... * Detect event contest affection boost * Re-order check	2018-03-26 10:43:42 -07:00
Kurt	4d3877bf7f	Add EncounterMovesetGenerator ... lack of a better name; generates IEncounterable list.	2018-03-25 22:50:32 -07:00
Kurt	99a4c55579	Relocate some logic to core ... party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically	2018-03-25 19:05:49 -07:00
Kurt	a24e5aa742	Update personalinfo usages ... less temp array usages, add methods for cleaner understanding	2018-03-25 13:54:30 -07:00
Kurt	1e708a2102	Simplify default met location fetch ... now that IGeneration is available, don't call pkm.GenNumber (slower)	2018-03-24 17:28:56 -07:00
Kurt	a6977af19a	Pull out Contest Stat logic to interface	2018-03-24 10:36:48 -07:00
Kurt	d1cfdd782e	Rework ball / frame check passing ... Two checks are performed for Gen 3 & 4: A: Encounterability (wurmple, ball, ability) B: RNG Compatibility (frame) Original code only checked 'A' Recent code ordered by 'A', but returned anything that matched 'B'. If 'B was not satisfied, an 'A' match would get deferred, allowing for an eventual B & !A to be returned before a A & !B being returned. yay bool logic we want to prefer a RNGFrameMatch as well as a SlotCompatible match original code (no RNG checks) retrieves with SlotCompatible just fine recent adding in framematch resulted in deferring compatible if not RNG frame, yielding !A matches before A & !B maintain 3 queues (A & B get yielded immediately) to track A!B, !AB, and !A!B not necessary to check unown case anymore as it'll fall into the A!B group. better performant to skip that check in favor of only adding for fail. thanks theSlayer!	2018-03-21 20:19:54 -07:00
Kurt	636736c3fa	Add g3 safari ball wild deferrals ... Pineco is valid but also can be sourced to altering cave similar for sandslash Thanks theSlayer!	2018-03-21 17:30:19 -07:00
Kurt	2c4e3358e4	Fix ninjask evo move comparison ... https://projectpokemon.org/home/forums/topic/44413-bug-information-about-bug-found-on-the-new-version-180319/	2018-03-18 15:30:19 -07:00
Kurt	f55028c1a0	Fix KChart errors ... gen1 & gen2 types aren't laid out contiguously (yay bird type and extra types) fix gen2 type accessors looking at the wrong byte type sprites now load correctly, and 3rd ability no longer throws an error (forced to None).	2018-03-18 11:22:20 -07:00
Kurt	88ce27f26b	Add R/S roamer data offset ... is different from emerald Thanks TetsuyaGR! https://projectpokemon.org/home/forums/topic/44407-bug-rubysapphire-roamer-bug/ (use concatall in encounters4)	2018-03-18 08:37:40 -07:00
Kurt	e9a3b4acf1	Merge PIDType and bool? shiny property ... Gen5 does not follow the same convention, 0 = non, 1 = rnd, 2 = always; not gonna bother updating for just that one bool? occupies 2 bytes; enum:byte is 1 byte. should probably move validity checking logic into the IEncounterable objects instead...	2018-03-16 19:35:55 -07:00
Kurt	274d2200a3	Correctly flag hidden7apricorn ... [0] -> Last() Thanks Davil! https://projectpokemon.org/home/forums/topic/44374-bug-about-hidden-apricorn-voltorb-bronzor/	2018-03-15 19:04:14 -07:00
Kurt	2685fe29c2	Ban hidden-apricorn voltorb bronzor ... Thanks @wwwwwwzx !	2018-03-14 08:10:12 -07:00
Kurt	1cdbe6f4f8	Fix ditto5 IV order ... closes #1863	2018-03-12 19:34:54 -07:00
Kurt	aa65d88d3d	Cache pressure slot instead of saving all to list ... faster to do: null check & comparison for each vs collection add (especially if growing collection) don't evaluate all slots (faster), capturing the dexlevel[] object is fine until the enumerable is discarded	2018-03-11 11:02:02 -07:00
Kurt	5148fd2c4e	Add minimally filtered encounter generators ... Filters by species at most, resulting in something that can be scanned for a preferred encounter.	2018-03-11 00:29:31 -08:00
Kurt	94811d9052	Split up IEncounterable generators ... Can break the filtering out into smaller methods such that the generator can return results with less strict filtering	2018-03-10 19:51:09 -08:00
Kurt	84c5decfc0	Comment out unused ... temp = temp permanent lul	2018-03-10 19:40:57 -08:00
Kurt	2bd9d99d9e	Refactoring ... WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator	2018-03-10 18:03:09 -08:00
Kurt	9da1913f1b	Only check static IVs if original IVs still exist ... https://projectpokemon.org/home/forums/topic/44319-bug-vc-mew/ Thanks Davil!	2018-03-09 20:00:13 -08:00
Kurt	cda2cfcefd	Clean up EncounterLink ... no new gen6 pkm link gifts, simplify usages	2018-03-09 18:58:00 -08:00
Kurt	452ffe2369	Refactoring ... relocate location of stuff	2018-03-08 21:18:32 -08:00
ReignOfComputer	8147258e9e	Unban Gen 7 Starters HA (#1860) ... HA Starters Event via Pokemon Bank	2018-03-08 05:55:47 -08:00
Kurt	cbf4038a95	Refactoring ... relocate gift data storage out of legal.cs	2018-03-05 22:19:56 -08:00
Kurt	21cdf4f642	Reorganization ... wonder if it's possible to provide a more lightweight core by pulling out legality stuff to a separate project?	2018-03-05 20:49:45 -08:00
wwwwwwzx	c9a54307c4	Fix WC6/7 IV generation (#1857) ... https://pastebin.com/bbpS6svw IV lock doesn't work for IV3 case	2018-03-02 16:17:14 -08:00
Kurt	89d3437d0b	prevent blue flabebe apricorn/beast ... closes #1850 impossible SOS's were already removed from the SOS list (e.g. no slots in the SOS table with w.Species == 669 && w.Form == 3)	2018-02-24 17:28:07 -08:00
Kurt	e33bd4c327	Add Dialga/Palkia headbutt location ... turns out route 47 (below route 48) also yields dialgapalkia, which also has a tall grass patch that can be headbutted from. Closes #1833	2018-02-15 19:40:42 -08:00
Kurt	f8bf3e400b	Misc tweaks ... Add bulkstorage SaveFile template remove unused using un-virtual box property (don't override behavior) Split new-USUM island names (unused) Remove island names from valid egg locations (thanks Davil !) https://projectpokemon.org/home/forums/topic/43874-bug-met-location/?tab=comments#comment-227684	2018-02-15 17:05:45 -08:00
Kurt	89248b30a9	Re-add rufflet pelago for sn ... Thanks @wwwwwwzx !	2018-02-12 17:38:31 -08:00
Kurt	28180687a5	Add transfer2 future evos for legality reuse ... https://projectpokemon.org/home/forums/topic/43827-gsc-mismagius-treated-as-illegal/	2018-02-11 20:48:36 -08:00
Kurt	38fb30e847	Remove Punishment from Murkrow USUM eggmoves ... Closes #1829 "In Pokémon Ultra Sun and Ultra Moon, Murkrow is programmed to be able to learn Punishment through breeding, but no other Pokémon in the Flying Group can pass down Punishment as an Egg Move in those games. Vullaby and Mandibuzz are the only Flying Egg Group Pokémon that can learn Punishment, but they cannot pass down the move due to being female-only species."	2018-02-10 18:56:06 -08:00
wwwwwwzx	9187be8177	Update CHS translation files (#1827) ... * Update CHS translation files * Fix crabrawler outliers Double check the wild encounters level range again.	2018-02-10 15:29:22 -08:00
Kurt	f289249b2d	Add oddball crabrawler berry pile levels ... thanks @wwwwwwzx !	2018-02-09 21:26:28 -08:00
Kurt	033d5baa06	Check EC-PID same for gen1/2 transfers ... Fix PID->EC on gen<3 transfers https://projectpokemon.org/home/forums/topic/43779-about-vc-pokemons-pid-and-encryptionconstant/	2018-02-08 18:47:52 -08:00
Kurt	d6fbd0f0d7	Reorder gsc encounters ... new string resources have shuckle last thanks @sora10pls	2018-02-08 17:05:15 -08:00
Kurt	05c4a0f286	partner cap pikachu update ... great job gamefreak allow current handler to be 0, remove static encounter as the data was sneakily faked as a WC7 in the events gallery. Closes #1817 ; still needs to update with new pikachu pid method allowing shinies (next update).	2018-02-07 19:56:02 -08:00
Kurt	9408255bee	Add other international (non english) gen2 tradeOTs	2018-02-06 23:09:00 -08:00
Matt	1b2aded412	Allow shiny Partner Cap Pikachu (#1820) ... good job Game Freak https://twitter.com/wwwwwwzx/status/961057063198539778	2018-02-06 18:54:45 -08:00
Kurt	05355f3566	Fix gsc shuckle jp name ... Closes #1818 strengthen language specific checks (JP or INT, not any)	2018-02-05 20:55:10 -08:00
Kurt	246b9d46a9	Add GSC fishing swarm encounters ... Closes #1814	2018-02-04 23:14:12 -08:00
Kurt	2a638a957f	Refactoring ... compress some ideas	2018-02-04 19:17:44 -08:00
Kurt	e3ca751e2c	Add dp/hgss shedinja gender glitch handling ... not providing pkmeditor ability since Pt behaves correctly. Closes #1813 , thanks @ultima-soul & @Lusamine !	2018-02-04 18:12:20 -08:00
Kurt	420a18ea85	Rework shadow lock checking ... tested for 2 locks, later commits with legality check implementation will feature more lengthy lock checks (test case automation). https://pastebin.com/VdbjWaqL (species doesn't matter since most are 50/50 ratio)	2018-02-04 16:33:53 -08:00
Kurt	c20f03434f	Add FrameCache object ... arbitrary access for RNG frame results, only generating frames when the frame is unavailable. all calculated frames are cached. to be used in RNG searching where caching seeds is necessary (repeat checks)	2018-02-04 16:30:50 -08:00
Kurt	35e5dbfb32	Add eterna forest honey tree location ... Closes #1812 , thanks @ultima-soul !	2018-02-04 14:03:35 -08:00
Kurt	04888a5c39	Add crabrawler berry pile scripted encounter ... https://projectpokemon.org/home/forums/topic/43628-crabawler-bug/ doesn't exist in static encounters, maybe is set up like the swooping encounters of gen6.	2018-02-04 13:04:45 -08:00
Kurt	9a20734be2	Update lock checks ... test case https://pastebin.com/f4K7uc56 only checked for single locks	2018-02-04 00:06:07 -08:00
Kurt	14fc71a5d2	Fix Zygarde Aura Break formechange detect ... original was AltForm != 1, 0 is also invalid so >1 suffices. remove parameter from method & update usages	2018-02-03 21:12:36 -08:00
Kurt	0a22ccdb2b	Disallow invalid pelago levels ... simplify pelago slot generation too linq for now; can be silly and make it a for loop but meh	2018-02-02 20:52:44 -08:00
Kurt	382c94c348	drop sm pelago exclusives back to 1-55 not 37-55 ... https://projectpokemon.org/home/forums/topic/43711-vullaby-invalid-error/	2018-02-02 20:10:43 -08:00
Kurt	b603bc87b8	Update shedinja ninjask move checks ... check level of source moves for any incompatibility in non-bred cases. Closes #1805	2018-02-01 19:57:02 -08:00
Kurt	999427f484	Update gen2 egg generator ... Level = Level is equivalent to Level = 0 update EggInfoSource to use Level instead of LevelMin (LevelMin returns Level, just be clear on usage) update VerifyCurrentMoves so that only gen1/2 do the gen1/2 move update methods. Recently extended all encounters to have a generation property; we only care about gen1/2 here. https://projectpokemon.org/home/forums/topic/43655-pokemon-crystal-egg-mark-as-not-legit/	2018-01-30 20:36:22 -08:00
Kurt	84a0381050	Add Italian to gb languages ... https://projectpokemon.org/home/forums/topic/43655-pokemon-crystal-egg-mark-as-not-legit/	2018-01-30 20:34:11 -08:00
Kurt	836566004f	Use CXD met location string on verbose output ... was previously using RSEFRLG locations for CXD encounters	2018-01-30 20:24:45 -08:00
Kurt	7063ea2971	Remove vc1 pay day mewtwo restriction ... Closes #1794	2018-01-30 09:38:45 -08:00
Kurt	4ac92b9418	Update nincada->shedinja evo chain check ... Thanks @admiral-fish & @Marty-D !	2018-01-29 20:52:05 -08:00
Kurt	74f185591a	Fix shiny/nonshiny egg mysterygift link trade checks ... thanks @Admiral-Fish for finding this case	2018-01-28 23:40:57 -08:00
Kurt	2365e2394c	Add eggcycles override for Odd Eggs ... not gonna bother checking for exp < 125 because after transfer these are indistinguishable from regular eggs.	2018-01-28 09:46:11 -08:00
Kurt	735ff26486	Rework GetEncounterMoves to match games ... Closes #1787 Noticed that the search-backwards approach for GetMoves yields Sludge for muk even though it shouldn't be allowed im fine with this for now because gen2 never had online checks and any current-gen checks allow relearning.	2018-01-28 00:09:11 -08:00
Kurt	13e7d8ff85	Fix dragonair ingame trade genders ... #1787	2018-01-27 23:23:10 -08:00
Kurt	282676e2f2	Refactoring ... reduces mental footprint	2018-01-27 17:49:18 -08:00
Kurt	ca2898d648	Rework gbc celebi detection ... disallow outside jp games	2018-01-27 11:46:51 -08:00
Kurt	0e7350ee9e	Update korean vc string checks ... https://projectpokemon.org/home/forums/topic/43610-legality-about-gen-2/	2018-01-27 09:45:33 -08:00
Kurt	c066df243f	Misc fixes/updates ... Fix crystal lacking met level<->current level checks Fix met location loading for gen2 saves (gen7 sav loaded gen1/2 pkm -> load gen2 sav) refactor some logic with pattern matching/consistent method names	2018-01-26 09:19:20 -08:00
Kurt	48564d7e30	Fix celebi iv check ... update version ID as well Closes #1775	2018-01-25 20:39:32 -08:00
Kurt	9b7b0b25d4	Flag iv<5 celebi ... thanks @sora10pls	2018-01-25 19:34:18 -08:00
Kurt	58e374bcc6	Add celebi / more crystal legality handling ... Closes #1772	2018-01-25 19:25:10 -08:00
Kurt	802105d22d	Allow pay day mewtwo, disallow dizzy punch ... #1772 transfer pk1->pk2->pk7 for mewtwo knowing dizzy punch, just so we can keep Pay Day	2018-01-25 19:17:42 -08:00
Kurt	5472f869cf	Remove some crystal vc checks ... now legal assuming x->kor7 sets the language val based on the cart language, should be good for the kor crystal checks.	2018-01-25 09:14:25 -08:00
Kurt	b69a6df6e7	Add roamer glitch IV collision detection ... M1 is checked before M1R. A M1R PIDIV can also be a M1 PIDIV, so check that collision. https://projectpokemon.org/home/forums/topic/43567-gen-3-suicune-unaffected-by-roamers-glitch/	2018-01-24 19:07:03 -08:00
Kurt	713e9ea209	Compress box padding	2018-01-23 17:18:37 -08:00
Kurt	b229a947f2	Fix pt/hgss egg location handling 4->5 ... Closes #1766 pt/hgss egg location data is lost on transfer, retaining faraway place only. 2c8e2176e9 fix was incorrect	2018-01-21 11:57:34 -08:00
Kurt	e616b56bfa	Remove uncatchable grubbin static encounter ... #1763	2018-01-18 14:06:17 -08:00
Kurt	387030e16f	Fix 7th gen pikachu altform check ... https://projectpokemon.org/home/forums/topic/43498-bug-about-event-pikachu/	2018-01-18 13:50:29 -08:00
Kurt	17e4bdbe3a	Add pikachu7 forme nongift check ... other branch was unhandled, flag if we have a mismatch closes #1762	2018-01-15 17:50:33 -08:00
Kurt	029539003b	FormChange check: use original form not current form ... Closes #1758 noticing the different usage for species (encounter species vs current), iterating over possible dexlevels (unnecessary?)	2018-01-13 12:10:17 -08:00
Kurt	fb6738f18b	Add unown 2->7+ shiny check ... closes #1755 also: fix vc transfer checks not being called (EncounterOriginalGB is no longer GBEncounterData). remove usages of GBEncounterData -- class is (as of a ~~month ago) now never leaked out of the EncounterGenerator -- always returns the actual encounter data as the wrapper is not needed. simplify logic flow / references	2018-01-10 16:16:35 -08:00
Kurt	c751c987a9	Add DebutGeneration get ... https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)	2018-01-10 15:40:33 -08:00
Kurt	701edbc592	Remove KOR language from gen3 selection ... add flag for non japanese lang gen3 eggs Closes #1747	2018-01-06 22:43:48 -08:00
Kurt	63a983749e	Don't generate encounter slots for eggs ... Closes #1749	2018-01-06 21:51:58 -08:00
Kurt	6a9e2ed4b9	Refactoring ... improve speed for resource fetch, add optional Shiny parameter (currently unused) #1735	2018-01-02 16:53:39 -08:00
Kurt	0f21fc2217	add location interface for verbose analysis output ... indicates met location for transferred mons most gen1/2 encounters won't show values due to the location not being stored respective to the string tables (anyone wanna do a location remap after initial load?)	2018-01-02 12:00:41 -08:00
Kurt	5888898e7d	fix gen2 egg met level mod ... https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/?tab=comments#comment-225577	2018-01-01 21:51:36 -08:00
Kurt	76385a6b4a	Fix gsc pre-evo species chain filtering ... simplify gsc check to do only once https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/	2018-01-01 13:53:28 -08:00
Kurt	cfe78a7a0c	Add rby power plant static encounters ... https://projectpokemon.org/home/forums/topic/43272-small-electrode-legality-bug/?tab=comments#comment-225537	2018-01-01 10:38:38 -08:00
Kurt	1b409dd327	Ban phione egg in non-pokeball ... Thanks Davil! https://projectpokemon.org/home/forums/topic/43262-bug-phione-ball/	2017-12-31 09:56:27 -08:00
Kurt	0c2b16391f	fix spanish ranch gift name check ... oops	2017-12-29 13:08:06 -08:00
Kurt	90260187f7	Add light of ruin & plasma fists as invalid sketch ... moves not available for sketch without hacking a specimen in https://projectpokemon.org/home/forums/topic/43244-two-problems/?tab=comments#comment-225421	2017-12-29 12:00:06 -08:00
Kurt	43cb0e8d7d	Provide more accurate met level for eggs ... Gen6 egg with met level != 1 (ie 98) will use the gen3-4 metlevel branch. fuzzed input from #1728 to be hacked (met level = 98)	2017-12-28 10:01:48 -08:00
Kurt	a1f2f8708a	Refactoring ... pass identifier on cloning pkm remove unnecessary ref for passing Data (not modifying array reference) const some magic numbers	2017-12-27 16:36:24 -08:00
sora10pls	c3d5266b89	Add XY gift Lapras ability check	2017-12-23 18:28:00 -05:00
Kurt	ea76d6a899	Misc tweaks ... minor perf improvements (don't ToList for encounter slots, store all slots incrementally); has better performance for legal pkm checks	2017-12-23 11:49:20 -08:00
Kurt	7f21728e84	Add area->location references to remaining slots	2017-12-23 11:48:10 -08:00
Kurt	5e59e20ea1	Store matched encounter generation ... previously was only defined for gen1/2, why not all gens can now query encounters in Core for encounters per generation via reflection; can help group encounters for data vis or be faster than getting individual gen numbers	2017-12-18 16:17:21 -08:00
Kurt	80baaea3b7	add b2w2 n's pokemon PIDs ... add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning	2017-12-18 15:25:40 -08:00
Kurt	24b5cc48ed	Fix gb encounter move comparison ... don't calc NoMoveReminder for non-gen2 formats, also fix comparisons (gen1 || gen2&&noRemind) Closes #1707	2017-12-17 21:26:31 -08:00
Kurt	47eee3aa98	Add roto powers as held items ... not gonna add sprites because these are useless, anyone can submit via pr (image might need downscaling to <15x15) Closes #1703 remove useless null checks (throws the exact same exception it would if it were not there, except without detail)	2017-12-16 19:52:06 -08:00
Kurt	21c1dde3a7	Fix static encounter gift / egg edge case ... extract EncounterStatic match determination; in doing so fixes "lvl" by passing byval. Pichu encounters (2) come before the Gift level 25 pikachu, causing lvl to be dropped to 5. When pikachu comes around, it compares 5==25 -> bad; pulling out the method and passing byval allows it to be 25 at the start of every new encounterstatic checked.	2017-12-16 18:24:03 -08:00
Kurt	0b58d4ffe9	Add form/nature checks for gen5 trades ... altform wasn't checked for EncounterTrade nature wasn't checked for gen5 origin (decoupled from PID, but forced) #1702	2017-12-16 14:09:03 -08:00
Kurt	e5aa39a6bb	Refactoring ... get language list now doesn't return new objects (or re-enumerate) update rand usage to be inclusive for top bound, extend shuffle to collections remove unnecessary location overrides (already overriden in legal fetch)	2017-12-14 20:58:55 -08:00
Kurt	b5640de538	Misc tweaks ... reorder some args, reuse some standard methods; add spanish for gen1/2 egg name case	2017-12-14 16:16:47 -08:00
Kurt	9a39f818f9	Misc fixes ... #1700 dp personal: add wormadam/deoxys manual forme count values generator: bcc handling for pkm present in & out of bcc, and static/wild duplicates util: fix incorrect variable reference	2017-12-13 16:17:02 -08:00
Kurt	a9ff74059a	Misc perf tweaks ... checking untraded should just check for the first character (rather than creating string object) hashset for wild6 balls	2017-12-13 16:12:53 -08:00
Kurt	816ebf6b0e	Refactoring ... no functional change	2017-12-11 16:01:24 -08:00
Kurt	dd21f9375f	Misc updates ... Disallow sandygast on US Add 2 more records thanks @feralfalcon Closes #1698	2017-12-08 08:54:00 -08:00
Kurt	a43880184a	Fix artist ribbon gen6+ ... having 4 ribbons is sufficient (normal/super/hyper/master = 4, etc) https://projectpokemon.org/home/forums/topic/42933-2-issues-invalid-ribbons-artist-encounter-level-in-origin-game/	2017-12-07 07:57:07 -08:00
Kurt	f9946368a0	Remove usage of LegalityAnalysis from PK* ... CK3<->XK3 transfers to PK3 first now (no direct transfer legally)	2017-12-06 21:28:34 -08:00
Kurt	bd9f7fc7e2	Remove fossils from usum capture list	2017-12-06 21:05:36 -08:00
Kurt	4550f656d0	Update gs vc check female ... will be revised when/if vc-c is released	2017-12-05 15:08:02 -08:00
Kurt	88f67ebd36	fix crystal gender flagging ... C->GS->Gen7 keeps female OT but gives GS version also fixes wrong logic path for format2 thanks randomdice101	2017-12-05 14:43:02 -08:00
Kurt	5bc2e6da88	Refactoring ... de-linq some areas where direct accessing is possible (list/array)	2017-12-04 20:16:54 -08:00
Kurt	4a63769351	Add voltorb to beast ball permissible table ... closes #1694	2017-12-04 16:54:09 -08:00
Kurt	3d7b2a2b29	Misc tweaks ... RNG frame mismatch -> fishy (for now) fix xmldoc copypaste clean up some resharper warnings	2017-12-04 16:26:26 -08:00
Kurt	1007c5ddb8	don't flag pokespot for frame not matching ... #1693	2017-12-04 16:05:21 -08:00
Kurt	a5dbdf91bd	Misc tweaks ... detect antishiny cxd remove unused using don't set caught for seenAll (gen7 dex)	2017-12-04 13:18:28 -08:00
Kurt	6773a2801d	update static/magnet slot permutations ... using certain slot modifiers (swarm/game pak) causes different arrangements of slots for different static/magnet pull groups to pull from store a list of permuted/different slots and add them to the table at the end with the rest move static/magnet pull marking into gen4 methods (only leave for gen3) move trophy slot generation into gen4dppt area fetch (necessary for static/magnet permuting) fix electric off-by-one (yay for curse ??? type shifting everything)	2017-12-03 12:20:53 -08:00
Kurt	f21906ee9a	store gen3 origin seed for default frames	2017-12-03 07:13:28 -08:00
Kurt	d301cb5469	Remove ESV rollback for varied level encounters ... ESV rand is stored uniquely now via generated frames from FrameFinder, no need to roll back.	2017-12-02 22:34:54 -08:00
Kurt	133cc22f50	Add bypass for gen4 unown ... meh	2017-12-02 19:54:50 -08:00
Kurt	9c32b36709	Don't reuse friend safari message ... use the string format variant that has less hints. https://projectpokemon.org/home/forums/topic/42869-bugg7-ditto/?tab=comments#comment-224365	2017-12-02 18:54:41 -08:00
Kurt	e06b7945ad	Merge pull request #1682 from wwwwwwzx/master ... Breeding ball legality fixes	2017-12-02 16:40:42 -08:00
Kurt	15489b8a7c	Use dppt specific rand calls	2017-12-02 15:44:44 -08:00
wwwwwwzx	21a31c9fce	Breeding ball legality fixes ... Unban safari ball Slakoth, Pichu and Igglybuff, beast ball Helioptile.	2017-12-02 15:44:04 -08:00
Kurt	87748e18c9	Continued updates for frame generating ... fixes broken test, provide encounter proc call	2017-12-01 22:49:38 -08:00
Kurt	40ec87fc9d	Add gen4 lead frame finding variants ... can use level call or not at all (fixed slot) still untested, assumed same call order as gen3.	2017-12-01 21:23:37 -08:00
Kurt	48242109fd	Rework lead required to flags	2017-12-01 17:27:09 -08:00
Kurt	15ab0d5aff	Add origin seed for frame output ... looks like for gen4 I have to yield twice as many frames (for FixedLevel and non) as level call usage is dependent on encounter	2017-12-01 16:33:03 -08:00
Matt	1fcac7c06b	Fix level check compare	2017-12-01 15:13:03 -05:00
Kurt	4b954cd102	Add static/magnet fail enum value ... can fail leading to regular ESV calc	2017-11-30 23:07:11 -08:00
Kurt	5d74096243	Apply static/magnet groups by slot type ... only apply for emerald (only game in gen3 that supports it)	2017-11-30 22:34:57 -08:00
Kurt	de25056275	Check SOS hidden ability minimum IVs ... Closes #1675	2017-11-30 21:06:11 -08:00
Kurt	2ab805ba98	Add method h safari analogues for ESV->slot	2017-11-30 19:31:38 -08:00
Kurt	8c675793ba	Fix gen4 trade nickname/ot check ... Closes #1672 by changing length check to check the correct dimension add handling for DP english trades (localization error).	2017-11-30 18:13:30 -08:00
Kurt	9930e8765a	Add frame level checking ... still WIP but should be working fairly well	2017-11-29 23:20:49 -08:00
Kurt	d3d7d7d50d	Add slot level / IsEncounterable beginnings ... dynamic level -> calc level no sweet scent -> proc available (rock smash/fish) change frame checking in encountergenerator to save which frame it was found on (unused but possibly later can capture this for output)	2017-11-29 21:31:52 -08:00
Kurt	36894a588d	Add FRLG unown frame matching ... Turns out there was no documentation anywhere on encounterslot numbers for the individual forms; some sites had overall rates. Assuming a human filled out the encounter slots, forms would repeat left to right until a new form takes over. Below slot numbers match the rates when summed up. https://pastebin.com/raw/bQt3ZMbq	2017-11-29 18:28:20 -08:00
Kurt	8f8cf5bc9a	Fix tradepair calculation (link trade eggs) ... returned invalid pair values for gen7 due to 2 unused game IDs between the gen6&gen7 pairs	2017-11-29 09:21:17 -08:00
Kurt	dc2ef24fcd	Handle fixed lang trade name detection explicitly ... edge cases suck	2017-11-28 22:26:31 -08:00
Kurt	dd7684735a	Add Frame mismatch illegal message handling ... encounter will no longer be ignored as valid, will instead show the RNG frame mismatch message.	2017-11-28 21:30:53 -08:00
Kurt	c7a59453b1	Fix frlg safari rod slot checks ... tfw whole legit boxes of dratini were flagged -> now legal	2017-11-28 20:56:21 -08:00
Kurt	fb4fffffa0	Change rse feebas to swarm slottype ... behaves the same as a swarm pkm in terms of proc (50% -> level -> generate), so have it travel the same code path.	2017-11-28 19:41:29 -08:00
Kurt	0bc2ee0938	Skip scatterbug static encounter forme check ... closes #1668 add 2/3 pkms provided as test cases (spewpa can be ignored, close enough. just want an evo & orig).	2017-11-28 19:29:25 -08:00
Matt	42d6d483f2	Comment out Old Amber Aerodactyl	2017-11-28 19:10:56 -05:00
Kurt	1e0bf7b6ea	handle hgss volty pikachu trade lang swap ... en<->fr not sure what FR has for the pikachu language (is it EN? if so the code here works fine); if not, the OT should be checked for lang detection.	2017-11-27 23:21:19 -08:00
Kurt	c5b7ebf50a	Add egg forme check ... all other egg formes that are disallowed are checked later; check for totems here Closes #1667	2017-11-27 18:13:54 -08:00
Kurt	b2c3884391	Permit 5->6+ forme mismatch keldeo ... BW tutor -> transfer up doesn't update the form thanks @wwwwwwzx !	2017-11-26 22:19:27 -08:00
wwwwwwzx	f70dab1d19	Remove duplicates ... oops..	2017-11-26 20:45:27 -08:00
wwwwwwzx	5886b3e609	ban beast ball fossils ... - Add G1/G3/G6 fossils to Alolannatives - Ban all fossils in beast ball	2017-11-26 20:38:52 -08:00
Kurt	be4d30bb6d	Add pokeblock slot filtering ... since there's 300 calls to rand to shuffle, I wouldn't be surprised if there are vblanks messing up the frames judging from my data 6 years ago (wow, still wrong, just look at the frame offsets) http://www.smogon.com/forums/threads/past-gen-rng-research.61090/page-35#post-4021415 looks like it happens quite erratically. may have to just override this to return true for all gen3 safari mons as it's entirely unpredictable.	2017-11-26 20:07:38 -08:00
Kurt	187726b4af	Use static/magnet pull values ... reorganize a little for lead use cases	2017-11-26 16:09:24 -08:00
Kurt	22abce5e16	Update gen3 frame finder	2017-11-26 14:48:55 -08:00
Kurt	0f3529e764	Add gen3 swarm encounter slot call ... via pret/pokeemerald (and pokeruby); rate is set at 50% swarm pokemon have the ability to have 4 fixed moves, so derive from EncounterSlot to have moves, and remove special handling from VerifyCurrentMoves (now picked up by IMoveset pattern	2017-11-26 11:00:54 -08:00
Kurt	1162ba5b3d	update bcc slot table ... https://pastebin.com/Y0VRnJxu not sure what the 2nd rand value is still some things to sort out with RoC's PC	2017-11-25 22:28:38 -08:00
Kurt	2be84b6005	Rework encounterslot location fetch ... store ref to area instead of location, useful for fetching sibling slots from the parent.	2017-11-25 18:16:50 -08:00
Kurt	690cbaae79	Unban fossils ... except for aerodactyl (old amber not obtainable) https://projectpokemon.org/home/forums/topic/42761-fossil-legality-issue-usum/ https://www.serebii.net/itemdex/clawfossil.shtml etc	2017-11-25 15:20:45 -08:00
Kurt	ad5e69550e	Add hgss safari slot block priority bypass ... allows hgss safari mons regardless of frame call (table is currently all Slot=0). may need separate handling down the road: * switch slot number to an enum for slot codes (>0 = slot number, less than -> do something else). not something im interested in right now	2017-11-25 15:03:37 -08:00
Kurt	fbce8582c7	Add encounter slot checking ... emerald silly stuff like magnet pull not implemented so some stuff may be not matched.	2017-11-25 13:53:39 -08:00
Kurt	76903bce9f	Fix gen4-6 gen4 origin encounter type defer check ... only check etype if appropriate (not gen7+)	2017-11-25 09:48:49 -08:00
Kurt	d1bae13250	Add flagging for crystal transfers ... users should know better but best to know allow gen2 female when from crystal	2017-11-24 18:19:16 -08:00
Kurt	20cd29c088	remove mind blown for sm ... off by one Closes #1658, thanks @Ntonio36	2017-11-24 12:05:08 -08:00
Kurt	3483b4bb91	Clean up vc2 legality/transfer stuff	2017-11-24 10:13:42 -08:00
Kurt	b8a5657d5a	misc tweaks ... pull out transfer locations to const references add vc2 & crown beast/celebi met location suggesting add vc2 crystal sensitive detection add 2 more usum trainer stats (thanks holla!)	2017-11-22 21:45:30 -08:00
Kurt	4bbe586981	block ash greninja from USUM game origin ... should really be part of a 'receivable by game' check; not doing any more of these edge cases. need card hash -> permit bits for future cases.	2017-11-22 08:24:54 -08:00
Kurt	d834ae3ccf	allow banned pokemon for BattleTreeGreat in USUM ... stupid banlist removal case master still downlevels/bans	2017-11-22 08:23:50 -08:00
Kurt	d5411f1453	Add nickname flag override for encountertrade ... closes #1649	2017-11-22 08:11:53 -08:00
Kurt	9806677d5e	EncounterType init update ... move MarkEncounterTypeData back above the area size reduction so that the mark-by-locationID special handling will work prevent slottype from becoming overwritten if already defined by special case handling add examples provided to automated test cases closes #1648	2017-11-22 07:52:17 -08:00
Kurt	f25b4fea9c	Add forme range check method to personalinfo ... relocates logic to better location	2017-11-21 18:32:27 -08:00
Kurt	b2b6df7808	Shuffle encountertype loading around ... add rocksmash type for cianwood closes #1646	2017-11-21 18:32:26 -08:00
Kurt	05f2968c95	Add wormhole species to AlolanCaptureOffspring ... allows apricorn & beast balls	2017-11-20 17:16:16 -08:00
Kurt	8f5fbeb504	allow pupitar hidden ability on 2->7 ... yay	2017-11-19 19:48:45 -08:00
Kurt	a570d13dc5	Quacklin’ edge case ... can't be bothered remapping the input file to match encoding/decoding tweaks. best to just handle this one case.	2017-11-19 19:37:25 -08:00
Kurt	01dacce214	Add gs transfer met location ... 30017	2017-11-19 19:19:35 -08:00
Kurt	ef9722153f	move evochain fetch outside of location iterator ... also relocate gen12 code so it only runs for gen12	2017-11-19 15:26:41 -08:00
Kurt	6d3ee54d44	Reorder case fallthrough ... closes #1631 based on 5859daf1d8 any case -> reverse game order	2017-11-19 13:15:32 -08:00
Kurt	1b9d657c2f	Remove double encounter slot species filtering ... GetValid already filters by species move some common non-location code out of the method; can be done for the dexlevel fetching too -- future improvement.	2017-11-19 12:41:23 -08:00
Kurt	5859daf1d8	Add maxspecies checks for gen7 ... accesses arrays outside the range for the new USUM species Closes #1631 , add test case also adds lycanroc test cases for #1630	2017-11-18 21:50:48 -08:00
Kurt	6b281cbefe	more rockruff 1 handling ... y u do dis gf Closes #1630	2017-11-18 20:08:11 -08:00
Kurt	3b5e6239de	Add usum pelago encounters ... nothing exclusive, but different from sm https://pastebin.com/NhAA1vJn	2017-11-18 13:53:51 -08:00
Kurt	6394dac19f	Rework mysterygift pkm sprite generation ... don't bother converting to pkm then generating the sprite off that; use the overload with int/bool removes sav/pkm dependency for generating gift descriptions, and standardizes the names a little. maybe a PKMBase interface would be useful...	2017-11-18 11:34:23 -08:00
Kurt	f7e20a3c43	Misc tweaks ... fix roamer3 not setting IVs fix usum z items rightmost pixel getting chopped off use Gen* instead of GenNumber for specific cases (faster) add WasGiftEgg location case for Gen7 remove some unnecessary array allocations	2017-11-17 22:19:23 -08:00
wwwwwwzx	f48e6f711a	Unban white/orange Flabebe HA ... obtainable from SOS call	2017-11-17 20:19:41 -08:00
Kurt	311e110f6b	Block wild dusk rockruff ... closes #1627 adds test cases	2017-11-17 20:02:01 -08:00
Kurt	61c0bf5271	Fix italian/german b2w2 yancy/curtis OT swap ... https://projectpokemon.org/home/forums/topic/42528-bw2-in-game-trades-yancycurtis-20171117/	2017-11-17 08:38:38 -08:00
Kurt	5ae7c9a5da	Merge pull request #1623 from ReignOfComputer/master ... Flip Valid Trade OT Compare Operator	2017-11-17 08:31:30 -08:00
Kamron Batman	d2d04075bc	Replaces PCD.pkl with WC4.pkl. Tested and working.	2017-11-17 08:11:49 -08:00
ReignOfComputer	69f11ec3bc	Flip Valid Trade OT Compare Operator ... Related: https://projectpokemon.org/home/forums/topic/42528-bw2-in-game-trades-yancycurtis-20171117/	2017-11-17 23:57:55 +08:00
Kurt	55d8f4aa26	Add rockruff event evo edge case ... different altform IDs	2017-11-16 21:04:51 -08:00
Kurt	025b8da52c	Flag invalid forms on sav compatibility check ... closes #1615	2017-11-16 14:30:18 -08:00
Kurt	8958646ae6	Fix game specific pair evolution comparison ... US table with SN result in false; just check the even/odd for these (as they are pair specific). Closes #1611 , thanks @Ammako !	2017-11-16 14:20:13 -08:00
Kurt	0cfb79a3e2	handle hacked edge case input ... gen7 pkm version on format5 -> exception on new int[-X] normally caught via exception suppression but better to handle the cause.	2017-11-15 18:13:04 -08:00
Kurt	725d094a0d	Add dusk form rockruff check ... Repurposes "alolan only form" to specify that the form cannot be obtained with the current game of origin. Closes #1611 sorry for butchering any translation	2017-11-15 16:28:47 -08:00
Kurt	5fbf331827	Fix trade evolution check ... incorrect behavior; check for milotic case if appropriate first Closes #1609	2017-11-15 10:11:05 -08:00
Kurt	897ed84933	update milotic specific evolution checks ... verifier: return true if detectably traded check: invert condition to skip out if it is verified traded	2017-11-15 08:36:09 -08:00
Kurt	3832a8afd4	Fix noibat trade gender ... closes #1608	2017-11-15 08:23:45 -08:00
Kurt	5e6b2f43c2	Update wild/egg generators for totem cases ... so wonky edge cases	2017-11-14 08:43:04 -08:00
Kurt	8b5803781d	Add bewear location ... All static encounters have been found! Closes #1577	2017-11-13 20:50:10 -08:00
Kurt	4341dc1775	Add Galactic Key to usum key items permitted ... add zygarde cube reconstructs gifts, thanks @sora10pls !	2017-11-12 21:56:08 -08:00
Kurt	9b61c94402	Add ditto5 natures ... thanks @wwwwwwzx for pointing this out remove others that have encounter details forced (for totem battles)	2017-11-12 12:15:08 -08:00
Kurt	55c31cb598	Update encounters ... add ability locks for sm gifts add poipole secondary location add magearna details	2017-11-12 10:59:23 -08:00
Kurt	54b9fa7c93	Merge pull request #1592 from sora10pls/patch-1 ... Update USUM static encounter list	2017-11-12 09:18:31 -08:00
Kurt	064d18c13f	Add necrozma special forme moves ... not present in the levelup movepool like they should be...	2017-11-12 09:17:59 -08:00
Matt	6ecc7f2efb	Update USUM static encounter list	2017-11-12 12:08:48 -05:00
ReignOfComputer	0b95f7d4b8	Porygon/Zygarde/Trainer School Encounters	2017-11-12 22:29:21 +08:00
ReignOfComputer	f1e7c0f759	Hypno Trio Encounter at Hau'oli City PD	2017-11-12 18:33:06 +08:00
Kurt	dea70bf243	Add cosmog & zygarde gift locations ... thanks @architdate ! (thanks @bui for the pikachu!) porygon remains	2017-11-11 17:24:49 -08:00
Kurt	d674ea4f39	Add surf pikachu details ... Closes #1589 Thanks @PolarPeridot !	2017-11-11 17:16:31 -08:00
Kurt	e6c68a8fc9	Add heavy ball permissions for USUM ... heavy ball now works in USUM	2017-11-11 16:26:22 -08:00
Kurt	5d90e9dc53	Refactoring ... check alolan forms for forme matching, break up large method to something a little more understandable.	2017-11-11 09:35:07 -08:00
Kurt	f5a6f23161	Add more static enc data ... clear out unused (highly certain) SM encounters add solgaleo/lunala locations add partner form pikachu	2017-11-10 19:43:31 -08:00
sora10pls	6cd2a08238	Fix Type: Null location	2017-11-10 13:19:47 -05:00
sora10pls	1d44c45fe0	Fix indenting	2017-11-10 13:16:43 -05:00
sora10pls	6f58698187	Add more static encounter locations	2017-11-10 13:08:36 -05:00