Kurt
78ff441e8b
Update iencounterable api with new criteria arg
...
rearrange some logic for clearer function (extract some methods)
2018-12-29 22:24:34 -08:00
Kurt
c2422d6927
Misc updates
...
possibly gonna update the iencounterable api for criteria
check/enforcement, rather than just generating random encounter data.
2018-12-29 22:19:44 -08:00
Kurt
d5a8d29088
Misc updates
...
reduce some allocs, clearer names/enum usage
2018-12-27 20:24:24 -08:00
Kurt
2d75e93ef0
Move encounter matching logic to iencounterable
...
generator logic is now clean
2018-12-27 01:00:08 -08:00
Kurt
3481780e06
Add initial sizes
...
maximum is always 3; sometimes we know the max size so specify.
bcl has default size = 0, which then resizes to 4 on first addition
wow such optimization
2018-12-26 22:13:04 -08:00
Kurt
950d0a8525
Add nature bounds check & legality
...
expand string array check to cast and check against length; batch editor
Nature>=25 causes problems in hover tooltips. Previous commit fixed for
pb7 stat calcs for invalid natures, pretty sure the actual game is
exploitable for stat calcs and invalid natures (bad access), but isn't
exploitable as it's only used to retrieve an enum to switch against.
2018-12-25 22:59:52 -08:00
Kurt
69a3272036
Remove fossils from key item (count==1) list
...
Closes #2215
can't depend on 'key item' item flag since the game allows you to get
multiples
2018-12-25 12:31:13 -08:00
Kurt
ff649009ca
Misc tweaks
...
misc perf adjustments
add utility for slot locked check (without box argument, absolute slot
index)
localize dragdrop strings
increase dragdrop file delete delay (dropping files into discord waits
until you confirm; 10s gives enough time to hit confirm)
2018-12-17 11:17:19 -08:00
Kurt
22b9da58e2
Add priority setting for yielding possible encs
2018-12-15 21:34:50 -08:00
Kurt
269524849e
Fix crystal-only base move case
...
Qwilfish has crystal-only move for the encounter, and the encounter is
available on G,S,C. Check both origin games always, better to be
complete & exhaustive than faster & incorrect :)
Thanks Brittany!
https://projectpokemon.org/home/forums/topic/48802-bugemerald-eggs-crystal-learnsets/
2018-12-15 15:10:20 -08:00
Kurt
5d5259ddd2
edge case for egg OT name length
...
https://projectpokemon.org/home/forums/topic/48802-bugemerald-eggs-crystal-learnsets/
2018-12-14 23:30:21 -08:00
Kurt
eb69e86722
Unban go sandshrew/slash & shiny
...
https://twitter.com/serebiinet/status/1070583259875237888?s=21
2018-12-06 07:10:39 -08:00
Kurt
20e3da7e5f
Add pb7 evo check continuation
...
oops
Closes #2202
2018-12-05 20:55:57 -08:00
Kurt
06d8b6609b
Add outsider evo check for beluga
...
Closes #2200
2018-12-05 18:38:05 -08:00
Kurt
ec4088b1fe
Cleanly lay out hgss swarm data
2018-12-02 14:46:17 -08:00
Kurt
77a4691a58
Add remainder of relicanth swarm data
...
https://projectpokemon.org/home/forums/topic/48702-bug-ss-relicanth-encounter-error/
Thanks finalevil151!
2018-12-02 14:39:24 -08:00
Kurt
2c2e5f60b3
Fix AV message for go transfers
...
formatted now
2018-12-02 09:08:42 -08:00
Kurt
d41197828b
Misc fixes
...
apply version after adding (was previously left as Unknown version ID)
add Route 9 to rarespawn flying list (thanks @sora10pls )
2018-11-29 16:06:25 -08:00
Kurt
35a85670b3
Set height/weight dex values
...
Closes #2167
Based off sub_71001D16A0 with shortcut modifications:
* code marks new entries for evolution processing later using the low
bit (hence the << 1); in save files I can't see any bits set, but I
can't see anywhere in the code that DOESNT set this bit. Thus the
assumption of post-processing.
As noted in gameplay, a new capture doesn't set Min and Max; it only
sets it if it is above the usual sizing values.
Megas apparently don't set until seen in battle, so don't worry about
setting the other forme based indexes.
2018-11-27 22:05:36 -08:00
Kurt
76a2e4f527
Add AltForm parameter to exp/level fetch
...
Starter Pikachu & Eevee have different growth rates than their base
forms (seriously WHY?)
remove old api surface in PKX as a breaking change as adding the
parameter is necessary.
2018-11-26 16:55:16 -08:00
Kurt
5f0d1d423b
Disallow volt tackle tutor for pb7
2018-11-25 19:44:19 -08:00
Kurt
71f1e6238a
Misc fixes
2018-11-23 10:15:49 -08:00
Kurt
f358c0e4cf
Handle all deviating met location string versions
2018-11-22 10:11:51 -08:00
Kurt
58080f36c9
Add WB7 and legality detection logic
...
Derived from WC7 with minor alterations (dynamic OT/Nickname which is
stored in the Full data). Since the 0x108 is not stored in the save
file, just keep the full data around.
2018-11-21 12:24:41 -08:00
Kurt
0ebfb38717
Add Route 20 to sky encounter rarespawn list
...
Thanks @ReignOfComputer !
2018-11-20 23:00:16 -08:00
Kurt
7bd3bfc52e
Update rarespawn restrictions for birds
2018-11-20 13:38:49 -08:00
Kurt
3e711acd05
Disallow egg moves in suggestions for cxd/gg encs
...
https://projectpokemon.org/home/forums/topic/48547-remove-eggmoves-from-green-learnables-move-in-lets-go/
2018-11-20 13:38:05 -08:00
Kurt
ba1a7c2bcf
Fix broken tests
...
rework getblank for version specific
2018-11-19 16:14:49 -08:00
Kurt
4022d7fea9
Add check for invalid pgo shiny transfer
...
Thanks @sora10pls !
2018-11-19 13:07:21 -08:00
Kurt
70fe7f58ee
Remove eevee, revert porygon
2018-11-18 20:39:15 -08:00
Kurt
67cc6bdead
Account for wild catch combo/lure level boost
...
Route 4 sandshrew captured at level 13 (12 is max)
+1 for now, not sure if it can go higher
2018-11-18 16:17:39 -08:00
Kurt
b818aff48a
Remove evo tree sanitization
...
Evo data doesn't provide evolution values for these, fortunately.
2018-11-18 15:25:03 -08:00
Kurt
17348c1808
Add bird rare spawns
2018-11-18 10:36:28 -08:00
Kurt
1c0b2488ef
Update lapras/porygon gift locationIDs
...
Thanks Asia81!
2018-11-18 09:41:52 -08:00
Kurt
edce01a857
More strict egg nickname length check
...
only fishy if it was traded & within bounds
2018-11-17 18:29:05 -08:00
Kurt
029e0e0a08
Manually add rare slot locations
...
placeholder; hopefully this isn't permanent
2018-11-17 15:12:32 -08:00
Kurt
d3534781db
Allow premier ball for captures
2018-11-16 18:59:18 -08:00
Kurt
1c26c7713f
Fix starter bypass
...
lol oops, hotfix inc
2018-11-16 18:17:01 -08:00
Kurt
013bc70ed9
Add more pb7 legality checks
...
can give nicknames to chinese mons now! Encoding looks the same
@wwwwwwzx :)
2018-11-16 17:42:50 -08:00
Kurt
a2eef9deae
Misc fixes
...
it is version exclusive; fix magikarp speed IV
2018-11-16 16:44:25 -08:00
Kurt
ea4d9861c8
Disallow starter friendship move in learnset
...
Joycon shake only, never actually in moveset
2018-11-16 14:56:20 -08:00
Kurt
720e04ff91
Allow 7b trades to be shiny
...
remove the todo, thanks twittersphere
remove version exclusivity for puppycat (can be done on either ver)
2018-11-16 14:20:06 -08:00
Kurt
dae4a0a0ae
Add EV/AV verification for pb7
2018-11-16 14:19:24 -08:00
Kurt
7da46623b8
Ignore ball check for invalid encounters
...
Defaulting to pokeball isn't entirely appropriate
2018-11-15 18:40:08 -08:00
Kurt
ed5abbd686
Add puppycat NPC location
...
Thanks (twitter) thelostdogg!
2018-11-15 18:39:30 -08:00
Kurt
94b924fdfc
Add ingame trade IVs and random AV notes
...
exclusive maximum, not inclusive
2018-11-15 17:35:34 -08:00
Kurt
93ff395875
Add more succinct go park IV check string
2018-11-15 17:35:11 -08:00
Kurt
43a9d4eb99
Add gg evolution tree
...
turns out it was totally needed; am glad I didn't do the silly stuff of
past gen evo tables (gen6/7 is just raw evo data)
2018-11-15 17:34:54 -08:00
Kurt
22063d3907
Add ingame trade met locations
2018-11-14 23:04:40 -08:00
Kurt
a64d08e7e9
Add GO transfer IV verification
2018-11-14 18:25:43 -08:00
