Kurt
2874f6fc69
Revise pichu volt tackle egg handling
...
Clean up ParseMovesWasEggPreRelearn as only EncounterEgg call into it, and no EncounterEgg has a special moves interface implemented.
2021-09-15 18:43:18 -07:00
Kurt
63580a2835
Minor tweaks
...
For BigEndian we don't have to invert the array access if we just iterate backwards :)
Fix xmldoc for gen1 trades ampersand
Add xmldoc for enc trade classes
No functional change.
2021-09-15 18:13:17 -07:00
Lusamine
a779000097
Include Thunderstorm for Honeycalm Sea Seadra
2021-09-12 16:14:22 -05:00
Kurt
1d00e17217
Add properties for cleaner interaction
2021-09-07 15:31:54 -07:00
Kurt
2575d73144
Add IFixedAbilityNumber, hide vivillon region flags
...
tfw can't using static a private class in the file, gotta be explicit.
2021-09-06 18:11:32 -07:00
Kurt
41b1aaeb19
Search mystery gift relearn moves for needed moves
...
Add to encountertrades searcher, for futureproofing
solves gen8 mg searching volt tackle pikachu
2021-09-06 11:43:42 -07:00
Lusamine
9751a75f59
Free Sgr7121 GMax Duraludon
2021-09-06 13:26:18 -05:00
sora10pls
9bd0104954
Add new distribution raids 🧹
2021-09-02 20:04:14 -04:00
Kurt
348fa4c9fa
Force Gen2 Red Gyarados to be male only, fixed IVs
...
Closes #3251
Uses fixed IVs to force shininess (rather than mutating DVs)
1f9e688b76/engine/battle/core.asm (L6103-L6110)
2021-08-29 13:23:34 -07:00
Kurt
7434af48bf
Fix HT know move memory deferral
...
Checks if it can know the move up until the current format, rather than origin game
2021-08-28 13:44:10 -07:00
LegoFigure11
eeaf19f1c2
Fix incorrect met locations in XD GoD ( #3250 )
...
The Hexagon Brothers can be rematched in Phenac City if their shadows aren't snagged at the Cipher Lab, but Seedot, Houndour, Gulpin, and Spheal are all encountered outdoors (Phenac City (XD) [100]). Mareep and Baltoy are both encountered downstairs in the Mayor's House (Phenac City (XD) [096]).
Relevant .xk3 files: https://cdn.discordapp.com/attachments/537784151970021376/880816626176495626/Phenac_Rematches.zip
2021-08-27 07:33:12 -07:00
Kurt
0e2dac3ff6
Minor tweaks
...
Empty return for invalid species encountertemplate fetch
Expose property for ck3 @ 0xD7
show legal memory context items rather than gen8 always
2021-08-25 19:23:15 -07:00
Kurt
c1a7d04c5c
Fix ck3 fateful read
...
Hope 555e81205d
2021-08-24 22:23:45 -07:00
Kurt
ffcd2e96e0
Fateful Mattle Ho-oh on japanese colosseum
...
must have been an oopsie they reverted for international releases
Thanks @liketolike !
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
#3242
2021-08-24 19:29:51 -07:00
Kurt
6e3bcd5b66
Encounter visualization: Show ball and differentiate visually
2021-08-24 14:03:20 -07:00
Kurt
28e7473f1a
Condense some expressions
2021-08-22 01:26:28 -07:00
Kurt
92d1666970
Make PIDIV a readonly struct
...
Add tests to ensure the optimization remains in effect later
2021-08-21 18:24:38 -07:00
Kurt
ae0ca49628
Arrange CXD Shadow encounters, add ShadowID documentation
2021-08-21 17:01:50 -07:00
Kurt
cd12962a50
Remove Tradeback state caching in PKM data
...
Since we have more metadata with move learn sourcing, we can check if it was traded to gen2 to get new moves / deleted.
Adjust call sites appropriately
might have some issues, to be ironed out maybe
2021-08-20 15:59:54 -07:00
Kurt
bedc52943e
Trailing commas
...
No functional change
2021-08-20 13:49:20 -07:00
sora10pls
5379bad7ff
Add new distribution raids 👻
2021-08-19 21:20:56 -04:00
Kurt
934628b077
Pre-filter memory mismatch on moves
...
All over the place with prior commits; everything should be correct (and more robust) now.
2021-08-15 14:23:15 -07:00
Kurt
31ddaf2bc4
Don't defer on ability mismatch
2021-08-15 11:07:59 -07:00
Kurt
42330eb771
Memories and special moves, bite the bullet
...
Allocate a list :(
We need to keep all the secondary deferred around, since they have special movepools.
2021-08-15 09:47:31 -07:00
Kurt
7c60363b38
Rework match ranking to have multi levels of deferral
2021-08-15 09:28:47 -07:00
Kurt
db1cbf8cce
Handle raids with specific TR moves tripping memory checks
...
Defer the ones that have the memory and don't have the move; we'll likely find another match else settle for this one.
2021-08-14 19:47:52 -07:00
Kurt
b8e203bdef
Remove invalidmatch tracking
...
The Encounter verifier method rarely rejects as our inner encounter matching methods are all-or-nothing. Don't bother keeping references for this bloat.
Ran the unit tests and nothing hit this logic.
2021-08-06 15:38:39 -07:00
Kurt
9f8642f7d2
Hide Generation/Game setters behind mutation method
2021-08-06 15:35:49 -07:00
Kurt
70e10478dd
Extract fog boost location check
2021-08-06 14:54:32 -07:00
Kurt
c126cd968a
Only boost templates to 60 in wild area
...
No functional change for legality checks, so should be fine unless you're trying to get tiny edge case stuff.
2021-08-06 09:42:27 -07:00
Kurt
0f3e5095c5
Replace more linq usage
2021-08-05 22:39:38 -07:00
Kurt
e18c2d8fa4
Replace linq with similar but faster logic
2021-08-05 20:47:32 -07:00
Kurt
5c472a400d
Expand shorthand parameters
...
int i => int index, or whatever the value is representing.
2021-08-05 20:33:25 -07:00
sora10pls
2766c2c900
Add new distribution raids
...
Apparently the theme is summer
2021-08-05 20:03:56 -04:00
Kurt
2f9a60b5e6
Organize byte resources into subfolders
2021-08-05 15:35:29 -07:00
Kurt
cc0397f087
Misc tweaks
...
Improved readability
2021-08-05 15:18:43 -07:00
Kurt
ab3795abaa
Handle enc->pk7 form-random vivillon Island Scan static
2021-08-05 12:36:47 -07:00
Kurt
0a74f6c33d
Ignore species for rby if not present
...
encounter moves not present for those, lol
2021-08-05 12:36:19 -07:00
Kurt
616acc8bbd
Misc fixes
2021-08-04 19:54:04 -07:00
Kurt
83a72df7cc
Include gen1 encounter moves in not-needed list
...
Might result in some illegal matches as it includes it for all evolutions in the chain, but whatever. Could probably rewrite the generator to only generate for different starting-species, but it's fine now.
Inline the max level calc
2021-08-04 19:07:20 -07:00
Lusamine
2858c6636d
Minor adjustments to area slot extensions
...
Invert check for crossover to disallow hidden (there are more symbol
tables). Galar Mine No. 2 has hidden fishing slots as well as curry.
HiddenMain3 SlotType was never used so it was removed.
Updates pkl to remove HiddenMain3.
2021-08-03 13:03:04 -05:00
Kurt
277b1b658d
Un-nest 3ds console region bitflags
...
Insert 3DS into the name to indicate that it's for the 3DS
2021-08-02 20:59:40 -07:00
Kurt
66f1b23dc6
Consider the "SkipFormCheck" for gen7 scatterbug static
...
Rework to match the encounter slot form-ambiguous checks
2021-08-02 20:45:52 -07:00
Kurt
140f814f90
Update EncounterMovesetGenerator.cs
2021-08-02 20:25:16 -07:00
Kurt
1efebe51d3
Simplify Country/Region/ConsoleRegion to byte from int
...
Only exists in gen6/7 games.
2021-08-02 19:43:57 -07:00
Kurt
c1f13923c8
Update EncounterSlot7.cs
2021-08-02 08:57:03 -07:00
Kurt
846f9506fb
Misc form handling update (EncounterSlots)
...
Mark gen7 Minior slots with 31
Mark gen2 Unown slots with 31
Mark gen4 Unown slots with 31
2021-07-31 22:41:52 -07:00
Kurt
1bc5cb1113
Handle special form cases for IsSane
2021-07-31 20:50:29 -07:00
Kurt
e2db713621
Update EncounterSlot8.cs
2021-07-31 00:01:55 -07:00
Kurt
de94876822
Minor tweaks
...
no functional change
2021-07-30 16:22:10 -07:00
