Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 00:13:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
4912 commits 3 branches 76 tags 119 MiB
Commit graph

4912 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kurt
c5ea35a1a1 Continued refactoring 
Move chain prune from Analysis to evochain spawn
 2018-06-19 17:50:10 -07:00
Kurt
9728d7a09f Fix gender formes carrying over to others 
Closes #2022
Thanks @iiippppk !
 2018-06-19 17:27:44 -07:00
Kurt
f10cc183a7 Refactoring 
Relocate Evolution Chain logic
minor reorg of check arguments for nesting / grouping
 2018-06-19 17:14:22 -07:00
Kurt
f3ef122214 Refactoring 
continued simplification

core.cs is pretty much the following:
misc one-off junk
moveset fetch
encounter table fetch
evo chain fetch

might eventually move things around a bit further for cleanliness so
that misc meta junk is the only thing that remains in core.
 2018-06-18 21:56:30 -07:00
Kurt
c6e968c77d Only generate encounter moves if species unmodified 
Closes #2020
 2018-06-18 21:54:32 -07:00
Kurt
0c06506a8d Refactoring 
remove some unneeded logic
moves in gen1/2 can be reordered, sequence match should be intersect
(full) contains match.
 2018-06-18 19:57:32 -07:00
Kurt
2e1081086d Refactoring 
Split evolution data specific DexLevel properties from DexLevel

use IReadOnlyList instead of IList for covariant collection
 2018-06-18 19:10:21 -07:00
Kurt
bff5a3cd9a Add altform permissive checks for gen1/2 
Should always be zero, but necessary for regional variant evolutions
needing to be excluded
#2018 (not fixed yet)
 2018-06-17 21:54:04 -07:00
Kurt
2813b19be0 Fix out of bounds species fetch 
provide max species ID rather than table length check; this[>#] can
return forme specific values which do not relate to the species

#2020
 2018-06-17 21:52:52 -07:00
Kurt
7791020cb4 Check format before trim 
Closes #2016
 2018-06-17 21:01:07 -07:00
Kurt
a6915030ca Remove duplicate dict entries 
oops
 2018-06-17 20:51:02 -07:00
Kurt
33eded08d1 Add missing learn/personal references for pairs 
Closes #2019
 2018-06-17 20:49:03 -07:00
Kurt
9a0ddf1f5e Handle farfetch'd ’ nickname check case 
https://projectpokemon.org/home/forums/topic/45837-g3%C2%A0farfetch’d-nickname/
Thanks Davil!
 2018-06-17 11:34:39 -07:00
Kurt
e91cfeb707 Handle pre-VC2 era tradeback status for suggestions 
#2015

Can't get a shiny female 1:7 f:m gender ratio transfer after the VC2
bank update; need to respect that when generating random moves for the
pkm by removing any gen2 evo chain data.
 2018-06-17 09:55:07 -07:00
Kurt
dd57558e98 Update moveset suggestion for vc origin 
Closes #2014
 2018-06-17 09:39:01 -07:00
Kurt
d15acea6b4 Flag KOR on Battle Revolution savefiles 
Closes #2013
 2018-06-17 09:27:14 -07:00
Kurt
3a7a257a01 Add export current box to showdown pastes 
Rework box fetch in SaveFile to be a little more flexible, can now fetch
a single box

Hold control to... export all boxes :)

I wonder if there's a decorator that showdown skips when importing lines
that can help differentiate the boxes since there's the potential for
hundreds output (ie comments in a showdown set?) doubt it.
 2018-06-16 21:56:16 -07:00
Kurt
1ab7acc958 Ignore empty pkms when exporting a list of sets 
chain method calls
 2018-06-16 21:46:43 -07:00
Kurt
39ce7e56e4 Cancel boxmenu if not clicking tab 
contextmenu is set causing it to open for anywhere in the box area
that's white
only show if right clicking the tab at the top
 2018-06-16 17:03:22 -07:00
Kurt
cb0ae14a50 Set gender for gen3-5 reroll 
#2012
 2018-06-16 13:27:50 -07:00
Kurt
b81cad84ab Fix arg providing for GetRandomPID call 
Closes #2012
 2018-06-16 10:51:53 -07:00
Kurt
efe77e3b5c Don't clear unown forme on pk4->bk4 
Closes #2011
 2018-06-16 10:29:36 -07:00
Kurt
c3cbb0fc44 Fix gen2 vc1 evo prune 
https://github.com/kwsch/PKHeX/issues/1999#issuecomment-397818377

evo chain had already pruned tyrogue due to level 20 transfer level
(lvl19 tyrogue not possible), can't just remove last entry. Remove any
entry after the g1 species.
 2018-06-16 09:06:12 -07:00
Kurt
be3eeb4036 Hide batrev trainer/inventory buttons 
Closes #2010
 2018-06-16 07:52:45 -07:00
Kurt
f8a1d26694 Fill empty ability values with ability1 
update handling that checked for this case to instead check for
equivalence to ability1 instead of 0

was generating a PGF with ability[1] = 0, which is not correct. Just fix
the binaries to behave and get rid of all the workarounds since future
tables don't have missing values.
 2018-06-15 23:41:07 -07:00
Kurt
88b5277062 Misc mg gen fixes 
Fixed gender PCD with dynamic PID needs to check gender validity (some
korean card had it)
Fixed wc3 generated force-hatching to unflag fateful for non-frlg and to
hatch on the designated game just in case

stuck on a PGF issue where ability doesn't match PID, need to revisit
that PID creation...
Card #: 0002 - がくえんさい×ポケモンプレゼント
 2018-06-15 22:00:51 -07:00
Kurt
b0b2fb5d4b ShowdownSet parse refactoring 
Rework line parse to be simpler
Closes #2009 , now handles case
 2018-06-15 20:30:23 -07:00
Kurt
49c36e2173 Misc legality gen tweaks 
bypass savefile language checks if no language set
fix gen2 static gift egg that is really a wild encounter -- egg flag was
set & not cleared -> no wild pkm, bad! Adds test case for this.
(probably isn't a better place to clear, enforces only once per
generation rather than on every yield/end of every static yield)
 2018-06-15 18:47:17 -07:00
Kurt
6fc33f4b19 Fix level fetch arg order 2018-06-15 16:53:28 -07:00
Kurt
cb5e1239ae Refactoring 
Extract game value limits
Rearrange GameVersion util logic extensions
add better gameversion fetch for generator (equivalent to pkmeditor)
 2018-06-15 16:00:28 -07:00
Archit Date
b9f4a554f0 Reset IV backcolor if pkm cannot be hypertained (#2008) 
fixes #2007
 2018-06-15 13:45:56 -07:00
Kurt
e8d5252b8c Reject moves introduced by gsc in pk1/vc1 cases 
Closes #2005
(no tutor moves are new moves, just beam moves)
 2018-06-14 18:52:43 -07:00
Kurt
7a5ce5aa78 Remove unmaintained portuguese side-translation 
Closes #2004
no changes had been submitted since originally committed on 3/5/2015; 3y
of inactivity.

users can always place "lang_en" to replace the english translation with
their own GUI strings; not worth maintaining non-series language
support.
 2018-06-14 17:03:56 -07:00
Kurt
f54f90bd4b Add egg Rotom/Furfrou form check 
Closes #2002
Thanks @iiippppk !
 2018-06-13 22:10:01 -07:00
Kurt
5579c4c80d Tidy up MoveLevelUp 
use the Learn objects from prior commits for adding a range of moves
 2018-06-13 22:03:58 -07:00
Kurt
dcfeff7bf3 Update batch editing 
Permit all possible properties in the dropdown, handle can't write cases
(many) as well as can't read (I don't think there are any of these).

https://projectpokemon.org/home/forums/topic/45789-how-to-require-a-pkm-equals-a-shiny-pid-in-batch-editor/?do=findComment&comment=232757
 2018-06-13 18:52:09 -07:00
Kurt
39daa6c65d Split GetIsLevelUp to individual versions 
static the GameVersion reference as we're excessively using it in the
switch cases, for clearer reading
 2018-06-12 22:15:06 -07:00
Kurt
b9652a835d Weaken gen2 egg species checks for pre-evos in gen1 
VC can inhabit both gens

Add Tradeback setting setter for legality tests
Add GBCartEra setting setter for legality tests

Thanks @iiippppk !
 2018-06-12 18:46:31 -07:00
Kurt
64a64b8ce1 Add special handling for gen1 encounter move fetch 
Begin splitting of GetMovesLevelUp per-gen into per-version
 2018-06-12 18:35:56 -07:00
Kurt
33fb382c3c Hide ResetMoves for Gen1/2 
Legally resetting data is too much of a pain, just hide the option.
Closes #2000
 2018-06-12 17:54:21 -07:00
Kurt
c3314f1b8e Remove Mirage Island met location from valid gen3 
Although Pokémon Ruby, Sapphire, and Emerald include a location pointer
for "Mirage Island", any Wynaut caught here will simply display "Met on
Route 130" in their summary. This is because the player is technically
still on Route 130's map.

Can't get anything with that location ID as an egg or as wild
 2018-06-12 16:41:44 -07:00
Kurt
5ad8a4e5a4 Return version-sensitive moves for nonspecial fetch 
Closes #1998 , GetValidMoves returns moves without sensitivity for
current version for pre gen6 moves... can resolve that later.
 2018-06-11 20:23:28 -07:00
Kurt
fb6e28112a Update emerald event flags 
0x60 + RS offset, add some E exclusive flags (frontier)
update const a little
Closes #1997
 2018-06-11 16:27:42 -07:00
Kurt
4778c9c758 Fix RSBOX checksum 
Closes #1995
clean up variable names
 2018-06-11 09:12:41 -07:00
Kurt
32a83c16f1 Add egg relearn/move sequence match check 
#1994
 2018-06-11 08:13:50 -07:00
Kurt
e5a2e12fa5 Check held items for pk2 eggs 
Closes #1993
Thanks @iiippppk !
 2018-06-11 08:05:15 -07:00
Kurt
242fc295b4 Handle smeargle egg case 
#1993
Just use precomputed array since it can only know sketch
 2018-06-11 08:03:10 -07:00
Kurt
9faba26e90 Add egg base move branch 
Closes #1991
Thanks @iiippppk  !

Improve pk2 version detect to better provide gs vs c egg base moves
 2018-06-11 07:23:48 -07:00
Kurt
1d24e459f9 Fix box data report out of range gen1/2 
Closes #1992 , val was -1
 2018-06-11 06:36:43 -07:00
Kurt
ca9f21fa49 Fix base move count vs inherit check 
Closes #1990
Thanks @iiippppk !
 2018-06-10 20:26:59 -07:00