Matt
963cb1aa99
Unban GO Shiny Lapras ( #2287 )
2019-04-17 22:49:58 -07:00
Kurt
d8f064409f
Fix pk1->pk2 conversion parameters
...
https://projectpokemon.org/home/forums/topic/52273-replicable-issue-cant-inject-pk1-in-silvercrystal-save/
Thanks Maddaren!
2019-04-17 18:35:51 -07:00
Matt
b8c490ae2e
Update GO shiny banlist ( #2286 )
2019-04-17 12:53:13 -07:00
Kurt
35851fcf5c
Simplify and enhance expression
...
cache fetch of PersonalInfo (avoid re-fetching)
If event, the pkm wasn't bred with ditto
If genderless or male-only (except nido/volb), assume ditto
2019-04-16 23:07:47 -07:00
Kurt
ab64eb5850
Trim unused
2019-04-16 22:58:37 -07:00
Kurt
a481757b45
Relocate CheckEncrypted to PKX
...
PKX references within the method; no dependence on anything in
PKMConverter
2019-04-16 22:51:01 -07:00
Kurt
5a53c2490a
Simplify expression, emit inner error messages
...
existing logic had been overwriting the inner error messages with the
generic fail message
Remove backwards conversion precondition check; the ConvertPKM method
has no branches that allow conversion so it'll naturally fail -- end
result is the same with less upfront logic.
2019-04-16 22:38:50 -07:00
Kurt
86d10af78b
Minor clean
...
cache Generation value, store arceus stuff as ushort
2019-04-16 22:14:21 -07:00
Matt
7e553155e1
Fix PKM conversion prompt order ( #2285 )
2019-04-16 10:54:29 -07:00
Kurt
5da9051431
More accurate sound option names
...
Deviating from official option names, reflect the end result instead.
clarity > accuracy
#2283
2019-04-15 15:46:03 -07:00
Kurt
934595126f
Simplify qr gender
...
use personalinfo object to do majority of work,
end result has the 4 sequential bytes set neatly
2019-04-15 15:43:48 -07:00
Kurt
286df71c5a
Hide sound type for nonyellow gen1 saves
...
Closes #2283
Fix label name & update translation file for them
2019-04-15 15:38:49 -07:00
Kurt
9736efd332
Updates continued
...
Use clone track bool
could instead track the result for each pkm step instead, for extending
functionality to mass-delete any flagged entry (cleanup).
2019-04-14 16:04:36 -07:00
Kurt
95267afb2d
Add bulk check to Checksums button
...
Hold control to have the Bulk Legality analysis spit out its results to
the clipboard.
2019-04-14 09:08:33 -07:00
Kurt
34ea56c2a7
Minor updates
...
Fresh day, fresh tests of the new code :)
Fix assert conditions
Add extra considerations
Detected clones should be skipped for PID/EC/TID checks -- should
probably detect this a different way rather than checking a computed
string (bool array of flags for the clone check results)
2019-04-14 09:06:43 -07:00
Kurt
0fdd9d98e6
Fix xmldoc typo
2019-04-14 09:04:40 -07:00
Kurt
3d60bea245
Add savefile-wide pkm legality checks
...
clone checks, duplicate PID/EC/TID
untested & no gui access for now
2019-04-14 01:06:34 -07:00
Kurt
74a45c436a
Remove machoke trade catchrate restriction
...
reverts to 90
Closes #2282 , also evident in RoC's PC files (as 90 catch rate).
2019-04-12 22:46:05 -07:00
Kurt
289a36cbd4
Relocate tables to folder
...
less overpopulated folders
2019-04-12 14:12:30 -07:00
Kurt
ba2b9ace8d
Use byte for pp value storage
...
more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-10 22:05:57 -07:00
Kurt
27dfffd5b2
Add model-gender/starter-gender get/set
...
https://projectpokemon.org/home/forums/topic/52127-lgpe-save-research/?tab=comments#comment-243751
Thanks theSlayer!
(starter gender not modifiable via gui)
2019-04-10 17:03:05 -07:00
Kurt
82fb95b436
Add ConfigSave language get/set
...
This value is what determines what language the game runs with
2019-04-09 21:19:08 -07:00
Kurt
f4740bbe52
Capture reused variables
2019-04-09 20:58:19 -07:00
Kurt
1a343c3b21
Add more xmldoc
2019-04-09 20:57:44 -07:00
Kurt
2f2512b09c
Reduce allocations for checking file write time
...
FileInfo inherits from FileSystemInfo, which initializes a bunch of
strings that we don't need
this isn't a great optimization, just a fun exercise finding a quicker
approach to get these values
2019-04-05 18:45:59 -07:00
Kurt
054d498619
Add vc transfer nature checks
...
Closes #2279 thanks @SadisticMystic !
2019-04-03 20:13:35 -07:00
Matt
21e7d82468
Update GO shiny banlist ( #2278 )
2019-04-02 13:59:43 -07:00
Kurt
9e83e13559
Update 19.04.02
...
Update mgdb too
2019-04-01 18:35:01 -07:00
Kurt
e96fafcfdd
Remove version.txt
...
now done with gh release metadata
2019-04-01 18:18:26 -07:00
Kurt
e3b3c74ccb
Split off old changelog text
...
archives changelog, prevents it from being compiled in (size reduction)
2019-04-01 18:18:14 -07:00
Evan Dixon
1ccbddd442
Merge pull request #2276 from kwsch/nupkg-license
...
Add NuGet metadata
2019-04-01 19:47:55 -05:00
Kurt
e6fd8560ee
Only show reset key value for int/ko saves
...
e1a3c8edb3 (commitcomment-32979627)
2019-03-31 16:59:01 -07:00
Kurt
bbe56a3318
Simplify trade trainer parameters
...
Bank was always false, don't try to minimalize gets by fetching before
call (be simple)
remove unreachable branches now that dust has settled
2019-03-30 22:05:28 -07:00
Kurt
e614aa9ac8
Relocate xd/batrev encryption
...
update some xmldoc too
2019-03-30 21:28:32 -07:00
Kurt
f212ba29c9
Misc reductions
...
same stuff as previous commit but for Gen2
EventConstMax is always > 0, remove guards
2019-03-30 16:38:52 -07:00
Kurt
4f347fbfa9
Misc reductions
...
no functional change
2019-03-30 16:21:45 -07:00
Kurt
609db23dc5
Consolidate pouch load/set
2019-03-30 16:10:14 -07:00
Kurt
db7feaa8eb
Update translations with latest additions
2019-03-30 12:37:18 -07:00
Kurt
e1a3c8edb3
Add RTC reset, allows game to define on continue
...
Closes #2273 , thanks @SatoMew !
2019-03-30 12:34:51 -07:00
Kurt
bb8cf5d3d8
Simplify get/decrypt pkm access
2019-03-29 19:43:33 -07:00
Kurt
5dcf2f4dc8
Use enum instead of nullable bool tristate
2019-03-29 17:52:26 -07:00
Kurt
4f2b9baede
Add missing stamp
...
Closes #2274
2019-03-29 09:40:31 -07:00
Kurt
86db3e85e7
Unban HA g7 monkeys
...
https://twitter.com/SerebiiNet/status/1111223652178112513
bank gift can breed to pass on HA
2019-03-28 21:44:46 -07:00
Kurt
c7a610b02b
Fix typo in method names
...
Transferrable->Transferable
2019-03-28 21:44:06 -07:00
Kurt
796e836811
Add Settings reset button
...
force closes program to prevent main form closing event from saving
settings
Closes #2272
2019-03-23 19:05:35 -07:00
Kurt
e83f313281
Remove unnecessary abstraction
...
less objects with only 1 property/field, less objects created = faster
2019-03-23 18:59:45 -07:00
Kurt
55c7bf9858
Remove unnecessary abstraction
...
EvolutionSet was just an object that hides an array, with no logic
was planning to use the EvolutionSet to do the evolution checks, but
EvolutionTree was required to connect the evolution chains together
2019-03-23 10:36:28 -07:00
Kurt
41e066c562
Consolidate duplicate logic
...
Reformat g1/2 evolution data binaries for easy loading
precomputed count => no unnecessary allocation/resizing
2019-03-23 10:05:33 -07:00
Kurt
20f023e619
Reduce allocations
...
GetMethod used to create new array every time; reuse static hashset
(same arrays)
use scan approach to allocate required count
2019-03-23 01:01:04 -07:00
Kurt
4650a6f5b5
Reduce sizes
2019-03-22 21:19:47 -07:00
