Kurt
69ad16c30f
Remove has move check for static encounters
...
Event Move special encounters are yielded after static encounters by the generator, so this iterator-picker will never behave as originally intended.
Since the encounter generator works fine for these events in its current form, we can just remove it. If we need to prefer GB era events before static, then we'd reinstate the priority and move the GenerateGBEvents before the static yielder.
bla bla bla this is just a cleanup from old preference code where we wanted to recognize the encounter as an event/trade as they're more recognizable. We just want to track the progress of the iterator so that g1/g2 follow a merged yielding order
2020-11-22 17:03:30 -08:00
Kurt
37782f0ce4
Consolidate EncounterTrade1 level objects
...
Adds Nickname checks, thanks @ShadowMario3 for grabbing these into separate text files from Bulbapedia.
I reordered all the encounters to match Bulbapedia; each level is denoted if different if it can be sourced from RBY.
2020-11-22 16:19:03 -08:00
Kurt
e701bf2725
Add Frostpoint Field for dens 175/176
...
Closes #3091
2020-11-20 18:20:00 -08:00
Kurt
dba7dc9911
Forest distribution raids
2020-11-19 16:06:43 -08:00
Kurt
ce17fd4050
Minor tweaks
...
Enc static 4 should check met location, since locations are flexible for roamers
Simplify expressions
Disallow 0 moves in "needed moves" list.
2020-11-19 15:34:06 -08:00
Kurt
9d8b528437
Update EncounterMovesetGenerator.cs
2020-11-19 07:33:35 -08:00
Kurt
0af0c05bac
Update go slot list yield and move fetch
2020-11-18 21:34:40 -08:00
sora10pls
f8dd2cf977
Update PogoType.cs
2020-11-18 21:05:46 -05:00
sora10pls
3b66e2e9b1
Add min. Level requirement for PogoType FieldP
...
Mew, Celebi, Jirachi and Victini (one-time Mythicals) require Lv. 15 with at least 10/10/10 IVs.
2020-11-17 21:56:47 -05:00
Kurt
4a8ad8b149
Expose raw evolution chain methods
2020-11-17 14:23:15 -08:00
Kurt
037db7b8a3
Add xmldoc for new obj/func related to GO legality
2020-11-16 21:17:45 -08:00
Kurt
e6a60ec210
Add single day tolerance to end of appearance period
2020-11-16 15:41:39 -08:00
Kurt
26e0f31c95
Include date legality parameters for LGPE
...
Extract common abstract class for GO transferred encounters
Clamp minlevel instead of met level
Add optional parameter for GO IV randomization
Update go legality binaries with latest
2020-11-16 15:32:22 -08:00
Kurt
770f7584c9
Behavior tweaks
2020-11-16 14:33:21 -08:00
Kurt
f25a7c7cf2
Apply valid ball on create
2020-11-15 20:51:07 -08:00
Kurt
d393773fb0
Update EncounterSlot8GO.cs
2020-11-15 18:32:30 -08:00
Kurt
d7dc69104b
Fix year check
...
still testing
2020-11-15 18:12:58 -08:00
Kurt
0ba2f6a53a
Update EncounterSlot8GO.cs
2020-11-15 17:44:13 -08:00
sora10pls
a4125472f4
Add PogoType for GO Battle League Mythicals
...
Covers Darkrai and any other future Mythical rewards from GBL.
2020-11-15 18:48:33 -05:00
Kurt
760adb4945
Check date legality
2020-11-15 08:31:48 -08:00
sora10pls
d5e1447f7c
Add additional PogoType enums, add min Lv/IVs
2020-11-14 19:36:07 -05:00
Kurt
cb57e807ce
Update EncounterSlot8GO.cs
2020-11-14 15:33:32 -08:00
Kurt
377ec02c9b
Minor clean
...
Remove GoPark as a "Type" since it is now baked into the encounter object type
2020-11-14 12:55:30 -08:00
Kurt
ad9e9ddfa0
Relocate go encounter maintenance outside of pkhex.core
...
PKHeX.Core now accepts generated pkl binaries from PoGoEncounterTool (PGET).
Refer to pporg's repo. This will be treated like event data; occasionally updated.
2020-11-14 12:51:24 -08:00
Kurt
5e22c119be
Continued refinements
2020-11-13 08:20:51 -08:00
Kurt
67a796e982
Update EncountersGO.cs
2020-11-12 22:08:13 -08:00
Kurt
82c016639d
Update EncountersGO.cs
2020-11-12 22:00:09 -08:00
Kurt
f366d27bdb
Revert Mothim form
2020-11-12 22:00:02 -08:00
Kurt
3e4d685d37
Update EncountersGO.cs
2020-11-12 20:50:39 -08:00
Kurt
01c597cba7
GO checks round 2
2020-11-12 20:41:01 -08:00
Kurt
98f602fc87
Require tracker for HOME gifts too
2020-11-11 21:27:33 -08:00
Kurt
72e209a156
Split some methods, handle flow for go enc
2020-11-11 21:22:13 -08:00
Kurt
edd9ace51e
More pogo rules
2020-11-11 21:03:47 -08:00
Kurt
df5ebd1f54
Minor clean
...
Resolve some messages
2020-11-11 21:01:41 -08:00
Kurt
915727ed67
Add g-kanto formes
...
Probably will refactor things when shiny/ball legality is detailed
2020-11-11 13:27:08 -08:00
Kurt
93ff841a1d
Update EncounterMovesetGenerator.cs
2020-11-10 22:17:23 -08:00
Lusamine
86096201e8
Add Route 3 -> Motostoke City crossover ( #3085 )
...
Not related to the location glitch; whistle to lead Zigzagoon.
Co-Authored-By: tehvik <40148574+tehvik@users.noreply.github.com>
2020-11-10 22:11:19 -08:00
Kurt
7654ce2123
Add initial legality checks for GO->HOME transfers
...
took me less than an hour to do these changes, and i can flag bad form movesets no problemo
Expect tightening of restrictions (ball, level, shininess) later
if someone wants to curate met date restrictions, go ahead!
2020-11-10 22:10:53 -08:00
ShadowMario3
7b2f76b621
Fix issue #3083 ( #3084 )
2020-11-07 22:48:46 -08:00
Kurt
cb24c20a44
Remove relearn suggestion logic from relearn move verification
...
Sure it's nice to cache a valid array, but the amount of logic was small enough that it can be done with 10 lines of code rather than at the end of each verification method.
Reduces parameter passing & removes 1 field from the info object, as relearn suggestions are only done rarely after legality checking.
Allows for a simpler api surface (pkm, encounter) rather than a bigger object reference
2020-11-07 12:25:15 -08:00
Kurt
227efc1fc3
Only allow checking if lvl60 when lvl<60
2020-11-05 21:17:13 -08:00
Kurt
ae85097c2d
Allow go shiny xor!0
...
Thanks @Lusamine for bruteforce testing to confirm
2020-11-04 20:55:47 -08:00
Kurt
c5b6c20c7b
Update MarkVerifier.cs
2020-11-04 12:58:56 -08:00
Kurt
8b25af5f85
Enforce xor=0 for go shiny transfers
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-11-03 18:56:58 -08:00
Kurt
d78424a3ad
Hande Ability Patch edge case
...
4 legends have A/A/H on form-0, and B/B/B on form-1. You can get a form-1 by applying the patch on the form-0, and changing it to form-1 will retain the AbilityNumber=4.
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-11-03 18:48:29 -08:00
Kurt
c60ae57ab0
Handle Ranked Battle Series 7 permissions
...
Closes #3070
Exclude all classified as Legends; everything else is permitted assuming it can exist in SW/SH.
Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com>
2020-11-02 16:38:00 -08:00
Kurt
51c872f4e1
Move more logic closer to where it's used
2020-11-02 14:46:26 -08:00
Kurt
7cb6ee0060
Move some static arrays closer to where they're used
...
Split EvolutionRestrictions to its own class
Can probably refine things further to clamp down access to these arrays
2020-11-02 13:11:51 -08:00
Kurt
b4c9e90c28
Enhance transparency in failed generator test
2020-11-02 13:03:08 -08:00
Kurt
d257ad1b1a
Update MoveTutor.cs
2020-11-01 19:59:26 -08:00
Kurt
64a6214b82
no nuts here
2020-11-01 16:05:55 -08:00
Kurt
24346cc4e1
Update EncounterTrade1.cs
2020-11-01 15:58:42 -08:00
Kurt
4db6661ffd
Handle JP-Blue trade quirks + stadium2 trade bypass
...
Co-Authored-By: ShadowMario3 <36941677+ShadowMario3@users.noreply.github.com>
2020-11-01 15:27:54 -08:00
ShadowMario3
7659b57c4f
Corrected catch rates for the Haunter and Graveler trades. ( #3071 )
...
* Fix catch rate for JP Blue trade evolutions
2020-11-01 14:39:49 -08:00
Lusamine
d5e5df802e
Add Ballimere Lake -> Lakeside Cave crossover ( #3069 )
2020-10-31 22:29:08 -07:00
Kurt
15348d3fdd
Bypass crustle flag
2020-10-31 11:43:17 -07:00
Kurt
c9ee07e9b9
Update form for friendsafari vivillon
...
Closes #3066
2020-10-30 22:23:13 -07:00
Kurt
975c4f8a4a
Prevent nickname change for fateful encounter trades
...
Handle empty nickname trades for gen6+ assuming there's a nickname
2020-10-30 20:31:12 -07:00
Kurt
d7042fb19e
Inline parameter passing
...
nothing passes anything, so swsh is default
shared raids yay
2020-10-30 19:56:37 -07:00
Kurt
a33120c93e
Boo
...
Poor Gourgeist-0&2 being left out of the 60-shiny club...
Mimikyu is a repeat from the Pikachu Mass Appearance in early August.
2020-10-29 19:34:17 -07:00
Kurt
62d5375f67
Update EncounterStatic8U.cs
2020-10-29 08:52:38 -07:00
Lusamine
5e92b7b5f7
Add crossover and static encounters for CT ( #3050 )
...
* Add crossover encounters for CT
* Old Cemetery -> Giant's Foot
* Add some static encounters
* Add Frostpoint Field -> Freezington crossover
2020-10-27 22:08:49 -07:00
Kurt
cb545781b0
Split off es5dr to separate file, require never shiny
...
Shiny check was mistakenly forgotten :)
2020-10-27 18:03:45 -07:00
Kurt
2303077ed1
Expose move source classes for api purposes
...
Not guaranteeing the method signature will be stable forever, but allows people to reference the public methods inside.
Closes #3056
2020-10-27 09:25:33 -07:00
Kurt
82c579da82
Disallow E birth island deoxys with JP origin
...
Closes #3040
Ty @Atrius97 !
"The Japanese Aurora Ticket was only distributed in Summer 2004, before Emerald (Sept 16th 2004) was released. The software at that time had no support for Emerald games."
2020-10-25 21:42:14 -07:00
ReignOfComputer
43d031604f
Static Encounters Update ( #3044 )
...
Alakazam in the Insular Sea (on the Isle of Armor)
Zapdos at Watchtower Ruins (in a Wild Area)
Zapdos at West Lake Axewell (in a Wild Area)
Moltres in the Soothing Wetlands (on the Isle of Armor)
Moltres on Challenge Beach (on the Isle of Armor)
Moltres in Loop Lagoon (on the Isle of Armor)
Dragapult in the Giant’s Bed (in the Crown Tundra)
Nidorina in Frostpoint Field (in the Crown Tundra)
Glalie on Snowslide Slope (in the Crown Tundra)
2020-10-25 18:10:07 -07:00
Kurt
bb60b140e2
Allow Gen8 balls on gen3-species eggs originating in Gen8
2020-10-25 18:07:13 -07:00
Kurt
2bb399c8e7
Check egg state before allowing gmax toggle
...
eggs can't toggle gmax state
2020-10-25 13:41:49 -07:00
Kurt
36051e0f82
Minor clean
2020-10-25 10:02:52 -07:00
Kurt
681d64d007
Update AltFormInfo.cs
2020-10-25 09:35:19 -07:00
Kurt
608e0bb88e
Update AltFormInfo.cs
...
Static species enum ref for simplicity
2020-10-25 09:30:42 -07:00
Kurt
691f12ae72
Extract battle form logic into a separate class
...
format is included in the method call to futureproof, not currently necessary
2020-10-25 09:15:16 -07:00
Kurt
90b760b9bf
Unban porygon capture-breed ball for eggs
...
Shows up in dynamax adventures for capture
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-10-24 20:46:43 -07:00
Kurt
babf5a48ca
Bounds check species name on report summary
2020-10-24 20:22:08 -07:00
Kurt
6079f53d9a
Handle unfused Calyrex with fused-TR flags
...
Thanks CC6174 # 4880 (Discord) !
2020-10-24 19:10:59 -07:00
ReignOfComputer
29408e3ada
Static Encounter Updates ( #3043 )
2020-10-24 12:33:14 -07:00
Kurt
0c8966796e
Add wild area strong encounters for Crown Tundra
...
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com>
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
2020-10-24 11:24:01 -07:00
Kurt
2e4af1afc5
Update legality comparisons for Crown Tundra
...
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2020-10-24 11:16:01 -07:00
Kurt
0741c8c035
Handle Calyrex TR bug
...
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
2020-10-24 11:12:25 -07:00
Kurt
9b2d7c0341
Minor tweak
...
no functional change, just use Generation instead of recomputing
2020-10-24 11:11:53 -07:00
Kurt
5fa4ddd4a2
Update internal data sources for Crown Tundra
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>
2020-10-24 11:11:05 -07:00
Kurt
799dbde1a2
Add Nest Data for Crown Tundra
...
Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
2020-10-24 11:06:05 -07:00
Kurt
24bd796302
Fix erroneous legality message with 0IV
...
Revised string now uses string format, will be in the new localization text update.
2020-10-24 10:52:22 -07:00
Kurt
8c4b7e9060
Prefer form match for suggested encounters
...
Closes #3038
2020-10-19 11:54:59 -07:00
Kurt
3dd47dc898
Check ability bit for gen3 based on PID
2020-10-19 11:36:57 -07:00
Kurt
83171ab133
Change shininess check
...
Encounter definitions should be marked as Never Shiny or not in their definition, rather than assuming
2020-10-18 16:05:01 -07:00
Kurt
a4baec9939
Check shiny state for GB Era events
2020-10-18 10:57:18 -07:00
ShadowMario3
f6476a4737
Add Gen 1 North American Mew Events ( #3036 )
2020-10-18 10:01:55 -07:00
Kurt
7a01b1249c
Minor clean
...
Handle more messages, add more xmldoc
2020-10-18 09:43:41 -07:00
Kurt
c09fb9a0ec
Simplify "Flag" field in move source tracking
2020-10-17 13:40:12 -07:00
Kurt
1bd3ec79cf
Misc tweaks for suggesting moves when IsEgg
...
Closes #3032
Don't suggest tutor moves for current moves if it is an egg
2020-10-14 18:55:30 -07:00
Kurt
2e8586f364
Read swarm slots correctly
2020-10-13 15:37:18 -07:00
Kurt
367859c536
Make MoveEgg / MoveTM internal methods public
...
Closes #3031
2020-10-13 11:22:13 -07:00
Kurt
1524093099
Revise g5 pid bit check for forced PID statics
...
Closes #3027
Roamers: Get PID generated externally
NPokemon: Get PID from a fixed value
Forced (Anti)Shiny: Get PID altered
Thanks @LegoFigure11 && Princess Emily (discord 4650) !
2020-10-12 11:04:29 -07:00
Kurt
ea81bb2c1e
Add swsh items based on DLC1 metadata
2020-10-10 14:14:02 -07:00
Kurt
7132750c9b
Placeholder crown tundra logic
...
To be updated:
- Tables8: magic numbers for maximums
- IGigantamax: any new gigantamax forms?
- FormConverter: any new forms? (calyrex)
2020-10-10 13:14:32 -07:00
Kurt
078322f146
Fix logic to fix a broken raid test
2020-10-10 12:59:31 -07:00
Kurt
a0a8dd0f91
Handle Ability Patch changed abilities ( #3024 )
...
Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability.
Per the description, it goes 1/2=>H, not the other way around.
Verify ability bit first, as mystery gift case handling skips the bit check logic :P
2020-10-10 12:30:57 -07:00
Lusamine
e6e3166f13
Add Comfey from Honeycalm Island ( #3023 )
2020-10-10 10:07:17 -07:00
ShadowMario3
ba4eadfde9
Add location for Stadium 2 Events ( #3022 )
...
* Fix game version for International Gen 2 events
* Add Stadium 2 Event location
2020-10-10 08:13:54 -07:00