Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-23 20:43:07 +00:00
Code Issues Projects Releases Packages Wiki Activity
8686 commits 3 branches 76 tags 106 MiB
Commit graph

96 commits

Author SHA1 Message Date
Kurt
a287efe3a1 Inline pk2/pk3 form setter, only SetGender if different 
Helps out ALM generate unown
 2022-02-09 20:20:32 -08:00
Kurt
a7051107ea Conditionally set PP Ups and Purchase/Mastery flags on set import 2022-02-07 15:40:02 -08:00
Kurt
0b32cbf132 Update PKHeX.Core abstractions with latest logic 
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
 2022-02-04 17:35:15 -08:00
Kurt
27e899ffdd Yield SP eggs in encounter db, detect "link trade" correctly 2021-11-21 18:36:36 -08:00
Kurt
723514e89c
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) 
Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :(

Builds will fail because azure pipelines not yet updated with net6.
 2021-11-19 18:23:49 -08:00
Kurt
bedc52943e Trailing commas 
No functional change
 2021-08-20 13:49:20 -07:00
Kurt
2655892db1 Choose a gender on unspecified 2021-05-19 17:12:30 -07:00
Kurt
2c820bfbe9 Minor tweaks 2021-05-18 13:29:55 -07:00
Kurt
d9c22b1d74 Move pk1/2 EV maxing to class 2021-04-20 01:50:27 -07:00
Kurt
645f2b4db5 Revert implicit casting 
Looks like netstandard2.0 wasn't meant to receive that new c#9 goodie
 2021-03-29 00:14:44 -07:00
Kurt
21e1e6def5 Check format 3/4 for setpidnature 2021-02-02 15:39:41 -08:00
Kurt
bb1d23e112 Minor clean 
Use some enums, save a few virtual/static fetches
 2021-01-16 12:01:40 -08:00
Kurt
33ad654be6 Mark encstatic version on init rather than post-init 2021-01-03 16:49:49 -08:00
Kurt
1f600f3518 Fix Gen2 Shiny ShowdownSet import 
SetNature loops by changing the PID which doesn't exist; there's no nature or abilities in gen1/2 so just skip these two methods completely.
 2021-01-02 19:58:25 -08:00
Kurt
09089da14e Use more expression return style 
Reduces indentation & bracketing, a bit more concise
 2021-01-01 17:08:49 -08:00
Kurt
514b60b447 Merge type check with usage in if statements 
if x is y with z property true, then :D
 2020-12-21 22:33:48 -08:00
Kurt
5729718d68 Simplify ternary byte casts 
No longer needed to explicitly cast, thanks c#9 !
 2020-12-21 16:53:28 -08:00
Kurt
62018cce1a Unify concepts with different names 
AltForm & Form & Forme => Form
GenNumber & Generation => Generation

Extract out SpeciesForm interface, and re-add IGeneration

For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
 2020-12-10 20:42:30 -08:00
Kurt
7c4c1e0913 Minor prep clean 2020-12-10 19:49:53 -08:00
Kurt
9264150b2b Add shiny1 batch editor, add ctrl-shiny (1) 
GUI: Ctrl click star to get shiny1, shift click for shiny0, any-click to get random

make Alt click modify the SID instead of PID

add SetShinySID shiny type
 2020-10-25 10:42:48 -07:00
Kurt
706618d331 Force Hidden Power IVs for format2 imports 
Closes #3019
 2020-10-09 09:52:29 -07:00
Kurt
0111c3dd6f Set Max EVs for ShowdownSet`s imported onto GBPKM with unspecified EVs 
https://github.com/architdate/PKHeX-Plugins/issues/48
 2020-09-07 10:56:25 -07:00
Kurt
cf9e5ec37f Minor refactoring 
Change Ability array to IReadOnlyList, add method to check ability index in personal data
Suppress some message warnings
Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue.

Simplify pk5 conversion
 2020-09-06 10:53:13 -07:00
Brian Fischer
c4e9bbcc45
Changes to suggested hyper training logic (#2968) 
- Changed suggested hyper training logic to not hyper train over some possibly intentional unusual speed IVs
- Showdown import will not do any hyper training on pokemon encountered in gen 8, because with Hidden Power removed from the game in gen 8, all specified IVs in the showdown format are guaranteed to be deliberate for stat purposes.
 2020-08-14 21:49:01 -07:00
Kurt
36dd5ece21 Initial Isle of Armor support 
Co-Authored-By: sciresm <sciresm@users.noreply.github.com>
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-06-19 18:51:15 -05:00
Kurt
2cdb5d26db Clean up some method signatures 
rename things to be a little more consistent in naming conventions
 2020-06-16 21:46:22 -05:00
Kurt
bfef634a1a Set shiny type regardless of format 
Don't loop if not required to loop
 2020-06-12 11:45:56 -07:00
Kurt
4f40330af9 Add Dynamax Level = 10 to showdownset if legal 
Closes #2835 ; zacian/zamazenta/eternatus can't have a DynamaxLevel other than 0.

Co-Authored-By: Mikewando <mikewando@users.noreply.github.com>
 2020-05-16 15:15:41 -07:00
Kurt
30d21e4532 Extract out showdown set interface 2020-04-12 13:05:29 -07:00
Kurt
5e32e9203e Add setting to apply nature to statnature on import 
Co-Authored-By: toim22 <toim22@users.noreply.github.com>

#2794
 2020-03-19 13:47:25 -07:00
Kurt
5240e67a14 Revert "Loop shiny force regardless of format" 
This reverts commit cc8e5d9c32.
 2020-02-21 15:02:16 -08:00
Kurt
cc8e5d9c32 Loop shiny force regardless of format 
https://github.com/kwsch/PKHeX/issues/2717#issuecomment-586741748
 2020-02-16 11:46:06 -08:00
Kurt
c301ce88ab Update Random to be a bit more thread safe 
Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available.

Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method.

https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8
https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158
 2020-01-25 21:49:52 -08:00
Kurt
b5d48bc14f Split up portions of CommonEdits 
Cuts out about half the size; there's still a bunch of apply-value logic but it's not really big enough for a separate class.

Rename BallRandomizer->BallApplicator
 2020-01-25 16:47:44 -08:00
Kurt
8312c52cc1 Make Move[] readonly list 
contract: don't modify the template movesets
mystery gift now exposes IRelearn, remove unnecessary type checks
 2020-01-18 16:46:38 -08:00
Kurt
0cd9c47953 Make Relearn array for encounters readonly 
No change em
 2020-01-18 16:31:24 -08:00
Kurt
eaeebea923 Remove another method shortcut 
EncounterSuggestion needs a facelift anyway
 2020-01-12 17:00:03 -08:00
Kurt
ecabbfff53 Add individual Move#_PP $suggest 
#2603
add in "secret" heal/healPP actions -- do ".Heal=$suggest" to refresh
all stats like it was healed at the pokecenter. I can't think of a good
way to handle invoking of methods (">", but what about parameters?)
 2020-01-03 20:21:02 -08:00
Kurt
b255937e86 Revise input parameter names 
pk instead of pkm (consistency)
Lowercase anything that started with uppercase (not static state)
 2019-12-26 18:47:31 -08:00
Kurt
a0f2aded02 Use more optimized index find 2019-12-03 18:24:28 -08:00
Kurt
5435a5d93e Minor updates 
Fix mark (ribbon) read for index > 64
Heal party stats on set detail import
Wipe HT Language for eggs/untraded
Extract BST total color logic
 2019-11-25 17:32:10 -08:00
Kurt
22a5df5181 Only set permitted record flags for Move[] 
Closes #2523
 2019-11-25 12:02:30 -08:00
Kurt
dd51ed707f Update record flags on default showdown import 
Closes #2511
 2019-11-24 06:06:08 -08:00
Kurt
a50169d3d2 Add shift-set shinyxor0 pid 
Display xor value on hover, not gonna do alternate stars/square display
Closes #2482
 2019-11-20 20:38:05 -08:00
Kurt
2aaa3763ee Fix record setting logic 
Thanks @AnalogMan151 ! #2416
Fix method reference lol
 2019-11-20 18:18:33 -08:00
Archit Date
686f69484d set gigantamax flag from showdown set (#2469) 2019-11-19 15:57:08 -08:00
Kurt
d7657f948d Update documentation for techrecord flag methods 
Allow an ienumerable of moves rather than a readonly list
 2019-11-16 08:18:57 -08:00
Kurt
87bb8f3b3f Fix record clear 2019-11-16 08:00:58 -08:00
Kurt
981ed9a253 Add technical record flag editor & api 2019-11-15 23:12:28 -08:00
Kurt
cefb56a749 Sword/Shield Update 2019-11-15 17:52:08 -08:00