Kurt
515a694afa
Add LanguageID enum
...
no functional change, just less-magic-numbers for easier to understand
src
2017-10-22 21:01:08 -07:00
Kurt
cd16a7721b
Set roamer data back on save
...
existing code cloned the savedata reference to a new array, and didn't
copy back
the Roamer3 reader/writer does all the r/w, and writing only happens
with the setter when the form is called to Save.
Thanks TheRealAlphA!
2017-10-22 17:17:17 -07:00
Kurt
44c80bd722
Exclude light ball pikachu from gen1 species setter
...
Thanks Dunsparce!
https://projectpokemon.org/home/forums/topic/41880-yellow-version-pikachu-editing-bug/
non-functional change but fix misuse of gameversion checks (used X/Y
instead of YelloW)
2017-10-22 17:11:48 -07:00
Kurt
42d1c252ee
Enhance gen1/2 language detection
...
Closes #1540 , check for german only characters (gen1/2 can trade
between resulting in only OT being checkable). May be worth changing the
german check to return an int instead and check for other language
specific values.
2017-10-22 16:52:46 -07:00
Kurt
096f6bbd18
Add RANDY Gen2 ingame trade
...
closes #1538
rename pid deferral to pidiv deferral for clarity
2017-10-22 10:41:27 -07:00
Kurt
c5b0ed6c35
Move encountertype deferral to main generator
...
gen4->gen5/6 electrode will match static & wild slots, but deferral only
defers within the same IEncounterable group.
2017-10-22 09:42:15 -07:00
Kurt
3970b177af
Fix kor table 0x5 0x30-3A swaps
...
pls no more
2017-10-22 09:27:00 -07:00
Kurt
cc2e379880
Fix kor table 0x5 0x10-0x20 swaps
...
there's still more in the 0x5_30 region
y u rong bulbapedia
2017-10-21 19:05:38 -07:00
Kurt
528593b59e
Disallow crystal tutors if VC
2017-10-21 19:01:23 -07:00
Kurt
791a41b1a7
Fix KOR encoding table off by 1
...
Closes #1534
Thanks @host1126 !
2017-10-21 10:32:08 -07:00
Kurt
14ba3fad0b
Merge pull request #1536 from wwwwwwzx/master
...
Fix Gen3-5 MaxEV per stat
2017-10-21 08:05:22 -07:00
wwwwwwzx
0820059adf
Fix Gen3-5 MaxEV per stat
2017-10-21 01:06:25 -07:00
Kurt
39279a7ad4
Add VC transfer checks
...
checks were previously only performed when finding the encounter, once
found, the GB encounter was validated. the transfer encounter is derived
after all encounter checks, thus remaining unchecked (really, only for
Locations).
Move generating logic to the generator, and double check the locations
are valid.
#1535
Thanks @DJPanda065 !
2017-10-20 21:07:15 -07:00
Kurt
00adfda6e4
Flag Hidden Ability -> other change (hacked)
...
Closes #1535
2017-10-20 20:10:56 -07:00
Kurt
0e24b5237e
cleanup
...
remove redundant/repetitive match update (updateTypeInfo with Format>=7
already updates the encountermatch just prior to this method call)
2017-10-20 20:10:13 -07:00
Kurt
f85910abe2
Show Time of Day for gen2
...
apparently both controls were hidden
also hide encountertype control panel when not applicable (shifts time
of day up beneath other controls)
2017-10-20 19:53:38 -07:00
Kurt
7c36190661
Expand IdentifierContains feature
...
now behaves the same as a property filtering
2017-10-20 08:47:31 -07:00
Kurt
ae0bf5c75c
remove (None) egg gen4 hatch location
2017-10-19 22:00:31 -07:00
Kurt
a75614ed77
Modify eggmove fetch
...
fetch is exclusively done with version already known; there are cases
where version can change for eggs so it's safer this way.
version change reference (gen6+):
212a489335
2017-10-19 21:20:47 -07:00
Kurt
a561948371
Detect mixed->fixed gender incompatibility
...
Calculate and compare the original encounter's gender's as well.
exclude azurill gender change (only case where this can happen) by
continuing the if-else.
Add Snorunt-Froslass to FixedGenderFromBiGender.
Thanks Davil !
2017-10-19 20:56:59 -07:00
Kurt
90d965e6bc
Fix gen2 kor lang detection loading
...
closes #1533
Thanks @host1126 !
2017-10-19 19:59:34 -07:00
Kurt
14ccf1f778
Merge pull request #1531 from sora10pls/patch-1
...
Ban Sport Ball
2017-10-19 12:13:16 -07:00
Matt
4353f39286
Ban Sport Ball
2017-10-19 14:33:39 -04:00
Kurt
6e42d01779
calculate 4->5 string dictionaries
2017-10-18 22:16:48 -07:00
Kurt
228b0e84fb
Simplify some dex interaction
...
utilize get/set flag method calls, add xml docs for the two methods
2017-10-18 21:43:42 -07:00
Kurt
a53e8ddb7e
Fix grotto mienfoo level range
...
Thanks paf!
2017-10-18 21:16:52 -07:00
Kurt
5a09cd9122
Add deferral case for gen6 magmar classic ribbon
...
use "when" for easy src code
Thanks Nessus!
2017-10-18 18:28:17 -07:00
Kurt
cd6dfceb9e
Update fateful/shiny lock check gen3 wc3
...
VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3);
simplify that branch and reintroduce the shiny check as a separate
method
Thanks Davil!
2017-10-18 18:18:23 -07:00
Kurt
0c3414a60b
Merge branch 'master' of https://github.com/kwsch/PKHeX
2017-10-18 18:11:29 -07:00
Kurt
d76f1dd7a5
update emergency err log datetime format
2017-10-18 18:11:20 -07:00
Kurt
61f6ce9e14
Merge pull request #1527 from architdate/patch-2
...
Zygarde 50% Power construct Showdown Import fix
2017-10-18 11:57:21 -07:00
Archit Date
6f5d0489d5
Zygarde 50% Power construct Showdown Import fix
2017-10-19 02:45:45 +08:00
Kurt
9ef07eac5b
Merge pull request #1526 from sora10pls/patch-1
...
Update README screenshot
2017-10-18 11:24:41 -07:00
Matt
6bcdf72c41
Update README screenshot
2017-10-18 13:02:46 -04:00
Kurt
f5b22d7873
Update 17.10.17
...
Update event binaries with latest from the Event Gallery
2017-10-17 23:59:14 -07:00
Kurt
886b2ef632
misc refactoring
...
simplification / splitting, also more usum prep and other readability
updates
2017-10-17 23:19:34 -07:00
Kurt
0cc60e6006
Change lookup arrays to hashsets
...
faster checking (slightly negligible but using the correct data
structure for the use case)
2017-10-17 22:06:07 -07:00
Kurt
a9261a1eec
Fix starly safari ball species ID
...
not staravia dawg
Thanks Britty!
2017-10-17 19:23:22 -07:00
Kurt
18aa7fe100
ban more safari/hidden ability pairs
...
https://projectpokemon.org/home/forums/topic/41840-bug-pokemon-in-ball/?tab=comments#comment-221383
2017-10-17 09:08:48 -07:00
Kurt
c3e0d5339c
Fix jp gen2 save detection
...
simplification commit was dyslexic on JP/EN.
20 <-> 30 (EN 20, JP 30 is the correct count)
https://bulbapedia.bulbagarden.net/wiki/Pokémon_Storage_System#Core_series_games
pk2 structure is smaller for jp (smaller strings), thus has 30 cap.
International has 20.
2017-10-16 17:33:09 -07:00
Kurt
4d91aad876
Flag gen2 egg moves when transferred from gen1
...
move must be removed 2->1 so cannot be permitted as egg move.
remove unreachable code (ParseMovesRelearn only is called for Generation
>= 6, and thus Format != 2).
2017-10-16 17:24:19 -07:00
Kurt
e744dcc340
Add OT too short check
...
apparently some people can be this oblivious
2017-10-15 18:11:20 -07:00
Kurt
f5e595772d
Add more sav7 properties
2017-10-14 23:47:16 -07:00
Kurt
331d6ec6a0
Sync missing file
...
#1523
yeah lol
2017-10-14 16:48:43 -07:00
Kurt
fa310e8c4e
Add gen6 map mirror coordinate changing
...
not sure what they do but the values should match
Closes #1523
2017-10-14 16:32:34 -07:00
Kurt
a11b6f4a60
add recent de strings as resource
...
now load instead of not at all
2017-10-13 22:40:34 -07:00
Kurt
6f69ce11b5
Merge pull request #1522 from Korados/master
...
German Translation for Gen1-3 item strings
2017-10-13 21:36:10 -07:00
Kurt
07133e22fd
Add $suggest for HyperTrainFlags
...
#1521 didn't consider trick room speed IVs
can possibly consider EVs in the suggestion, but meh
2017-10-13 17:31:53 -07:00
Kurt
a28fe9d6a0
Allow batch editor to process many instructionsets
...
Closes #1521
separate each list with ;
=CurrentLevel=100
!IV_HP=31
.HT_HP=True
;
=CurrentLevel=100
!IV_ATK=0
!IV_ATK=1
!IV_ATK=31
.HT_ATK=True
2017-10-13 17:24:26 -07:00
Korados
ef6a7827bf
Create text_ItemsG3_de.txt
2017-10-14 01:34:15 +02:00