Kurt
4f489a720f
Refactoring
...
move logic back to cgearbackground, initialize the bg regardless of
psk/cgb input format
cache background data to return psk (potentially unintended side effects
if importing bw psk to b2w2, will have to fix cgb->psk first then undo
this tempfix)
#1699
2018-01-09 23:30:44 -08:00
Kurt
f332e41869
misc updates
...
#1699
generally pertaining to detecting a de-obfuscated input (cgb) vs native
(psk)
still issues with saving data (deobf->native)
2018-01-09 21:47:04 -08:00
Kurt
84a755a8c9
minor simplifications
...
#1699
2018-01-08 22:40:34 -08:00
Kurt
d187370671
fix checksum/footer set
...
#1699
checksum in the +0x100 was missing the +SAV.CGearDataOffset
add a few more modifications for better parity
still not 100% fixed
2018-01-08 22:40:34 -08:00
Kurt
26015b44bc
Add max cap difference for dppt
...
#1746
2018-01-06 14:12:28 -08:00
Kurt
218c20d804
Add sav4 coin edits to misc4
...
closes #1746
2018-01-06 14:02:55 -08:00
Kurt
fa90ae21df
Fix variable reference
...
#1731
2017-12-29 18:30:13 -08:00
Kurt
45eee8575a
Only promt roto-OT if OT is changed
...
reduces nag
closes #1731
2017-12-29 10:00:32 -08:00
Kurt
61b65198f2
Allow box name editing on gen2
2017-12-27 15:52:29 -08:00
Kurt
9457db9059
Fix mystery gift qr export text
...
closes #1720
2017-12-21 09:49:40 -08:00
Kurt
9429bc6961
Fix showdown import on gen3
...
https://projectpokemon.org/home/forums/topic/43126-problems-with-importing-rse-showdown-files-from-clipboard-in-pkhex/
Sceptile @ Leftovers
EVs: 4 Def / 252 SpA / 252 Spe
Timid Nature
- Leaf Blade
- Leech Seed
- Substitute
- Hidden Power Ice
also fix apricorn form title
2017-12-19 15:33:23 -08:00
Kurt
9263856845
Add apricorn pouch editing
2017-12-18 09:36:53 -08:00
Kurt
dd21f9375f
Misc updates
...
Disallow sandygast on US
Add 2 more records
thanks @feralfalcon
Closes #1698
2017-12-08 08:54:00 -08:00
Kurt
eff8855729
Allow throw type changes to be saved
...
move SM/USUM branch inside the method
closes #1695
2017-12-05 07:26:55 -08:00
Kurt
3d7b2a2b29
Misc tweaks
...
RNG frame mismatch -> fishy (for now)
fix xmldoc copypaste
clean up some resharper warnings
2017-12-04 16:26:26 -08:00
Kurt
a5dbdf91bd
Misc tweaks
...
detect antishiny cxd
remove unused using
don't set caught for seenAll (gen7 dex)
2017-12-04 13:18:28 -08:00
pokecal
0f52f94222
fix MailBoxEditor
...
add Mail5, almost same as Mail4.
2017-12-04 00:00:14 +09:00
Kurt
bdc9d7edce
fix plaza get set
...
closes #1684
2017-12-02 21:37:46 -08:00
Kurt
2d3203fc1a
Refactoring
...
extract out Mail classes to core
2017-12-02 19:12:04 -08:00
pokecal
3e5e49219b
fix MailBoxEditor
...
fix Gen4 Controls
add Mail .Empty for LegalCheck
add Mail SetBlank() for make BlankMail
2017-12-03 11:24:57 +09:00
pokecal
c4ca3aba75
add MailBox Editor
...
I just wanted to fix PK3 heldMailID.
2017-12-03 07:21:07 +09:00
Kurt
fdc52e2c19
Add pkm league starter EC for gen7
...
Closes #1671
2017-11-29 20:04:01 -08:00
Kurt
4a898b0829
Leave empty item slots for gen7+
...
game depends on an existing value to check for if the item is truly
"New"
Closes #1670
Don't clear count=0 slots for gen7+
For sorting, put all the count=0 at the near top (any feedback on how
this actually works?)
2017-11-29 19:47:27 -08:00
Kurt
fa78154df7
Save current facility on save action
...
unsaved combobox choices only are saved when the current index is
changed, need to save when the form is closed (saved).
2017-11-29 08:38:32 -08:00
pokecal
e86b8c670f
add Crystal GS EventFlags
...
have checked with US ver.
2017-11-28 03:35:55 +09:00
Kurt
b30cc933e5
Extract festafacility from gui code
...
move to core project as a structure/class
2017-11-26 08:47:25 -08:00
pokecal
8fe81e8610
update FestaPlazaEditor
...
add BattleAgent Grade30 reward giving
2017-11-26 19:40:18 +09:00
pokecal
2c15170844
update FestaPlazaEditor
...
Add Result of FortuneTeller
and found that the Unknown Value of FestaID(not introduced)
was mistake, contaminate NPCs.
2017-11-25 03:14:55 +09:00
Kurt
5ae408c316
cleanup
...
no functional changes
2017-11-23 09:43:43 -08:00
Kurt
5be401cc73
Merge pull request #1652 from pokecal/master
...
update FestaPlazaEditor
2017-11-22 22:12:29 -08:00
Kurt
b8a5657d5a
misc tweaks
...
pull out transfer locations to const references
add vc2 & crown beast/celebi met location suggesting
add vc2 crystal sensitive detection
add 2 more usum trainer stats (thanks holla!)
2017-11-22 21:45:30 -08:00
pokecal
c3716440e6
update FestaPlazaEditor
...
I think the form contains almost all controls that needed.
2017-11-23 09:49:53 +09:00
Kurt
5fd1e85ce6
Refactoring
...
are the ace trainer genders swapped? removed the iteration loop in favor
of precomputed values
(pattern goes m/f *n?)
add wormhole max dist val
2017-11-21 19:08:31 -08:00
Kurt
15496aa9be
Merge pull request #1642 from pokecal/master
...
add USUM BattleAgency control
2017-11-21 15:38:43 -08:00
Kurt
486e5dc4fe
Move forme check after species check
...
compatibility message of 803-807 dex pkm on S/M needs to say species
first rather than checking forme first
Closes #1643
2017-11-21 15:22:33 -08:00
pokecal
8c08ec1328
add USUM BattleAgency control
...
the NOTE(Giovanni alert) is a little excessive I think,
I will remove it after detect a list of upcoming trainers.
2017-11-22 03:37:40 +09:00
pokecal
7799450193
fix FestaPlazaEdit value
...
When the facility is NOT introduced with visitors
and start FestaPlaza after latest started date,
VisitorFesID become unknown small value.(0/5/7/9/11)
So I stop auto-deletion of visitor data.(and put delete button)
2017-11-21 05:15:32 +09:00
pokecal
16a0abaf62
fix FestaPlazaEdit value
...
found "misc value" as used stats.
exchange left count is also up to 255.
(value 0x83 shows "?", 0x103 shows "3")
fix dye#5(blue) color value
2017-11-20 19:08:41 +09:00
Kurt
6534ef1919
Refactoring
...
Reworks festa facility into a get/set object, simplify some operations
naming convention (PascalCase) for methods/properties
closes #1635
2017-11-19 21:25:46 -08:00
Kurt
70ec1fda5e
cleanup
...
wasn't able to view the designer layout so I removed & readded to
project -- works fine now.
uppercase method names
2017-11-19 16:16:44 -08:00
pokecal
3c85b0ead3
add G7 FestivalPlaza Editor
...
There are too many phrases,
I have no plan to complete all list of phrases.
But I think user can edit phrases of each facility
by using their phrase settings.
2017-11-20 06:50:39 +09:00
Kurt
469587bbbd
Add Rotom OT name
...
"nah lets just store the OT in the save file twice"
add a double check if OT != RotOT to remind the user
2017-11-18 22:26:57 -08:00
Kurt
243f94f02b
Add map coordinate writeback check
...
same as sav7; apparently some areas in gen6 are also truncation prone
2017-11-18 12:22:54 -08:00
Kurt
6394dac19f
Rework mysterygift pkm sprite generation
...
don't bother converting to pkm then generating the sprite off that; use
the overload with int/bool
removes sav/pkm dependency for generating gift descriptions, and
standardizes the names a little. maybe a PKMBase interface would be
useful...
2017-11-18 11:34:23 -08:00
Kurt
f7e20a3c43
Misc tweaks
...
fix roamer3 not setting IVs
fix usum z items rightmost pixel getting chopped off
use Gen* instead of GenNumber for specific cases (faster)
add WasGiftEgg location case for Gen7
remove some unnecessary array allocations
2017-11-17 22:19:23 -08:00
pokecal
95bbbfaf08
fix Sticker location
...
Who is that Pokemon...Steelix!
2017-11-17 11:53:54 +09:00
Kurt
407f3f06d4
Unbreak clearing dex
...
add sound notification that the mass-edit is finished.
refactor slightly for clearer routines
2017-11-16 17:42:11 -08:00
Kurt
bd08d11597
separate out throw learn/unlocked
...
flags and handling is different for USUM, disabled until flags are found
2017-11-15 17:03:44 -08:00
Kurt
aea1577a11
fix mega venusaur female disabled / meowstic
...
<= goes to <
Thanks Holla!
https://projectpokemon.org/home/forums/topic/42332-gen-7-stuff/?tab=comments#comment-222689
2017-11-14 22:56:45 -08:00
Kurt
1c42cbebb7
Hide debug values
...
Closes #1607
wasn't Hall of Fame clear count values, just the 4 bytes prior to the
HoF 2 * 6 * u16 teams that serves an unknown purpose.
2017-11-14 21:48:38 -08:00
