Kurt
ff849b9c5b
Allow fullness values for format8
...
ty anubis
this totally isn't fullness, but the toys increase the value (saturation?)
2020-05-31 13:29:13 -07:00
Kurt
5c0d6d0f31
Extract downlevel check for reuse; clamp edge moves to max raid lvl
2020-05-31 13:28:14 -07:00
Kurt
3fcb29e68a
Remove some reliance on GenNumber
2020-05-31 12:12:48 -07:00
Kurt
9ff01bccc6
Add ToString override for debugging
2020-05-31 12:12:20 -07:00
Kurt
6aab8ca449
Minor renaming/type change of passed args
...
Next commit will have more changes where we remove some reliance on PKM.GenNumber, in favor of the passed encounter's generation
2020-05-31 12:12:07 -07:00
Kurt
97d8bcebfe
Only check Korean if game isn't recognized as Crystal
...
https://projectpokemon.org/home/forums/topic/57203-pkhex-error-crystal-save-dont-load/
2020-05-31 09:18:45 -07:00
Kurt
51a4001ce6
Update RaidSpawnList8.cs
2020-05-29 11:20:28 -07:00
Kurt
7f1039d155
Update RaidSpawnList8.cs
2020-05-29 11:19:49 -07:00
Matt
4d47e4ab83
Pretty up GP1 summary/filename ( #2846 )
2020-05-29 11:13:49 -07:00
XxPhoenix1996xX
fe8001f991
Update Spanish Translation ( #2845 )
...
* Update LegalityCheckStrings_es.txt
* Update MessageStrings_es.txt
* Update LegalityCheckStrings_es.txt
2020-05-28 23:30:57 -07:00
Kurt
dc5af9ea57
Add zh frlg event flags
...
Closes #2844
Closes #2843 via prior commit
Co-Authored-By: kamisama6866 <kamisama6866@users.noreply.github.com>
2020-05-28 22:06:33 -07:00
Kurt
940a9cb269
Add zh rs event flags
...
Closes #2843
Co-Authored-By: kamisama6866 <kamisama6866@users.noreply.github.com>
2020-05-28 14:48:44 -07:00
Kurt
afa368823e
Minor clean
...
handle some compiler messages
2020-05-26 16:59:47 -07:00
Kurt
043ba3b6f0
Add ability to sideload key names
2020-05-26 15:58:48 -07:00
Kurt
4f039fe732
Remove duplicate icon
...
only one icon file remains
make splash screen smaller since we don't have a 64x64 icon preview anymore (only 32x32 & smaller)
2020-05-26 14:43:57 -07:00
Matt
9b6190a3e9
Add Gigantamax Meowth Distribution Raids ( #2842 )
2020-05-25 17:39:07 -07:00
Kurt
46b443903d
Fix SM dex form fetch for spewpa
...
Closes #2826
It doesn't find it in the SM table, but didn't return -1
rework logic flow to return when found, rather than after loop finishes.
Also fix display off-by-1 since we're not using zero indexing for our entry numbers.
Thanks @Ammako !
2020-05-24 20:42:45 -07:00
Kurt
7c6ea78c63
Add fullness legality check
...
Closes #2836
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
2020-05-24 20:00:32 -07:00
Kurt
9619306a8f
Update BattleTree7.cs
2020-05-24 18:42:08 -07:00
Kurt
09cbe47240
Add battle tree scout edits
...
Closes #2833
2020-05-24 18:31:52 -07:00
Kurt
053eef2767
Add encount block
...
Closes #2840 -- access via Block Editor "Encount"
Tons of undecipherable junk in the roamer struct; looks like a mishmash of past gen code repurposed for their pseudo-stationary|roamer encounter.
ORAS has the same structure (same size/block), but the roamer portion isn't used
2020-05-24 17:31:10 -07:00
Kurt
8ce4f64239
Move files to their correct location
2020-05-24 17:11:39 -07:00
Kurt
bbe1cf3ee1
Fix gen6 gamesync ID read
2020-05-24 17:10:55 -07:00
Kurt
c4326698a5
Add prompt for loading new save with unsaved changes
...
Closes #2823
remove old gen6 powersaves decrypted-xorpad strings (unused logic)
remove gen8 save fixing beta-pkhex-caused corruption (behaved for 6months)
2020-05-24 11:03:23 -07:00
Kurt
d8cd75908b
Handle gen2 gift egg collision with low hatch cycle req
...
Closes #2824
ty @KR1dude !
change miscverifier to use OT_Friendship instead of CurrentFriendship.
2020-05-24 10:46:08 -07:00
Kurt
4a5a913142
Handle downleveled cases correctly
...
Downleveled shared nest can't go below 20
Downleveled self nest can only happen for 1 or 3 badges and certain star counts, and the result can't be shiny
2020-05-23 22:17:47 -07:00
Kurt
64428539bd
Fix sav4 active block detect
...
Closes #2697 ty @Ammako !
lazy slice check has flaws; just compare the major/minor counters in the save footer and check the uninitialized cases
nobody is gonna save the game 2^32 times, but check for the overflow case too!
first ff'd is preferred when the second is ff'd-1!
2020-05-23 22:17:03 -07:00
Matt
8c6d674472
Misc changes ( #2838 )
...
Allow for up to 16 characters in SWSH Box Names.
Fix Rockruff-1 big sprite display.
2020-05-21 16:19:25 -07:00
Kurt
0cdc225224
Kecleon: Comment out static in favor of dexnav encounterslot
...
Encounter Generator stops yielding if anything was yielded (assumes things that are static encounters can't have anything else that would match).
DexNav boosts the wild level (from 25/27) up to the same level 30 of the static encounter.
Thanks @KR1dude !
Co-Authored-By: KR1dude <kr1dude@users.noreply.github.com>
2020-05-20 18:24:55 -07:00
Kurt
6970c3a5fb
Remove IVersion.set property, as separate interface
...
I don't want people to mutate IEncounterable.Version; it's only intended to be set on-load
2020-05-19 21:46:05 -07:00
Kurt
301350d32b
Make IEncounterable expose IVersion get
2020-05-19 21:07:30 -07:00
Kurt
cce3d5d9f5
Handle race condition on get->set new cached string
...
overwrite add if it somehow was added from another thread in between lock checks
2020-05-19 20:40:51 -07:00
Kurt
232a9de32e
Add gmax ev
2020-05-18 17:04:31 -07:00
Kurt
6164884700
Merge IGeneration into IEncounterable
...
all but egg exposed it; now, just make egg expose it and remove the unnecessary interface
we still need to Set generation for non-eggs/mgift, so have a separate Settable interface for internal purposes.
2020-05-17 12:32:28 -07:00
Kurt
4f40330af9
Add Dynamax Level = 10 to showdownset if legal
...
Closes #2835 ; zacian/zamazenta/eternatus can't have a DynamaxLevel other than 0.
Co-Authored-By: Mikewando <mikewando@users.noreply.github.com>
2020-05-16 15:15:41 -07:00
Kurt
1b5292cb04
append shared egg-moves rather than early return
...
dl[0].Species is the same as pk.Species; more clear && array access might be slower
only append shared egg moves if shared egg moves exist
2020-05-15 22:49:11 -07:00
Kurt
c8a141534c
make enc move gen tree fetch non-pkm specific
...
just need to get all evo chains possible
fetching a GO leafeon, need to reverse leafeon->eevee, but the LGPE evo chains don't know about leafeon
works fine now
2020-05-15 21:59:06 -07:00
ultima-soul
496a3a45ff
Add flag for Foreign DexNav Encounters Unlocked. ( #2834 )
2020-05-12 11:57:56 -07:00
Kurt
3210ced006
Add new gmax-pikachu distribution details
...
can be shiny
can be any ability
still can't evolve
can't wait for gmax-eevee when this bcat expires ;)
2020-05-11 17:17:27 -07:00
Kurt
045e289c0a
Account for antishiny skip on the NPC mon right before shadow
...
pretty much a copy from the other method with simplifications
2020-05-11 16:52:09 -07:00
Kurt
9b0e74dd2a
Update ContestStatVerifier.cs
2020-05-11 16:51:10 -07:00
Kirk Scheibelhut
0aa84f3456
Fix minor typos in FormConverter comments ( #2831 )
2020-05-10 14:27:12 -07:00
Kurt
4decaa73f7
Verify Contest stats on gen5 origin
...
extract to separate logic class; only gen3+ call this (was originally called by gen6+); only really needs to include gen5
2020-05-09 20:47:32 -07:00
Kurt
8650b5ceb2
Verify g4 tower ribbons as invalid on >=g5 origin
...
https://projectpokemon.org/home/forums/topic/57026-gen-5-contest-stats-ribbons-bugissue/
2020-05-09 20:45:19 -07:00
Kurt
5fc15dc9c8
Correctly prevent xd locked shinies
...
oops, 7fd7a86074
was not correct (only handled lockless) -- the verifier doesn't check the final shadow pokemon (not a lock).
https://projectpokemon.org/home/forums/topic/57014-shiny-shadow-pok%C3%A9mon-from-xd-shown-as-legal-pkhex-legality-check-error/
2020-05-08 10:07:21 -07:00
Matt
383cf3e514
Unban GO Shiny Voltorb ( #2829 )
...
Philadelphia Safari Zone.
2020-05-08 07:48:24 -07:00
Matt
333693775e
Update GO Shiny Banlist ( #2827 )
...
Remove Venonat (Throwback Challenge 2020: Kanto).
Also switch to using enum like SWSH Hidden Ability banlist -- evolution families all on one line.
2020-04-30 17:05:44 -07:00
Kurt
9f490a605e
Rearrange order/anchoring for main tab
...
allows expanding the window to show location names
Closes #2825
2020-04-29 09:32:29 -07:00
Kurt
67b19f7244
Update Encounters8NestDist.cs
...
Bye bye invalid drilbur, nice meme GF
The first rotom2 in Shield had its moves changed too. Keep that rotom-2 since Discharge can't be learned at that level.
since sw and sh have the same drilbur, it moves from sw -> common.
2020-04-28 11:36:03 -07:00
Kurt
2e390573bc
Add new meta distribution raids
2020-04-27 17:44:36 -07:00