Kurt
92d2d48e95
Skip detecting saves twice
...
Paths already has the regular backup locations + more, don't re-detect
later
Closes #2093
2018-08-14 21:04:22 -07:00
Kurt
57c6de2825
Add nickname length check for gen>2
...
Closes #2091
2018-08-14 20:13:15 -07:00
Kurt
75d700c171
Fix sav1 jp load order
...
oops
2018-08-14 20:12:10 -07:00
Kurt
af87752475
Reference underlying control visibility
...
closes #2092
2018-08-14 19:39:14 -07:00
Kurt
f079f62956
Remove fullness/enjoyment check
...
Although bank 6->7 deletes the values for these fields, Pokémon Refresh
can still reintroduce new values.
Closes #2090 , thanks @Lusamine !
2018-08-14 16:45:51 -07:00
Kurt
10f050eb18
Update translations with new hide savdetail setting
2018-08-13 19:40:00 -07:00
Kurt
70a6cd9421
Remove untranslatable content
...
sav6 recently added trainer appearance editor, prior commits removed pt
translation (only official ingame translations)
2018-08-13 19:24:49 -07:00
Kurt
10746ae45f
Add hiding of save details in program title option
2018-08-13 19:11:58 -07:00
Kurt
61013b8f18
Simplify drop/set into party
...
would reset the battle box sprites legality to not shown; also, the
prior fix for #2069 did not work for reloaded save files since
GetSlotFiller was called instead.
2018-08-12 19:28:35 -07:00
Kurt
6edc828cc3
misc style updates
2018-08-12 19:27:11 -07:00
Kurt
1c718e641e
Prevent box scrolling if contextmenu is open
2018-08-12 11:01:21 -07:00
Kurt
d3ec969187
Style updates
...
split pcd/pgt
add more xmldoc
2018-08-09 21:53:39 -07:00
Kurt
8187606a89
Clarify sav6 boxflag in src
...
7 wallpaper flags (not all used), top bit unlocks box 31
https://projectpokemon.org/home/forums/topic/34466-box-31-is-unlocked-but-not-showing-on-bank-any-ideas/
PCFlags + 2 is just CurrentBox, don't include it anymore.
2018-08-08 22:02:06 -07:00
Kurt
6b62dd29ee
Update xy fashion edits
...
different for each gender
2018-08-08 21:27:14 -07:00
Kurt
7403c0f91a
Add more pokewalker moves
...
igglybuff wish, happiny heal bell, and the elemental punches to round
things out even though they can be tutored
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234991
2018-08-08 17:35:06 -07:00
Kurt
975759e53c
Update str<->val base32 encoder
...
simpler
2018-08-07 16:32:31 -07:00
Kurt
259feae038
re-allow event flag editing on gen1
...
closes #2088
2018-08-07 07:54:14 -07:00
Kurt
421c522eb4
Fix gen1 sav load
...
Starter fetches via Offsets, which was null, reorder the init
Thanks @Ninjistix !
Closes #2087
2018-08-06 21:29:47 -07:00
Kurt
98f21a12dd
Relocate gen6 trainer stat records to core
...
use trainerstat editor control in gen6 editor
fill in some details from the disassembly via setrecord usages
still slightly fuzzy on some:
fureai (based on usum idb name, similar logic)
soaring sky counts
looks like there's some other usages of the fields which were outside
the stat range, throwing an exception when loading to NumericUpDown,
added bypass logic
Thanks Holla!
2018-08-06 21:27:31 -07:00
Kurt
37e5c9fc69
Add record details for gen6
...
pulled from exefs data
2018-08-06 16:52:43 -07:00
Kurt
48a61a00a2
Relocate record stat id's to core
...
can potentially add localization by changing the method of fetching
2018-08-06 16:17:32 -07:00
Kurt
0296f98777
Add offset table for sav1
...
calling Japanese ? X : Y on every single access is too excessive, just
compute one layout for each type whenever the first sav1 requires it.
could probably reduce the amount of properties by reusing others + shift
value; offsets are different due to string lengths being different
2018-08-05 20:27:25 -07:00
Kurt
fc73eee570
Extract PokemonList* to inherited class
...
Logic is essentially identical; implement a base class and have the
generation specific structures implment the differences.
Reduce the verbosity a little
2018-08-05 17:28:54 -07:00
Kurt
84185dc6c9
misc improvements
...
add records class for managing info for trainer records
add more b2w2 block docs
2018-08-05 12:39:06 -07:00
Kurt
ca39843046
Length check relearn suggestion
...
CLsoes #2086
2018-08-04 17:06:51 -07:00
Kurt
279c9d4665
Fix tradeback detect for gen2->1->2 evolve case
...
https://projectpokemon.org/home/forums/topic/46909-certain-gen-i-moves-are-showing-invalid/
Thanks Raptor385!
2018-08-04 13:36:05 -07:00
Kurt
c3136187de
Style updates
2018-08-04 10:06:06 -07:00
Kurt
53857df647
Copy addmoves special case to individual fetch
...
see prior commits
2018-08-04 10:05:47 -07:00
Kurt
0f63b0a0ee
Allow bw movepool except for kyurem
...
workaround provided for kyurem movepool (which is same bw-b2w2) but the
AddMoves logic with form != 0 points to the form == 0 data
Closes #2085
2018-08-03 07:46:53 -07:00
Kurt
30a614484e
Update STADIUM ot checks again
...
jp: 1999 if stadium1, 2000 if stadium2
en: 2000
jp: always same OT
en: lowercase if stadium2, uppercase if stadium1
https://projectpokemon.org/home/forums/topic/46893-pkhex-bug-stadium-ot-issue/
2018-08-03 07:38:29 -07:00
Kurt
4103b4d4b0
Update 18.08.03
...
Update event binaries with latest from the Event Gallery
2018-08-02 21:01:17 -07:00
Kurt
1486b7f14a
Misc style & minor tweaks
...
Remove move combobox flicker hack (no longer necessary)
Add more Array.Empty usages
cache mysterygift sizes
seal some classes
no functionality changes
2018-08-02 20:11:42 -07:00
Kurt
0745ba3294
Defer move combobox repop until dropdown
...
Yay sneaky smart solutions!
Instead of refilling the combobox when the legal move list changes, wait
until the full list is required then repopulate the individual combobox
can't even notice the lag besides the individual tab load. yess
2018-08-01 21:57:15 -07:00
Kurt
0ee9b04bf7
Skip move combobox repop if no changes
...
cache a hashset to determine if the legally allowed moves are the same.
reuse cache in paint method
previously, was noticeable if you load the Moves tab then check
legality; the legality message was delayed by a couple hundred
milliseconds due to repopulating 4 comboboxes (Combobox.NativeAdd
hotspot triggered by RefreshItems, which happens when we set the
datasource). By skipping unnecessary repopulations, gui lag is lessened.
would be preferred if I can just reorder the list inside, but noo.
2018-08-01 21:22:49 -07:00
Kurt
19a897923d
Reference original encounter for sensitive checks
...
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234360
thanks paf!
2018-08-01 20:39:20 -07:00
Kurt
f4bfdb8311
Remove unnecessary empty array allocations
...
yay net 4.6
read more: http://justinvp.com/2015/07/20/array-empty/
2018-08-01 18:30:51 -07:00
Kurt
fe6c071d72
Be more generous on nick parse
...
benefits manual-edit users who forget to put a space between
nick(species)
2018-08-01 18:28:05 -07:00
Kurt
007ec93d85
Update trade nick check for non-nicknamed
...
Closes #2084
2018-07-31 17:27:28 -07:00
Kurt
4c96efb9b7
Update pk2->pk1 party stat transfer logic
...
pk1 boxdata stores current level & current hp, which is only present in
pk2 party data.
if the user drops in pk2(boxdata), the transfer leaves 0 for both
values, which isn't correct.
detect stat_level to determine if values should be regenerated or not.
Thanks HaxAras for finding this :)
2018-07-31 14:29:47 -07:00
Kurt
32b90fab13
Simplify some logic
2018-07-29 21:54:02 -07:00
Kurt
02a6d26e1b
Break apart BAKName into smaller components
...
simplifies definition & makes it easier to update bakname usage later
2018-07-29 21:51:45 -07:00
Kurt
f35712fcf2
Extract experience logic to separate file
...
add exp bar logic, unused.
2018-07-29 17:43:30 -07:00
Kurt
3fd21db51e
Style & function extracting
2018-07-29 16:39:15 -07:00
Kurt
0de335d52b
Misc reorg
2018-07-29 14:04:16 -07:00
Kurt
b16015e8e5
Split InventoryPouch to inheriting classes
2018-07-29 13:55:07 -07:00
Kurt
d916be1020
Style updates
2018-07-29 13:27:48 -07:00
Kurt
41643a4c86
Use correct language ID for nickname check
2018-07-29 12:47:38 -07:00
Kurt
96484eceb5
Update version logic
...
Fixes broken tests (glaceon card can only be received by SM, was getting
set to UM).
2018-07-29 11:34:27 -07:00
Kurt
1313d84d5d
re-add lock to avoid race condition
...
enough pls
2018-07-29 11:05:48 -07:00
Kurt
aa08ed0c24
Resize slot background colors
...
Now plays nice with hover glow, not too many bytes added.
2018-07-29 10:54:51 -07:00
