Kurt
3b8974665e
Move ballbrowser init logic to subform
2019-02-14 20:23:51 -08:00
Kurt
95159686cd
Move ball browser form to separate file
2019-02-14 20:18:31 -08:00
Kurt
7acdf0d16d
Expose parse results for external consumption
2019-02-14 20:14:46 -08:00
Kurt
3d01617c93
Fix safari unlock
...
dat 0 -> o
Closes #2262
2019-02-14 18:17:16 -08:00
Kurt
2bb0ea0b38
Fix apply/clear trash
...
Closes #2261
2019-02-14 18:12:50 -08:00
Kurt
c67b774e1e
use enum to decorate rather than comments
2019-02-14 18:12:25 -08:00
Matt
7538a33c81
Update GO shinies ( #2260 )
2019-02-14 10:49:37 -08:00
Kurt
e7486e4534
Update gender check
...
showdownset now no longer leaks nulls
2019-02-13 15:50:48 -08:00
Kurt
6f76a3b1ae
Add setting to ignore "Legal!" popup
...
just plays sound
change 'bad field data' sound to Hand
2019-02-12 20:17:09 -08:00
Kurt
e82b4de657
Misc clean
...
replace Friendship control click to match shortcut description (used to
do nothing)
Remove some duplicate translation strings
fix gameselect string formatting
apparently systemsounds changed in a recent win10 update, Question is
now silent?? Exclamation is now the same as Asterisk (same as Beep?) Use
hand instead of Exclamation.
only use asterisk for notifications
2019-02-11 22:39:12 -08:00
Kurt
309633a214
Replace some trycatch with tryparse
2019-02-11 22:04:47 -08:00
Kurt
684191772f
Misc refactoring (showdownset null)
...
Set default values to prevent any properties from being null
extract ClearNickname logic for hot path & reusable method
extract item conversion and move to appropriate logic class
2019-02-11 21:49:05 -08:00
Kurt
2498b6bf50
Misc updates
...
Simplify unknown gen expression
allow mutation of FormIndex if desired
2019-02-10 21:31:27 -08:00
Kurt
304203262d
Add species & ability enumerations
...
remove hardcoded 810 in unit test, add ability test too
2019-02-10 21:28:32 -08:00
Kurt
182348526c
Add display TID/SID get/set
2019-02-10 10:31:20 -08:00
Kurt
9715a08342
Fix custom hex parse
...
hurr dont write your own parsers
Closes #2256
2019-02-10 10:19:05 -08:00
Kurt
a39f917f84
Simplify expression
...
ternary with a null check and long method signature is pretty ugly
2019-02-09 23:22:22 -08:00
Kurt
54ba9a0312
Update file->open for pb7 filtering
...
add pb7 to pkm extension list, ignore it in gen7 (sm/usum), update gg
filtering (allow pb7, not bk7)
add comments indicating format source game
2019-02-09 20:33:37 -08:00
Kurt
e96ef76dcd
Add xmldoc
...
no code changes
2019-02-09 20:24:38 -08:00
Kurt
48e2bbcfed
Refactor DumpBox to return 1 value
...
count < 0 implies an error; values >= 0 can be used to indicate actual
dumped count
2019-02-09 20:19:55 -08:00
Kurt
9a93b20515
Minor rework
...
use hashset instead of new[] every call
precompute empty arr
allow criteria input for better gen requests
2019-02-09 20:07:15 -08:00
Kurt
ec1d3069a5
Remove SaveFile dependency for wallpaper data fetch
...
reusability++
2019-02-09 20:05:32 -08:00
Kurt
efed851a89
Make move display consistent
...
old overridden behavior didn't display the font cleanly
use TextRenderer instead with formatting, and squish things down to
regular size (-2px).
lightened the green color in a previous commit
since redrawing is good now, can maybe expand upon coloring (move type
shown on left side as a color?)
2019-02-09 18:44:21 -08:00
Kurt
dc5cdc34d7
Remove FieldsInitialized and rename check method
2019-02-09 17:07:44 -08:00
Kurt
cb98c83bd2
Remove references to Stat_HPMax
...
use computed value to check if Party Stats are present
maybe I want to use Span and stop resizing all pkm arrays to party
format years from now idk
2019-02-09 13:17:00 -08:00
Kurt
19ae752937
Extract color config to separate class
2019-02-09 13:15:37 -08:00
Kurt
e79f46673c
Refactoring iencounterable->pkm
...
SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats
future?)
memes aside, this is where criteria data is forced
Split N encounterstatic (has fixed PID and special flag) from
EncounterStaticPID
2019-02-09 11:37:20 -08:00
Kurt
cda06bc701
Increase custom parse speed
...
remove double string replace (now less allocations); only add up values
if they're valid numbers.
builtin int.Parse throws with "1 2", but users can type stupid stuff
like that in the program (so we parse as 12).
2019-02-08 18:29:26 -08:00
Kurt
383d4b7700
"" -> string.Empty
...
be explicit that the string is empty rather than possibly missing
disallow encrypted export for BK4 (they're not encrypted), removes type
check
simplify replaceall in showdownset (don't call ReplaceAll 4x, just get
valid chars and rebuild)
simplify get ribbon sprite name (precompute ToLower and appended values
2019-02-07 21:40:20 -08:00
Kurt
3474d97fb2
Weaken float comparison for weight/height
...
ThePunish3D was able to find examples with less precise calcs
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=240188
assuming these were unmodified
2019-02-07 16:57:17 -08:00
Kurt
a6659fb767
Revert prior commit re: relearn suggestion set
...
bad logic causes the relearnmoves to get reset when first one is
applied, just revert to the old way instead of wrapping FieldsLoading
around this (repopulating legality would have to be manually called
after)
2019-02-07 16:54:56 -08:00
Kurt
59b41937e1
Misc variable name changes
...
readability++
2019-02-06 23:28:02 -08:00
Kurt
ddd1a36fa6
Update 19.02.07
2019-02-06 15:23:11 -08:00
Kurt
d03ff30140
Fix ita traded lgpe diglett OT
...
ty ThePunish3D!
https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=240159
2019-02-05 17:09:47 -08:00
Kurt
a97ae79086
Unban m&m go shinies
...
https://twitter.com/SerebiiNet/status/1092892163782991873
2019-02-05 15:33:59 -08:00
Kurt
29253ed636
More cleaning
2019-02-03 20:28:03 -08:00
Kurt
264c7d1cbc
Replace null return val
...
Closes #2255
2019-02-03 20:01:56 -08:00
Kurt
893f98d667
Misc clarity
...
no functional change
make batch editor prefix list readonly
2019-02-03 10:28:33 -08:00
Kurt
2eef523475
Misc clean
...
meh
2019-02-02 15:20:08 -08:00
Kurt
f481404503
Misc clean
2019-02-02 10:19:41 -08:00
Kurt
6ed9f979de
Continued refactoring
...
removing null results as indicators of no data (c# 8 sooooon)
2019-02-01 23:26:43 -08:00
Kurt
aa022fad40
Misc refactoring
...
remove some null usages, return an empty array instead
reduce as arg
2019-02-01 23:08:03 -08:00
Kurt
6178a5abe5
Fix bad test comparison
...
should not be equals to string was always satisfied; fix to check
against null.
2019-01-31 22:01:31 -08:00
Kurt
d29f670840
Add QRPK7 to PK7
...
roughly converts the data into a PK7
2019-01-29 21:07:42 -08:00
Kurt
945d853c54
Rename setting to more accurately describe purpose
2019-01-27 22:04:10 -08:00
Kurt
8cfd6d5a63
Expose SetBoxData
2019-01-27 21:57:33 -08:00
Kurt
3b8dc42f1a
Allow hidden settings to be displayed
...
hold control
2019-01-27 21:57:26 -08:00
Kurt
6353e8d84d
Add special set operation for alph rocksmash
...
closes #2253
ty @Subject21J & @ReignOfComputer
2019-01-27 11:08:21 -08:00
PMArkive
5cb93be681
add legendary pokemon to wormhole slots ( #2252 )
...
changed slot numbering from 0-4 to 1-15
fixed drapion's pokedex number in wormhole slot table
2019-01-27 10:40:19 -08:00
Kurt
552ec48c55
Remove fieldsloaded bypass
...
We're really just manually changing fields; let the GUI logic update
stuff.
Closes #2251 , also fills in Nickname now.
2019-01-26 16:25:21 -08:00
