13 commits

Author	SHA1	Message	Date
Kurt	8c970ec991	Minor tweaks ... no functional change, readability++ add more xmldoc	2021-06-03 12:04:19 -07:00
Kurt	013aac602f	Don't clone string resources on fetch ... Hardcode egg names, don't rely on string resource loading order for SpeciesNames to get an un-mutated copy. fixes the infrequent race condition for legality unit tests	2021-05-10 18:41:01 -07:00
Kurt	3597eb14ad	Improve gen1-4 species name fetch ... reduce nesting (separated methods) handle gen2 french egg name (all caps) use stringbuilder to replace chars	2021-05-10 16:09:28 -07:00
Kurt	758b6e6770	Remove '<->’ aliasing ... Farfetch’d uses the non-vertical apostrophe, still. Showdown is consistent with their usage (in/outputting ’), but we'll keep the '->’ for that sanitization just in case other services/users enter the wrong char. Closes #3185	2021-04-12 17:04:02 -07:00
Kurt	fa3fe0a380	Invert check, fix xmldoc descriptions	2021-01-31 20:12:46 -08:00
Kurt	3b5bcc9dad	Update comments with context/clarification ... No functional change, the order of switch case won't matter	2020-10-24 23:08:39 -07:00
Kurt	5326067c8d	Return old Chinese species name for Gen7 fetch ... Add documentation comments, because changing species names is so weird. ty anubis for confirming the game resets the old-nickname to new-nickname even without transferring to HOME. Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>	2020-10-24 22:28:39 -07:00
Kurt	478cb33788	Unshorten parameter names ... lang->language nick->nickname	2020-10-08 13:59:58 -07:00
Kurt	1ee459a46c	Use language for checking IsNicknamed flag	2020-08-29 10:40:41 -07:00
ReignOfComputer	f313321126	Gen 4 French Egg Fix (#2978) ... * Gen 4 French Egg Fix Mauvais œuf, je le réparerai. Bon appétit! Fixes Gen 4 edge case reported by Taya on Discord. * Tweak flow to handle gen2 Add a comment to indicate why this special handling is required	2020-08-26 10:18:10 -07:00
Kurt	a7ba178005	Remove unreachable/const logic ... Earlier compares result in some logic being unnecessary The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)	2020-06-27 22:44:14 -05:00
Kurt	8acb336d51	Use enum for species comparisons ... slightly easier to read with named values	2019-12-08 17:39:19 -08:00
Kurt	b41f2a3062	Extract logic from PKX ... Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only	2019-09-18 19:58:23 -07:00