Kurt
5a20dc707d
Rewrite encounter suggestions
...
Don't clone legality templates, and keep suggested information minimal -- this isn't automod
2020-01-12 19:40:36 -08:00
Kurt
eaeebea923
Remove another method shortcut
...
EncounterSuggestion needs a facelift anyway
2020-01-12 17:00:03 -08:00
Kurt
3b5c7062ac
Minor perf improvement
...
pass in, don't constantly fetch
helps generated IL code be slightly more efficient
2020-01-12 16:49:12 -08:00
Kurt
a8c28369b6
Add Yamask-1 max hp calc for formArg compare
...
Closes #2632 ty @CanoeHope
2020-01-12 16:22:56 -08:00
Kurt
d5948b9dbe
Add relearn moves to Except comparison
...
Burn Up ho-oh is dumb
2020-01-12 16:09:35 -08:00
Kurt
48fd36a9a2
Handle g4 shedinja learn case too
...
change 291/292 to Shedinja/Ninjask for easy enum reference check
2020-01-12 14:34:29 -08:00
Kurt
61ecb52347
Remove unnecessary allocation
2020-01-12 12:06:33 -08:00
Kurt
a305c00ac4
Reorder feebas evo for swsh, patch data
...
Updated comment in #2394 with byte swap info
Forgot to check tests when importing patched data :)
2020-01-12 11:48:42 -08:00
Kurt
82eaf39d45
Remove method alias for init mysterygift db
2020-01-12 11:41:23 -08:00
Kurt
9ed441885a
Remove manual personal info fix
...
Change FDDC from 47 -> 41
SM is 40, as the tutor isn't possible in that game.
2020-01-12 11:39:43 -08:00
Kurt
f6fb54aecc
Move shedinja/egg evo chain short circuit
...
Some routes use the evolutiontree directly instead of this method (with the same name); should probably consolidate but meh
This causes Shedinja to yield the correct evolution chain when called directly (because nothing naturally evolves to shedinja; it's created out of thin air as a clone)
Take the egg short circuit with it to keep things simple
2020-01-11 21:43:58 -08:00
Kurt
0eca1bbd1c
g3 shedinja api usage fix
...
see comments in src for justification
need ninjask moves if gen3; dl.Count is guaranteed to be >= 1
2020-01-11 21:41:24 -08:00
Kurt
7cbf8d0fcf
Set gen3 count ribbons appropriately
...
ty anubis
2020-01-11 15:51:25 -08:00
Kurt
7e6edbaded
Remove unnecessary constructor
...
Make key readonly
2020-01-11 14:18:11 -08:00
Kurt
95f24a9d36
Revise suggested AV set logic
...
Closes #2630
2020-01-11 11:43:53 -08:00
Kurt
62c35194c3
Remove unnecessary form duration code
...
probably misinterpreted the furfrou/hoopa stuff; probably is "SetMaxFormDuration"
d3f6d5935f (commitcomment-36754955)
ty @CanoeHope
2020-01-10 22:16:30 -08:00
Kurt
d3f6d5935f
Add form argument legality checks
...
Closes #2611 (Alcremie)
Closes #2604 (Runerigus)
2020-01-10 16:33:40 -08:00
Kurt
507868ce58
Merge branch 'master' of https://github.com/kwsch/PKHeX
2020-01-10 16:08:51 -08:00
Kurt
fdd321dd8c
Make memory 6 fishy if textvar present
...
Closes #2621
2020-01-10 16:08:34 -08:00
Egzon Qukovci Jusufi
fe13b3374d
Spanish Translations ( #2625 )
...
* Update LegalityCheckStrings_es.txt
* Update lang_es.txt
2020-01-10 16:03:28 -08:00
Kurt
be92d4436e
Rearrange argument check order
...
USUM evo table has Meowstic with Arg=-1, which early aborted.
Closes #2627
2020-01-10 16:02:22 -08:00
Kurt
f291da8f32
Add 2 bw flags
...
Closes #2628
2020-01-10 15:53:26 -08:00
Kurt
718d00f970
Ban ha slowpoke-1
2020-01-09 23:50:15 -08:00
Kurt
cf06335a22
Update 20.01.10
...
Update with latest events from EventsGallery
2020-01-09 21:13:07 -08:00
Kurt
2915692daa
Use more performant block lookup strategy
...
Rather than storing a dictionary of keys, we can abuse the fact that the SCBlock[] is stored in order of ascending block key.
Binary Search doesn't require extra memory like a Dictionary would; also, we only need to find a few blocks.
2020-01-09 19:00:49 -08:00
Kurt
51d2fc9d93
Update with slowpoke-1/new raid data
...
TransferVerifier: Revise transfer check to allow slowpoke-1 (slowpoke-0 is flagged via next check)
2020-01-09 18:44:45 -08:00
Kurt
3fa44361e6
Update block fetch & blank init
...
blanks: {key,size}
fetch: get block by key (index isnt the same between patches, as blocks with different keys get added). The savefile stores them as a SortedDictionary (by key), hence the shifting.
2020-01-09 08:59:26 -08:00
Kurt
bbd1aff5fe
Add new lengths
...
new format still crashes as block absolute index is now different
should do a different way of loading blocks (key instead of index)
2020-01-09 08:17:41 -08:00
Kurt
0dd4d1fe7a
Remove unnecessary casts
2020-01-06 17:50:18 -08:00
Kurt
efbac28b91
Rework accessors for PKMConverter trainer cache
...
Might break downstream users, for the better. Internal behavior had to change!
2020-01-05 21:51:02 -08:00
Kurt
1906a1040f
Relocate console-location data setting to PKMConverter
...
When adding data, check if the current Trainer has valid console data; if not, use a default value.
2020-01-05 21:41:32 -08:00
Kurt
3d581283c2
Minor clean
...
move Text.cs manual Courier new() to the designer, have it dispose when form is disposed. Set it as the numericupdown's font and just reuse that :)
2020-01-05 18:46:30 -08:00
Kurt
7caeebd772
Add formcount for scatterbug/spewpa
...
USUM had 20 for both, but XY/AO/SM had only 1 (vivillon had 20); make
them consistent so that our generated evolution paths behave correctly
Add meowstic specific evolution form modifier... so silly
simpler to have it inlined with the sSpecies, for jit optimization
could probably do this with silvally but meh, things work fine now
Closes #2603
2020-01-04 22:31:46 -08:00
Kurt
e21d108fb2
Split PokeCrypto from PKX
...
All logic in PokeCrypto is separate from the rest of the PKHeX.Core
library; makes it easy to just rip this portion out and reuse in other
projects without needing the entirety of PKHeX.Core logic
optimize out the CheckEncrypted to the actual path, separate methods.
Only usages of this method were with hardcoded Format values, so no
impact
2020-01-04 14:48:39 -08:00
Kurt
68e6644d40
Split off shared nest class, deduplicate logic
...
use generics to have shared logic in one spot
Handle downleveled distribution/crystal(soon?) data
2020-01-04 11:44:16 -08:00
Kurt
308e6fa291
Add temp workaround for version encounter fetch
...
PKX.Generation is 8, which returns SWSH evo tree; evo tree doesn't have
non-galar-native species data, so stuff like Ambipom don't get reversed
properly.
use math.max for tree fetch when appropriate:
- egg generator: pre-evolutions like pichu should be allowed if pk1
- don't fetch format twice, just do math.max
2020-01-04 11:14:25 -08:00
Kurt
ecabbfff53
Add individual Move#_PP $suggest
...
#2603
add in "secret" heal/healPP actions -- do ".Heal=$suggest" to refresh
all stats like it was healed at the pokecenter. I can't think of a good
way to handle invoking of methods (">", but what about parameters?)
2020-01-03 20:21:02 -08:00
Kurt
15779513f5
Add stubs for raid correlation verifiers/generators
...
Not going to implement this within the base repo as z3 is too large of a
dependency and is platform specific.
If anyone wants to implement as a plugin project, just inject your new
methods via the setters on the static func/action at the top of the 3
classes.
Since z3's searches aren't instant, I'd recommend caching recent results
in a dictionary, as re-parses are common. Something like the Wordfilter
is what you'd be aiming for :)
Closes #2617
2020-01-03 20:03:04 -08:00
Kurt
a08ebff699
Add gen8 mimikyu form case
...
Closes #2618
2020-01-03 19:20:16 -08:00
Kurt
0788780404
Add bewear motostoke crossover location
...
Closes #2619
2020-01-03 19:14:03 -08:00
Kurt
852bd2af20
Relocate gui-only text files to WinForms project
...
Split up the DataUtil method to load text files so that the caching
functionality can be reused
2020-01-03 15:53:48 -08:00
Kurt
10b2120b93
Update translations with latest translatable fields
2020-01-03 15:29:31 -08:00
Kurt
350895aba6
Use permissive string search, add indeedee-M case
...
Manually modified showdown sets can contain errors (capitalization,
etc). Use the string search api to permit weaker matches, since there's
not going to be any exact-matches-with-different-caps/spaces.
2020-01-02 15:49:35 -08:00
Kurt
fe8e5e3fd9
Add more string search methods
...
exposes some common string search operations that can be useful for
parsing user entered data
2020-01-02 12:06:58 -08:00
Kurt
35c7195d77
Add custom int/uint parse tests
...
Correctly handle negative parsing for int by flipping sign at end
optimize out a compare char digit/hex check
2020-01-02 11:11:31 -08:00
Kurt
b55dc37e05
Extend some logic
...
make summary more accessible
2020-01-02 10:55:37 -08:00
Kurt
166f8d82e5
Misc clean
...
Refactor out some logic, make "en" literals reference one spot (where
appropriate)
2020-01-01 19:07:21 -08:00
Kurt
7e490b8dcc
Add lanturn/bronzong alt locations
...
Closes #2613
2019-12-31 21:47:28 -08:00
Kurt
0002f1d1ad
Grab CXD location if encounter is COLO or XD
2019-12-31 12:15:48 -08:00
Kurt
14eae5f62d
Add magikarp distribution data
2019-12-30 22:32:12 -08:00
Kurt
3b2b86950f
Ignore symbols (apostrophe) for string matching
...
Farfetch'd vs Farfetch’d
2019-12-30 15:39:13 -08:00
Kurt
84c5f6e914
Add another met location for gastro-1
...
Closes #2612
2019-12-30 15:11:54 -08:00
Kurt
9864f23427
Handle Bridge Field->Stony Wilderness berry tree
...
Closes #2610
2019-12-29 12:48:34 -08:00
Kurt
d6471e2b3b
Add more pelipper & dusclops strong locs
...
ty anubis
2019-12-29 11:28:29 -08:00
Kurt
ce62d63c5a
Fix eggmove fetch for move check
...
Closes #2609
2019-12-29 10:17:07 -08:00
Kurt
f4bafe0809
Add extension methods for gym team get/set for all
...
Closes #2607
SAV6XY/AO had GymTeams get/set, this now makes similar logic accessible
for even SAV5BW/B2W2.
2019-12-28 22:32:45 -08:00
Kurt
be50abcc44
Add SubEventLog block object, etc
...
Adds gym team records, remove from savefile properties
update block list documentation
2019-12-28 21:53:58 -08:00
Kurt
0ce6254cee
Add GymTeam records for Gen5 saves
2019-12-28 21:51:10 -08:00
Kurt
bfd9bf6b53
Simplify formchange calls
...
Don't use the dex chain for certain checks, it's unnecessary.
2019-12-28 19:00:01 -08:00
Kurt
8493471793
Add alcremie form change case
2019-12-28 18:59:00 -08:00
Kurt
3280adcb9f
Add another location for Golurk & Galvantula
...
Closes #2606
2019-12-28 18:03:20 -08:00
Matt
6f1611f360
Add Gen 4-6 Starter Event Constants ( #2608 )
2019-12-28 17:39:46 -08:00
Kurt
b294eba181
Fix combee gender check
...
silly convoluted checks
#2603
2019-12-27 19:17:08 -08:00
Kurt
f65e0a96a7
repoint sav4 event constant reads
...
should work fine now
2019-12-27 18:30:39 -08:00
Kurt
940cdccb6b
Restrict downleveled to lvl % 5 == 0
2019-12-27 00:17:59 -08:00
Kurt
c7e396ef14
Update 19.12.26
...
Update with latest event data from the Events Gallery
2019-12-26 19:07:04 -08:00
Kurt
ceae77c677
Add load-line overlap location for Den 27/42
...
The nest is situated right next to the load line, and may be accessed
from either map (across the load line), resulting in a Dusty Bowl
Pumpkaboo-0.
Many thanks to Anubis on Discord for figuring this (very silly) thing
out !
2019-12-26 18:59:02 -08:00
Kurt
b255937e86
Revise input parameter names
...
pk instead of pkm (consistency)
Lowercase anything that started with uppercase (not static state)
2019-12-26 18:47:31 -08:00
Kurt
d736f24bb7
Heal PP on transfer
...
force everything to their current pp count
2019-12-26 15:28:04 -08:00
Kurt
5cb3556eee
Add Move PP verification
...
Eggs already had it, adding now for regular pkm
Closes #2602
2019-12-26 14:28:01 -08:00
Kurt
9ee2b08ce5
Update rare flag logic
...
Closes #2601
Add ComponentModel attributes for properties, add u64 typeconverter for
propertygrid
2019-12-26 13:39:07 -08:00
Kurt
6c7065fb7b
Fix bool compare
...
oops
https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569134146
ty @slp32 !
2019-12-26 13:12:10 -08:00
Kurt
bb7c94dadb
Add seismitoad location
...
https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568235086
2019-12-26 13:04:44 -08:00
Kurt
baf0f52f06
Handle downleveled raids
...
Closes #2573
- self-hosted raids can be downleveled too (see cufant), probably only
by 1 rank
- min-rank check now checks for downleveled cases
- Add extra gyarados/ferrothorn locations
2019-12-26 12:59:16 -08:00
Kurt
4740fab5ec
Have separate encounter yielder for gen8
...
the "Strong" static encounters can be near-matches with wild encounter
slots; example is a evolved Cutiefly->Ribombee with Quiver Dance.
Remove unnecessary IsLink/FriendSafari check for this gen8 method
https://github.com/kwsch/PKHeX/issues/2573#issuecomment-569126371
2019-12-26 12:32:48 -08:00
Kurt
420307d4bf
Make non-exportable saves (fake) act as VC saves
...
https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569125853
2019-12-26 12:21:35 -08:00
Kurt
06348096aa
Fix block de-referencing issue
...
SCBlock is an input to the individual save blocks; changing the SCBlock
byte[] reference won't change the individual save block reference. Just
copy the data and keep the original reference instead.
Repro: trainer data editor, save-close window, then delete a slot.
Export save; reload. Changes to box data were using old byte[]
reference, and didn't get repointed. Works fine with latest commit now.
I think I wanted to avoid copyto since it's slower than just a reference
change; but that didn't work out perfectly :)
2019-12-25 23:24:40 -08:00
Kurt
0a8c791e10
Pad with null terminators rather than 0
...
Can have a single digit (not forced to 3), so null terminate I assume.
2019-12-25 21:31:49 -08:00
Kurt
0c7d347a29
Add Delibird distribution data, split files
...
ROM nest data definitions are already pretty hefty and won't be revised;
split out the future content
2019-12-25 14:26:49 -08:00
Kurt
827a7649c1
Export PCD/PGT as encrypted format
...
add Write method for writing the data outside the program; only use Data
if you know what you're doing!
2019-12-24 23:24:28 -08:00
Kurt
9d1bfd67b5
Add braces
...
style fix, no functional change
2019-12-24 23:23:42 -08:00
Kurt
e6dcf64abe
Disallow Spiky Ear Pichu eggs
...
sneaky gen4 bad hacks are bad
2019-12-24 13:21:56 -08:00
Kurt
97c3c6b610
Add raid/den detail browser
...
Hold alt when hitting activate all to dump instead
I've seen DenType=5 Event=2 for at least one raid so far... not sure if
the event/rare properties are accurate.
2019-12-23 23:30:21 -08:00
Kurt
bc3e84d30e
Check high bound of language when generating wb7/8
...
Closes #2599 ty @slp32
2019-12-23 11:27:36 -08:00
Kurt
3b1cab0ab5
Update translation resources
...
things are pretty stabilized, so it seems like a good time to allow
translations
2019-12-22 13:53:16 -08:00
Kurt
ea5ca7b2d2
Add Ingredients to swsh held item list
...
Closes #2597
2019-12-22 12:16:06 -08:00
Kurt
3b2ebbb84f
Add PID check for gen4/5 Combee->Vespiquen evo
...
Closes #2593
2019-12-21 16:52:56 -08:00
Kurt
7edfe4543f
Flag eggs with HT string
...
Closes #2586
Modify PKM Info already clears it, but if disabled, will be flagged.
2019-12-21 16:01:51 -08:00
Kurt
ce463d057a
Add Pikachu Beach Score editing for YW saves
...
Closes #2585
2019-12-21 15:17:05 -08:00
Kurt
8309060298
Add more egg verification for statnature/techrecord
2019-12-21 14:51:52 -08:00
Kurt
7889a0abe6
Simplify form egg move handling
...
Closes #2588
2019-12-21 13:37:20 -08:00
Kurt
d7bc68d7a5
Add HT case for capture memory check
...
#2570
https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568149050
2019-12-20 19:47:40 -08:00
NotTsunami
a05b38ab39
Legality: Add Nature and Gender to Gen 8 Trades ( #2591 )
...
Closes #2589
https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Sword_and_Shield
2019-12-20 10:48:46 -08:00
Kurt
4bf71de621
Minor clean
...
automatically update total_watt if insufficient
SAV8 is not SAV8SWSH
#2583
2019-12-12 22:58:18 -08:00
Atzgi
d9c59666e0
Add watt in trainer data editor ( #2583 )
2019-12-12 16:27:01 -08:00
Kurt
506e64186a
Rearrange & re-do "CanHaveMemory" value check
...
Closes #2581
2019-12-11 19:37:57 -08:00
iiippppk
dfa951d76c
Update Gen8 Traditional Chinese Species ( #2579 )
2019-12-11 06:09:41 -08:00
iiippppk
35c0a4d931
Fix Chinese text error ( #2578 )
2019-12-11 06:09:12 -08:00
Kurt
802b93bb16
Fix xor order
...
oops, upper half gets the star/square xor
no real difference since PID is random
2019-12-10 22:05:47 -08:00
Kurt
108233b45f
Add glalie/skuntank locations
...
#2570
2019-12-10 19:54:26 -08:00