1634 commits

Author	SHA1	Message	Date
Kurt	a9f65a4617	add lock for cross thread dictionary manip ... could use concurrentdictionary but after reading some perf drawbacks vs manual locks, just do it manually. regex checking is the real slow part, whatever add some comments to describe	2018-08-25 10:48:37 -07:00
Kurt	5fe9226c62	Ignore fixed language trades for gen4 korean check ... Closes #2103 Thanks @Narithegreat !	2018-08-22 22:36:56 -07:00
Kurt	d40b10f4a4	Remove unused method ... SaveFile already has ModifyBoxes which has better built in checks for locked slots.	2018-08-22 22:35:50 -07:00
Kurt	ab0a792968	Move valid item override to pk1, pk2 uses base ... Closes #2101	2018-08-21 07:47:23 -07:00
Kurt	ebb1e8a704	Update 'cant hold item' message ... #2101	2018-08-21 07:46:55 -07:00
Kurt	19f9765752	Add missing species setter ... Closes #2100	2018-08-21 07:37:15 -07:00
Kurt	29f73993b1	Misc reorg ... simplify gameinfo comments/return move item1->item2 conversion to itemconverter just general upkeep	2018-08-20 22:09:35 -07:00
Kurt	7ccaf8783b	Unban bred HA sableye ... yeah totally genderless https://projectpokemon.org/home/forums/topic/47101-gen-v-hidden-ability-sableye/	2018-08-20 20:08:42 -07:00
Kurt	daf9364fb2	Alphebetize settings ... probably want to switch to a propertygrid later.	2018-08-19 21:25:21 -07:00
Kurt	c7aea9cad2	add option to hide pid/ec ... hides pid & ec in pkmeditor, gamesync & securevalue in saveditor easier to share screenshots/stream without leaking identifying information fix auto-centering of pkmeditor subwindows when a savefile is detected on program load(tab_otmisc isn't initialized and reads an incorrect width)	2018-08-19 18:22:07 -07:00
Kurt	af0b8b2a37	Add egg sprite alternate display + setting ... egg sprites can be a little difficult to see what's underneath (glance value) make the new egg sprite method the new default; adds setting to revert to old behavior adds translation text for the mega rayq control from #2098	2018-08-19 16:45:20 -07:00
Kurt	d307a30cad	misc optimization ... list initial size is 4; oftentimes it's greater, and always padded	2018-08-19 16:26:08 -07:00
Kurt	c0b5d3eef7	Abstract away pk1/pk2 properties to shared class ... some inefficiencies with pk1 altform/iskorean but is much easier to manage	2018-08-19 15:50:15 -07:00
Kurt	7ef5d9e547	Add pk1 current level property party->box setter ... https://projectpokemon.org/home/forums/topic/47086-bug-trades-between-two-saves-1g/?do=findComment&comment=235241 fresh encounters have yet to be boxed and don't have the value; set it whenever setting a Stored slot.	2018-08-19 13:35:20 -07:00
Matt	8c64f378c1	Add Mega Rayquaza unlock to GUI (#2098) ... * Add Mega Rayquaza unlock to GUI	2018-08-19 08:24:59 -07:00
Kurt	a200dc85c7	Add bvid util	2018-08-18 20:10:34 -07:00
Alberto Tudela	58eddd0225	Update spanish translations with new hide savdetail setting	2018-08-18 16:45:39 +02:00
Kurt	633f0e1da9	Extract filetype detection, add xmldoc	2018-08-17 23:23:44 -07:00
Kurt	b526d4657b	rework tile flip check flow, remove goto	2018-08-17 16:22:54 -07:00
Kurt	d7f39ea343	Extract pkm searching to separate classes ... search logic can now be reused by core projects adds option to provide extra filters run at the end (prior to clone check)	2018-08-16 20:06:40 -07:00
Kurt	e366f9a93d	Misc tweaks ... only have one empty forme array object rename method for clarity show version ID for hidden savefile program window titles	2018-08-15 21:15:06 -07:00
Kurt	eec14645ef	Lessen string length severity on egg encounters ... Hatched eggs can have mismatched languages<->OT/Nick restrictions	2018-08-15 15:26:42 -07:00
Kurt	5514530dfb	update OT name edge case ... traded ENG->KOR egg was getting flagged #2094	2018-08-15 15:19:54 -07:00
Kurt	b6de41bfa7	Add OT name max length checks ... Closes #2094	2018-08-15 14:58:55 -07:00
Kurt	bc262a7cdf	Remove Plasma Fists from unsketchable ... Closes #2095 split out unsketchable moves (struggle/chatter) to separate array remove trailing spaces (auto fixed by my visual studio plugin), add space before comment //	2018-08-15 14:52:25 -07:00
Kurt	57c6de2825	Add nickname length check for gen>2 ... Closes #2091	2018-08-14 20:13:15 -07:00
Kurt	75d700c171	Fix sav1 jp load order ... oops	2018-08-14 20:12:10 -07:00
Kurt	f079f62956	Remove fullness/enjoyment check ... Although bank 6->7 deletes the values for these fields, Pokémon Refresh can still reintroduce new values. Closes #2090 , thanks @Lusamine !	2018-08-14 16:45:51 -07:00
Kurt	10f050eb18	Update translations with new hide savdetail setting	2018-08-13 19:40:00 -07:00
Kurt	70a6cd9421	Remove untranslatable content ... sav6 recently added trainer appearance editor, prior commits removed pt translation (only official ingame translations)	2018-08-13 19:24:49 -07:00
Kurt	6edc828cc3	misc style updates	2018-08-12 19:27:11 -07:00
Kurt	d3ec969187	Style updates ... split pcd/pgt add more xmldoc	2018-08-09 21:53:39 -07:00
Kurt	8187606a89	Clarify sav6 boxflag in src ... 7 wallpaper flags (not all used), top bit unlocks box 31 https://projectpokemon.org/home/forums/topic/34466-box-31-is-unlocked-but-not-showing-on-bank-any-ideas/ PCFlags + 2 is just CurrentBox, don't include it anymore.	2018-08-08 22:02:06 -07:00
Kurt	6b62dd29ee	Update xy fashion edits ... different for each gender	2018-08-08 21:27:14 -07:00
Kurt	7403c0f91a	Add more pokewalker moves ... igglybuff wish, happiny heal bell, and the elemental punches to round things out even though they can be tutored https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234991	2018-08-08 17:35:06 -07:00
Kurt	975759e53c	Update str<->val base32 encoder ... simpler	2018-08-07 16:32:31 -07:00
Kurt	259feae038	re-allow event flag editing on gen1 ... closes #2088	2018-08-07 07:54:14 -07:00
Kurt	421c522eb4	Fix gen1 sav load ... Starter fetches via Offsets, which was null, reorder the init Thanks @Ninjistix ! Closes #2087	2018-08-06 21:29:47 -07:00
Kurt	98f21a12dd	Relocate gen6 trainer stat records to core ... use trainerstat editor control in gen6 editor fill in some details from the disassembly via setrecord usages still slightly fuzzy on some: fureai (based on usum idb name, similar logic) soaring sky counts looks like there's some other usages of the fields which were outside the stat range, throwing an exception when loading to NumericUpDown, added bypass logic Thanks Holla!	2018-08-06 21:27:31 -07:00
Kurt	37e5c9fc69	Add record details for gen6 ... pulled from exefs data	2018-08-06 16:52:43 -07:00
Kurt	48a61a00a2	Relocate record stat id's to core ... can potentially add localization by changing the method of fetching	2018-08-06 16:17:32 -07:00
Kurt	0296f98777	Add offset table for sav1 ... calling Japanese ? X : Y on every single access is too excessive, just compute one layout for each type whenever the first sav1 requires it. could probably reduce the amount of properties by reusing others + shift value; offsets are different due to string lengths being different	2018-08-05 20:27:25 -07:00
Kurt	fc73eee570	Extract PokemonList* to inherited class ... Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little	2018-08-05 17:28:54 -07:00
Kurt	84185dc6c9	misc improvements ... add records class for managing info for trainer records add more b2w2 block docs	2018-08-05 12:39:06 -07:00
Kurt	ca39843046	Length check relearn suggestion ... CLsoes #2086	2018-08-04 17:06:51 -07:00
Kurt	279c9d4665	Fix tradeback detect for gen2->1->2 evolve case ... https://projectpokemon.org/home/forums/topic/46909-certain-gen-i-moves-are-showing-invalid/ Thanks Raptor385!	2018-08-04 13:36:05 -07:00
Kurt	53857df647	Copy addmoves special case to individual fetch ... see prior commits	2018-08-04 10:05:47 -07:00
Kurt	0f63b0a0ee	Allow bw movepool except for kyurem ... workaround provided for kyurem movepool (which is same bw-b2w2) but the AddMoves logic with form != 0 points to the form == 0 data Closes #2085	2018-08-03 07:46:53 -07:00
Kurt	30a614484e	Update STADIUM ot checks again ... jp: 1999 if stadium1, 2000 if stadium2 en: 2000 jp: always same OT en: lowercase if stadium2, uppercase if stadium1 https://projectpokemon.org/home/forums/topic/46893-pkhex-bug-stadium-ot-issue/	2018-08-03 07:38:29 -07:00
Kurt	4103b4d4b0	Update 18.08.03 ... Update event binaries with latest from the Event Gallery	2018-08-02 21:01:17 -07:00
Kurt	1486b7f14a	Misc style & minor tweaks ... Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes	2018-08-02 20:11:42 -07:00
Kurt	19a897923d	Reference original encounter for sensitive checks ... https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234360 thanks paf!	2018-08-01 20:39:20 -07:00
Kurt	f4bfdb8311	Remove unnecessary empty array allocations ... yay net 4.6 read more: http://justinvp.com/2015/07/20/array-empty/	2018-08-01 18:30:51 -07:00
Kurt	fe6c071d72	Be more generous on nick parse ... benefits manual-edit users who forget to put a space between nick(species)	2018-08-01 18:28:05 -07:00
Kurt	007ec93d85	Update trade nick check for non-nicknamed ... Closes #2084	2018-07-31 17:27:28 -07:00
Kurt	4c96efb9b7	Update pk2->pk1 party stat transfer logic ... pk1 boxdata stores current level & current hp, which is only present in pk2 party data. if the user drops in pk2(boxdata), the transfer leaves 0 for both values, which isn't correct. detect stat_level to determine if values should be regenerated or not. Thanks HaxAras for finding this :)	2018-07-31 14:29:47 -07:00
Kurt	32b90fab13	Simplify some logic	2018-07-29 21:54:02 -07:00
Kurt	02a6d26e1b	Break apart BAKName into smaller components ... simplifies definition & makes it easier to update bakname usage later	2018-07-29 21:51:45 -07:00
Kurt	f35712fcf2	Extract experience logic to separate file ... add exp bar logic, unused.	2018-07-29 17:43:30 -07:00
Kurt	3fd21db51e	Style & function extracting	2018-07-29 16:39:15 -07:00
Kurt	0de335d52b	Misc reorg	2018-07-29 14:04:16 -07:00
Kurt	b16015e8e5	Split InventoryPouch to inheriting classes	2018-07-29 13:55:07 -07:00
Kurt	d916be1020	Style updates	2018-07-29 13:27:48 -07:00
Kurt	41643a4c86	Use correct language ID for nickname check	2018-07-29 12:47:38 -07:00
Kurt	96484eceb5	Update version logic ... Fixes broken tests (glaceon card can only be received by SM, was getting set to UM).	2018-07-29 11:34:27 -07:00
Kurt	cfa3479a4b	Add egg experience check ... Closes #2083	2018-07-28 18:09:29 -07:00
Kurt	2092d55b23	Update e/fr/lg stats for deoxys formes ... Closes #2082	2018-07-28 09:02:41 -07:00
Kurt	c46924d220	Use wcxfull version/language restriction data ... some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.	2018-07-27 22:26:27 -07:00
Kurt	77bd91397a	Update form sizing / es translations ... use some close synonyms (Reiniciar -> Borrar) omit some words (potential / training) to keep layout compact capitalize Equipado to match main window Closes #2080	2018-07-27 17:38:23 -07:00
ajtudela	11ab585368	Big spanish changes (#2081) ... * Update spanish translations	2018-07-27 12:40:30 -07:00
Kurt	3d0a2946eb	Allow only one movepool for BW-B2W2 source ... they're both the same, but bw's pool does not have b2w2 formes Closes #2078	2018-07-26 21:51:11 -07:00
Kurt	c8563a3737	Respacening ... Style guidelines, handle a bunch of files no functional change	2018-07-26 19:34:27 -07:00
Kurt	9551d4e707	Relocate logic to core ... probable/possible lgpe uses similar dex stuff, so best I totally understand it (assuming quirks will be present)	2018-07-26 18:01:16 -07:00
Kurt	d19705f5a9	Fix incorrectly ordered name<->bitindex ... names have sinnoh second not first https://projectpokemon.org/home/forums/topic/46377-invalid-invalid-ribbons-record/	2018-07-26 17:12:27 -07:00
Kurt	75801e22e0	Update egg location -> encounter generating checks ... WasEgg only checks for EncounterEgg valid locations; check for any value instead.	2018-07-26 14:55:49 -07:00
ajtudela	1c05001fb7	Update spanish translations (#2077) ... * Update spanish translations	2018-07-26 07:06:14 -07:00
Kurt	711157f3ea	Refactoring ... Extract trainer pkm origin check to interface extension	2018-07-25 20:40:57 -07:00
Kurt	f0fc4b0693	remove alias'd properties	2018-07-25 19:43:02 -07:00
Kurt	e8644280a1	Update sav4 block detect logic ... #2070 desmume inits a savefile to FFFFFF... others instead init to 00's. check both init states, add IsRangeAll method 5f39118b8a Thanks @Filo97 !	2018-07-25 16:00:52 -07:00
Kurt	609e6b4c43	Add jangmo-o/hakamo-o to dashedspecies group ... importing little cup idk	2018-07-25 15:53:02 -07:00
Kurt	5fbf132615	Add handling for pgt ranger manaphy ... skip out on load if pgt extract pgt pid gen method set gender & PID if rangeregg since PID == 0 not 1. Closes #2075 yay 5k!	2018-07-25 07:34:48 -07:00
Kurt	f0090669bb	Update catch rate related logic ... #2071	2018-07-24 19:33:42 -07:00
Kurt	279f44a645	Simplify GB stat calc, fix pk2->pk1 xfer fainting ... Remove unnecessary floor operation, don't fetch stat arrays for each stat Current HP is a box stat in pk1 format (offset 0x1), which isn't stored in box pk2's. If the hp is zero, set it to the current HP. Thanks HaxAras for the conversion tip!	2018-07-24 16:41:18 -07:00
Kurt	3294805380	Update translations ... Translatable about menu, translatable PKMConverter strings	2018-07-24 15:50:00 -07:00
Kurt	64284eafef	Add pk1/pk2 direct import checks ... dragdrop: check import files from folder: check no other paths convert afaik Closes #2074	2018-07-24 15:49:00 -07:00
Kurt	81355dfaf4	Update translatables for pkm conversion	2018-07-24 15:36:46 -07:00
Archit Date	e52838df37	glow setting (#2073) ... * add PKM glow setting * change setting name for consistency	2018-07-23 19:25:54 -07:00
Kurt	3c4ba0d52b	Misc cleanup	2018-07-22 17:26:19 -07:00
Kurt	b97e967304	Misc cleanup	2018-07-22 17:14:22 -07:00
Kurt	a693ba87ba	Update cosplay sprite handling ... Cosplay are stuck on gen6, cap pikachu can interact with bank; make Cosplay the oddball resource.	2018-07-22 12:06:43 -07:00
Kurt	c9408e6af4	Misc clean	2018-07-22 12:00:03 -07:00
Kurt	abe6ef1be3	Move ribbon verifiers to appropriate folder ... no functional change	2018-07-22 11:50:11 -07:00
Kurt	da839988af	Simplify RBY checksum calc ... utilize unchecked byte overflow remove unnecessary zeroing -- t's immediately after the checksummed region. even if it was included, chk += 0 is still 0.	2018-07-21 19:24:09 -07:00
Kurt	0c5c9bc33c	Misc clean / xmldoc updates ... remove unused label in QR (use window Font) escape & -> &amp; for xmldoc proper style	2018-07-21 19:20:11 -07:00
Kurt	1c49b0681d	Extract dex logic	2018-07-21 11:46:38 -07:00
Kurt	63b9b72a49	Relocate save detection to core ... Environment.GetLogicalDrives is not present in net standard 1.3; relocate code and add it as a parameter	2018-07-21 10:23:15 -07:00
Kurt	0c632604d2	Move files ... Saves now has a similar folder structure to PKM	2018-07-20 21:33:55 -07:00
Kurt	c7175fbdb4	Misc reorg ... bye bye SAVUtil and PKMUtil	2018-07-20 21:32:33 -07:00
Kurt	f27f11bfc8	Clean up pk7/sav6/sav7 simple methods ... extract GetFormDuration to method, remove unused GetIsCompatible specialized variant (there's a generalized version in SAVUtil.cs, IsPKMCompatible -- might do another round of WinForms->Core absorption	2018-07-20 20:25:28 -07:00
Kurt	4b0a2d90b9	Add xmldoc	2018-07-20 20:22:46 -07:00
Kurt	c9abeda508	Update stadium check again ... #2065	2018-07-20 05:57:57 -07:00
Kurt	1ff8ebf777	Misc overload add/use ... Some values are already computed; pass them in to overloads for quicker execution	2018-07-19 19:38:44 -07:00
Kurt	614d2629ce	Remove unnecessary ref passing ... object is already passed byref, don't need to repoint the reference	2018-07-19 18:09:37 -07:00
Kurt	9a91619580	Update vc1 invalid transfer pruning ... Closes #2065 Thanks @WEERSOQUEER ! Single evo species weren't getting flagged in the evolution verification as they early returned (species matched), just move the sanity check before that	2018-07-19 16:42:45 -07:00
Kurt	69e7d49d03	Simplify Stadium OT Check ... TID is always 2000 : #2065	2018-07-19 15:54:34 -07:00
Kurt	ff4ca47ebe	Remove GBEncounterData boxing ... Interfaces implement enough detail, so can simplify extract local methods (likely will be inlined) less obj allocations = faster!	2018-07-18 16:37:21 -07:00
Kurt	1c75093e27	Specify altform for ranch shellos ... 1 not 0 https://projectpokemon.org/home/files/file/336-shellos/?do=findComment&comment=1290&tab=comments	2018-07-18 07:15:46 -07:00
Kurt	01c4ca348f	Allow FolderList to be translated	2018-07-17 21:02:01 -07:00
Kurt	a100488142	add gen12 generator kadabra catch rate case ... https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/ Thanks Cloud AC ! update misc verifier for catchrate to better indicate for any->nontradeback scenarios	2018-07-17 16:54:23 -07:00
Kurt	fe7fea877b	Replace boolean OrderBy with DeferBy ... orderby consumes the entire input enumerable in 'sorting' the list; since we don't care about the order besides a yes/no, just manage the yield order ourselves. don't bother using this method more than the spot it's in; was a fun exercise but other spots are set up for easier debugging (overall flow is where->deferby->yield), could make things easier to read but meh	2018-07-17 16:28:42 -07:00
Kurt	e4aa16f396	Fill out gen5 hidden ability banlist ... now flags gen5 contrary serperior ;)	2018-07-16 21:53:46 -07:00
Kurt	99c790a4b0	Update File name/path/folder fields ... original file path is not saved with the two listed properties, add FileFolder and relcoate existing FilePath functions to that field move some GetVariantSAV usages to the string method instead of byte[]	2018-07-16 21:00:43 -07:00
Kurt	bdb5aaee36	Ignore mismatch if explicitly permitted by prior check ... Closes #2062	2018-07-16 16:12:19 -07:00
Kurt	7ec1cab9a7	Update gen1/2 trade generator to emit gen1 if match ... Closes #2060	2018-07-16 15:22:40 -07:00
Kurt	f51ac7d1f3	Update translations ... Internal repositioning to match source (auto generated changes)	2018-07-16 15:12:40 -07:00
kang1806	afca1b8145	Update MessageStrings_zh.txt (#2063)	2018-07-16 15:09:01 -07:00
Kurt	9a1695f319	Update 18.07.16 ... Update event binaries with latest from the Event Gallery	2018-07-15 21:44:50 -07:00
Kurt	a81c28f114	Upgrade FolderList to show recent/backups ... sortable grid like the ReportGrid for pkm, can open/browse individual files	2018-07-15 17:48:31 -07:00
Kurt	99673706a0	Rework recent savefile detection ... return a reference to the savefile rather than the path, since a SaveFile has a FilePath property.	2018-07-15 13:35:58 -07:00
Kurt	cc509de83c	Add lgpe properties	2018-07-14 21:55:45 -07:00
Kurt	0f17445ef4	Update gen3 event pidiv method check for eggs ... closes #2057 Thanks @kamronbatman ! (nothing currently implemented uses BACD_U_S)	2018-07-14 20:19:13 -07:00
Kurt	cb80c02011	Check Yellow catchrates when updating species ... https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/	2018-07-14 18:08:51 -07:00
Kurt	d2eba35504	Update interface parameter names ... sync to previous	2018-07-14 18:08:30 -07:00
Kurt	6c8374f26f	Extract inner sprite building to class ... any romhack maker can replace the behavior with their own builder	2018-07-14 17:53:37 -07:00
Kurt	6b7ba49cba	Remove unnecessary logic ... gamestrings: call but not value used text.cs: use gamestrings method for auto-filtered, now removes korean in Gen3 context	2018-07-14 16:53:14 -07:00
Kurt	8c2b74c149	Refactoring ... max IVs use flawless method directly with 6 IVs specified move color blend/stat calc to ImageUtil move potential string to commonedits expose color properties for pkmeditor don't constantly create/dispose brushes for drawing legal moves	2018-07-14 15:08:14 -07:00
Kurt	baac632218	Enable editing gen1/2 hidden power type	2018-07-14 10:56:11 -07:00
Kurt	625a77589b	Extract geolocation logic to interface ... mixins would be nice but I guess extensions cover this	2018-07-14 10:34:34 -07:00
Kurt	7d1994dc8a	Add xmldoc for public members	2018-07-14 09:55:22 -07:00
Kurt	b039112a1d	Add gen1/2 hidden power setter calc	2018-07-13 20:30:57 -07:00
Kurt	5d20c79568	Add showdownset localization for slot previews ... Localization only for game strings (not Ability/Nature/Stat/etc labels) feels kinda goofy but it works	2018-07-13 19:13:25 -07:00
Kurt	83e61923f7	Add bw/2 jellicent deferral case ... https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?tab=comments#comment-233860 Thanks paf!	2018-07-13 13:48:27 -07:00
XxPhoenix1996xX	9f2712cf4d	Update text_Mail4_es.txt (#2056)	2018-07-13 08:40:18 -07:00
Kurt	ebed1026cd	Update national dex magic setting ... bulbapedia is wrong, first 4 bytes are info values: 0x0 = dex order (alphabetical, numerical), unused in frlg 0x1 = mode (unused in frlg), regional vs national 0x2 = national magic rse (always set in frlg) 0x3 = national magic frlg (never set in rse) refer to disassembly (pokefirered isn't too helpful, less developed. just compare save files & edit ram!) the other 2 values being set are the eventflag & event const, could use the abstraction for those rather than direct ofs writes	2018-07-12 23:23:36 -07:00
Kurt	d42cc7cacd	Add spinda/unown PID properties	2018-07-12 22:07:44 -07:00
Kurt	98a1677d14	Fix property reference ... oops	2018-07-12 20:36:59 -07:00
Kurt	ea5a981f4a	Add Hidden Power type calculation for pk1/pk2 ... Use format specific for import, with format guess to the current savefile known to pkmconverter.	2018-07-12 18:16:24 -07:00
Kurt	296d1c20ed	Use ITrainerInfo interface for trdata	2018-07-12 18:15:20 -07:00
Kurt	3da4873f94	Bounds check species ID for negative ... certain downstream consumers of the library be doin silly things	2018-07-12 17:09:39 -07:00
Kurt	04765ef411	Add more xmldoc ... Covers all gameversion enum members (whew)	2018-07-12 16:55:24 -07:00
Kurt	d20706dd70	Update xmldoc ... le lenny goes here	2018-07-11 19:19:19 -07:00
Kurt	e4e5018aa7	Extract some methods	2018-07-11 19:13:09 -07:00
Kurt	6816c2de43	Update OT affection check for 3-5 memories ... https://projectpokemon.org/home/forums/topic/46180-oras-transfered-pokemon-invalid-ribbon/ Thanks piplupwater! (there's no other usages of V129)	2018-07-11 17:43:48 -07:00
Kurt	8a83b9bde8	Update manaphy ability check again ... 57250823a8 covered it for format>=6, in 4/5 the abilitynumber is derived from PIDAbility Closes #2052	2018-07-10 21:30:13 -07:00
Kurt	01323c0ee8	Add id7 setters ... can now set TrainerID7 / TrainerSID7 via batch editor	2018-07-10 21:25:03 -07:00
Kurt	7f31fdf874	Simplify string trim ... RemoveRange instead of while {remove last}	2018-07-10 17:54:05 -07:00
Kurt	f8c43d4a06	Rework gen1 trade OT handling ... convert all dictionaries to char-byte instead of string (saves 50KB on compressed dll, lul) update OT string comparison for pre/post transfer specimens Showing "TRAINER" for all languages isn't correct, just show a mapped character Closes #2049 , thanks @egzonqj & @WEERSOQUEER !	2018-07-10 16:45:24 -07:00
Kurt	027d898f3d	Update Yancy Curtis trade OT checks ... Thanks paf! https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/	2018-07-10 12:37:40 -07:00
Kurt	c8897161b7	Fix gen6 evo tree resize miss ... https://projectpokemon.org/home/forums/topic/46144-a-couple-of-new-problems-in-the-pkhex-version/ Thanks CreamatedReptile2018 !	2018-07-09 22:51:01 -07:00
Kurt	93876d98eb	Fix CanInhabitGen1 comparison ... extracted and forgot to double check the boolean comparison when inverting the return value https://projectpokemon.org/home/forums/topic/46148-bug-gen-1-moves-and-legendaries-incorrectly-flagged-in-gen-2-game/ Thanks Raptor385!	2018-07-09 21:59:38 -07:00