Kurt
53dbdf62f7
Add more test cases, case insensitive parse
2019-03-18 00:04:17 -07:00
Kurt
5e3b390fe1
Add learnability API and tests
2019-03-17 22:19:46 -07:00
Kurt
d975081a86
Add short/long name property differentiation
2019-03-17 22:19:37 -07:00
Kurt
9f7f9f9e75
Use glyph dictionary instead of creating 19 strings
...
muh optimization
2019-03-16 20:15:12 -07:00
Kurt
3eed1370c1
Minor simplification
...
if conditional checks >=3, and all subsequent checks require Valid; add
this to the continue condition, and remove unnecessary comparisons
update some comments
2019-03-16 20:07:30 -07:00
Kurt
99baca5f5e
Use min parameter count
...
PK2 doesn't like getting passed null for the byte[] parameter (rightly
so); don't depend on the src code order having the first constructor
being the one with the least arguments
fix it in pk1/2 so that the first constructor has the least args, anyway
2019-03-16 20:04:44 -07:00
Kurt
8a08d32dff
Simplify pkm constructors
...
remove Identifier param. 99% of the time, identifier is not provided,
resulting in a useless call
end result:
provide 'create new' and 'create from' constructors
2019-03-16 18:41:56 -07:00
Kurt
fb76032a39
Remove unnecessary null checks on constructors
2019-03-16 18:23:50 -07:00
Kurt
5765ce8229
Extract gc version IDs to separate logic
2019-03-16 16:48:38 -07:00
Kurt
ebc7c6ae29
Remove PKX.LCRNG method
...
Duplicate with RNG.LCRNG
reuse cryptarray for gen5 mysterygift r/w
2019-03-16 16:25:25 -07:00
Kurt
fc10fd3d60
Simplify transfer xor, extract glyph conversion
2019-03-16 16:19:00 -07:00
Kurt
9ca4ef1e09
Move pkx hidden power logic to HiddenPower.cs
2019-03-16 12:07:22 -07:00
Kurt
13a6d16cb9
Relocate checksum/dexform logic
2019-03-16 12:01:21 -07:00
Kurt
7bab3a69fe
Merge pull request #2271 from bsinky/more-BV7-data
...
Add PlayerNames and MatchStamp to BV7
2019-03-15 14:36:06 -07:00
Benjamin Sinkula
e4d59b8b98
Add PlayerNames and MatchDate to BV7
2019-03-15 14:35:55 -05:00
Kurt
41bc3f6182
Fix header'ed file export
...
For xd, getfinaldata returned a standard 344KB save, but then slapped it together with the inner savedata (0x28000 bytes) rather than using the GCI header. Don't use 'Data'
2019-03-15 10:26:16 -07:00
Kurt
118dcb4d0b
Merge pull request #2270 from sora10pls/patch-1
...
Add file references for Let's Go
2019-03-12 09:33:43 -07:00
Matt
ecd8117e83
Add file references for Let's Go
2019-03-12 11:59:06 -04:00
Kurt
7e864c67b7
Update assembly info (version)
...
now reflects 19/03/11
2019-03-11 06:23:48 -07:00
Kurt
97c8c40855
fix typo
2019-03-10 22:59:08 -07:00
Kurt
94c80fd32c
Update 19.03.11
...
update mgdb latest
2019-03-10 22:56:30 -07:00
Kurt
e0ca0ac1f4
Add decoration / unown puzzle flags
...
UnlockAllDecorations already exists in SAV2.cs , but expose these in the
GUI with names
2019-03-09 23:13:07 -08:00
Kurt
e8a5a55323
Add union/berry crush stat ids
2019-03-09 10:26:43 -08:00
Kurt
88e2bce495
Sync gs en flags
...
match zh/ja
2019-03-09 00:16:16 -08:00
Kurt
0d5ee9489b
Fix memcard sav cloning
...
Closes #2267 , Thanks @PMArkive && @Subject21J !
2019-03-07 18:05:55 -08:00
Kurt
bd00680545
Fix incorrect block index ref
...
https://github.com/kwsch/PKHeX/issues/2267
Still doesn't fix the underlying issue
2019-03-07 17:30:50 -08:00
Kurt
7734e81adf
Remove unnecessary bytesperchar check
...
current.Length will always start right after the terminator data;
shifting further is unnecessary.
#2261
2019-03-07 16:58:19 -08:00
Kurt
ee787a0f71
Fix HoF size check
...
now matches the code in ChecksumsValid (< instead of <=)
2019-03-07 15:45:51 -08:00
Kurt
9b783dd047
Unban mankey/machop shiny pgo transfers
...
https://pokemongolive.com/en/post/battleshowdown2019/
Mar. 5, 2019, at 1:00 p.m. PST (GMT −8) to Mar. 12, 2019, at 1:00 p.m.
PDT (GMT −7)
2019-03-05 23:09:39 -08:00
Kurt
61bf82e2bd
Add gs event flags
...
https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804
via pret repo; looks like 2000 event flags, and 0x100 event
consts/work-vals (byte)
add more rebattle toggles
2019-03-05 23:06:05 -08:00
Kurt
a4bf6335a9
Unclamp max date
...
values above 2100, whatever, let them get saved however they end up
2019-03-05 16:33:54 -08:00
Kurt
8d49400b07
Change SecondsTo* from int to uint
...
having a year > 2050 can result in a 32bit seconds value (top bit set);
instead of being negative, keep it as a 32bit number.
2019-03-05 15:55:26 -08:00
Kurt
bb2c7e22cb
Add HoF checksum verification and saving
...
Thanks @av🥑 cado#0315 (discord)
2019-03-02 09:16:03 -08:00
Kurt
174f9758a1
Fix gen1 hm index check
...
Closes #2266
2019-02-28 10:01:28 -08:00
Kurt
e8ade4dd63
Add swsh placeholders
...
no point adding for legality until much closer to game release
2019-02-27 06:37:11 -08:00
Kurt
fb818f203d
Add gb pp/stat calc test
...
refer #2265
2019-02-25 17:39:41 -08:00
Kurt
297952db66
Merge pull request #2265 from SadisticMystic/patch-1
...
Fix a couple off-by-one logic errors in early gens
2019-02-25 17:30:31 -08:00
Russell Jones
2909c4afef
Update _K12.cs
2019-02-26 01:26:19 +00:00
Kurt
51bdd7d67c
Unban shiny rattata & pidgey
...
available on pokemon day 2019
https://twitter.com/SerebiiNet/status/1100138566833852421
2019-02-25 17:09:03 -08:00
Kurt
925167bd33
Fix Invalid/Missing Ribbon string format swap
...
Thanks TORNADO (discord)
2019-02-24 22:20:02 -08:00
Kurt
28823bd437
Split optional into overload
2019-02-24 22:16:30 -08:00
Kurt
30e36579be
Misc updates
...
add more xmldoc
revise some comments for clarity
redo a little bit of logic for perf
rename some methods for better description
2019-02-24 13:57:10 -08:00
Kurt
993bb00a61
Remove powersave unused logic
...
unused & deprecated in favor of using cfw (powersaves price >>>
ntrboot-b9s flashcart)
2019-02-23 18:02:50 -08:00
Kurt
7ba21c5d8c
Use subsection fetch
2019-02-23 17:59:46 -08:00
Kurt
52dd2d6701
Misc tweaks
...
replace linq for Encrypt/Decrypt pkmdata fetch with faster length check
& optional resize (Span pls!?)
update pk6 comment for why affection is not cleared
2019-02-23 16:05:01 -08:00
Kurt
d792c0d3a0
use u/L
...
use 'u' to denote uint values, so that less IL ops are required
~(21->17) in the case of IVs
no functional change, just a fun exercise looking at generated IL and
finding ways to use less ops
2019-02-23 15:36:26 -08:00
Kurt
5b29e71954
Misc tweaks
...
no functional change, just rewrite some logic for better flow
fix subform popup count restriction (OwnedForms requires forms to be
added/removed manually; it doesn't automatically update)
sanitize box names when dumping boxes with separate folders (and bad box
names)
2019-02-23 14:58:48 -08:00
Kurt
17f954b4e8
Xmldoc
...
Reorder to match parameter order
add more xmldoc
2019-02-23 14:57:35 -08:00
Kurt
ca51edbdcf
Change sav.LoadBoxes to return int
...
make MysteryGift specific method flexible so that any IEncounterable
enumerable can be passed.
2019-02-23 14:37:06 -08:00
Kurt
5e242833ba
Sync missing change
...
oops
2019-02-23 09:14:23 -08:00