PKHeX/PKHeX.Core/PersonalInfo/PersonalInfoG4.cs

using System;

namespace PKHeX.Core
{
    /// <summary>
    /// <see cref="PersonalInfo"/> class with values from Generation 4 games.
    /// </summary>
    public sealed class PersonalInfoG4 : PersonalInfoG3
    {
        public new const int SIZE = 0x2C;

        public PersonalInfoG4(byte[] data) : base(data)
        {
            // Unpack TMHM & Tutors
            TMHM = GetBits(Data, 0x1C, 0x0D);
            TypeTutors = Array.Empty<bool>(); // not stored in personal
        }

        public override byte[] Write()
        {
            SetBits(TMHM).CopyTo(Data, 0x1C);
            return Data;
        }

        // Manually added attributes
        public override int FormCount { get => Data[0x29]; set {} }
        protected internal override int FormStatsIndex { get => BitConverter.ToUInt16(Data, 0x2A); set {} }
    }
}
-												Add gen4 formes to personal

Manual tweaks

											
										
										
											2016-07-28 01:08:08 +00:00
+								using System;
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
-												Split winforms to separate project

resources still are associated with winforms, eh
program still runs fine and I've replicated the mono build options. lmk
if this breaks stuff

											
										
										
											2017-01-08 07:54:09 +00:00
+								namespace PKHeX.Core
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								{
-												add more pkhex.core xml documentation

adds a bunch of documentation useful for those unfamiliar with the core
library

											
										
										
											2017-10-24 06:12:58 +00:00
+								    /// <summary>
 								    /// <see cref="PersonalInfo"/> class with values from Generation 4 games.
 								    /// </summary>
-												sealed

sealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealedsealed

											
										
										
											2019-10-04 02:09:02 +00:00
+								    public sealed class PersonalInfoG4 : PersonalInfoG3
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								    {
-												Add&Split out PersonalTable

Will eventually have more complex operations associated with it, as the
PersonalInfo[] could not do that sort of logic.

											
										
										
											2016-07-18 05:39:18 +00:00
+								        public new const int SIZE = 0x2C;
-												Respacening

Style guidelines, handle a bunch of files
no functional change

											
										
										
											2018-07-27 02:34:27 +00:00
-												PKHeX.Core Nullable cleanup (#2401)

* Handle some nullable cases

Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization

* Handle bits more obviously without null

* Make SaveFile.BAK explicitly readonly again

* merge constructor methods to have readonly fields

* Inline some properties

* More nullable handling

* Rearrange box actions

define straightforward classes to not have any null properties

* Make extrabyte reference array immutable

* Move tooltip creation to designer

* Rearrange some logic to reduce nesting

* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum

* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case

* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable

* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator

* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever

* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)

* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
											
										
										
											2019-10-17 01:47:31 +00:00
+								        public PersonalInfoG4(byte[] data) : base(data)
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								        {
 								            // Unpack TMHM & Tutors
-												remove linq personalinfo bit fetch

reads the bits out of the original array (saves a few ms by not
allocating/gc)

											
										
										
											2018-02-17 03:34:42 +00:00
+								            TMHM = GetBits(Data, 0x1C, 0x0D);
-												Remove unnecessary empty array allocations

yay net 4.6
read more: http://justinvp.com/2015/07/20/array-empty/

											
										
										
											2018-08-02 01:30:51 +00:00
+								            TypeTutors = Array.Empty<bool>(); // not stored in personal
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								        }
-												Respacening

Style guidelines, handle a bunch of files
no functional change

											
										
										
											2018-07-27 02:34:27 +00:00
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								        public override byte[] Write()
 								        {
-												Fix platinum altforms not having formcount set

fix by hex editing the manually altered field in the personal table so
that it matches HGSS
thanks @sora10pls !

fix unused writeback location for saving tmhm data

											
										
										
											2017-11-29 07:14:08 +00:00
+								            SetBits(TMHM).CopyTo(Data, 0x1C);
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								            return Data;
 								        }
-												Add gen4 formes to personal

Manual tweaks

											
										
										
											2016-07-28 01:08:08 +00:00
 								        // Manually added attributes
-												Unify concepts with different names

AltForm & Form & Forme => Form
GenNumber & Generation => Generation

Extract out SpeciesForm interface, and re-add IGeneration

For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.

											
										
										
											2020-12-11 04:42:30 +00:00
+								        public override int FormCount { get => Data[0x29]; set {} }
-												Switch to c# 7 get/set expressions

Add gen5 battle box locked flags
no functional change otherwise, just shorter

											
										
										
											2017-05-13 03:32:36 +00:00
+								        protected internal override int FormStatsIndex { get => BitConverter.ToUInt16(Data, 0x2A); set {} }
-												Add PersonalInfo for gens4/5

Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.

											
										
										
											2016-07-03 03:24:17 +00:00
+								    }
 								}