PKHeX/PKHeX.Core/Legality/Areas/EncounterArea7g.cs

using System.Collections.Generic;

namespace PKHeX.Core
{
    /// <inheritdoc />
    /// <summary>
    /// <see cref="GameVersion.GO"/> encounter area for <see cref="GameVersion.GG"/>
    /// </summary>
    public sealed class EncounterArea7g : EncounterArea32
    {
        public override IEnumerable<EncounterSlot> GetMatchingSlots(PKM pkm, IReadOnlyList<EvoCriteria> chain)
        {
            foreach (var slot in Slots)
            {
                foreach (var evo in chain)
                {
                    if (slot.Species != evo.Species)
                        continue;

                    if (!slot.IsLevelWithinRange(pkm.Met_Level))
                        break;
                    if (slot.Form != evo.Form)
                        break;

                    yield return slot;
                    break;
                }
            }
        }
    }
}
-												Split encounter areas, relocate slot finding to obj

Now logic is reasonably split, and each format of area has its own way
of yielding slots

Too much junk with checking flute boosts or catch combo applicability;
just let the area dictate how slots match.

											
										
										
											2019-09-13 06:20:52 +00:00
+								using System.Collections.Generic;
 								namespace PKHeX.Core
 								{
 								    /// <inheritdoc />
 								    /// <summary>
 								    /// <see cref="GameVersion.GO"/> encounter area for <see cref="GameVersion.GG"/>
 								    /// </summary>
 								    public sealed class EncounterArea7g : EncounterArea32
 								    {
-												Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)


											
										
										
											2020-08-21 23:35:49 +00:00
+								        public override IEnumerable<EncounterSlot> GetMatchingSlots(PKM pkm, IReadOnlyList<EvoCriteria> chain)
-												Split encounter areas, relocate slot finding to obj

Now logic is reasonably split, and each format of area has its own way
of yielding slots

Too much junk with checking flute boosts or catch combo applicability;
just let the area dictate how slots match.

											
										
										
											2019-09-13 06:20:52 +00:00
+								        {
-												Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)


											
										
										
											2020-08-21 23:35:49 +00:00
+								            foreach (var slot in Slots)
-												Split encounter areas, relocate slot finding to obj

Now logic is reasonably split, and each format of area has its own way
of yielding slots

Too much junk with checking flute boosts or catch combo applicability;
just let the area dictate how slots match.

											
										
										
											2019-09-13 06:20:52 +00:00
+								            {
-												Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)


											
										
										
											2020-08-21 23:35:49 +00:00
+								                foreach (var evo in chain)
-												Split encounter areas, relocate slot finding to obj

Now logic is reasonably split, and each format of area has its own way
of yielding slots

Too much junk with checking flute boosts or catch combo applicability;
just let the area dictate how slots match.

											
										
										
											2019-09-13 06:20:52 +00:00
+								                {
-												Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)


											
										
										
											2020-08-21 23:35:49 +00:00
+								                    if (slot.Species != evo.Species)
 								                        continue;
 								                    if (!slot.IsLevelWithinRange(pkm.Met_Level))
 								                        break;
 								                    if (slot.Form != evo.Form)
 								                        break;
-												Split encounter areas, relocate slot finding to obj

Now logic is reasonably split, and each format of area has its own way
of yielding slots

Too much junk with checking flute boosts or catch combo applicability;
just let the area dictate how slots match.

											
										
										
											2019-09-13 06:20:52 +00:00
+								                    yield return slot;
-												Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)


											
										
										
											2020-08-21 23:35:49 +00:00
+								                    break;
-												Split encounter areas, relocate slot finding to obj

Now logic is reasonably split, and each format of area has its own way
of yielding slots

Too much junk with checking flute boosts or catch combo applicability;
just let the area dictate how slots match.

											
										
										
											2019-09-13 06:20:52 +00:00
+								                }
 								            }
 								        }
 								    }
 								}