Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 08:23:12 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Encounters/EncounterTrade/EncounterTrade.cs

288 lines
10 KiB
C#
Raw Normal View History

Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
using System;
Make Move[] readonly list contract: don't modify the template movesets mystery gift now exposes IRelearn, remove unnecessary type checks
2020-01-19 00:46:38 +00:00
using System.Collections.Generic;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
using System.Linq;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
namespace PKHeX.Core
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary>
/// Trade Encounter data
/// </summary>
/// <remarks>
/// Trade data is fixed level in all cases except for the first few generations of games.
/// </remarks>
Make Generation property get-only per class don't need to store an int since it's a const-per-class
2020-08-30 22:35:59 +00:00
public abstract class EncounterTrade : IEncounterable, IMoveset, ILocation, IVersionSet
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Change setters to init only
2020-12-22 01:05:05 +00:00
public int Species { get; init; }
public int Form { get; init; }
public int Level { get; init; }
Consolidate EncounterTrade1 level objects Adds Nickname checks, thanks @ShadowMario3 for grabbing these into separate text files from Bulbapedia. I reordered all the encounters to match Bulbapedia; each level is denoted if different if it can be sourced from RBY.
2020-11-23 00:19:03 +00:00
public virtual int LevelMin => Level;
Prep for next wave of implementation need to get a release out beforehand tho
2017-04-23 16:18:42 +00:00
public int LevelMax => 100;
Change setters to init only
2020-12-22 01:05:05 +00:00
public IReadOnlyList<int> Moves { get; init; } = Array.Empty<int>();
Make Generation property get-only per class don't need to store an int since it's a const-per-class
2020-08-30 22:35:59 +00:00
public abstract int Generation { get; }
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
Change setters to init only
2020-12-22 01:05:05 +00:00
public int CurrentLevel { get; init; } = -1;
public int Location { get; init; }
public int Ability { get; init; }
public int Gender { get; init; } = -1;
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
public Nature Nature = Nature.Random;
Change setters to init only
2020-12-22 01:05:05 +00:00
public Shiny Shiny { get; init; } = Shiny.Never;
public int Ball { get; init; } = 4;
Make Generation property get-only per class don't need to store an int since it's a const-per-class
2020-08-30 22:35:59 +00:00
Minor clean Handle remainder of c#9 sugar Fix some spelling mistakes
2020-12-22 07:37:07 +00:00
public int TID { get; init; }
public int SID { get; init; }
Change setters to init only
2020-12-22 01:05:05 +00:00
public int OTGender { get; init; } = -1;
Make multiple-met locations a single object instance make trade have Any again; it's a marker to apply the gameversion since we're lazy
2020-08-31 02:24:24 +00:00
public GameVersion Version { get; set; } = GameVersion.Any;
Make Generation property get-only per class don't need to store an int since it's a const-per-class
2020-08-30 22:35:59 +00:00
Change setters to init only
2020-12-22 01:05:05 +00:00
public IReadOnlyList<int> IVs { get; init; } = Array.Empty<int>();
public int FlawlessIVCount { get; init; }
Make Generation property get-only per class don't need to store an int since it's a const-per-class
2020-08-30 22:35:59 +00:00
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public bool EggEncounter => false;
Change setters to init only
2020-12-22 01:05:05 +00:00
public int EggLocation { get; init; }
public bool EvolveOnTrade { get; init; }
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
Misc updates
2018-11-11 05:07:31 +00:00
public int TID7
{
Minor clean Handle remainder of c#9 sugar Fix some spelling mistakes
2020-12-22 07:37:07 +00:00
init
Misc updates
2018-11-11 05:07:31 +00:00
{
TID = (ushort) value;
SID = value >> 16;
}
}
add b2w2 n's pokemon PIDs add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning
2017-12-18 23:25:40 +00:00
private const string _name = "In-game Trade";
public string Name => _name;
Add short/long name property differentiation
2019-03-18 05:19:37 +00:00
public string LongName => _name;
Change setters to init only
2020-12-22 01:05:05 +00:00
public bool IsNicknamed { get; init; } = true;
Two minor fixes (#1006) * Fix ingame trade legality check - fix early return - fix locations of the same name "a link trade", otherwise metlocation=30001 in sm be recogized as 30002 * Fix wc7 to pkm for event egg Nickname should be added * Fix gen4 in-game trade - fix ivs order - use default met location to compact table * Support multiple ingame trade filtering Fix Steelix glitch, fix some table data, thanks to RoCs' PC * Minor improvement As suggested * Fix gen5 in-game trade - skip gender checks if set to default - fix in-game trade metloaction for gen5 - fix ivs order
2017-03-29 07:48:32 +00:00
Make the template IV/contest stat array readonly See prior commits no longer need to clone subarrays, they're shared immutable
2020-01-19 03:11:29 +00:00
public IReadOnlyList<string> Nicknames { get; internal set; } = Array.Empty<string>();
public IReadOnlyList<string> TrainerNames { get; internal set; } = Array.Empty<string>();
public string GetNickname(int language) => (uint)language < Nicknames.Count ? Nicknames[language] : string.Empty;
public string GetOT(int language) => (uint)language < TrainerNames.Count ? TrainerNames[language] : string.Empty;
Misc iencounterable->pkm generator fixes Still some pending stuff like bad mystery gifts gen2 static encounters on g/s applying met level and not location gen6 ralts trade (no nickname) being flagged as nicknamed when it shouldn't gen4 manaphy egg not having a hatch location (worked fine if you transferred it up) gen3 antishiny gifts not setting their PIDs (jirachi WC3) gen5 N's pkm gifts setting the wrong nature gen3 unown not being generated correctly, cosplay pikachu being allowed form0, non-BugCatchingContest no longer require Sport ball, oras dexnav marill now uses the azurill eggmove table
2020-09-04 02:00:46 +00:00
public bool HasNickname => Nicknames.Count != 0 && IsNicknamed;
Make the template IV/contest stat array readonly See prior commits no longer need to clone subarrays, they're shared immutable
2020-01-19 03:11:29 +00:00
public bool HasTrainerName => TrainerNames.Count != 0;
store encountertrade nick/ot within object allows for ot/nick fetch for a given language
2018-03-27 05:23:11 +00:00
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
private static int GetDefaultMetLocation(int generation)
Two minor fixes (#1006) * Fix ingame trade legality check - fix early return - fix locations of the same name "a link trade", otherwise metlocation=30001 in sm be recogized as 30002 * Fix wc7 to pkm for event egg Nickname should be added * Fix gen4 in-game trade - fix ivs order - use default met location to compact table * Support multiple ingame trade filtering Fix Steelix glitch, fix some table data, thanks to RoCs' PC * Minor improvement As suggested * Fix gen5 in-game trade - skip gender checks if set to default - fix in-game trade metloaction for gen5 - fix ivs order
2017-03-29 07:48:32 +00:00
{
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
return generation switch
{
1 => 0,
2 => Locations.LinkTrade2NPC,
3 => Locations.LinkTrade3NPC,
4 => Locations.LinkTrade4NPC,
5 => Locations.LinkTrade5NPC,
6 => Locations.LinkTrade6NPC,
7 => Locations.LinkTrade6NPC, // 7 is same as 6
8 => Locations.LinkTrade6NPC, // 8 is same as 6
_ => throw new IndexOutOfRangeException(nameof(generation)),
};
}
Add IEncounterable -> pkm interface method egg,slot,static,link,trade need to be implemented later remove IEncounterable from PL6
2018-03-29 03:38:07 +00:00
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
public PKM ConvertToPKM(ITrainerInfo sav) => ConvertToPKM(sav, EncounterCriteria.Unrestricted);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
public PKM ConvertToPKM(ITrainerInfo sav, EncounterCriteria criteria)
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
{
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
var pk = PKMConverter.GetBlank(Generation, Version);
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
sav.ApplyTo(pk);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
ApplyDetails(sav, criteria, pk);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return pk;
}
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
protected virtual void ApplyDetails(ITrainerInfo sav, EncounterCriteria criteria, PKM pk)
Sword/Shield Update
2019-11-16 01:34:18 +00:00
{
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
var version = this.GetCompatibleVersion((GameVersion)sav.Game);
int lang = (int)Language.GetSafeLanguage(Generation, (LanguageID)sav.Language);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
int level = CurrentLevel > 0 ? CurrentLevel : LevelMin;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
if (level == 0)
Add min levels for trades Make PIDs readonly for trades Clone FR/LG Lickitung (different min levels)
2020-03-14 04:39:35 +00:00
level = Math.Max(1, LevelMin);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
int species = Species;
if (EvolveOnTrade)
species++;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.EncryptionConstant = Util.Rand32();
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk.Species = species;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
pk.Form = Form;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
pk.Language = lang;
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
pk.OT_Name = pk.Format == 1 ? StringConverter12.G1TradeOTStr : HasTrainerName ? GetOT(lang) : sav.OT;
pk.OT_Gender = HasTrainerName ? Math.Max(0, OTGender) : sav.Gender;
Misc iencounterable->pkm generator fixes Still some pending stuff like bad mystery gifts gen2 static encounters on g/s applying met level and not location gen6 ralts trade (no nickname) being flagged as nicknamed when it shouldn't gen4 manaphy egg not having a hatch location (worked fine if you transferred it up) gen3 antishiny gifts not setting their PIDs (jirachi WC3) gen5 N's pkm gifts setting the wrong nature gen3 unown not being generated correctly, cosplay pikachu being allowed form0, non-BugCatchingContest no longer require Sport ball, oras dexnav marill now uses the azurill eggmove table
2020-09-04 02:00:46 +00:00
pk.SetNickname(HasNickname ? GetNickname(lang) : string.Empty);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.CurrentLevel = level;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
pk.Version = (int) version;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.TID = TID;
pk.SID = SID;
pk.Ball = Ball;
pk.OT_Friendship = pk.PersonalInfo.BaseFriendship;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetPINGA(pk, criteria);
SetMoves(pk, version, level);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
var time = DateTime.Now;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
if (pk.Format != 2 || version == GameVersion.C)
{
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
var location = Location != 0 ? Location : GetDefaultMetLocation(Generation);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetMetData(pk, level, location, time);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
Misc iencounterable->pkm generator fixes Still some pending stuff like bad mystery gifts gen2 static encounters on g/s applying met level and not location gen6 ralts trade (no nickname) being flagged as nicknamed when it shouldn't gen4 manaphy egg not having a hatch location (worked fine if you transferred it up) gen3 antishiny gifts not setting their PIDs (jirachi WC3) gen5 N's pkm gifts setting the wrong nature gen3 unown not being generated correctly, cosplay pikachu being allowed form0, non-BugCatchingContest no longer require Sport ball, oras dexnav marill now uses the azurill eggmove table
2020-09-04 02:00:46 +00:00
else
{
pk.OT_Gender = 0;
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
if (EggLocation != 0)
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetEggMetData(pk, time);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Continued pkmgen updates * adds g4 forced shiny seed->pid (Chain Shiny Lake of Rage Gyarados) * adds cxd starter pid generating handling * adds g5 forced shiny seed->pid (MG5Shiny Shiny gift Dratini) * excludes gen4 route45 surf impossible encounters * actually use ingame trade edge case handler Up to dragonair (147) yay; yellow dragonair is likely the catch rate edge case.
2018-05-08 04:16:54 +00:00
UpdateEdgeCase(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (pk.Format < 6)
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Clean up some method signatures rename things to be a little more consistent in naming conventions
2020-06-17 02:46:22 +00:00
sav.ApplyHandlingTrainerInfo(pk, force: true);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.SetRandomEC();
Split memories from main pkm class to interface pk6/7/8, not pb7
2020-08-01 00:25:14 +00:00
if (pk is PK6 pk6)
pk6.SetRandomMemory6();
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
}
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
protected virtual void SetPINGA(PKM pk, EncounterCriteria criteria)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
Use criteria for getting ability
2020-06-21 23:16:34 +00:00
var pi = pk.PersonalInfo;
int gender = criteria.GetGender(Gender, pi);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
int nature = (int)criteria.GetNature(Nature);
Differentiate AbilityType from AbilityNumber invert ability index favoring so that the first ability index is most favored ability num: -1=>0/1/2 0=>0/1, 1=>0 2 =>1 4=>2 Ability Type: 0,1,2=>0,1,2 3=>0/1 4=>0/1/2 Should probably get rid of AbilityNumber definition usage but it's so entwined in the trade/static definitions...
2020-06-23 03:01:42 +00:00
int ability = criteria.GetAbilityFromNumber(Ability, pi);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
PIDGenerator.SetRandomWildPID(pk, Generation, nature, ability, gender);
Set StatNature on IEncounterable->PKM Mystery Gift formats already set it appropriately in their individual implementations Closes #2901
2020-06-27 16:46:23 +00:00
pk.Nature = pk.StatNature = nature;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.Gender = gender;
pk.RefreshAbility(ability);
SetIVs(pk);
}
protected void SetIVs(PKM pk)
{
Make the template IV/contest stat array readonly See prior commits no longer need to clone subarrays, they're shared immutable
2020-01-19 03:11:29 +00:00
if (IVs.Count != 0)
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.SetRandomIVs(IVs, 0);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
else
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.SetRandomIVs(flawless: 3);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
private void SetMoves(PKM pk, GameVersion version, int level)
{
Make Move[] readonly list contract: don't modify the template movesets mystery gift now exposes IRelearn, remove unnecessary type checks
2020-01-19 00:46:38 +00:00
var moves = Moves.Count != 0 ? Moves : MoveLevelUp.GetEncounterMoves(pk, level, version);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
if (pk.Format == 1 && moves.All(z => z == 0))
moves = ((PersonalInfoG1)PersonalTable.RB[Species]).Moves;
Make Move[] readonly list contract: don't modify the template movesets mystery gift now exposes IRelearn, remove unnecessary type checks
2020-01-19 00:46:38 +00:00
pk.SetMoves(moves);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk.SetMaximumPPCurrent(moves);
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private void SetEggMetData(PKM pk, DateTime time)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
pk.Egg_Location = EggLocation;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.EggMetDate = time;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private static void SetMetData(PKM pk, int level, int location, DateTime time)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
pk.Met_Level = level;
pk.Met_Location = location;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.MetDate = time;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
private void UpdateEdgeCase(PKM pkm)
{
switch (Generation)
{
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 3 when Species == (int)Core.Species.Jynx && pkm.Version == (int) GameVersion.LG && pkm.Language == (int) LanguageID.Italian:
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
// Italian LG Jynx untranslated from English name
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
pkm.OT_Name = GetOT((int)LanguageID.English);
pkm.SetNickname(GetNickname((int)LanguageID.English));
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
break;
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 4 when Version == GameVersion.DPPt && Species == (int)Core.Species.Magikarp: // Meister Magikarp
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
// Has German Language ID for all except German origin, which is English
pkm.Language = (int)(pkm.Language == (int)LanguageID.German ? LanguageID.English : LanguageID.German);
break;
case 4 when Version == GameVersion.DPPt && (pkm.Version == (int)GameVersion.D || pkm.Version == (int)GameVersion.P):
// DP English origin are Japanese lang
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
pkm.Language = (int)LanguageID.Japanese;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
break;
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 4 when Version == GameVersion.HGSS && Species == (int)Core.Species.Pikachu: // Pikachu
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
// Has English Language ID for all except English origin, which is French
pkm.Language = (int)(pkm.Language == (int)LanguageID.English ? LanguageID.French : LanguageID.English);
break;
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
case 5 when Version == GameVersion.BW && pkm.Language == (int)LanguageID.Japanese:
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
// Trades for JPN games have language ID of 0, not 1.
pkm.Language = 0;
break;
}
}
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
public virtual bool IsMatch(PKM pkm, DexLevel evo)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Make the template IV/contest stat array readonly See prior commits no longer need to clone subarrays, they're shared immutable
2020-01-19 03:11:29 +00:00
if (IVs.Count != 0)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
{
Fix Static/Gift IV method call (#2310)
2019-05-15 19:07:48 +00:00
if (!Legal.GetIsFixedIVSequenceValidSkipRand(IVs, pkm))
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
return false;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
}
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (!IsMatchNatureGenderShiny(pkm))
return false;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
if (TID != pkm.TID)
return false;
if (SID != pkm.SID)
return false;
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
if (!IsMatchLevel(pkm, evo))
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return false;
if (CurrentLevel != -1 && CurrentLevel > pkm.CurrentLevel)
return false;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
if (Form != evo.Form && !FormInfo.IsFormChangeable(Species, Form, pkm.Form, pkm.Format))
Sword/Shield Update
2019-11-16 01:34:18 +00:00
return false;
if (OTGender != -1 && OTGender != pkm.OT_Gender)
return false;
if (EggLocation != pkm.Egg_Location)
return false;
// if (z.Ability == 4 ^ pkm.AbilityNumber == 4) // defer to Ability
Set StatNature on IEncounterable->PKM Mystery Gift formats already set it appropriately in their individual implementations Closes #2901
2020-06-27 16:46:23 +00:00
// continue;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (!Version.Contains((GameVersion)pkm.Version))
return false;
return true;
}
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
private bool IsMatchLevel(PKM pkm, DexLevel evo)
Sword/Shield Update
2019-11-16 01:34:18 +00:00
{
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
if (!pkm.HasOriginalMetLocation)
Xmldoc, minor tweaks Move form-info logic from FormConverter to AltFormInfo; now FormConverter is entirely form=>string[] Add a bunch of xmldoc Make pogo no-end-date cmp agaisnt UTCnow rather than local now.
2020-11-27 19:51:02 +00:00
return evo.Level >= Level;
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Continued refactoring EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.
2020-09-13 21:40:10 +00:00
var loc = Location != 0 ? Location : GetDefaultMetLocation(Generation);
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
if (loc != pkm.Met_Location)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
if (pkm.Format < 5)
Xmldoc, minor tweaks Move form-info logic from FormConverter to AltFormInfo; now FormConverter is entirely form=>string[] Add a bunch of xmldoc Make pogo no-end-date cmp agaisnt UTCnow rather than local now.
2020-11-27 19:51:02 +00:00
return evo.Level >= Level;
Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)
2020-08-21 23:35:49 +00:00
Xmldoc, minor tweaks Move form-info logic from FormConverter to AltFormInfo; now FormConverter is entirely form=>string[] Add a bunch of xmldoc Make pogo no-end-date cmp agaisnt UTCnow rather than local now.
2020-11-27 19:51:02 +00:00
return pkm.Met_Level == Level;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
protected virtual bool IsMatchNatureGenderShiny(PKM pkm)
{
if (!Shiny.IsValid(pkm))
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (Gender != -1 && Gender != pkm.Gender)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (Nature != Nature.Random && pkm.Nature != (int)Nature)
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return false;
return true;
}
Add shared memory interface (encounter)
2019-11-26 18:46:16 +00:00
}
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
}
Reference in a new issue Copy permalink