Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-28 06:50:23 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Encounters/EncounterTrade.cs

361 lines
12 KiB
C#
Raw Normal View History

Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
using System;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
using System.Linq;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
namespace PKHeX.Core
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary>
/// Trade Encounter data
/// </summary>
/// <remarks>
/// Trade data is fixed level in all cases except for the first few generations of games.
/// </remarks>
Refactoring add IVersion interface with common interactions
2018-03-30 23:31:40 +00:00
public class EncounterTrade : IEncounterable, IMoveset, IGeneration, ILocation, IContestStats, IVersion
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Minor refactoring Switch EncounterGeneric to IEncounterable. A way to tie together all encounters. Added a few setters for mystery gifts if the code is ever reused in other projects for that purpose. No functional change.
2017-01-05 06:25:45 +00:00
public int Species { get; set; }
Simplify encounter move checking populates a list of possible encounters and iterates over all of them the encounterstatic / mystery gift loop check was the same, and all they provided was a set of special moves. Introduces an interface for easy moveset retrieval. fix typo in defaultmetlocation var name add egg check for mystery gifts if transferred (can't transfer eggs across generations)
2017-04-05 05:01:48 +00:00
public int[] Moves { get; set; }
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Level { get; set; }
Prep for next wave of implementation need to get a release out beforehand tho
2017-04-23 16:18:42 +00:00
public int LevelMin => Level;
public int LevelMax => 100;
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public int Generation { get; set; } = -1;
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Location { get; set; } = -1;
public int Ability { get; set; }
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
public Nature Nature = Nature.Random;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int TID { get; set; }
public int SID { get; set; }
public GameVersion Version { get; set; } = GameVersion.Any;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
public int[] IVs { get; set; }
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Form { get; set; }
Merge PIDType and bool? shiny property Gen5 does not follow the same convention, 0 = non, 1 = rnd, 2 = always; not gonna bother updating for just that one bool? occupies 2 bytes; enum:byte is 1 byte. should probably move validity checking logic into the IEncounterable objects instead...
2018-03-17 02:35:55 +00:00
public virtual Shiny Shiny { get; set; } = Shiny.Never;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public int Gender { get; set; } = -1;
public int OTGender { get; set; } = -1;
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
public bool EggEncounter => false;
add location interface for verbose analysis output indicates met location for transferred mons most gen1/2 encounters won't show values due to the location not being stored respective to the string tables (anyone wanna do a location remap after initial load?)
2018-01-02 20:00:41 +00:00
public int EggLocation { get; set; }
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public bool EvolveOnTrade { get; set; }
public int Ball { get; set; } = 4;
Add ranch ingame trades debut of the long awaited EncounterTradePID class gist to generate trades from folder (using LINQPad): https://gist.github.com/kwsch/d778f1f63e4c393e5440dfb0e14cfcc3 Closes #1458 , although Mew/Phione's PIDIV method is unknown.
2017-09-21 04:28:29 +00:00
public int CurrentLevel { get; set; } = -1;
Refactoring Move fossils check to static encounter apply small amount of inheritance to all encounter types (including mystery gifts) get actual evolution chain to ignore pre-evolution movepools (example Surf Pikachu event gift cannot devolve to Pichu to get Nasty Plot). #694 A little bit of logic has been moved around, but my 5k pkmdb had no change in legal/illegal counts. Hopefully no false positives from this change :thumbsup:
2017-01-04 04:51:33 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
public int[] Contest { set => this.SetContestStats(value); }
public int CNT_Cool { get; set; }
public int CNT_Beauty { get; set; }
public int CNT_Cute { get; set; }
public int CNT_Smart { get; set; }
public int CNT_Tough { get; set; }
public int CNT_Sheen { get; set; }
Misc updates
2018-11-11 05:07:31 +00:00
public int TID7
{
set
{
TID = (ushort) value;
SID = value >> 16;
}
}
add b2w2 n's pokemon PIDs add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning
2017-12-18 23:25:40 +00:00
private const string _name = "In-game Trade";
public string Name => _name;
Add short/long name property differentiation
2019-03-18 05:19:37 +00:00
public string LongName => _name;
Add ranch ingame trades debut of the long awaited EncounterTradePID class gist to generate trades from folder (using LINQPad): https://gist.github.com/kwsch/d778f1f63e4c393e5440dfb0e14cfcc3 Closes #1458 , although Mew/Phione's PIDIV method is unknown.
2017-09-21 04:28:29 +00:00
public bool Fateful { get; set; }
Add nickname flag override for encountertrade closes #1649
2017-11-22 16:11:53 +00:00
public bool IsNicknamed { get; set; } = true;
Two minor fixes (#1006) * Fix ingame trade legality check - fix early return - fix locations of the same name "a link trade", otherwise metlocation=30001 in sm be recogized as 30002 * Fix wc7 to pkm for event egg Nickname should be added * Fix gen4 in-game trade - fix ivs order - use default met location to compact table * Support multiple ingame trade filtering Fix Steelix glitch, fix some table data, thanks to RoCs' PC * Minor improvement As suggested * Fix gen5 in-game trade - skip gender checks if set to default - fix in-game trade metloaction for gen5 - fix ivs order
2017-03-29 07:48:32 +00:00
store encountertrade nick/ot within object allows for ot/nick fetch for a given language
2018-03-27 05:23:11 +00:00
public string[] Nicknames { get; internal set; }
public string[] TrainerNames { get; internal set; }
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
public string GetNickname(int language) => Nicknames?.Length > language ? Nicknames[language] : null;
public string GetOT(int language) => TrainerNames?.Length > language ? TrainerNames[language] : null;
Add nickname reset modify nickname reset clears except for encountertrades (some have fixed nicknames). remove untraded check for HT memory verification, has to be traded if it has a HT memory.
2018-06-01 02:49:47 +00:00
public bool HasNickname => Nicknames != null;
store encountertrade nick/ot within object allows for ot/nick fetch for a given language
2018-03-27 05:23:11 +00:00
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
public static readonly int[] DefaultMetLocation =
Two minor fixes (#1006) * Fix ingame trade legality check - fix early return - fix locations of the same name "a link trade", otherwise metlocation=30001 in sm be recogized as 30002 * Fix wc7 to pkm for event egg Nickname should be added * Fix gen4 in-game trade - fix ivs order - use default met location to compact table * Support multiple ingame trade filtering Fix Steelix glitch, fix some table data, thanks to RoCs' PC * Minor improvement As suggested * Fix gen5 in-game trade - skip gender checks if set to default - fix in-game trade metloaction for gen5 - fix ivs order
2017-03-29 07:48:32 +00:00
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
0,
Locations.LinkTrade2NPC,
Locations.LinkTrade3NPC,
Locations.LinkTrade4NPC,
Locations.LinkTrade5NPC,
Locations.LinkTrade6NPC,
Locations.LinkTrade6NPC, // 7 is same as 6
Two minor fixes (#1006) * Fix ingame trade legality check - fix early return - fix locations of the same name "a link trade", otherwise metlocation=30001 in sm be recogized as 30002 * Fix wc7 to pkm for event egg Nickname should be added * Fix gen4 in-game trade - fix ivs order - use default met location to compact table * Support multiple ingame trade filtering Fix Steelix glitch, fix some table data, thanks to RoCs' PC * Minor improvement As suggested * Fix gen5 in-game trade - skip gender checks if set to default - fix in-game trade metloaction for gen5 - fix ivs order
2017-03-29 07:48:32 +00:00
};
Add IEncounterable -> pkm interface method egg,slot,static,link,trade need to be implemented later remove IEncounterable from PL6
2018-03-29 03:38:07 +00:00
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
public PKM ConvertToPKM(ITrainerInfo SAV) => ConvertToPKM(SAV, EncounterCriteria.Unrestricted);
public PKM ConvertToPKM(ITrainerInfo SAV, EncounterCriteria criteria)
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
{
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
var pk = PKMConverter.GetBlank(Generation, Version);
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SAV.ApplyToPKM(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
var version = this.GetCompatibleVersion((GameVersion)SAV.Game);
int lang = (int)Legal.GetSafeLanguage(Generation, (LanguageID)SAV.Language);
int level = CurrentLevel > 0 ? CurrentLevel : LevelMin;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
if (level == 0)
level = 25; // avoid some cases
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
int species = Species;
if (EvolveOnTrade)
species++;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.EncryptionConstant = Util.Rand32();
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
pk.Species = species;
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
pk.AltForm = Form;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
pk.Language = lang;
Split StringConverter into smaller pieces reduces loading time (don't have to allocate conversion arrays when launching a gen7 game), and separates things to easier to manage locations reworks gen3 string encode/decode, no longer does 3->4->5 and 5->4->3; instead goes straight to the end result without an intermediary format. String sanitization should probably be broken up rather than reused, oh well.
2019-03-21 04:50:44 +00:00
pk.OT_Name = pk.Format == 1 ? StringConverter12.G1TradeOTStr : GetOT(lang) ?? SAV.OT;
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
pk.OT_Gender = GetOT(lang) != null ? Math.Max(0, OTGender) : SAV.Gender;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.SetNickname(GetNickname(lang));
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.CurrentLevel = level;
pk.Version = (int)version;
pk.TID = TID;
pk.SID = SID;
pk.Ball = Ball;
pk.OT_Friendship = pk.PersonalInfo.BaseFriendship;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetPINGA(pk, criteria);
SetMoves(pk, version, level);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
var time = DateTime.Now;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
if (pk.Format != 2 || version == GameVersion.C)
{
var location = Location > 0 ? Location : DefaultMetLocation[Generation - 1];
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetMetData(pk, level, location, time);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
if (EggLocation != 0)
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
SetEggMetData(pk, time);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (pk is PK1 pk1 && this is EncounterTradeCatchRate c)
pk1.Catch_Rate = (int)c.Catch_Rate;
Simplify IContestStats usage remove new[] creating for checking if any contest stats exist (HasContestStats)
2018-06-03 04:19:03 +00:00
if (pk is IContestStats s)
this.CopyContestStatsTo(s);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (Fateful)
pk.FatefulEncounter = true;
Continued pkmgen updates * adds g4 forced shiny seed->pid (Chain Shiny Lake of Rage Gyarados) * adds cxd starter pid generating handling * adds g5 forced shiny seed->pid (MG5Shiny Shiny gift Dratini) * excludes gen4 route45 surf impossible encounters * actually use ingame trade edge case handler Up to dragonair (147) yay; yellow dragonair is likely the catch rate edge case.
2018-05-08 04:16:54 +00:00
UpdateEdgeCase(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
if (pk.Format < 6)
return pk;
More generator updates Graveler (SM Trade) -> Force applying handling trainer details for ingame trades Ponyta (Ranch Trade) Apply correct ability for encountertradePID Up to 98 : Wild Gen2 Krabby (safari zone impossible location needs to get filtered from possible encounters)
2018-04-30 04:29:34 +00:00
SAV.ApplyHandlingTrainerInfo(pk, force: true);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
pk.SetRandomEC();
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
if (pk.Format == 6)
pk.SetRandomMemory6();
else if (pk.Format == 7)
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
SetSMOTMemory(pk);
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
return pk;
}
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
protected virtual void SetPINGA(PKM pk, EncounterCriteria criteria)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
int gender = criteria.GetGender(Gender, pk.PersonalInfo);
int nature = (int)criteria.GetNature(Nature);
int ability = Ability >> 1;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
PIDGenerator.SetRandomWildPID(pk, Generation, nature, ability, gender);
pk.Nature = nature;
pk.Gender = gender;
pk.RefreshAbility(ability);
SetIVs(pk);
}
protected void SetIVs(PKM pk)
{
if (IVs != null)
pk.SetRandomIVs(IVs, 0);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
else
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.SetRandomIVs(flawless: 3);
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
private void SetMoves(PKM pk, GameVersion version, int level)
{
var moves = Moves ?? MoveLevelUp.GetEncounterMoves(pk, level, version);
if (pk.Format == 1 && moves.All(z => z == 0))
moves = ((PersonalInfoG1)PersonalTable.RB[Species]).Moves;
pk.Moves = moves;
pk.SetMaximumPPCurrent(moves);
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private void SetEggMetData(PKM pk, DateTime time)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
pk.Egg_Location = EggLocation;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.EggMetDate = time;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
private static void SetMetData(PKM pk, int level, int location, DateTime time)
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
{
pk.Met_Level = level;
pk.Met_Location = location;
Refactoring iencounterable->pkm SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID
2019-02-09 19:37:20 +00:00
pk.MetDate = time;
Update iencounterable api with new criteria arg rearrange some logic for clearer function (extract some methods)
2018-12-30 06:24:34 +00:00
}
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
private void UpdateEdgeCase(PKM pkm)
{
switch (Generation)
{
case 3 when Species == 124 && pkm.Version == (int) GameVersion.LG && pkm.Language == (int) LanguageID.Italian:
// Italian LG Jynx untranslated from English name
pkm.OT_Name = GetOT(2);
pkm.SetNickname(GetNickname(2));
break;
case 4 when Version == GameVersion.DPPt && Species == 129: // Meister Magikarp
// Has German Language ID for all except German origin, which is English
pkm.Language = (int)(pkm.Language == (int)LanguageID.German ? LanguageID.English : LanguageID.German);
break;
case 4 when Version == GameVersion.DPPt && (pkm.Version == (int)GameVersion.D || pkm.Version == (int)GameVersion.P):
// DP English origin are Japanese lang
pkm.Language = 1;
break;
case 4 when Version == GameVersion.HGSS && Species == 25: // Pikachu
// Has English Language ID for all except English origin, which is French
pkm.Language = (int)(pkm.Language == (int)LanguageID.English ? LanguageID.French : LanguageID.English);
break;
case 5 when Version == GameVersion.BW && pkm.Language == 1:
// Trades for JPN games have language ID of 0, not 1.
pkm.Language = 0;
break;
}
}
private static void SetSMOTMemory(PKM pk)
{
pk.OT_Memory = 1;
pk.OT_Intensity = 3;
pk.OT_TextVar = 40;
pk.OT_Feeling = 5;
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
public bool IsMatch(PKM pkm, int lvl)
{
if (IVs != null)
{
for (int i = 0; i < 6; i++)
{
if (IVs[i] != -1 && IVs[i] != pkm.GetIV(i))
return false;
}
}
if (this is EncounterTradePID p)
{
if (p.PID != pkm.EncryptionConstant)
return false;
if (Nature != Nature.Random && (int)Nature != pkm.Nature) // gen5 BW only
return false;
}
else
{
if (!Shiny.IsValid(pkm))
return false;
if (Nature != Nature.Random && (int)Nature != pkm.Nature)
return false;
if (Gender != -1 && Gender != pkm.Gender)
return false;
}
if (TID != pkm.TID)
return false;
if (SID != pkm.SID)
return false;
if (pkm.HasOriginalMetLocation)
{
var loc = Location > 0 ? Location : DefaultMetLocation[Generation - 1];
if (loc != pkm.Met_Location)
return false;
if (pkm.Format < 5)
{
if (Level > lvl)
return false;
}
else if (Level != lvl)
{
return false;
}
}
else if (Level > lvl)
{
return false;
}
if (CurrentLevel != -1 && CurrentLevel > pkm.CurrentLevel)
return false;
if (Form != pkm.AltForm && !Legal.IsFormChangeable(pkm, pkm.Species))
return false;
if (OTGender != -1 && OTGender != pkm.OT_Gender)
return false;
if (EggLocation != pkm.Egg_Location)
return false;
// if (z.Ability == 4 ^ pkm.AbilityNumber == 4) // defer to Ability
// countinue;
if (!Version.Contains((GameVersion)pkm.Version))
return false;
if (pkm is IContestStats s && s.IsContestBelow(this))
return false;
return true;
}
public bool IsMatchVC1(PKM pkm)
{
if (Level > pkm.CurrentLevel) // minimum required level
return false;
if (pkm.Format != 1 || !pkm.Gen1_NotTradeback)
return true;
// Even if the in game trade uses the tables with source pokemon allowing generation 2 games, the traded pokemon could be a non-tradeback pokemon
var rate = (pkm as PK1)?.Catch_Rate;
if (this is EncounterTradeCatchRate r)
{
if (rate != r.Catch_Rate)
return false;
}
else
{
if (Version == GameVersion.YW && rate != PersonalTable.Y[Species].CatchRate)
return false;
if (Version != GameVersion.YW && rate != PersonalTable.RB[Species].CatchRate)
return false;
}
return true;
}
public bool IsMatchVC2(PKM pkm)
{
if (Level > pkm.CurrentLevel) // minimum required level
return false;
if (TID != pkm.TID)
return false;
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
if (pkm.Format <= 2)
{
if (Gender >= 0 && Gender != pkm.Gender)
return false;
if (IVs != null && !Legal.GetIsFixedIVSequenceValidNoRand(IVs, pkm)) return false;
}
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
if (pkm.Met_Location != 0 && pkm.Format == 2 && pkm.Met_Location != 126)
return false;
return IsValidTradeOT12(pkm);
}
private bool IsValidTradeOT12(PKM pkm)
{
var OT = pkm.OT_Name;
if (pkm.Japanese)
return TrainerNames[(int)LanguageID.Japanese] == OT;
if (pkm.Korean)
return TrainerNames[(int)LanguageID.Korean] == OT;
const int start = (int)LanguageID.English;
const int end = (int)LanguageID.Italian;
recognize gen12 italian trade OT https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?page=3 Thanks ThePunish3D!
2019-01-03 23:47:41 +00:00
var index = Array.FindIndex(TrainerNames, start, end - start + 1, w => w == OT);
Move encounter matching logic to iencounterable generator logic is now clean
2018-12-27 09:00:08 +00:00
return index >= 0;
}
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
}
}
Reference in a new issue Copy permalink