Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-24 03:13:18 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/PKM/PK4.cs

432 lines
33 KiB
C#
Raw Normal View History

First look at PK4 code
2015-12-26 21:00:00 +00:00
using System;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
using System.Collections.Generic;
First look at PK4 code
2015-12-26 21:00:00 +00:00
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
First look at PK4 code
2015-12-26 21:00:00 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary> Generation 4 <see cref="PKM"/> format. </summary>
Rename abstract pkm inherited class names leading underscore for a class name = pls no
2019-10-26 19:42:33 +00:00
public sealed class PK4 : G4PKM
First look at PK4 code
2015-12-26 21:00:00 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private static readonly ushort[] Unused =
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
0x42, 0x43, 0x5E, 0x63, 0x64, 0x65, 0x66, 0x67, 0x87
};
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
public override IReadOnlyList<ushort> ExtraBytes => Unused;
Allow dynamic default savefile type load Make extrabytes a pkm property (don't mutate array pls) reconfigure startup loading to only initialize after initial load of sav & pkm (using blanks if not provided)
2018-12-20 06:10:32 +00:00
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
public override int SIZE_PARTY => PokeCrypto.SIZE_4PARTY;
public override int SIZE_STORED => PokeCrypto.SIZE_4STORED;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public override int Format => 4;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
public override PersonalInfo PersonalInfo => PersonalTable.HGSS.GetFormEntry(Species, Form);
Add personalinfo references per PKM format Fix possible hang in pk6/pk7 if country/region is unset (continues loop). PersonalInfo references are not to be used when calculating stats (use the savefile table instead)
2016-10-24 05:01:39 +00:00
Make pkm.Data a readonly field rather than property
2020-09-26 19:09:02 +00:00
public PK4() : base(PokeCrypto.SIZE_4PARTY) { }
public PK4(byte[] data) : base(DecryptParty(data)) { }
Add parameter-less constructors Removes null check for hot path where data is actually provided
2018-11-21 22:15:48 +00:00
Make pkm.Data a readonly field rather than property
2020-09-26 19:09:02 +00:00
private static byte[] DecryptParty(byte[] data)
First look at PK4 code
2015-12-26 21:00:00 +00:00
{
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
PokeCrypto.DecryptIfEncrypted45(ref data);
Minor clean add xmldoc remove unnecessary array resizes (see https://github.com/kwsch/PKHeX/commit/9f20aa2f4fd65c6eb756cb1656425a22a2e4debe ) show more extrabytes for gen8; remove unused byte accessor functions
2020-08-02 22:51:22 +00:00
Array.Resize(ref data, PokeCrypto.SIZE_4PARTY);
Make pkm.Data a readonly field rather than property
2020-09-26 19:09:02 +00:00
return data;
First look at PK4 code
2015-12-26 21:00:00 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately (#3222) * Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately Don't store within the object, track the slot origin data separately. Batch editing now pre-filters if using Box/Slot/Identifier logic; split up mods/filters as they're starting to get pretty hefty. - Requesting a Box Data report now shows all slots in the save file (party, misc) - Can now exclude backup saves from database search via toggle (separate from settings preventing load entirely) - Replace some linq usages with direct code * Remove WasLink virtual in PKM Inline any logic, since we now have encounter objects to indicate matching, rather than the proto-legality logic checking properties of a PKM. * Use Fateful to directly check gen5 mysterygift origins No other encounter types in gen5 apply Fateful * Simplify double ball comparison Used to be separate for deferral cases, now no longer needed to be separate. * Grab move/relearn reference and update locally Fix relearn move identifier * Inline defog HM transfer preference check HasMove is faster than getting moves & checking contains. Skips allocation by setting values directly. * Extract more met location metadata checks: WasBredEgg * Replace Console.Write* with Debug.Write* There's no console output UI, so don't include them in release builds. * Inline WasGiftEgg, WasEvent, and WasEventEgg logic Adios legality tags that aren't entirely correct for the specific format. Just put the computations in EncounterFinder.
2021-06-23 03:23:48 +00:00
public override PKM Clone() => new PK4((byte[])Data.Clone());
First look at PK4 code
2015-12-26 21:00:00 +00:00
Lowercase method paremeters
2021-07-26 22:31:46 +00:00
private string GetString(int offset, int count) => StringConverter4.GetString4(Data, offset, count);
Minor tweaks no functional change, readability++ add more xmldoc
2021-06-03 19:04:19 +00:00
private static byte[] SetString(string value, int maxLength) => StringConverter4.SetString4(value, maxLength);
String editing refactor Move all sanitization operations from PK* and SAV* to PKX; add general method for fetching a generation specific string Changes the Text subform editor to show trash bytes when appropriate. Special characters to be shown can be easily inserted in the future.
2017-04-09 21:06:50 +00:00
First look at PK4 code
2015-12-26 21:00:00 +00:00
// Structure
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override uint PID { get => BitConverter.ToUInt32(Data, 0x00); set => BitConverter.GetBytes(value).CopyTo(Data, 0x00); }
public override ushort Sanity { get => BitConverter.ToUInt16(Data, 0x04); set => BitConverter.GetBytes(value).CopyTo(Data, 0x04); }
public override ushort Checksum { get => BitConverter.ToUInt16(Data, 0x06); set => BitConverter.GetBytes(value).CopyTo(Data, 0x06); }
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
First look at PK4 code
2015-12-26 21:00:00 +00:00
#region Block A
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Species { get => BitConverter.ToUInt16(Data, 0x08); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x08); }
public override int HeldItem { get => BitConverter.ToUInt16(Data, 0x0A); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x0A); }
public override int TID { get => BitConverter.ToUInt16(Data, 0x0C); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x0C); }
public override int SID { get => BitConverter.ToUInt16(Data, 0x0E); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x0E); }
public override uint EXP { get => BitConverter.ToUInt32(Data, 0x10); set => BitConverter.GetBytes(value).CopyTo(Data, 0x10); }
public override int OT_Friendship { get => Data[0x14]; set => Data[0x14] = (byte)value; }
public override int Ability { get => Data[0x15]; set => Data[0x15] = (byte)value; }
public override int MarkValue { get => Data[0x16]; protected set => Data[0x16] = (byte)value; }
public override int Language { get => Data[0x17]; set => Data[0x17] = (byte)value; }
public override int EV_HP { get => Data[0x18]; set => Data[0x18] = (byte)value; }
public override int EV_ATK { get => Data[0x19]; set => Data[0x19] = (byte)value; }
public override int EV_DEF { get => Data[0x1A]; set => Data[0x1A] = (byte)value; }
public override int EV_SPE { get => Data[0x1B]; set => Data[0x1B] = (byte)value; }
public override int EV_SPA { get => Data[0x1C]; set => Data[0x1C] = (byte)value; }
public override int EV_SPD { get => Data[0x1D]; set => Data[0x1D] = (byte)value; }
Make ContestStat fields byte (from int)
2021-01-01 21:39:08 +00:00
public override byte CNT_Cool { get => Data[0x1E]; set => Data[0x1E] = value; }
public override byte CNT_Beauty { get => Data[0x1F]; set => Data[0x1F] = value; }
public override byte CNT_Cute { get => Data[0x20]; set => Data[0x20] = value; }
public override byte CNT_Smart { get => Data[0x21]; set => Data[0x21] = value; }
public override byte CNT_Tough { get => Data[0x22]; set => Data[0x22] = value; }
public override byte CNT_Sheen { get => Data[0x23]; set => Data[0x23] = value; }
First look at PK4 code
2015-12-26 21:00:00 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte RIB0 { get => Data[0x24]; set => Data[0x24] = value; } // Sinnoh 1
private byte RIB1 { get => Data[0x25]; set => Data[0x25] = value; } // Sinnoh 2
private byte RIB2 { get => Data[0x26]; set => Data[0x26] = value; } // Unova 1
private byte RIB3 { get => Data[0x27]; set => Data[0x27] = value; } // Unova 2
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override bool RibbonChampionSinnoh { get => (RIB0 & (1 << 0)) == 1 << 0; set => RIB0 = (byte)((RIB0 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonAbility { get => (RIB0 & (1 << 1)) == 1 << 1; set => RIB0 = (byte)((RIB0 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonAbilityGreat { get => (RIB0 & (1 << 2)) == 1 << 2; set => RIB0 = (byte)((RIB0 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonAbilityDouble { get => (RIB0 & (1 << 3)) == 1 << 3; set => RIB0 = (byte)((RIB0 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonAbilityMulti { get => (RIB0 & (1 << 4)) == 1 << 4; set => RIB0 = (byte)((RIB0 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonAbilityPair { get => (RIB0 & (1 << 5)) == 1 << 5; set => RIB0 = (byte)((RIB0 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonAbilityWorld { get => (RIB0 & (1 << 6)) == 1 << 6; set => RIB0 = (byte)((RIB0 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonAlert { get => (RIB0 & (1 << 7)) == 1 << 7; set => RIB0 = (byte)((RIB0 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonShock { get => (RIB1 & (1 << 0)) == 1 << 0; set => RIB1 = (byte)((RIB1 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonDowncast { get => (RIB1 & (1 << 1)) == 1 << 1; set => RIB1 = (byte)((RIB1 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonCareless { get => (RIB1 & (1 << 2)) == 1 << 2; set => RIB1 = (byte)((RIB1 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonRelax { get => (RIB1 & (1 << 3)) == 1 << 3; set => RIB1 = (byte)((RIB1 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonSnooze { get => (RIB1 & (1 << 4)) == 1 << 4; set => RIB1 = (byte)((RIB1 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonSmile { get => (RIB1 & (1 << 5)) == 1 << 5; set => RIB1 = (byte)((RIB1 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonGorgeous { get => (RIB1 & (1 << 6)) == 1 << 6; set => RIB1 = (byte)((RIB1 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonRoyal { get => (RIB1 & (1 << 7)) == 1 << 7; set => RIB1 = (byte)((RIB1 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonGorgeousRoyal { get => (RIB2 & (1 << 0)) == 1 << 0; set => RIB2 = (byte)((RIB2 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonFootprint { get => (RIB2 & (1 << 1)) == 1 << 1; set => RIB2 = (byte)((RIB2 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonRecord { get => (RIB2 & (1 << 2)) == 1 << 2; set => RIB2 = (byte)((RIB2 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonEvent { get => (RIB2 & (1 << 3)) == 1 << 3; set => RIB2 = (byte)((RIB2 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonLegend { get => (RIB2 & (1 << 4)) == 1 << 4; set => RIB2 = (byte)((RIB2 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonChampionWorld { get => (RIB2 & (1 << 5)) == 1 << 5; set => RIB2 = (byte)((RIB2 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonBirthday { get => (RIB2 & (1 << 6)) == 1 << 6; set => RIB2 = (byte)((RIB2 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonSpecial { get => (RIB2 & (1 << 7)) == 1 << 7; set => RIB2 = (byte)((RIB2 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonSouvenir { get => (RIB3 & (1 << 0)) == 1 << 0; set => RIB3 = (byte)((RIB3 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonWishing { get => (RIB3 & (1 << 1)) == 1 << 1; set => RIB3 = (byte)((RIB3 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonClassic { get => (RIB3 & (1 << 2)) == 1 << 2; set => RIB3 = (byte)((RIB3 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonPremier { get => (RIB3 & (1 << 3)) == 1 << 3; set => RIB3 = (byte)((RIB3 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RIB3_4 { get => (RIB3 & (1 << 4)) == 1 << 4; set => RIB3 = (byte)((RIB3 & ~(1 << 4)) | (value ? 1 << 4 : 0)); } // Unused
public override bool RIB3_5 { get => (RIB3 & (1 << 5)) == 1 << 5; set => RIB3 = (byte)((RIB3 & ~(1 << 5)) | (value ? 1 << 5 : 0)); } // Unused
public override bool RIB3_6 { get => (RIB3 & (1 << 6)) == 1 << 6; set => RIB3 = (byte)((RIB3 & ~(1 << 6)) | (value ? 1 << 6 : 0)); } // Unused
public override bool RIB3_7 { get => (RIB3 & (1 << 7)) == 1 << 7; set => RIB3 = (byte)((RIB3 & ~(1 << 7)) | (value ? 1 << 7 : 0)); } // Unused
First look at PK4 code
2015-12-26 21:00:00 +00:00
#endregion
#region Block B
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Move1 { get => BitConverter.ToUInt16(Data, 0x28); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x28); }
public override int Move2 { get => BitConverter.ToUInt16(Data, 0x2A); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x2A); }
public override int Move3 { get => BitConverter.ToUInt16(Data, 0x2C); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x2C); }
public override int Move4 { get => BitConverter.ToUInt16(Data, 0x2E); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x2E); }
public override int Move1_PP { get => Data[0x30]; set => Data[0x30] = (byte)value; }
public override int Move2_PP { get => Data[0x31]; set => Data[0x31] = (byte)value; }
public override int Move3_PP { get => Data[0x32]; set => Data[0x32] = (byte)value; }
public override int Move4_PP { get => Data[0x33]; set => Data[0x33] = (byte)value; }
public override int Move1_PPUps { get => Data[0x34]; set => Data[0x34] = (byte)value; }
public override int Move2_PPUps { get => Data[0x35]; set => Data[0x35] = (byte)value; }
public override int Move3_PPUps { get => Data[0x36]; set => Data[0x36] = (byte)value; }
public override int Move4_PPUps { get => Data[0x37]; set => Data[0x37] = (byte)value; }
public uint IV32 { get => BitConverter.ToUInt32(Data, 0x38); set => BitConverter.GetBytes(value).CopyTo(Data, 0x38); }
use u/L use 'u' to denote uint values, so that less IL ops are required ~(21->17) in the case of IVs no functional change, just a fun exercise looking at generated IL and finding ways to use less ops
2019-02-23 23:36:26 +00:00
public override int IV_HP { get => (int)(IV32 >> 00) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 00)) | ((value > 31 ? 31u : (uint)value) << 00); }
public override int IV_ATK { get => (int)(IV32 >> 05) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 05)) | ((value > 31 ? 31u : (uint)value) << 05); }
public override int IV_DEF { get => (int)(IV32 >> 10) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 10)) | ((value > 31 ? 31u : (uint)value) << 10); }
public override int IV_SPE { get => (int)(IV32 >> 15) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 15)) | ((value > 31 ? 31u : (uint)value) << 15); }
public override int IV_SPA { get => (int)(IV32 >> 20) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 20)) | ((value > 31 ? 31u : (uint)value) << 20); }
public override int IV_SPD { get => (int)(IV32 >> 25) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 25)) | ((value > 31 ? 31u : (uint)value) << 25); }
public override bool IsEgg { get => ((IV32 >> 30) & 1) == 1; set => IV32 = (IV32 & ~0x40000000u) | (value ? 0x40000000u : 0u); }
public override bool IsNicknamed { get => ((IV32 >> 31) & 1) == 1; set => IV32 = (IV32 & 0x7FFFFFFFu) | (value ? 0x80000000u : 0u); }
First look at PK4 code
2015-12-26 21:00:00 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte RIB4 { get => Data[0x3C]; set => Data[0x3C] = value; } // Hoenn 1a
private byte RIB5 { get => Data[0x3D]; set => Data[0x3D] = value; } // Hoenn 1b
private byte RIB6 { get => Data[0x3E]; set => Data[0x3E] = value; } // Hoenn 2a
private byte RIB7 { get => Data[0x3F]; set => Data[0x3F] = value; } // Hoenn 2b
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override bool RibbonG3Cool { get => (RIB4 & (1 << 0)) == 1 << 0; set => RIB4 = (byte)((RIB4 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonG3CoolSuper { get => (RIB4 & (1 << 1)) == 1 << 1; set => RIB4 = (byte)((RIB4 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonG3CoolHyper { get => (RIB4 & (1 << 2)) == 1 << 2; set => RIB4 = (byte)((RIB4 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonG3CoolMaster { get => (RIB4 & (1 << 3)) == 1 << 3; set => RIB4 = (byte)((RIB4 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonG3Beauty { get => (RIB4 & (1 << 4)) == 1 << 4; set => RIB4 = (byte)((RIB4 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonG3BeautySuper { get => (RIB4 & (1 << 5)) == 1 << 5; set => RIB4 = (byte)((RIB4 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonG3BeautyHyper { get => (RIB4 & (1 << 6)) == 1 << 6; set => RIB4 = (byte)((RIB4 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonG3BeautyMaster { get => (RIB4 & (1 << 7)) == 1 << 7; set => RIB4 = (byte)((RIB4 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonG3Cute { get => (RIB5 & (1 << 0)) == 1 << 0; set => RIB5 = (byte)((RIB5 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonG3CuteSuper { get => (RIB5 & (1 << 1)) == 1 << 1; set => RIB5 = (byte)((RIB5 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonG3CuteHyper { get => (RIB5 & (1 << 2)) == 1 << 2; set => RIB5 = (byte)((RIB5 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonG3CuteMaster { get => (RIB5 & (1 << 3)) == 1 << 3; set => RIB5 = (byte)((RIB5 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonG3Smart { get => (RIB5 & (1 << 4)) == 1 << 4; set => RIB5 = (byte)((RIB5 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonG3SmartSuper { get => (RIB5 & (1 << 5)) == 1 << 5; set => RIB5 = (byte)((RIB5 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonG3SmartHyper { get => (RIB5 & (1 << 6)) == 1 << 6; set => RIB5 = (byte)((RIB5 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonG3SmartMaster { get => (RIB5 & (1 << 7)) == 1 << 7; set => RIB5 = (byte)((RIB5 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonG3Tough { get => (RIB6 & (1 << 0)) == 1 << 0; set => RIB6 = (byte)((RIB6 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonG3ToughSuper { get => (RIB6 & (1 << 1)) == 1 << 1; set => RIB6 = (byte)((RIB6 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonG3ToughHyper { get => (RIB6 & (1 << 2)) == 1 << 2; set => RIB6 = (byte)((RIB6 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonG3ToughMaster { get => (RIB6 & (1 << 3)) == 1 << 3; set => RIB6 = (byte)((RIB6 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
Rename Gen3 Champ ribbon to be more accurate been like this since mid 2016 this ribbon can be obtained in either Hoenn or Kanto within Gen3 https://bulbapedia.bulbagarden.net/wiki/List_of_Ribbons_in_the_games#League_Ribbons
2021-04-10 19:09:43 +00:00
public override bool RibbonChampionG3 { get => (RIB6 & (1 << 4)) == 1 << 4; set => RIB6 = (byte)((RIB6 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override bool RibbonWinning { get => (RIB6 & (1 << 5)) == 1 << 5; set => RIB6 = (byte)((RIB6 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonVictory { get => (RIB6 & (1 << 6)) == 1 << 6; set => RIB6 = (byte)((RIB6 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonArtist { get => (RIB6 & (1 << 7)) == 1 << 7; set => RIB6 = (byte)((RIB6 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonEffort { get => (RIB7 & (1 << 0)) == 1 << 0; set => RIB7 = (byte)((RIB7 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonChampionBattle { get => (RIB7 & (1 << 1)) == 1 << 1; set => RIB7 = (byte)((RIB7 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonChampionRegional { get => (RIB7 & (1 << 2)) == 1 << 2; set => RIB7 = (byte)((RIB7 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonChampionNational { get => (RIB7 & (1 << 3)) == 1 << 3; set => RIB7 = (byte)((RIB7 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonCountry { get => (RIB7 & (1 << 4)) == 1 << 4; set => RIB7 = (byte)((RIB7 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonNational { get => (RIB7 & (1 << 5)) == 1 << 5; set => RIB7 = (byte)((RIB7 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonEarth { get => (RIB7 & (1 << 6)) == 1 << 6; set => RIB7 = (byte)((RIB7 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonWorld { get => (RIB7 & (1 << 7)) == 1 << 7; set => RIB7 = (byte)((RIB7 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool FatefulEncounter { get => (Data[0x40] & 1) == 1; set => Data[0x40] = (byte)((Data[0x40] & ~0x01) | (value ? 1 : 0)); }
public override int Gender { get => (Data[0x40] >> 1) & 0x3; set => Data[0x40] = (byte)((Data[0x40] & ~0x06) | (value << 1)); }
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
public override int Form { get => Data[0x40] >> 3; set => Data[0x40] = (byte)((Data[0x40] & 0x07) | (value << 3)); }
Add pk4/bk4 shared class reflection no longer used for official transfers
2018-02-03 23:31:35 +00:00
public override int ShinyLeaf { get => Data[0x41]; set => Data[0x41] = (byte) value; }
First look at PK4 code
2015-12-26 21:00:00 +00:00
// 0x43-0x47 Unused
#endregion
#region Block C
Shorten string get/set to valid range Implicit terminator set
2021-08-01 02:46:14 +00:00
public override string Nickname { get => GetString(0x48, 20); set => SetString(value, 10).CopyTo(Data, 0x48); }
First look at PK4 code
2015-12-26 21:00:00 +00:00
// 0x5E unused
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Version { get => Data[0x5F]; set => Data[0x5F] = (byte)value; }
private byte RIB8 { get => Data[0x60]; set => Data[0x60] = value; } // Sinnoh 3
private byte RIB9 { get => Data[0x61]; set => Data[0x61] = value; } // Sinnoh 4
private byte RIBA { get => Data[0x62]; set => Data[0x62] = value; } // Sinnoh 5
private byte RIBB { get => Data[0x63]; set => Data[0x63] = value; } // Sinnoh 6
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override bool RibbonG4Cool { get => (RIB8 & (1 << 0)) == 1 << 0; set => RIB8 = (byte)((RIB8 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonG4CoolGreat { get => (RIB8 & (1 << 1)) == 1 << 1; set => RIB8 = (byte)((RIB8 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonG4CoolUltra { get => (RIB8 & (1 << 2)) == 1 << 2; set => RIB8 = (byte)((RIB8 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonG4CoolMaster { get => (RIB8 & (1 << 3)) == 1 << 3; set => RIB8 = (byte)((RIB8 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonG4Beauty { get => (RIB8 & (1 << 4)) == 1 << 4; set => RIB8 = (byte)((RIB8 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonG4BeautyGreat { get => (RIB8 & (1 << 5)) == 1 << 5; set => RIB8 = (byte)((RIB8 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonG4BeautyUltra { get => (RIB8 & (1 << 6)) == 1 << 6; set => RIB8 = (byte)((RIB8 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonG4BeautyMaster { get => (RIB8 & (1 << 7)) == 1 << 7; set => RIB8 = (byte)((RIB8 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonG4Cute { get => (RIB9 & (1 << 0)) == 1 << 0; set => RIB9 = (byte)((RIB9 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonG4CuteGreat { get => (RIB9 & (1 << 1)) == 1 << 1; set => RIB9 = (byte)((RIB9 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonG4CuteUltra { get => (RIB9 & (1 << 2)) == 1 << 2; set => RIB9 = (byte)((RIB9 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonG4CuteMaster { get => (RIB9 & (1 << 3)) == 1 << 3; set => RIB9 = (byte)((RIB9 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RibbonG4Smart { get => (RIB9 & (1 << 4)) == 1 << 4; set => RIB9 = (byte)((RIB9 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public override bool RibbonG4SmartGreat { get => (RIB9 & (1 << 5)) == 1 << 5; set => RIB9 = (byte)((RIB9 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public override bool RibbonG4SmartUltra { get => (RIB9 & (1 << 6)) == 1 << 6; set => RIB9 = (byte)((RIB9 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public override bool RibbonG4SmartMaster { get => (RIB9 & (1 << 7)) == 1 << 7; set => RIB9 = (byte)((RIB9 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public override bool RibbonG4Tough { get => (RIBA & (1 << 0)) == 1 << 0; set => RIBA = (byte)((RIBA & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public override bool RibbonG4ToughGreat { get => (RIBA & (1 << 1)) == 1 << 1; set => RIBA = (byte)((RIBA & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public override bool RibbonG4ToughUltra { get => (RIBA & (1 << 2)) == 1 << 2; set => RIBA = (byte)((RIBA & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public override bool RibbonG4ToughMaster { get => (RIBA & (1 << 3)) == 1 << 3; set => RIBA = (byte)((RIBA & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public override bool RIBA_4 { get => (RIBA & (1 << 4)) == 1 << 4; set => RIBA = (byte)((RIBA & ~(1 << 4)) | (value ? 1 << 4 : 0)); } // Unused
public override bool RIBA_5 { get => (RIBA & (1 << 5)) == 1 << 5; set => RIBA = (byte)((RIBA & ~(1 << 5)) | (value ? 1 << 5 : 0)); } // Unused
public override bool RIBA_6 { get => (RIBA & (1 << 6)) == 1 << 6; set => RIBA = (byte)((RIBA & ~(1 << 6)) | (value ? 1 << 6 : 0)); } // Unused
public override bool RIBA_7 { get => (RIBA & (1 << 7)) == 1 << 7; set => RIBA = (byte)((RIBA & ~(1 << 7)) | (value ? 1 << 7 : 0)); } // Unused
public override bool RIBB_0 { get => (RIBB & (1 << 0)) == 1 << 0; set => RIBB = (byte)((RIBB & ~(1 << 0)) | (value ? 1 << 0 : 0)); } // Unused
public override bool RIBB_1 { get => (RIBB & (1 << 1)) == 1 << 1; set => RIBB = (byte)((RIBB & ~(1 << 1)) | (value ? 1 << 1 : 0)); } // Unused
public override bool RIBB_2 { get => (RIBB & (1 << 2)) == 1 << 2; set => RIBB = (byte)((RIBB & ~(1 << 2)) | (value ? 1 << 2 : 0)); } // Unused
public override bool RIBB_3 { get => (RIBB & (1 << 3)) == 1 << 3; set => RIBB = (byte)((RIBB & ~(1 << 3)) | (value ? 1 << 3 : 0)); } // Unused
public override bool RIBB_4 { get => (RIBB & (1 << 4)) == 1 << 4; set => RIBB = (byte)((RIBB & ~(1 << 4)) | (value ? 1 << 4 : 0)); } // Unused
public override bool RIBB_5 { get => (RIBB & (1 << 5)) == 1 << 5; set => RIBB = (byte)((RIBB & ~(1 << 5)) | (value ? 1 << 5 : 0)); } // Unused
public override bool RIBB_6 { get => (RIBB & (1 << 6)) == 1 << 6; set => RIBB = (byte)((RIBB & ~(1 << 6)) | (value ? 1 << 6 : 0)); } // Unused
public override bool RIBB_7 { get => (RIBB & (1 << 7)) == 1 << 7; set => RIBB = (byte)((RIBB & ~(1 << 7)) | (value ? 1 << 7 : 0)); } // Unused
First look at PK4 code
2015-12-26 21:00:00 +00:00
// 0x64-0x67 Unused
#endregion
#region Block D
Shorten string get/set to valid range Implicit terminator set
2021-08-01 02:46:14 +00:00
public override string OT_Name { get => GetString(0x68, 14); set => SetString(value, 7).CopyTo(Data, 0x68); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Egg_Year { get => Data[0x78]; set => Data[0x78] = (byte)value; }
public override int Egg_Month { get => Data[0x79]; set => Data[0x79] = (byte)value; }
public override int Egg_Day { get => Data[0x7A]; set => Data[0x7A] = (byte)value; }
public override int Met_Year { get => Data[0x7B]; set => Data[0x7B] = (byte)value; }
public override int Met_Month { get => Data[0x7C]; set => Data[0x7C] = (byte)value; }
public override int Met_Day { get => Data[0x7D]; set => Data[0x7D] = (byte)value; }
First look at PK4 code
2015-12-26 21:00:00 +00:00
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public override int Egg_Location
First look at PK4 code
2015-12-26 21:00:00 +00:00
{
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
get
{
ushort hgssloc = BitConverter.ToUInt16(Data, 0x44);
if (hgssloc != 0)
return hgssloc;
return BitConverter.ToUInt16(Data, 0x7E);
}
First look at PK4 code
2015-12-26 21:00:00 +00:00
set
{
Fix gen4 pkm location/ball interaction Met Location fixed from Daycare Couple to "Faraway Place" (2000 -> 3002) Check no egg location before writing faraway place. HGSSBall handled directly by Ball property (like met location) Constrain balls and met locations for DP Thanks BeyondTheHorizon for the initial bug report prompting this improvement.
2016-08-06 06:21:27 +00:00
if (value == 0)
{
BitConverter.GetBytes((ushort)0).CopyTo(Data, 0x44);
BitConverter.GetBytes((ushort)0).CopyTo(Data, 0x7E);
}
Minor clean Condense some expressions Use less linq Rename some fields
2021-05-29 22:31:47 +00:00
else if (Locations.IsPtHGSSLocation(value) || Locations.IsPtHGSSLocationEgg(value))
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
// Met location not in DP, set to Faraway Place
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x44);
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
BitConverter.GetBytes((ushort)0xBBA).CopyTo(Data, 0x7E);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
else
{
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
int pthgss = PtHGSS ? value : 0; // only set to PtHGSS loc if encountered in game
BitConverter.GetBytes((ushort)pthgss).CopyTo(Data, 0x44);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x7E);
}
First look at PK4 code
2015-12-26 21:00:00 +00:00
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public override int Met_Location
Fix conversion issues pk5->pk6 conversion was missing Gender/AltForm definition.
2015-12-29 18:28:24 +00:00
{
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
get
{
ushort hgssloc = BitConverter.ToUInt16(Data, 0x46);
if (hgssloc != 0)
return hgssloc;
return BitConverter.ToUInt16(Data, 0x80);
}
Fix conversion issues pk5->pk6 conversion was missing Gender/AltForm definition.
2015-12-29 18:28:24 +00:00
set
{
Fix gen4 pkm location/ball interaction Met Location fixed from Daycare Couple to "Faraway Place" (2000 -> 3002) Check no egg location before writing faraway place. HGSSBall handled directly by Ball property (like met location) Constrain balls and met locations for DP Thanks BeyondTheHorizon for the initial bug report prompting this improvement.
2016-08-06 06:21:27 +00:00
if (value == 0)
{
BitConverter.GetBytes((ushort)0).CopyTo(Data, 0x46);
BitConverter.GetBytes((ushort)0).CopyTo(Data, 0x80);
}
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
else if (Locations.IsPtHGSSLocation(value) || Locations.IsPtHGSSLocationEgg(value))
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
// Met location not in DP, set to Faraway Place
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x46);
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
BitConverter.GetBytes((ushort)0xBBA).CopyTo(Data, 0x80);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
else
{
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
int pthgss = PtHGSS ? value : 0; // only set to PtHGSS loc if encountered in game
BitConverter.GetBytes((ushort)pthgss).CopyTo(Data, 0x46);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x80);
}
Fix conversion issues pk5->pk6 conversion was missing Gender/AltForm definition.
2015-12-29 18:28:24 +00:00
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte PKRS { get => Data[0x82]; set => Data[0x82] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override int PKRS_Days { get => PKRS & 0xF; set => PKRS = (byte)((PKRS & ~0xF) | value); }
public override int PKRS_Strain { get => PKRS >> 4; set => PKRS = (byte)((PKRS & 0xF) | (value << 4)); }
Fix gen4 pkm location/ball interaction Met Location fixed from Daycare Couple to "Faraway Place" (2000 -> 3002) Check no egg location before writing faraway place. HGSSBall handled directly by Ball property (like met location) Constrain balls and met locations for DP Thanks BeyondTheHorizon for the initial bug report prompting this improvement.
2016-08-06 06:21:27 +00:00
public override int Ball
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get =>
Tweak HGSS Ball set PGT -> PK4 doesn't have HGSS ball data (value=0) Return the higher of the two When setting, consider the Fateful Encounter status before writing to 0x86
2016-09-06 03:20:56 +00:00
// Pokemon obtained in HGSS have the HGSS ball set (@0x86)
// However, this info is not set when receiving a wondercard!
// The PGT contains a preformatted PK4 file, which is slightly modified.
// No HGSS balls were used, and no HGSS ball info is set.
// Sneaky way = return the higher of the two values.
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
Math.Max(Data[0x86], Data[0x83]);
Fix gen4 pkm location/ball interaction Met Location fixed from Daycare Couple to "Faraway Place" (2000 -> 3002) Check no egg location before writing faraway place. HGSSBall handled directly by Ball property (like met location) Constrain balls and met locations for DP Thanks BeyondTheHorizon for the initial bug report prompting this improvement.
2016-08-06 06:21:27 +00:00
set
{
Tweak HGSS Ball set PGT -> PK4 doesn't have HGSS ball data (value=0) Return the higher of the two When setting, consider the Fateful Encounter status before writing to 0x86
2016-09-06 03:20:56 +00:00
// Ball to display in DPPt
Data[0x83] = (byte)(value <= 0x10 ? value : 4); // Cap at Cherish Ball
// HGSS Exclusive Balls -- If the user wants to screw things up, let them. Any legality checking could catch hax.
if (value > 0x10 || (HGSS && !FatefulEncounter))
Fix gen4 pkm location/ball interaction Met Location fixed from Daycare Couple to "Faraway Place" (2000 -> 3002) Check no egg location before writing faraway place. HGSSBall handled directly by Ball property (like met location) Constrain balls and met locations for DP Thanks BeyondTheHorizon for the initial bug report prompting this improvement.
2016-08-06 06:21:27 +00:00
Data[0x86] = (byte)(value <= 0x18 ? value : 4); // Cap at Comp Ball
else
Data[0x86] = 0; // Unused
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Met_Level { get => Data[0x84] & ~0x80; set => Data[0x84] = (byte)((Data[0x84] & 0x80) | value); }
public override int OT_Gender { get => Data[0x84] >> 7; set => Data[0x84] = (byte)((Data[0x84] & ~0x80) | value << 7); }
Revise EncounterArea and EncounterType for clarity (#3228) EncounterArea now stores a more specific type'd array for encounter slots. Better iteration and less casting, as the nonspecific `Slots` fetch is rarely referenced. EncounterType renamed to GroundTile to reflect how it actually works in Gen4. Was previously an ambiguous field that was clarified a little; we can describe it a little better now. Keep the GUI the same to not scare the end users. Change Trash Byte properties to get/set a Span. Trash Byte legality checking easier on the garbage collector?
2021-06-30 03:58:06 +00:00
public override GroundTileType GroundTile { get => (GroundTileType)Data[0x85]; set => Data[0x85] = (byte)value; }
public byte PokéathlonStat { get => Data[0x87]; set => Data[0x87] = value; }
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
// Unused 0x87
#endregion
Add status condition prop to all mainline formats Closes #2160 , use Batch Editor to modify slots; it's not worth GUI presence as it's only saved for party format mons and is undocumented for anything besides affliction flags
2018-12-03 05:23:10 +00:00
#region Battle Stats
Add Heal, make status_condition a pkm property also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk :+1:
2019-01-12 06:25:48 +00:00
public override int Status_Condition { get => BitConverter.ToInt32(Data, 0x88); set => BitConverter.GetBytes(value).CopyTo(Data, 0x88); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Stat_Level { get => Data[0x8C]; set => Data[0x8C] = (byte)value; }
public override int Stat_HPCurrent { get => BitConverter.ToUInt16(Data, 0x8E); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x8E); }
public override int Stat_HPMax { get => BitConverter.ToUInt16(Data, 0x90); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x90); }
public override int Stat_ATK { get => BitConverter.ToUInt16(Data, 0x92); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x92); }
public override int Stat_DEF { get => BitConverter.ToUInt16(Data, 0x94); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x94); }
public override int Stat_SPE { get => BitConverter.ToUInt16(Data, 0x96); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x96); }
public override int Stat_SPA { get => BitConverter.ToUInt16(Data, 0x98); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x98); }
public override int Stat_SPD { get => BitConverter.ToUInt16(Data, 0x9A); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x9A); }
Change signatures to use readonly if possible Extract get/set team methods for battle video
2020-12-05 14:09:33 +00:00
public byte[] GetHeldMailData() => Data.Slice(0x9C, 0x38);
public void SetHeldMailData(byte[] value) => value.CopyTo(Data, 0x9C);
Add status condition prop to all mainline formats Closes #2160 , use Batch Editor to modify slots; it's not worth GUI presence as it's only saved for party format mons and is undocumented for anything besides affliction flags
2018-12-03 05:23:10 +00:00
#endregion
First look at PK4 code
2015-12-26 21:00:00 +00:00
// Methods
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
protected override byte[] Encrypt()
Past gen fixes + improvements Fixed crypt of past gen pkms (use chk not PID), add gen4 save, add save version detection
2016-05-15 22:24:31 +00:00
{
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
RefreshChecksum();
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
return PokeCrypto.EncryptArray45(Data);
Past gen fixes + improvements Fixed crypt of past gen pkms (use chk not PID), add gen4 save, add save version detection
2016-05-15 22:24:31 +00:00
}
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
Add gen4/5 synthetic trade logic was previously present for gen6 and gen7 only, resulting in eggs in gen4/5 not getting link trade values applied. that's really all. https://projectpokemon.org/home/forums/topic/44437-bug-eggs-transfer-for-gen-4-dppt-and-hgss/
2018-03-22 04:10:23 +00:00
// Synthetic Trading Logic
public bool Trade(string SAV_Trainer, int SAV_TID, int SAV_SID, int SAV_GENDER, int Day = 1, int Month = 1, int Year = 2009)
{
// Eggs do not have any modifications done if they are traded
if (IsEgg && !(SAV_Trainer == OT_Name && SAV_TID == TID && SAV_SID == SID && SAV_GENDER == OT_Gender))
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
SetLinkTradeEgg(Day, Month, Year, Locations.LinkTrade4);
Add gen4/5 synthetic trade logic was previously present for gen6 and gen7 only, resulting in eggs in gen4/5 not getting link trade values applied. that's really all. https://projectpokemon.org/home/forums/topic/44437-bug-eggs-transfer-for-gen-4-dppt-and-hgss/
2018-03-22 04:10:23 +00:00
return true;
}
return false;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public BK4 ConvertToBK4()
PBR support (#290) * Initial (still buggy) PBR commit * Basic save slot support
2016-09-26 23:14:11 +00:00
{
Add pk4/bk4 shared class reflection no longer used for official transfers
2018-02-03 23:31:35 +00:00
BK4 bk4 = ConvertTo<BK4>();
// Enforce DP content only (no PtHGSS)
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
if (Form != 0 && !PersonalTable.DP[Species].HasForms && Species != 201)
bk4.Form = 0;
Purge non-dp data for BK4 transfer #1690
2017-12-03 21:10:14 +00:00
if (HeldItem > Legal.MaxItemID_4_DP)
bk4.HeldItem = 0;
PBR support (#290) * Initial (still buggy) PBR commit * Basic save slot support
2016-09-26 23:14:11 +00:00
bk4.RefreshChecksum();
return bk4;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public PK5 ConvertToPK5()
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
{
// Double Check Location Data to see if we're already a PK5
if (Data[0x5F] < 0x10 && BitConverter.ToUInt16(Data, 0x80) > 0x4000)
return new PK5(Data);
DateTime moment = DateTime.Now;
Update FormArgument handling for gen6/7 Disassociate pk4/pk6 backing byte[] when converting to pk5|pk7, as we no longer make a copy of the byte[] in the pkm's constructor. Change UpdatePKM to include isParty, as we want it optional to update FormArgument too. Change FormArgument saving to be handled by FormConverter; kinda not really good to have it there, but nothing else is handling FormArgument values. Expand IFormArgument to have all FormArgument values exposed. "Maximum" is furfrou only. PK6: Max is in the "FormArgument" u32, and the remain/elapsed is in party stats (hence the reverting when boxed) PK7: u8 remain, u8 elapsed, u8 max, u8 unused. PK8: assumedly the same as PK7, given the disassembly hints that it's the same as past games (even though Furfrou and Hoopa are not in SWSH).
2021-02-09 04:26:53 +00:00
PK5 pk5 = new((byte[])Data.Clone()) // Convert away!
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
{
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
OT_Friendship = 70,
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
// Apply new met date
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
MetDate = moment
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
};
Fix arceus form 4->5 Form needs to be reset when removing the held plate
2016-10-22 04:55:26 +00:00
// Arceus Type Changing -- Plate forcibly removed.
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (pk5.Species == (int)Core.Species.Arceus)
Remove arceus plate 4->5 Since 4->5 now allows item transfer, remove plate when appropriate.
2017-03-17 04:22:49 +00:00
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
pk5.Form = 0;
Remove arceus plate 4->5 Since 4->5 now allows item transfer, remove plate when appropriate.
2017-03-17 04:22:49 +00:00
pk5.HeldItem = 0;
}
Replace more linq usage
2021-08-06 05:39:38 +00:00
else if (Array.IndexOf(Legal.HeldItems_BW, (ushort)HeldItem) == -1)
Refactoring Pre 3-5 moving of useful arrays Reduce footprint of unpackMini (was taking 88ms, now <1us)
2017-03-17 06:16:11 +00:00
{
Extract some reused logic Put the methods in Tables4; kinda breaks the 'only arrays here' rule but they only reference values in this file(partial class).
2019-02-21 06:10:15 +00:00
pk5.HeldItem = 0; // if valid, it's already copied
Refactoring Pre 3-5 moving of useful arrays Reduce footprint of unpackMini (was taking 88ms, now <1us)
2017-03-17 06:16:11 +00:00
}
Fix arceus form 4->5 Form needs to be reset when removing the held plate
2016-10-22 04:55:26 +00:00
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
// Fix PP
Extract some reused logic Put the methods in Tables4; kinda breaks the 'only arrays here' rule but they only reference values in this file(partial class).
2019-02-21 06:10:15 +00:00
pk5.HealPP();
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
Refactoring Pre 3-5 moving of useful arrays Reduce footprint of unpackMini (was taking 88ms, now <1us)
2017-03-17 06:16:11 +00:00
// Disassociate Nature and PID, pk4 getter does PID%25
pk5.Nature = Nature;
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
// Delete Platinum/HGSS Met Location Data
BitConverter.GetBytes((uint)0).CopyTo(pk5.Data, 0x44);
// Met / Crown Data Detection
Extract some reused logic Put the methods in Tables4; kinda breaks the 'only arrays here' rule but they only reference values in this file(partial class).
2019-02-21 06:10:15 +00:00
pk5.Met_Location = Legal.GetTransfer45MetLocation(pk5);
Fix pt/hgss egg location handling 4->5 Closes #1766 pt/hgss egg location data is lost on transfer, retaining faraway place only. 2c8e2176e95e2002162193166efa10c6883d70ac fix was incorrect
2018-01-21 19:57:34 +00:00
// Egg Location is not modified; when clearing Pt/HGSS egg data, the location will revert to Faraway Place
// pk5.Egg_Location = Egg_Location;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
// Delete HGSS Data
BitConverter.GetBytes((ushort)0).CopyTo(pk5.Data, 0x86);
Fix gen4 pkm location/ball interaction Met Location fixed from Daycare Couple to "Faraway Place" (2000 -> 3002) Check no egg location before writing faraway place. HGSSBall handled directly by Ball property (like met location) Constrain balls and met locations for DP Thanks BeyondTheHorizon for the initial bug report prompting this improvement.
2016-08-06 06:21:27 +00:00
pk5.Ball = Ball;
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
Revert "Decapitalize non-nicknamed on 4->5 transfer" This reverts commit 904dc84b5225a19c6cdf819420b3e93404f4942c.
2019-07-10 03:24:47 +00:00
// Transfer Nickname and OT Name, update encoding
pk5.Nickname = Nickname;
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
pk5.OT_Name = OT_Name;
// Fix Level
Extract some reused logic Put the methods in Tables4; kinda breaks the 'only arrays here' rule but they only reference values in this file(partial class).
2019-02-21 06:10:15 +00:00
pk5.Met_Level = pk5.CurrentLevel;
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
Fix conversion issues pk5->pk6 conversion was missing Gender/AltForm definition.
2015-12-29 18:28:24 +00:00
// Remove HM moves; Defog should be kept if both are learned.
Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately (#3222) * Track a PKM's Box,Slot,StorageFlags,Identifier metadata separately Don't store within the object, track the slot origin data separately. Batch editing now pre-filters if using Box/Slot/Identifier logic; split up mods/filters as they're starting to get pretty hefty. - Requesting a Box Data report now shows all slots in the save file (party, misc) - Can now exclude backup saves from database search via toggle (separate from settings preventing load entirely) - Replace some linq usages with direct code * Remove WasLink virtual in PKM Inline any logic, since we now have encounter objects to indicate matching, rather than the proto-legality logic checking properties of a PKM. * Use Fateful to directly check gen5 mysterygift origins No other encounter types in gen5 apply Fateful * Simplify double ball comparison Used to be separate for deferral cases, now no longer needed to be separate. * Grab move/relearn reference and update locally Fix relearn move identifier * Inline defog HM transfer preference check HasMove is faster than getting moves & checking contains. Skips allocation by setting values directly. * Extract more met location metadata checks: WasBredEgg * Replace Console.Write* with Debug.Write* There's no console output UI, so don't include them in release builds. * Inline WasGiftEgg, WasEvent, and WasEventEgg logic Adios legality tags that aren't entirely correct for the specific format. Just put the computations in EncounterFinder.
2021-06-23 03:23:48 +00:00
// if has defog, remove whirlpool.
bool hasDefog = HasMove((int) Move.Defog);
var banned = hasDefog ? Legal.HM_HGSS : Legal.HM_DPPt;
Replace more linq usage
2021-08-06 05:39:38 +00:00
if (Array.IndexOf(banned, Move1) != -1) Move1 = 0;
if (Array.IndexOf(banned, Move2) != -1) Move2 = 0;
if (Array.IndexOf(banned, Move3) != -1) Move3 = 0;
if (Array.IndexOf(banned, Move4) != -1) Move4 = 0;
Fix conversion issues pk5->pk6 conversion was missing Gender/AltForm definition.
2015-12-29 18:28:24 +00:00
pk5.FixMoves();
pk2pk Refactoring Transition from modifying byte arrays to just having objects mediate the conversion. Farewell pk2pk! The PK# objects can convert up to the next generation through their own methods; doing this required having class structures for all generations :)
2015-12-28 05:26:07 +00:00
pk5.RefreshChecksum();
return pk5;
}
First look at PK4 code
2015-12-26 21:00:00 +00:00
}
}
Reference in a new issue Copy permalink