Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-10 14:44:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/MoveList.cs

324 lines
14 KiB
C#
Raw Normal View History

Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
using System;
using System.Collections.Generic;
using System.Linq;
using static PKHeX.Core.Legal;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
using static PKHeX.Core.GameVersion;
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
namespace PKHeX.Core
{
Minor clean add some xmldoc
2020-06-22 00:46:06 +00:00
/// <summary>
/// Logic for obtaining a list of moves.
/// </summary>
internal static class MoveList
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
internal static IEnumerable<int> GetValidRelearn(PKM pkm, int species, int form, bool inheritlvlmoves, GameVersion version = Any)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
Move more breeding logic to Breeding Simplify some method signatures, reduce checks for MoveEgg.GetEggMoves ran legality checks for 100,000 pkm, no more exceptions (Internal Error) -- added a "CanGameGenerateEggs" which filters out unused gameIDs
2021-01-01 23:01:22 +00:00
int generation = pkm.Generation;
if (generation < 6)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
return Array.Empty<int>();
var r = new List<int>();
Revise some method signatures
2020-12-23 04:50:33 +00:00
r.AddRange(MoveEgg.GetRelearnLVLMoves(pkm, species, form, 1, version));
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
Minor tweaks verify relearn: move split check before method call movelist: don't capture pkm in local method; meowstic ID pkm: flip argument for easier understanding
2020-07-19 23:30:46 +00:00
if (pkm.Format == 6 && pkm.Species != (int)Species.Meowstic)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
form = 0;
Move more breeding logic to Breeding Simplify some method signatures, reduce checks for MoveEgg.GetEggMoves ran legality checks for 100,000 pkm, no more exceptions (Internal Error) -- added a "CanGameGenerateEggs" which filters out unused gameIDs
2021-01-01 23:01:22 +00:00
r.AddRange(MoveEgg.GetEggMoves(pkm.PersonalInfo, species, form, version, Math.Max(2, generation)));
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (inheritlvlmoves)
Revise some method signatures
2020-12-23 04:50:33 +00:00
r.AddRange(MoveEgg.GetRelearnLVLMoves(pkm, species, form, 100, version));
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
return r.Distinct();
}
internal static int[] GetShedinjaEvolveMoves(PKM pkm, int generation, int lvl)
{
if (pkm.Species != (int)Species.Shedinja || lvl < 20)
return Array.Empty<int>();
// If Nincada evolves into Ninjask and learns a move after evolution from Ninjask's LevelUp data, Shedinja would appear with that move.
// Only one move above level 20 is allowed; check the count of Ninjask moves elsewhere.
return generation switch
{
3 when pkm.InhabitedGeneration(3) => LevelUpE[(int)Species.Ninjask].GetMoves(lvl, 20), // Same LevelUp data in all Gen3 games
4 when pkm.InhabitedGeneration(4) => LevelUpPt[(int)Species.Ninjask].GetMoves(lvl, 20), // Same LevelUp data in all Gen4 games
_ => Array.Empty<int>(),
};
}
internal static int GetShedinjaMoveLevel(int species, int move, int generation)
{
var src = generation == 4 ? LevelUpPt : LevelUpE;
var moves = src[species];
return moves.GetLevelLearnMove(move);
}
internal static int[] GetBaseEggMoves(PKM pkm, int species, int form, GameVersion gameSource, int lvl)
{
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
if (gameSource == Any)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
gameSource = (GameVersion)pkm.Version;
switch (gameSource)
{
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case GSC or GS:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
// If checking back-transfer specimen (GSC->RBY), remove moves that must be deleted prior to transfer
Replace more linq usage
2021-08-06 05:39:38 +00:00
static int[] getRBYCompatibleMoves(int format, int[] moves) => format == 1 ? Array.FindAll(moves, m => m <= MaxMoveID_1) : moves;
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(2))
Minor tweaks verify relearn: move split check before method call movelist: don't capture pkm in local method; meowstic ID pkm: flip argument for easier understanding
2020-07-19 23:30:46 +00:00
return getRBYCompatibleMoves(pkm.Format, LevelUpGS[species].GetMoves(lvl));
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case C:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(2))
Minor tweaks verify relearn: move split check before method call movelist: don't capture pkm in local method; meowstic ID pkm: flip argument for easier understanding
2020-07-19 23:30:46 +00:00
return getRBYCompatibleMoves(pkm.Format, LevelUpC[species].GetMoves(lvl));
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case R or S or RS:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(3))
return LevelUpRS[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case E:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(3))
return LevelUpE[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case FR or LG or FRLG:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
// The only difference in FR/LG is Deoxys, which doesn't breed.
if (pkm.InhabitedGeneration(3))
return LevelUpFR[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case D or P or DP:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(4))
return LevelUpDP[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case Pt:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(4))
return LevelUpPt[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case HG or SS or HGSS:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(4))
return LevelUpHGSS[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case B or W or BW:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(5))
return LevelUpBW[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case B2 or W2 or B2W2:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(5))
return LevelUpB2W2[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case X or Y or XY:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(6))
return LevelUpXY[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case AS or OR or ORAS:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(6))
return LevelUpAO[species].GetMoves(lvl);
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case SN or MN or SM:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (species > MaxSpeciesID_7)
break;
if (pkm.InhabitedGeneration(7))
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
int index = PersonalTable.SM.GetFormIndex(species, form);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
return LevelUpSM[index].GetMoves(lvl);
}
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case US or UM or USUM:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(7))
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
int index = PersonalTable.USUM.GetFormIndex(species, form);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
return LevelUpUSUM[index].GetMoves(lvl);
}
break;
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
case SW or SH or SWSH:
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
if (pkm.InhabitedGeneration(8))
{
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
int index = PersonalTable.SWSH.GetFormIndex(species, form);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
return LevelUpSWSH[index].GetMoves(lvl);
}
break;
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
case BD or SP or BDSP:
if (pkm.InhabitedGeneration(8))
{
int index = PersonalTable.SWSH.GetFormIndex(species, form);
return LevelUpBDSP[index].GetMoves(lvl);
}
break;
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
}
return Array.Empty<int>();
}
Extract move suggest logic, add battleversion clamp Closes #2911
2020-06-27 18:06:28 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
internal static IReadOnlyList<int>[] GetValidMovesAllGens(PKM pkm, IReadOnlyList<EvoCriteria>[] evoChains, MoveSourceType types = MoveSourceType.ExternalSources, bool RemoveTransferHM = true)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
Extract move suggest logic, add battleversion clamp Closes #2911
2020-06-27 18:06:28 +00:00
var result = new IReadOnlyList<int>[evoChains.Length];
for (int i = 0; i < result.Length; i++)
result[i] = Array.Empty<int>();
Move more breeding logic to Breeding Simplify some method signatures, reduce checks for MoveEgg.GetEggMoves ran legality checks for 100,000 pkm, no more exceptions (Internal Error) -- added a "CanGameGenerateEggs" which filters out unused gameIDs
2021-01-01 23:01:22 +00:00
var min = pkm is IBattleVersion b ? Math.Max(0, b.GetMinGeneration()) : 1;
Extract move suggest logic, add battleversion clamp Closes #2911
2020-06-27 18:06:28 +00:00
for (int i = min; i < evoChains.Length; i++)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
Return evolution chains with more accurate min-max Closes #3371 ty @Ninjistix !
2022-01-14 08:11:33 +00:00
var evos = evoChains[i];
if (evos.Count == 0)
Extract move suggest logic, add battleversion clamp Closes #2911
2020-06-27 18:06:28 +00:00
continue;
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
Return evolution chains with more accurate min-max Closes #3371 ty @Ninjistix !
2022-01-14 08:11:33 +00:00
result[i] = GetValidMoves(pkm, evos, i, types, RemoveTransferHM).ToList();
Extract move suggest logic, add battleversion clamp Closes #2911
2020-06-27 18:06:28 +00:00
}
return result;
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
internal static IEnumerable<int> GetValidMoves(PKM pkm, IReadOnlyList<EvoCriteria> evoChain, int generation, MoveSourceType types = MoveSourceType.ExternalSources, bool RemoveTransferHM = true)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
GameVersion version = (GameVersion)pkm.Version;
Fix dropdown suggested green moves from showing swsh moves Extract the IsLandlocked check to the IsMovesetRestricted which already exists.
2021-11-24 06:58:41 +00:00
if (!pkm.IsMovesetRestricted(generation))
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
version = Any;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return GetValidMoves(pkm, version, evoChain, generation, types: types, RemoveTransferHM: RemoveTransferHM);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
}
Add more xmldoc / enum clean
2021-03-14 18:28:46 +00:00
internal static IEnumerable<int> GetValidRelearn(PKM pkm, int species, int form, GameVersion version = Any)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
Extract breeding info to separate class Remove splitbreed check in encounteregg2 generator; gen is always 2, never >=3, so the splitbreed check is never executed
2020-12-08 04:54:55 +00:00
return GetValidRelearn(pkm, species, form, Breeding.GetCanInheritMoves(species), version);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
/// <summary>
/// ONLY CALL FOR GEN2 EGGS
/// </summary>
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
internal static IEnumerable<int> GetExclusivePreEvolutionMoves(PKM pkm, int Species, IReadOnlyList<EvoCriteria> evoChain, int generation, GameVersion Version)
{
var preevomoves = new List<int>();
var evomoves = new List<int>();
var index = EvolutionChain.GetEvoChainSpeciesIndex(evoChain, Species);
for (int i = 0; i < evoChain.Count; i++)
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
int minLvLG2;
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
var evo = evoChain[i];
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
if (ParseSettings.AllowGen2MoveReminder(pkm))
minLvLG2 = 0;
else if (i == evoChain.Count - 1) // minimum level, otherwise next learnable level
minLvLG2 = 5;
else if (evo.RequiresLvlUp)
minLvLG2 = evo.Level + 1;
else
minLvLG2 = evo.Level;
var moves = GetMoves(pkm, evo.Species, evo.Form, evo.Level, 0, minLvLG2, Version: Version, types: MoveSourceType.ExternalSources, RemoveTransferHM: false, generation: generation);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
var list = i >= index ? preevomoves : evomoves;
list.AddRange(moves);
}
return preevomoves.Except(evomoves).Distinct();
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
internal static IEnumerable<int> GetValidMoves(PKM pkm, GameVersion version, IReadOnlyList<EvoCriteria> chain, int generation, MoveSourceType types = MoveSourceType.Reminder, bool RemoveTransferHM = true)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
var r = new List<int> { 0 };
int species = pkm.Species;
Handle form changing for move memories Doesn't invalidate any of the statements made today. ty @Lusamine for identifying these cases.
2021-08-15 03:20:13 +00:00
if (FormChangeMovesRetain.Contains(species)) // Deoxys & Shaymin & Giratina (others don't have extra but whatever)
return GetValidMovesAllForms(pkm, chain, version, generation, types, RemoveTransferHM, species, r);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
// Generation 1 & 2 do not always have move relearning capability, so the bottom bound for learnable indexes needs to be determined.
var minLvLG1 = 0;
var minLvLG2 = 0;
Refactor some method signatures vs -> chain (clarity on what it is; an evolution chain, rather than e.v.o.s - vs) Clamp origin chain for transferred where we can use the max origin level
2020-06-28 03:18:29 +00:00
for (var i = 0; i < chain.Count; i++)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
Refactor some method signatures vs -> chain (clarity on what it is; an evolution chain, rather than e.v.o.s - vs) Clamp origin chain for transferred where we can use the max origin level
2020-06-28 03:18:29 +00:00
var evo = chain[i];
Return evolution chains with more accurate min-max Closes #3371 ty @Ninjistix !
2022-01-14 08:11:33 +00:00
bool encounteredEvo = i == chain.Count - 1;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
if (generation <= 2)
{
if (encounteredEvo) // minimum level, otherwise next learnable level
Update MoveList.cs
2021-08-03 02:56:09 +00:00
minLvLG1 = evo.MinLevel + 1;
Return evolution chains with more accurate min-max Closes #3371 ty @Ninjistix !
2022-01-14 08:11:33 +00:00
else // learns level up moves immediately after evolving
minLvLG1 = evo.MinLevel;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
if (!ParseSettings.AllowGen2MoveReminder(pkm))
minLvLG2 = minLvLG1;
}
Include gen1 encounter moves in not-needed list Might result in some illegal matches as it includes it for all evolutions in the chain, but whatever. Could probably rewrite the generator to only generate for different starting-species, but it's fine now. Inline the max level calc
2021-08-05 02:07:20 +00:00
var maxLevel = evo.Level;
Return evolution chains with more accurate min-max Closes #3371 ty @Ninjistix !
2022-01-14 08:11:33 +00:00
if (!encounteredEvo) // evolution
Include gen1 encounter moves in not-needed list Might result in some illegal matches as it includes it for all evolutions in the chain, but whatever. Could probably rewrite the generator to only generate for different starting-species, but it's fine now. Inline the max level calc
2021-08-05 02:07:20 +00:00
++maxLevel; // allow lvlmoves from the level it evolved to the next species
var moves = GetMoves(pkm, evo.Species, evo.Form, maxLevel, minLvLG1, minLvLG2, version, types, RemoveTransferHM, generation);
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
r.AddRange(moves);
}
if (pkm.Format <= 3)
return r.Distinct();
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
if (types.HasFlagFast(MoveSourceType.LevelUp))
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
MoveTutor.AddSpecialFormChangeMoves(r, pkm, generation, species);
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
if (types.HasFlagFast(MoveSourceType.SpecialTutor))
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
MoveTutor.AddSpecialTutorMoves(r, pkm, generation, species);
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
if (types.HasFlagFast(MoveSourceType.RelearnMoves) && generation >= 6)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
r.AddRange(pkm.RelearnMoves);
return r.Distinct();
}
Handle form changing for move memories Doesn't invalidate any of the statements made today. ty @Lusamine for identifying these cases.
2021-08-15 03:20:13 +00:00
internal static IEnumerable<int> GetValidMovesAllForms(PKM pkm, IReadOnlyList<EvoCriteria> chain, GameVersion version, int generation, MoveSourceType types, bool RemoveTransferHM, int species, List<int> r)
{
// These don't evolve, so don't bother iterating for all entries in the evolution chain (should always be count==1).
int formCount;
// In gen 3 deoxys has different forms depending on the current game, in the PersonalInfo there is no alternate form info
if (pkm.Format == 3 && species == (int) Species.Deoxys)
formCount = 4;
else
formCount = pkm.PersonalInfo.FormCount;
for (int form = 0; form < formCount; form++)
r.AddRange(GetMoves(pkm, species, form, chain[0].Level, 0, 0, version, types, RemoveTransferHM, generation));
if (types.HasFlagFast(MoveSourceType.RelearnMoves))
r.AddRange(pkm.RelearnMoves);
return r.Distinct();
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static IEnumerable<int> GetMoves(PKM pkm, int species, int form, int maxLevel, int minlvlG1, int minlvlG2, GameVersion Version, MoveSourceType types, bool RemoveTransferHM, int generation)
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
{
var r = new List<int>();
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
if (types.HasFlagFast(MoveSourceType.LevelUp))
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
r.AddRange(MoveLevelUp.GetMovesLevelUp(pkm, species, form, maxLevel, minlvlG1, minlvlG2, Version, types.HasFlagFast(MoveSourceType.Reminder), generation));
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
if (types.HasFlagFast(MoveSourceType.Machine))
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
r.AddRange(MoveTechnicalMachine.GetTMHM(pkm, species, form, generation, Version, RemoveTransferHM));
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
if (types.HasFlagFast(MoveSourceType.TechnicalRecord))
r.AddRange(MoveTechnicalMachine.GetRecords(pkm, species, form, generation));
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
if (types.HasFlagFast(MoveSourceType.AllTutors))
r.AddRange(MoveTutor.GetTutorMoves(pkm, species, form, types.HasFlagFast(MoveSourceType.SpecialTutor), generation));
Extract EvoBase and MoveList from Core These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
2020-06-21 00:44:05 +00:00
return r.Distinct();
}
}
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
[Flags]
Minor clean
2020-12-23 17:34:29 +00:00
#pragma warning disable RCS1154 // Sort enum members.
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
public enum MoveSourceType
Minor clean
2020-12-23 17:34:29 +00:00
#pragma warning restore RCS1154 // Sort enum members.
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
{
None,
LevelUp = 1 << 0,
RelearnMoves = 1 << 1,
Machine = 1 << 2,
TypeTutor = 1 << 3,
SpecialTutor = 1 << 4,
EnhancedTutor = 1 << 5,
SharedEggMove = 1 << 6,
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
TechnicalRecord = 1 << 7,
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
AllTutors = TypeTutor | SpecialTutor | EnhancedTutor,
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
AllMachines = Machine | TechnicalRecord,
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
Reminder = LevelUp | RelearnMoves | TechnicalRecord,
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
Encounter = LevelUp | RelearnMoves,
Permit TR flags for "Can Relearn", split branching for TR checks
2020-12-22 17:10:10 +00:00
ExternalSources = Reminder | AllMachines | AllTutors,
Change move source requests from a bunch of bools to bitflag enum little more sane & clear
2020-12-22 05:24:16 +00:00
All = ExternalSources | SharedEggMove | RelearnMoves,
}
public static class MoveSourceTypeExtensions
{
public static bool HasFlagFast(this MoveSourceType value, MoveSourceType flag) => (value & flag) != 0;
public static MoveSourceType ClearNonEggSources(this MoveSourceType value) => value & MoveSourceType.Encounter;
}
Extract move suggest logic, add battleversion clamp Closes #2911
2020-06-27 18:06:28 +00:00
}
Reference in a new issue Copy permalink