Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 04:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Core.cs

951 lines
42 KiB
C#
Raw Normal View History

Refactoring Move fossils check to static encounter apply small amount of inheritance to all encounter types (including mystery gifts) get actual evolution chain to ignore pre-evolution movepools (example Surf Pikachu event gift cannot devolve to Pichu to get Nasty Plot). #694 A little bit of logic has been moved around, but my 5k pkmdb had no change in legal/illegal counts. Hopefully no false positives from this change :thumbsup:
2017-01-04 04:51:33 +00:00
using System;
using System.Collections.Generic;
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
using System.Linq;
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
{
public static partial class Legal
{
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
/// <summary> e-Reader Berry is Enigma or special berry </summary>
public static bool EReaderBerryIsEnigma { get; set; } = true;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
/// <summary> e-Reader Berry Name </summary>
public static string EReaderBerryName { get; set; } = string.Empty;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
/// <summary> e-Reader Berry Name formatted in Title Case </summary>
Misc reorganization Move logical checks using encounter data out of Core.cs might be possible to excise legality checking objects from Legal/PKHeX.Core so that a 'slimmer' core can be made
2018-10-05 01:52:00 +00:00
public static string EReaderBerryDisplayName => string.Format(LegalityCheckStrings.L_XEnigmaBerry_0, Util.ToTitleCase(EReaderBerryName.ToLower()));
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
Add gen1 learnset/evo information Still need encounter info for all 3 games.
2017-02-11 23:20:44 +00:00
// Gen 1
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpRB = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_rb.pkl"), MaxSpeciesID_1);
internal static readonly Learnset[] LevelUpY = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_y.pkl"), MaxSpeciesID_1);
Add gen1 learnset/evo information Still need encounter info for all 3 games.
2017-02-11 23:20:44 +00:00
Add gen2 evolutions/learnset
2017-02-25 20:37:01 +00:00
// Gen 2
Add GetEncounterMoves method dictionary mapping common gameversions to their associated obj
2018-03-30 08:02:22 +00:00
internal static readonly EggMoves[] EggMovesGS = EggMoves2.GetArray(Util.GetBinaryResource("eggmove_gs.pkl"), MaxSpeciesID_2);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpGS = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_gs.pkl"), MaxSpeciesID_2);
Add GetEncounterMoves method dictionary mapping common gameversions to their associated obj
2018-03-30 08:02:22 +00:00
internal static readonly EggMoves[] EggMovesC = EggMoves2.GetArray(Util.GetBinaryResource("eggmove_c.pkl"), MaxSpeciesID_2);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpC = LearnsetReader.GetArray(Util.GetBinaryResource("lvlmove_c.pkl"), MaxSpeciesID_2);
Add gen2 evolutions/learnset
2017-02-25 20:37:01 +00:00
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
// Gen 3
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpE = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_e.pkl"), "em"));
internal static readonly Learnset[] LevelUpRS = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_rs.pkl"), "rs"));
internal static readonly Learnset[] LevelUpFR = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_fr.pkl"), "fr"));
internal static readonly Learnset[] LevelUpLG = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_lg.pkl"), "lg"));
internal static readonly EggMoves6[] EggMovesRS = EggMoves6.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_rs.pkl"), "rs"));
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
// Gen 4
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpDP = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_dp.pkl"), "dp"));
internal static readonly Learnset[] LevelUpPt = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_pt.pkl"), "pt"));
internal static readonly Learnset[] LevelUpHGSS = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_hgss.pkl"), "hs"));
internal static readonly EggMoves6[] EggMovesDPPt = EggMoves6.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_dppt.pkl"), "dp"));
internal static readonly EggMoves6[] EggMovesHGSS = EggMoves6.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_hgss.pkl"), "hs"));
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
// Gen 5
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly Learnset[] LevelUpBW = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_bw.pkl"), "51"));
internal static readonly Learnset[] LevelUpB2W2 = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_b2w2.pkl"), "52"));
internal static readonly EggMoves6[] EggMovesBW = EggMoves6.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_bw.pkl"), "bw"));
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
// Gen 6
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly EggMoves6[] EggMovesXY = EggMoves6.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_xy.pkl"), "xy"));
internal static readonly Learnset[] LevelUpXY = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_xy.pkl"), "xy"));
internal static readonly EggMoves6[] EggMovesAO = EggMoves6.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_ao.pkl"), "ao"));
internal static readonly Learnset[] LevelUpAO = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_ao.pkl"), "ao"));
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
// Gen 7
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
internal static readonly EggMoves7[] EggMovesSM = EggMoves7.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_sm.pkl"), "sm"));
internal static readonly Learnset[] LevelUpSM = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_sm.pkl"), "sm"));
internal static readonly EggMoves7[] EggMovesUSUM = EggMoves7.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_uu.pkl"), "uu"));
internal static readonly Learnset[] LevelUpUSUM = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_uu.pkl"), "uu"));
internal static readonly Learnset[] LevelUpGG = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_gg.pkl"), "gg"));
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
// Gen 8
Sword/Shield Update
2019-11-16 01:34:18 +00:00
internal static readonly EggMoves7[] EggMovesSWSH = EggMoves7.GetArray(Data.UnpackMini(Util.GetBinaryResource("eggmove_swsh.pkl"), "ss"));
internal static readonly Learnset[] LevelUpSWSH = LearnsetReader.GetArray(Data.UnpackMini(Util.GetBinaryResource("lvlmove_swsh.pkl"), "ss"));
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
// Setup Help
Remove Punishment from Murkrow USUM eggmoves Closes #1829 "In Pokémon Ultra Sun and Ultra Moon, Murkrow is programmed to be able to learn Punishment through breeding, but no other Pokémon in the Flying Group can pass down Punishment as an Egg Move in those games. Vullaby and Mandibuzz are the only Flying Egg Group Pokémon that can learn Punishment, but they cannot pass down the move due to being female-only species."
2018-02-11 02:56:06 +00:00
static Legal()
{
// Misc Fixes to Data pertaining to legality constraints
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
// Remove Punishment from USUM Murkrow (no species can pass it #1829)
// DONE: Egg Move Data for EggMovesUSUM no longer has it at the end
Prevent g7 silvally from learning fire/water pledge https://bulbapedia.bulbagarden.net/wiki/Silvally_(Pok%C3%A9mon)#Trivia has the two bitflags set but the game only tutors the first bitflag it sees
2019-02-20 06:57:07 +00:00
// Prevent Silvally from being tutored Fire/Water Pledge (logic can only tutor one, and Grass is first)
var pi = PersonalTable.USUM[773];
pi.TypeTutors[1] = false; // fire
pi.TypeTutors[2] = false; // water
Remove Punishment from Murkrow USUM eggmoves Closes #1829 "In Pokémon Ultra Sun and Ultra Moon, Murkrow is programmed to be able to learn Punishment through breeding, but no other Pokémon in the Flying Group can pass down Punishment as an Egg Move in those games. Vullaby and Mandibuzz are the only Flying Egg Group Pokémon that can learn Punishment, but they cannot pass down the move due to being female-only species."
2018-02-11 02:56:06 +00:00
}
Refactoring relocate gift data storage out of legal.cs
2018-03-06 06:19:56 +00:00
public static void RefreshMGDB(string localDbPath) => EncounterEvent.RefreshMGDB(localDbPath);
Converted PKHeX.Core to .Net Standard Refactored and rearranged things as needed to allow the change
2017-05-12 04:34:18 +00:00
Rework initial evochain trim push unsaved IVTotal/EVTotal stuff from prior commit rework exposed types for evo chain initial trim now uses much less linq can probably redo the get initial chain to provide a species to break on...
2018-06-23 00:59:02 +00:00
internal static List<int>[] GetValidMovesAllGens(PKM pkm, IReadOnlyList<EvoCriteria>[] evoChains, int minLvLG1 = 1, int minLvLG2 = 1, bool LVL = true, bool Tutor = true, bool Machine = true, bool MoveReminder = true, bool RemoveTransferHM = true)
Add getValidMovesAllGens to return the valid moves list from every valid generation from a pokemon instead of one list with all generations mixed, for crossgen legal analysis
2017-03-25 12:27:42 +00:00
{
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
var Moves = new List<int>[evoChains.Length];
Add getValidMovesAllGens to return the valid moves list from every valid generation from a pokemon instead of one list with all generations mixed, for crossgen legal analysis
2017-03-25 12:27:42 +00:00
for (int i = 1; i < evoChains.Length; i++)
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
{
Rework initial evochain trim push unsaved IVTotal/EVTotal stuff from prior commit rework exposed types for evo chain initial trim now uses much less linq can probably redo the get initial chain to provide a species to break on...
2018-06-23 00:59:02 +00:00
if (evoChains[i].Count != 0)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Moves[i] = GetValidMoves(pkm, evoChains[i], i, minLvLG1, minLvLG2, LVL, Tutor, Machine, MoveReminder, RemoveTransferHM).ToList();
Fix bad evo tree not creating move arrays
2017-03-26 05:23:54 +00:00
else
Moves[i] = new List<int>();
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
}
Add getValidMovesAllGens to return the valid moves list from every valid generation from a pokemon instead of one list with all generations mixed, for crossgen legal analysis
2017-03-25 12:27:42 +00:00
return Moves;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring Split evolution data specific DexLevel properties from DexLevel use IReadOnlyList instead of IList for covariant collection
2018-06-19 02:10:21 +00:00
internal static IEnumerable<int> GetValidMoves(PKM pkm, IReadOnlyList<EvoCriteria>[] evoChains, bool LVL = true, bool Tutor = true, bool Machine = true, bool MoveReminder = true, bool RemoveTransferHM = true)
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
{
Finish fix for gameversion passing
2016-11-09 06:10:32 +00:00
GameVersion version = (GameVersion)pkm.Version;
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
if (!pkm.IsUntraded)
Finish fix for gameversion passing
2016-11-09 06:10:32 +00:00
version = GameVersion.Any;
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
return GetValidMoves(pkm, version, evoChains, minLvLG1: 1, minLvLG2: 1, LVL: LVL, Relearn: false, Tutor: Tutor, Machine: Machine, MoveReminder: MoveReminder, RemoveTransferHM: RemoveTransferHM);
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring Split evolution data specific DexLevel properties from DexLevel use IReadOnlyList instead of IList for covariant collection
2018-06-19 02:10:21 +00:00
internal static IEnumerable<int> GetValidMoves(PKM pkm, IReadOnlyList<EvoCriteria> evoChain, int generation, int minLvLG1 = 1, int minLvLG2 = 1, bool LVL = true, bool Tutor = true, bool Machine = true, bool MoveReminder = true, bool RemoveTransferHM = true)
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
{
GameVersion version = (GameVersion)pkm.Version;
if (!pkm.IsUntraded)
version = GameVersion.Any;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetValidMoves(pkm, version, evoChain, generation, minLvLG1: minLvLG1, minLvLG2: minLvLG2, LVL: LVL, Relearn: false, Tutor: Tutor, Machine: Machine, MoveReminder: MoveReminder, RemoveTransferHM: RemoveTransferHM);
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
internal static IEnumerable<int> GetValidRelearn(PKM pkm, int species, int form, GameVersion version = GameVersion.Any)
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
{
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
return GetValidRelearn(pkm, species, form, GetCanInheritMoves(species), version);
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
}
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
internal static IEnumerable<int> GetValidRelearn(PKM pkm, int species, int form, bool inheritlvlmoves, GameVersion version = GameVersion.Any)
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
{
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
var r = new List<int> { 0 };
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
if (pkm.GenNumber < 6)
Add rby encounters Includes fishing slots todo on trades/static encounters; feel free to pull request (look at tables6/7 for ref).
2017-02-12 17:52:26 +00:00
return r;
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
r.AddRange(MoveEgg.GetRelearnLVLMoves(pkm, species, 1, form, version));
Fix alolan form egg move fetch
2016-11-12 06:13:40 +00:00
if (pkm.Format == 6 && pkm.Species != 678)
form = 0;
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
r.AddRange(MoveEgg.GetEggMoves(pkm, species, form, version));
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
if (inheritlvlmoves)
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
r.AddRange(MoveEgg.GetRelearnLVLMoves(pkm, species, 100, form, version));
Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
return r.Distinct();
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
misc updates use arrays instead of list when capacity known use enums for const decoration remove unnecessary aliases
2018-09-02 02:55:08 +00:00
internal static int[] GetShedinjaEvolveMoves(PKM pkm, int generation, int lvl = -1)
Shedinja evolution moves and some egg fixes (#1015) * Add getMoves function with min level and max level, usefull for shedjina evolves moves (min level 20) and generation 1 moves ( no move reminder, min level is min encounter level + 1) Also for gen1 encounters another function should be created to get by the encounter level the four moves that the pokemon learn by default, the last four in its movepool up until the encounter level * getShedinjaEvolveMoves, function that return the moves that shedinja could learn from Ninjask move pool at the moment when Nincada evolves, in the same format that getValidMovesAllGens * Add validation in parse moves for shedinja evolve moves. Shedinja could have any gen3/4 moves from Ninjas learnset but only one is allowed * Shedinja evolve moves text resources * Fix egg moves pre-gen 6 validation: Add skipoption variable to getEggMoves function from pre-gen6 games, to verify egg moves from split breed species Flag illegal combinations of base egg moves and special egg moves Return crystal egg moves for gen2 pokemon that can be tradeback to gen 1 games * Fix for mix between event egg moves and base egg moves * Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move * Revert "Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move" Revert the last change, i search in bulbapedia an there wasn't any nincada distributed with special moves in generation 3 nor 4, making this complicated validation unnecessary This reverts commit 57f5ac1bbb75e32e417b575619339cae5e5d1ef2. * Fix error
2017-04-01 00:40:30 +00:00
{
if (lvl == -1)
lvl = pkm.CurrentLevel;
if (pkm.Species != 292 || lvl < 20)
misc updates use arrays instead of list when capacity known use enums for const decoration remove unnecessary aliases
2018-09-02 02:55:08 +00:00
return Array.Empty<int>();
Misc simplifications Segregate gen4 transfer legality check from encounter detection reorder EncounterSlot[] match test to be before EncounterStatic. Closes #1016 Fix manaphy gift handling
2017-04-01 01:35:43 +00:00
Shedinja evolution moves and some egg fixes (#1015) * Add getMoves function with min level and max level, usefull for shedjina evolves moves (min level 20) and generation 1 moves ( no move reminder, min level is min encounter level + 1) Also for gen1 encounters another function should be created to get by the encounter level the four moves that the pokemon learn by default, the last four in its movepool up until the encounter level * getShedinjaEvolveMoves, function that return the moves that shedinja could learn from Ninjask move pool at the moment when Nincada evolves, in the same format that getValidMovesAllGens * Add validation in parse moves for shedinja evolve moves. Shedinja could have any gen3/4 moves from Ninjas learnset but only one is allowed * Shedinja evolve moves text resources * Fix egg moves pre-gen 6 validation: Add skipoption variable to getEggMoves function from pre-gen6 games, to verify egg moves from split breed species Flag illegal combinations of base egg moves and special egg moves Return crystal egg moves for gen2 pokemon that can be tradeback to gen 1 games * Fix for mix between event egg moves and base egg moves * Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move * Revert "Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move" Revert the last change, i search in bulbapedia an there wasn't any nincada distributed with special moves in generation 3 nor 4, making this complicated validation unnecessary This reverts commit 57f5ac1bbb75e32e417b575619339cae5e5d1ef2. * Fix error
2017-04-01 00:40:30 +00:00
// If nincada evolves into Ninjask an learn in the evolution a move from ninjask learnset pool
// Shedinja would appear with that move learned. Only one move above level 20 allowed, only in generations 3 and 4
Misc simplifications Segregate gen4 transfer legality check from encounter detection reorder EncounterSlot[] match test to be before EncounterStatic. Closes #1016 Fix manaphy gift handling
2017-04-01 01:35:43 +00:00
switch (generation)
Shedinja evolution moves and some egg fixes (#1015) * Add getMoves function with min level and max level, usefull for shedjina evolves moves (min level 20) and generation 1 moves ( no move reminder, min level is min encounter level + 1) Also for gen1 encounters another function should be created to get by the encounter level the four moves that the pokemon learn by default, the last four in its movepool up until the encounter level * getShedinjaEvolveMoves, function that return the moves that shedinja could learn from Ninjask move pool at the moment when Nincada evolves, in the same format that getValidMovesAllGens * Add validation in parse moves for shedinja evolve moves. Shedinja could have any gen3/4 moves from Ninjas learnset but only one is allowed * Shedinja evolve moves text resources * Fix egg moves pre-gen 6 validation: Add skipoption variable to getEggMoves function from pre-gen6 games, to verify egg moves from split breed species Flag illegal combinations of base egg moves and special egg moves Return crystal egg moves for gen2 pokemon that can be tradeback to gen 1 games * Fix for mix between event egg moves and base egg moves * Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move * Revert "Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move" Revert the last change, i search in bulbapedia an there wasn't any nincada distributed with special moves in generation 3 nor 4, making this complicated validation unnecessary This reverts commit 57f5ac1bbb75e32e417b575619339cae5e5d1ef2. * Fix error
2017-04-01 00:40:30 +00:00
{
Misc simplifications Segregate gen4 transfer legality check from encounter detection reorder EncounterSlot[] match test to be before EncounterStatic. Closes #1016 Fix manaphy gift handling
2017-04-01 01:35:43 +00:00
case 3: // Ninjask have the same learnset in every gen 3 games
if (pkm.InhabitedGeneration(3))
misc updates use arrays instead of list when capacity known use enums for const decoration remove unnecessary aliases
2018-09-02 02:55:08 +00:00
return LevelUpE[291].GetMoves(lvl, 20);
Misc simplifications Segregate gen4 transfer legality check from encounter detection reorder EncounterSlot[] match test to be before EncounterStatic. Closes #1016 Fix manaphy gift handling
2017-04-01 01:35:43 +00:00
break;
case 4: // Ninjask have the same learnset in every gen 4 games
if (pkm.InhabitedGeneration(4))
Update shedinja ninjask move checks check level of source moves for any incompatibility in non-bred cases. Closes #1805
2018-02-02 03:57:02 +00:00
return LevelUpPt[291].GetMoves(lvl, 20);
Misc simplifications Segregate gen4 transfer legality check from encounter detection reorder EncounterSlot[] match test to be before EncounterStatic. Closes #1016 Fix manaphy gift handling
2017-04-01 01:35:43 +00:00
break;
Shedinja evolution moves and some egg fixes (#1015) * Add getMoves function with min level and max level, usefull for shedjina evolves moves (min level 20) and generation 1 moves ( no move reminder, min level is min encounter level + 1) Also for gen1 encounters another function should be created to get by the encounter level the four moves that the pokemon learn by default, the last four in its movepool up until the encounter level * getShedinjaEvolveMoves, function that return the moves that shedinja could learn from Ninjask move pool at the moment when Nincada evolves, in the same format that getValidMovesAllGens * Add validation in parse moves for shedinja evolve moves. Shedinja could have any gen3/4 moves from Ninjas learnset but only one is allowed * Shedinja evolve moves text resources * Fix egg moves pre-gen 6 validation: Add skipoption variable to getEggMoves function from pre-gen6 games, to verify egg moves from split breed species Flag illegal combinations of base egg moves and special egg moves Return crystal egg moves for gen2 pokemon that can be tradeback to gen 1 games * Fix for mix between event egg moves and base egg moves * Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move * Revert "Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move" Revert the last change, i search in bulbapedia an there wasn't any nincada distributed with special moves in generation 3 nor 4, making this complicated validation unnecessary This reverts commit 57f5ac1bbb75e32e417b575619339cae5e5d1ef2. * Fix error
2017-04-01 00:40:30 +00:00
}
misc updates use arrays instead of list when capacity known use enums for const decoration remove unnecessary aliases
2018-09-02 02:55:08 +00:00
return Array.Empty<int>();
Update shedinja ninjask move checks check level of source moves for any incompatibility in non-bred cases. Closes #1805
2018-02-02 03:57:02 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Update shedinja ninjask move checks check level of source moves for any incompatibility in non-bred cases. Closes #1805
2018-02-02 03:57:02 +00:00
internal static int GetShedinjaMoveLevel(int species, int move, int generation)
{
var src = generation == 4 ? LevelUpPt : LevelUpE;
var moves = src[species];
return moves.GetLevelLearnMove(move);
Shedinja evolution moves and some egg fixes (#1015) * Add getMoves function with min level and max level, usefull for shedjina evolves moves (min level 20) and generation 1 moves ( no move reminder, min level is min encounter level + 1) Also for gen1 encounters another function should be created to get by the encounter level the four moves that the pokemon learn by default, the last four in its movepool up until the encounter level * getShedinjaEvolveMoves, function that return the moves that shedinja could learn from Ninjask move pool at the moment when Nincada evolves, in the same format that getValidMovesAllGens * Add validation in parse moves for shedinja evolve moves. Shedinja could have any gen3/4 moves from Ninjas learnset but only one is allowed * Shedinja evolve moves text resources * Fix egg moves pre-gen 6 validation: Add skipoption variable to getEggMoves function from pre-gen6 games, to verify egg moves from split breed species Flag illegal combinations of base egg moves and special egg moves Return crystal egg moves for gen2 pokemon that can be tradeback to gen 1 games * Fix for mix between event egg moves and base egg moves * Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move * Revert "Changes just to make if there is only shedinja evolve move that is also the only base egg move change it from base egg move to evolve move, to avoid flag illegal if also the pokemon have a special egg move" Revert the last change, i search in bulbapedia an there wasn't any nincada distributed with special moves in generation 3 nor 4, making this complicated validation unnecessary This reverts commit 57f5ac1bbb75e32e417b575619339cae5e5d1ef2. * Fix error
2017-04-01 00:40:30 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
internal static int[] GetBaseEggMoves(PKM pkm, int species, int form, GameVersion gameSource, int lvl)
Add Bank event checking
2016-03-06 19:19:09 +00:00
{
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
if (gameSource == GameVersion.Any)
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
gameSource = (GameVersion)pkm.Version;
Add more stringent wc6 comparators
2016-03-22 02:53:02 +00:00
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
switch (gameSource)
Add more stringent wc6 comparators
2016-03-22 02:53:02 +00:00
{
Add egg base move branch Closes #1991 Thanks @iiippppk ! Improve pk2 version detect to better provide gs vs c egg base moves
2018-06-11 14:23:48 +00:00
case GameVersion.GSC:
Fix levelup egg pre-relearnmove check Closes #991
2017-03-26 02:57:38 +00:00
case GameVersion.GS:
usum prep Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks
2017-09-01 05:37:28 +00:00
// If checking back-transfer specimen (GSC->RBY), remove moves that must be deleted prior to transfer
int[] getRBYCompatibleMoves(int[] moves) => pkm.Format == 1 ? moves.Where(m => m <= MaxMoveID_1).ToArray() : moves;
Fix levelup egg pre-relearnmove check Closes #991
2017-03-26 02:57:38 +00:00
if (pkm.InhabitedGeneration(2))
usum prep Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks
2017-09-01 05:37:28 +00:00
return getRBYCompatibleMoves(LevelUpGS[species].GetMoves(lvl));
Fix levelup egg pre-relearnmove check Closes #991
2017-03-26 02:57:38 +00:00
break;
case GameVersion.C:
if (pkm.InhabitedGeneration(2))
usum prep Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks
2017-09-01 05:37:28 +00:00
return getRBYCompatibleMoves(LevelUpC[species].GetMoves(lvl));
Fix levelup egg pre-relearnmove check Closes #991
2017-03-26 02:57:38 +00:00
break;
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
case GameVersion.R:
case GameVersion.S:
case GameVersion.RS:
if (pkm.InhabitedGeneration(3))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpRS[species].GetMoves(lvl);
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
break;
case GameVersion.E:
if (pkm.InhabitedGeneration(3))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpE[species].GetMoves(lvl);
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
break;
case GameVersion.FR:
case GameVersion.LG:
case GameVersion.FRLG:
// only difference in FR/LG is deoxys which doesn't breed.
if (pkm.InhabitedGeneration(3))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpFR[species].GetMoves(lvl);
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
break;
case GameVersion.D:
case GameVersion.P:
case GameVersion.DP:
if (pkm.InhabitedGeneration(4))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpDP[species].GetMoves(lvl);
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
break;
case GameVersion.Pt:
if (pkm.InhabitedGeneration(4))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpPt[species].GetMoves(lvl);
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
break;
case GameVersion.HG:
case GameVersion.SS:
case GameVersion.HGSS:
if (pkm.InhabitedGeneration(4))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpHGSS[species].GetMoves(lvl);
Fix egg move check for 3-5 Inherited levelup moves now properly checked adds gen5 levelup cases updates nickname check for all caps nicknames
2017-03-25 02:24:01 +00:00
break;
case GameVersion.B:
case GameVersion.W:
case GameVersion.BW:
if (pkm.InhabitedGeneration(5))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpBW[species].GetMoves(lvl);
Fix egg move check for 3-5 Inherited levelup moves now properly checked adds gen5 levelup cases updates nickname check for all caps nicknames
2017-03-25 02:24:01 +00:00
break;
case GameVersion.B2:
case GameVersion.W2:
case GameVersion.B2W2:
if (pkm.InhabitedGeneration(5))
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
return LevelUpB2W2[species].GetMoves(lvl);
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
break;
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
case GameVersion.X:
case GameVersion.Y:
case GameVersion.XY:
if (pkm.InhabitedGeneration(6))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpXY[species].GetMoves(lvl);
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
break;
Refactor, Check WC6 evos, Check WC6 egg Moved the wc6 fetch logic, added event egg; added a little linq finesse and things are clean! Added features and cleaned with 0 net lines :+1:
2016-03-05 04:43:00 +00:00
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
case GameVersion.AS:
case GameVersion.OR:
case GameVersion.ORAS:
if (pkm.InhabitedGeneration(6))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpAO[species].GetMoves(lvl);
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
break;
Add more stringent wc6 comparators
2016-03-22 02:53:02 +00:00
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
case GameVersion.SN:
case GameVersion.MN:
case GameVersion.SM:
Add maxspecies checks for gen7 accesses arrays outside the range for the new USUM species Closes #1631 , add test case also adds lycanroc test cases for #1630
2017-11-19 05:50:48 +00:00
if (species > MaxSpeciesID_7)
break;
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
if (pkm.InhabitedGeneration(7))
usum prep Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks
2017-09-01 05:37:28 +00:00
{
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
int index = PersonalTable.SM.GetFormeIndex(species, form);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return LevelUpSM[index].GetMoves(lvl);
usum prep Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks
2017-09-01 05:37:28 +00:00
}
break;
case GameVersion.US:
case GameVersion.UM:
case GameVersion.USUM:
if (pkm.InhabitedGeneration(7))
{
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
int index = PersonalTable.USUM.GetFormeIndex(species, form);
usum prep Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks
2017-09-01 05:37:28 +00:00
return LevelUpUSUM[index].GetMoves(lvl);
}
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
break;
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
case GameVersion.SW:
case GameVersion.SH:
case GameVersion.SWSH:
if (pkm.InhabitedGeneration(8))
{
Add Form (AltForm) to IEncounterable interface All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452
2019-11-19 06:20:55 +00:00
int index = PersonalTable.SWSH.GetFormeIndex(species, form);
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
return LevelUpSWSH[index].GetMoves(lvl);
}
break;
Add more stringent wc6 comparators
2016-03-22 02:53:02 +00:00
}
Remove unnecessary empty array allocations yay net 4.6 read more: http://justinvp.com/2015/07/20/array-empty/
2018-08-02 01:30:51 +00:00
return Array.Empty<int>();
Refactor, Check WC6 evos, Check WC6 egg Moved the wc6 fetch logic, added event egg; added a little linq finesse and things are clean! Added features and cleaned with 0 net lines :+1:
2016-03-05 04:43:00 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
internal static List<int> GetValidPostEvolutionMoves(PKM pkm, int species, IReadOnlyList<EvoCriteria>[] evoChains, GameVersion Version)
Check moves for pokemon that evolved leveling up while learning a specific move, if they have 4 moves they must have at least the move that make them evolve or one move that can be learned after evolving Fix generation 4 static encounters for those that have none encounter and those with not encounter type implemented yet Fix comprobation of encounter type is static to include the new typed class
2017-04-23 12:54:52 +00:00
{
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
// Return moves that the pokemon could learn after evolving
Check moves for pokemon that evolved leveling up while learning a specific move, if they have 4 moves they must have at least the move that make them evolve or one move that can be learned after evolving Fix generation 4 static encounters for those that have none encounter and those with not encounter type implemented yet Fix comprobation of encounter type is static to include the new typed class
2017-04-23 12:54:52 +00:00
var moves = new List<int>();
for (int i = 1; i < evoChains.Length; i++)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Rework initial evochain trim push unsaved IVTotal/EVTotal stuff from prior commit rework exposed types for evo chain initial trim now uses much less linq can probably redo the get initial chain to provide a species to break on...
2018-06-23 00:59:02 +00:00
if (evoChains[i].Count != 0)
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
moves.AddRange(GetValidPostEvolutionMoves(pkm, species, evoChains[i], i, Version));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Check moves for pokemon that evolved leveling up while learning a specific move, if they have 4 moves they must have at least the move that make them evolve or one move that can be learned after evolving Fix generation 4 static encounters for those that have none encounter and those with not encounter type implemented yet Fix comprobation of encounter type is static to include the new typed class
2017-04-23 12:54:52 +00:00
if (pkm.GenNumber >= 6)
moves.AddRange(pkm.RelearnMoves.Where(m => m != 0));
return moves.Distinct().ToList();
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
private static List<int> GetValidPostEvolutionMoves(PKM pkm, int species, IReadOnlyList<EvoCriteria> evoChain, int generation, GameVersion Version)
Check moves for pokemon that evolved leveling up while learning a specific move, if they have 4 moves they must have at least the move that make them evolve or one move that can be learned after evolving Fix generation 4 static encounters for those that have none encounter and those with not encounter type implemented yet Fix comprobation of encounter type is static to include the new typed class
2017-04-23 12:54:52 +00:00
{
var evomoves = new List<int>();
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
var index = EvolutionChain.GetEvoChainSpeciesIndex(evoChain, species);
Reduced for in getValidPostEvolutionMoves
2017-04-23 14:48:23 +00:00
for (int i = 0; i <= index; i++)
Check moves for pokemon that evolved leveling up while learning a specific move, if they have 4 moves they must have at least the move that make them evolve or one move that can be learned after evolving Fix generation 4 static encounters for those that have none encounter and those with not encounter type implemented yet Fix comprobation of encounter type is static to include the new typed class
2017-04-23 12:54:52 +00:00
{
var evo = evoChain[i];
Fix darumaka->darmanitan blizzard move #2416 Looks like the only issues left are: Shedinja Crossover/Bleed locations Static Encounter locations
2019-11-24 06:48:02 +00:00
var moves = GetMoves(pkm, evo.Species, 1, 1, evo.Level, evo.Form, moveTutor: true, Version: Version, LVL: true, specialTutors: true, Machine: true, MoveReminder: true, RemoveTransferHM: false, generation: generation);
Reduced for in getValidPostEvolutionMoves
2017-04-23 14:48:23 +00:00
// Moves from Species or any species after in the evolution phase
evomoves.AddRange(moves);
Check moves for pokemon that evolved leveling up while learning a specific move, if they have 4 moves they must have at least the move that make them evolve or one move that can be learned after evolving Fix generation 4 static encounters for those that have none encounter and those with not encounter type implemented yet Fix comprobation of encounter type is static to include the new typed class
2017-04-23 12:54:52 +00:00
}
return evomoves;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
internal static IEnumerable<int> GetExclusivePreEvolutionMoves(PKM pkm, int Species, IReadOnlyList<EvoCriteria> evoChain, int generation, GameVersion Version)
Split Breed Egg Moves improvements (#1058) * Added method getBaseEggSpecies to get the base species when the pokemon was an egg, is needed because for format 1 pokemon with egg origin every time getBaseSpecies is called is returning the gen 1 base species obtaining invalid eggmoves and base egg moves Also getBaseEggSpecies was using Evolves1 when format = 1 even when asking for a gen2 egg base species, returning Pikachu egg moves (empty list) instead of Pichu egg moves * Fix ability checking for generation 3 pokemon, likea de Seadra from Issue #1011 pkm.AbilityNumber have a value assuming PID match ability like a generation 4 pokemon but the validation should be ignored if is a generation 3 pokemon with only one ability in generation 3 Also changed the validation for ingame trades with fixed abilities to check only with generation 3 abilities in the case the species has two abilities generation 3, if only one was possible any PID should be valid with the generation 3 ability Encounter Trades Also the check for evolution was wrong, the most evolved species is the first in the evochain, not the last * Fix evoltuion chains for gen 3 pokemon in format 4 * Fix ability for generation 3 trades. Ability could not change if there were 2 abilities in generation 3, that means it is irrelevant if the pokemon evolved in gen 4-5, the ability number must match the encounter * Added missing skipOption to a call to getBaseEggSpecies * Functions to obtain moves excluvie to preevolutions, like moves that Azurill/Happiny could learn throught level up or TM but Marill/Chansey could not learn, icompatible with any Marill/Chansey egg moves Also add functions to return egg moves and base egg moves for both possible species for split breed eggs * Check both species from split breed egg at the same time to report moves incompatibilities * Reduced generation 4-5 was egg game check There is no need to check every possible generation game. For every egg species HGSS learnset tables y egg moves table contains all the moves from the same species in DP and Pt, without any move exclusive to that games except in legendaries, and they cant breed In generation 5 is the same with B2W2 except for Exxegutte, it have a exclusive level up move from B1W1, Psychic, but it can learn the move with TM, it wont count as an egg move * Check incompatible split breed moves in verify relearn egg * Fix generation 1 incompatibility moves check SolarBeam removed from Exeggcute/Exeggutor incompatiblity, Exeggutor could learn it with a TM in generation 1 Removed Vaporeon Mist and Eevee Take Down incompatiblity, Vaporeon could learn Take Down with a TM in generation 1
2017-04-14 17:11:50 +00:00
{
var preevomoves = new List<int>();
var evomoves = new List<int>();
Rework initial evochain trim push unsaved IVTotal/EVTotal stuff from prior commit rework exposed types for evo chain initial trim now uses much less linq can probably redo the get initial chain to provide a species to break on...
2018-06-23 00:59:02 +00:00
var index = EvolutionChain.GetEvoChainSpeciesIndex(evoChain, Species);
for (int i = 0; i < evoChain.Count; i++)
Split Breed Egg Moves improvements (#1058) * Added method getBaseEggSpecies to get the base species when the pokemon was an egg, is needed because for format 1 pokemon with egg origin every time getBaseSpecies is called is returning the gen 1 base species obtaining invalid eggmoves and base egg moves Also getBaseEggSpecies was using Evolves1 when format = 1 even when asking for a gen2 egg base species, returning Pikachu egg moves (empty list) instead of Pichu egg moves * Fix ability checking for generation 3 pokemon, likea de Seadra from Issue #1011 pkm.AbilityNumber have a value assuming PID match ability like a generation 4 pokemon but the validation should be ignored if is a generation 3 pokemon with only one ability in generation 3 Also changed the validation for ingame trades with fixed abilities to check only with generation 3 abilities in the case the species has two abilities generation 3, if only one was possible any PID should be valid with the generation 3 ability Encounter Trades Also the check for evolution was wrong, the most evolved species is the first in the evochain, not the last * Fix evoltuion chains for gen 3 pokemon in format 4 * Fix ability for generation 3 trades. Ability could not change if there were 2 abilities in generation 3, that means it is irrelevant if the pokemon evolved in gen 4-5, the ability number must match the encounter * Added missing skipOption to a call to getBaseEggSpecies * Functions to obtain moves excluvie to preevolutions, like moves that Azurill/Happiny could learn throught level up or TM but Marill/Chansey could not learn, icompatible with any Marill/Chansey egg moves Also add functions to return egg moves and base egg moves for both possible species for split breed eggs * Check both species from split breed egg at the same time to report moves incompatibilities * Reduced generation 4-5 was egg game check There is no need to check every possible generation game. For every egg species HGSS learnset tables y egg moves table contains all the moves from the same species in DP and Pt, without any move exclusive to that games except in legendaries, and they cant breed In generation 5 is the same with B2W2 except for Exxegutte, it have a exclusive level up move from B1W1, Psychic, but it can learn the move with TM, it wont count as an egg move * Check incompatible split breed moves in verify relearn egg * Fix generation 1 incompatibility moves check SolarBeam removed from Exeggcute/Exeggutor incompatiblity, Exeggutor could learn it with a TM in generation 1 Removed Vaporeon Mist and Eevee Take Down incompatiblity, Vaporeon could learn Take Down with a TM in generation 1
2017-04-14 17:11:50 +00:00
{
var evo = evoChain[i];
Fix darumaka->darmanitan blizzard move #2416 Looks like the only issues left are: Shedinja Crossover/Bleed locations Static Encounter locations
2019-11-24 06:48:02 +00:00
var moves = GetMoves(pkm, evo.Species, 1, 1, evo.Level, evo.Form, moveTutor: true, Version: Version, LVL: true, specialTutors: true, Machine: true, MoveReminder: true, RemoveTransferHM: false, generation: generation);
More refactoring simplify some expressions, reduce repeat operations
2017-09-02 06:45:47 +00:00
var list = i >= index ? preevomoves : evomoves;
list.AddRange(moves);
Split Breed Egg Moves improvements (#1058) * Added method getBaseEggSpecies to get the base species when the pokemon was an egg, is needed because for format 1 pokemon with egg origin every time getBaseSpecies is called is returning the gen 1 base species obtaining invalid eggmoves and base egg moves Also getBaseEggSpecies was using Evolves1 when format = 1 even when asking for a gen2 egg base species, returning Pikachu egg moves (empty list) instead of Pichu egg moves * Fix ability checking for generation 3 pokemon, likea de Seadra from Issue #1011 pkm.AbilityNumber have a value assuming PID match ability like a generation 4 pokemon but the validation should be ignored if is a generation 3 pokemon with only one ability in generation 3 Also changed the validation for ingame trades with fixed abilities to check only with generation 3 abilities in the case the species has two abilities generation 3, if only one was possible any PID should be valid with the generation 3 ability Encounter Trades Also the check for evolution was wrong, the most evolved species is the first in the evochain, not the last * Fix evoltuion chains for gen 3 pokemon in format 4 * Fix ability for generation 3 trades. Ability could not change if there were 2 abilities in generation 3, that means it is irrelevant if the pokemon evolved in gen 4-5, the ability number must match the encounter * Added missing skipOption to a call to getBaseEggSpecies * Functions to obtain moves excluvie to preevolutions, like moves that Azurill/Happiny could learn throught level up or TM but Marill/Chansey could not learn, icompatible with any Marill/Chansey egg moves Also add functions to return egg moves and base egg moves for both possible species for split breed eggs * Check both species from split breed egg at the same time to report moves incompatibilities * Reduced generation 4-5 was egg game check There is no need to check every possible generation game. For every egg species HGSS learnset tables y egg moves table contains all the moves from the same species in DP and Pt, without any move exclusive to that games except in legendaries, and they cant breed In generation 5 is the same with B2W2 except for Exxegutte, it have a exclusive level up move from B1W1, Psychic, but it can learn the move with TM, it wont count as an egg move * Check incompatible split breed moves in verify relearn egg * Fix generation 1 incompatibility moves check SolarBeam removed from Exeggcute/Exeggutor incompatiblity, Exeggutor could learn it with a TM in generation 1 Removed Vaporeon Mist and Eevee Take Down incompatiblity, Vaporeon could learn Take Down with a TM in generation 1
2017-04-14 17:11:50 +00:00
}
Refactoring Remove duplication of levelup fetch relocate some stuff to a more appropriate area
2018-06-10 17:44:05 +00:00
return preevomoves.Except(evomoves).Distinct();
Split Breed Egg Moves improvements (#1058) * Added method getBaseEggSpecies to get the base species when the pokemon was an egg, is needed because for format 1 pokemon with egg origin every time getBaseSpecies is called is returning the gen 1 base species obtaining invalid eggmoves and base egg moves Also getBaseEggSpecies was using Evolves1 when format = 1 even when asking for a gen2 egg base species, returning Pikachu egg moves (empty list) instead of Pichu egg moves * Fix ability checking for generation 3 pokemon, likea de Seadra from Issue #1011 pkm.AbilityNumber have a value assuming PID match ability like a generation 4 pokemon but the validation should be ignored if is a generation 3 pokemon with only one ability in generation 3 Also changed the validation for ingame trades with fixed abilities to check only with generation 3 abilities in the case the species has two abilities generation 3, if only one was possible any PID should be valid with the generation 3 ability Encounter Trades Also the check for evolution was wrong, the most evolved species is the first in the evochain, not the last * Fix evoltuion chains for gen 3 pokemon in format 4 * Fix ability for generation 3 trades. Ability could not change if there were 2 abilities in generation 3, that means it is irrelevant if the pokemon evolved in gen 4-5, the ability number must match the encounter * Added missing skipOption to a call to getBaseEggSpecies * Functions to obtain moves excluvie to preevolutions, like moves that Azurill/Happiny could learn throught level up or TM but Marill/Chansey could not learn, icompatible with any Marill/Chansey egg moves Also add functions to return egg moves and base egg moves for both possible species for split breed eggs * Check both species from split breed egg at the same time to report moves incompatibilities * Reduced generation 4-5 was egg game check There is no need to check every possible generation game. For every egg species HGSS learnset tables y egg moves table contains all the moves from the same species in DP and Pt, without any move exclusive to that games except in legendaries, and they cant breed In generation 5 is the same with B2W2 except for Exxegutte, it have a exclusive level up move from B1W1, Psychic, but it can learn the move with TM, it wont count as an egg move * Check incompatible split breed moves in verify relearn egg * Fix generation 1 incompatibility moves check SolarBeam removed from Exeggcute/Exeggutor incompatiblity, Exeggutor could learn it with a TM in generation 1 Removed Vaporeon Mist and Eevee Take Down incompatiblity, Vaporeon could learn Take Down with a TM in generation 1
2017-04-14 17:11:50 +00:00
}
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Remove WasEgg setter WasEgg (aka WasDefinitelyAnEgg) from stored properties is one thing, WasEgg from encounter info is another; don't mix
2019-07-26 00:42:15 +00:00
internal static bool GetCanBeEgg23(PKM pkm)
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
{
If pokemon is transfer from gen 3 to 4 or latter and it can be from an egg (pokeball 4, level and met level above 5, etc) check always for an egg encounter first, if does not match egg encounter then check other encounters When verify moves for this pokemon it here is a non egg possible encounter first check moves from that encounter and if does not match check egg encounters Also for gen 2 unhatched eggs ignore gen 1 encounters
2017-03-26 22:11:09 +00:00
if (pkm.IsEgg)
return true;
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
if (pkm.Format > 2 && pkm.Ball != 4)
return false;
int lvl = pkm.CurrentLevel;
if (lvl < 5)
return false;
Refactoring readability++
2017-09-04 20:48:10 +00:00
if (pkm.Format > 3 && pkm.Met_Level < 5)
If pokemon is transfer from gen 3 to 4 or latter and it can be from an egg (pokeball 4, level and met level above 5, etc) check always for an egg encounter first, if does not match egg encounter then check other encounters When verify moves for this pokemon it here is a non egg possible encounter first check moves from that encounter and if does not match check egg encounters Also for gen 2 unhatched eggs ignore gen 1 encounters
2017-03-26 22:11:09 +00:00
return false;
Fix issue #1001 Changed verifyEncounterG3Transfer, when both Egg Result and other Result happens Egg only overwrite if is the only valid encounter Corrections in verifyEncounterG3Transfer also adding code to check gen 3 WasEvent pokemon, but for now it will return Mistery Gift not found Changed verifyEncounterG3Transfer and verifyEncounterG4Transfer to return both message error for InvalidTransfer and G3/G4 invalid encounter if both errors happen at the same time Excluded fateful encounter pokemon from getWasEgg23, it can be WasEgg pokemon because FatefulEncounter from eggs is lost when hatch
2017-03-27 19:10:30 +00:00
if (pkm.Format > 3 && pkm.FatefulEncounter)
return false;
If pokemon is transfer from gen 3 to 4 or latter and it can be from an egg (pokeball 4, level and met level above 5, etc) check always for an egg encounter first, if does not match egg encounter then check other encounters When verify moves for this pokemon it here is a non egg possible encounter first check moves from that encounter and if does not match check egg encounters Also for gen 2 unhatched eggs ignore gen 1 encounters
2017-03-26 22:11:09 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return IsEvolutionValid(pkm);
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
}
Method reordering Nothing changed, just organization.
2016-03-23 05:50:54 +00:00
Use byte for pp value storage more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-11 05:05:57 +00:00
public static IReadOnlyList<byte> GetPPTable(PKM pkm, int format)
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
{
Use byte for pp value storage more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-11 05:05:57 +00:00
if (format != 7)
return GetPPTable(format);
return pkm.GG ? MovePP_GG : MovePP_SM;
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
}
Use byte for pp value storage more appropriate storage; for 3887 indexes -> saves 11.3KB
2019-04-11 05:05:57 +00:00
public static IReadOnlyList<byte> GetPPTable(int format)
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return format switch
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => MovePP_RBY,
2 => MovePP_GSC,
3 => MovePP_RS,
4 => MovePP_DP,
5 => MovePP_BW,
6 => MovePP_XY,
7 => MovePP_SM,
8 => MovePP_SWSH,
_ => Array.Empty<byte>()
};
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
}
hashset contains over array contains faster++, reduces some linq ToArray() allocations
2017-09-30 21:08:35 +00:00
internal static ICollection<int> GetWildBalls(PKM pkm)
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return pkm.GenNumber switch
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => WildPokeBalls1,
2 => WildPokeBalls2,
3 => WildPokeBalls3,
4 => (pkm.HGSS ? WildPokeBalls4_HGSS : WildPokeBalls4_DPPt),
5 => WildPokeBalls5,
6 => WildPokeballs6,
7 => (pkm.GG ? WildPokeballs7b : WildPokeballs7),
8 => WildPokeballs8,
_ => (ICollection<int>)Array.Empty<int>()
};
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
internal static int GetEggHatchLevel(PKM pkm) => GetEggHatchLevel(pkm.Format);
internal static int GetEggHatchLevel(int gen) => gen <= 3 ? 5 : 1;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
internal static ICollection<int> GetSplitBreedGeneration(int generation)
Verify egg moves from gen 2 to 5 pokemon inside egg with a algorithm similar to verify relearn moves. Egg moves should have fist the base egg moves and after that inherited egg moves, with base egg moves present if there are less that 4 egg moves. Also for special eggs like gift and events every special moves should be present after base egg moves but should not have any egg move that are not included in the special moves list
2017-03-26 13:39:09 +00:00
{
switch (generation)
{
case 3: return SplitBreed_3;
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
Refactoring Relocate & simplify some logic
2018-06-22 03:13:41 +00:00
case 4:
case 5:
case 6:
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
case 7:
case 8:
return SplitBreed;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
default: return Array.Empty<int>();
Verify egg moves from gen 2 to 5 pokemon inside egg with a algorithm similar to verify relearn moves. Egg moves should have fist the base egg moves and after that inherited egg moves, with base egg moves present if there are less that 4 egg moves. Also for special eggs like gift and events every special moves should be present after base egg moves but should not have any egg move that are not included in the special moves list
2017-03-26 13:39:09 +00:00
}
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static int GetMaxSpeciesOrigin(PKM pkm)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Weaken gen2 egg species checks for pre-evos in gen1 VC can inhabit both gens Add Tradeback setting setter for legality tests Add GBCartEra setting setter for legality tests Thanks @iiippppk !
2018-06-13 01:46:31 +00:00
if (pkm.Format == 1)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetMaxSpeciesOrigin(1);
Weaken gen2 egg species checks for pre-evos in gen1 VC can inhabit both gens Add Tradeback setting setter for legality tests Add GBCartEra setting setter for legality tests Thanks @iiippppk !
2018-06-13 01:46:31 +00:00
if (pkm.Format == 2 || pkm.VC)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetMaxSpeciesOrigin(2);
return GetMaxSpeciesOrigin(pkm.GenNumber);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static int GetMaxSpeciesOrigin(int generation)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => MaxSpeciesID_1,
2 => MaxSpeciesID_2,
3 => MaxSpeciesID_3,
4 => MaxSpeciesID_4,
5 => MaxSpeciesID_5,
6 => MaxSpeciesID_6,
7 => MaxSpeciesID_7b,
8 => MaxSpeciesID_8,
_ => -1
};
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
internal static ICollection<int> GetFutureGenEvolutions(int generation)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => FutureEvolutionsGen1,
2 => FutureEvolutionsGen2,
3 => FutureEvolutionsGen3,
4 => FutureEvolutionsGen4,
5 => FutureEvolutionsGen5,
_ => (ICollection<int>)Array.Empty<int>()
};
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
internal static int GetDebutGeneration(int species)
{
if (species <= MaxSpeciesID_1)
return 1;
if (species <= MaxSpeciesID_2)
return 2;
if (species <= MaxSpeciesID_3)
return 3;
if (species <= MaxSpeciesID_4)
return 4;
if (species <= MaxSpeciesID_5)
return 5;
if (species <= MaxSpeciesID_6)
return 6;
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
if (species <= MaxSpeciesID_7b)
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
return 7;
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
if (species <= MaxSpeciesID_8)
return 8;
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
return -1;
}
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
internal static int GetMaxLanguageID(int generation)
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => (int) LanguageID.Spanish, // 1-7 except 6
3 => (int) LanguageID.Spanish, // 1-7 except 6
2 => (int) LanguageID.Korean,
4 => (int) LanguageID.Korean,
5 => (int) LanguageID.Korean,
6 => (int) LanguageID.Korean,
7 => (int) LanguageID.ChineseT,
8 => (int) LanguageID.ChineseT,
_ => -1
};
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private static bool[] GetReleasedHeldItems(int generation)
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return generation switch
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
2 => ReleasedHeldItems_2,
3 => ReleasedHeldItems_3,
4 => ReleasedHeldItems_4,
5 => ReleasedHeldItems_5,
6 => ReleasedHeldItems_6,
7 => ReleasedHeldItems_7,
8 => ReleasedHeldItems_8,
_ => Array.Empty<bool>()
};
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring continued reduction in Core size, simplify/clean up usages
2018-06-10 21:45:25 +00:00
internal static bool IsHeldItemAllowed(PKM pkm)
{
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
if (pkm is PB7)
return pkm.HeldItem == 0;
Refactoring continued reduction in Core size, simplify/clean up usages
2018-06-10 21:45:25 +00:00
return IsHeldItemAllowed(pkm.HeldItem, pkm.Format);
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring continued reduction in Core size, simplify/clean up usages
2018-06-10 21:45:25 +00:00
private static bool IsHeldItemAllowed(int item, int generation)
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
{
if (item == 0)
return true;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
if (item < 0)
return false;
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var items = GetReleasedHeldItems(generation);
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
return items.Length > item && items[item];
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private static bool IsEvolvedFormChange(PKM pkm)
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
{
Flag evo stone evolved pkm in eggs Evolution stone pkm at level 1 slipped through (example Ninetails) while levelup evos were already caught. Add the check to getValidPreEvolutions as well as other evolution method checks. Closes #827
2017-02-05 21:08:25 +00:00
if (pkm.IsEgg)
return false;
Misc tweaks mark SOS slots for usum, only permit varied alolan evos to be forme changed (blocks totem raticate from being matched to non totem forme inputs)
2017-11-10 00:18:26 +00:00
if (pkm.Format >= 7 && AlolanVariantEvolutions12.Contains(pkm.Species))
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
return pkm.AltForm == 1;
Sword/Shield Update
2019-11-16 01:34:18 +00:00
if (pkm.Format >= 8)
{
if (GalarVariantFormEvolutions.Contains(pkm.Species))
return pkm.AltForm == 1;
if (GalarForm0Evolutions.TryGetValue(pkm.Species, out var orig))
return pkm.AltForm != orig; // bad compare?
Catch some evolution edge cases
2019-11-18 06:04:41 +00:00
if ((int) Species.Toxtricity == pkm.Species)
return pkm.AltForm == EvolutionMethod.GetAmpLowKeyResult(pkm.Nature);
Sword/Shield Update
2019-11-16 01:34:18 +00:00
}
Catch some evolution edge cases
2019-11-18 06:04:41 +00:00
if ((pkm.Species == (int)Species.Meowstic || pkm.Species == (int)Species.Indeedee) && pkm.Gender == 1)
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
return pkm.AltForm == 1;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
return pkm.Species == 773;
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework initial evochain trim push unsaved IVTotal/EVTotal stuff from prior commit rework exposed types for evo chain initial trim now uses much less linq can probably redo the get initial chain to provide a species to break on...
2018-06-23 00:59:02 +00:00
internal static bool IsTradeEvolved(IReadOnlyList<EvoCriteria>[] chain, int pkmFormat)
Method reordering Nothing changed, just organization.
2016-03-23 05:50:54 +00:00
{
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
return chain[pkmFormat].Any(z => z.IsTradeRequired);
Method reordering Nothing changed, just organization.
2016-03-23 05:50:54 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Add evolution minbound check https://projectpokemon.org/home/forums/topic/44834-bugabout-event-evolution/?do=findComment&comment=229887 (espeon at level 50 originating from a level 50 eevee gift is not valid)
2018-04-18 03:06:23 +00:00
internal static bool IsEvolutionValid(PKM pkm, int minSpecies = -1, int minLevel = -1)
Add egg level check Catches level 12 charizards and level 50 tyranitars that were bred
2016-04-08 01:19:21 +00:00
{
Provide min level to evochain fetch Feels pretty brittle with all the optional parameters; if things get funky for SW/SH it may warrant a rewrite of this portion Closes #2345 ty @iiippppk !
2019-07-02 15:34:28 +00:00
var curr = EvolutionChain.GetValidPreEvolutions(pkm, minLevel: minLevel);
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
var min = curr.FindLast(z => z.Species == minSpecies);
Add evolution minbound check https://projectpokemon.org/home/forums/topic/44834-bugabout-event-evolution/?do=findComment&comment=229887 (espeon at level 50 originating from a level 50 eevee gift is not valid)
2018-04-18 03:06:23 +00:00
if (min != null && min.Level < minLevel)
return false;
Provide min level to evochain fetch Feels pretty brittle with all the optional parameters; if things get funky for SW/SH it may warrant a rewrite of this portion Closes #2345 ty @iiippppk !
2019-07-02 15:34:28 +00:00
var poss = EvolutionChain.GetValidPreEvolutions(pkm, lvl: 100, minLevel: minLevel, skipChecks: true);
Add egg level check Catches level 12 charizards and level 50 tyranitars that were bred
2016-04-08 01:19:21 +00:00
Misc fixes enhance evolution checking add gen2 game corner static encounters simplify relearn checking methods that did the same thing
2017-05-29 22:21:39 +00:00
if (minSpecies != -1)
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
{
int last = poss.FindLastIndex(z => z.Species == minSpecies);
return curr.Count >= last;
}
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
int gen = pkm.GenNumber;
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
if (gen >= 3 && GetSplitBreedGeneration(gen).Contains(GetBaseSpecies(pkm, poss, 1).Species))
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
return curr.Count >= poss.Count - 1;
return curr.Count >= poss.Count;
Add egg level check Catches level 12 charizards and level 50 tyranitars that were bred
2016-04-08 01:19:21 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static bool IsEvolutionValidWithMove(PKM pkm, LegalInfo info)
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
{
// Exclude species that do not evolve leveling with a move
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
// Exclude gen 1-3 formats
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
// Exclude Mr. Mime and Snorlax for gen 1-3 games
var gen = info.Generation;
if (!SpeciesEvolutionWithMove.Contains(pkm.Species) || pkm.Format <= 3 || (BabyEvolutionWithMove.Contains(pkm.Species) && gen <= 3))
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
return true;
var index = Array.FindIndex(SpeciesEvolutionWithMove, p => p == pkm.Species);
var levels = MinLevelEvolutionWithMove[index];
var moves = MoveEvolutionWithMove[index];
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
var allowegg = EggMoveEvolutionWithMove[index][gen];
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
// Get the minimum level in any generation when the pokemon could learn the evolve move
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
var LearnLevel = 101;
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
for (int g = gen; g <= pkm.Format; g++)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
if (pkm.InhabitedGeneration(g) && levels[g] > 0)
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
LearnLevel = Math.Min(LearnLevel, levels[g]);
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
// Check also if the current encounter include the evolve move as an special move
// That means the pokemon have the move from the encounter level
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
if (info.EncounterMatch is IMoveset s && s.Moves.Any(m => moves.Contains(m)))
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
LearnLevel = Math.Min(LearnLevel, info.EncounterMatch.LevelMin);
// If the encounter is a player hatched egg check if the move could be an egg move or inherited level up move
if (info.EncounterMatch.EggEncounter && !pkm.WasGiftEgg && !pkm.WasEventEgg && allowegg)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (IsMoveInherited(pkm, info, moves))
Minor clean cache Generation value, store arceus stuff as ushort
2019-04-17 05:14:21 +00:00
LearnLevel = Math.Min(LearnLevel, gen <= 3 ? 6 : 2);
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
}
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
// If has original met location the minimum evolution level is one level after met level
// Gen 3 pokemon in gen 4 games: minimum level is one level after transfer to generation 4
// VC pokemon: minimum level is one level after transfer to generation 7
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
// Sylveon: always one level after met level, for gen 4 and 5 eevees in gen 6 games minimum for evolution is one level after transfer to generation 5
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
if (pkm.HasOriginalMetLocation || (pkm.Format == 4 && pkm.Gen3) || pkm.VC || pkm.Species == 700)
Fix issue #1200 and added speculation for Gen2 VC without move reminder (#1201) * Fix issue #1200 Minimum level for evolution moves in generation 7 is 2 thanks to the move reminder, also the evolution could be trigger at the minimum level and not the next level, except when the minimum level is the met level * Gen 2 VC Speculation, it wont have Move Reminder because the only gen 2 move reminder was in Pokemon Stadium 2 * Missing variable * Fix update generation 2 level moves
2017-06-07 23:15:13 +00:00
LearnLevel = Math.Max(pkm.Met_Level + 1, LearnLevel);
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
Fix issue #1200 and added speculation for Gen2 VC without move reminder (#1201) * Fix issue #1200 Minimum level for evolution moves in generation 7 is 2 thanks to the move reminder, also the evolution could be trigger at the minimum level and not the next level, except when the minimum level is the met level * Gen 2 VC Speculation, it wont have Move Reminder because the only gen 2 move reminder was in Pokemon Stadium 2 * Missing variable * Fix update generation 2 level moves
2017-06-07 23:15:13 +00:00
// Current level must be at least one the minimum learn level
// the level-up event that triggers the learning of the move also triggers evolution with no further level-up required
return pkm.CurrentLevel >= LearnLevel;
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private static bool IsMoveInherited(PKM pkm, LegalInfo info, int[] moves)
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
{
// In 3DS games, the inherited move must be in the relearn moves.
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
if (info.Generation >= 6)
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
return pkm.RelearnMoves.Any(moves.Contains);
// In Pre-3DS games, the move is inherited if it has the move and it can be hatched with the move.
if (pkm.Moves.Any(moves.Contains))
return true;
// If the pokemon does not have the move, it still could be an egg move that was forgotten.
// This requires the pokemon to not have 4 other moves identified as egg moves or inherited level up moves.
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return 4 > info.Moves.Count(m => m.Source == MoveSource.EggMove || m.Source == MoveSource.InheritLevelUp);
Cleanup little bit of simplification
2017-06-07 03:52:21 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Fix Zygarde Aura Break formechange detect original was AltForm != 1, 0 is also invalid so >1 suffices. remove parameter from method & update usages
2018-02-04 05:12:36 +00:00
internal static bool IsFormChangeable(PKM pkm, int species)
Add zygarde forme change->core ability in gen7 Closes #868
2017-02-21 05:19:25 +00:00
{
if (FormChange.Contains(species))
return true;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (IsEvolvedFormChange(pkm))
Add zygarde forme change->core ability in gen7 Closes #868
2017-02-21 05:19:25 +00:00
return true;
Fix Zygarde Aura Break formechange detect original was AltForm != 1, 0 is also invalid so >1 suffices. remove parameter from method & update usages
2018-02-04 05:12:36 +00:00
if (species == 718 && pkm.InhabitedGeneration(7) && pkm.AltForm > 1)
Add zygarde forme change->core ability in gen7 Closes #868
2017-02-21 05:19:25 +00:00
return true;
return false;
}
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
internal static bool GetCanInheritMoves(int species)
Refactor split gender breeding logic Inherit Levelup moves & hidden ability (gen5) issues addressed
2017-09-15 01:52:31 +00:00
{
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
if (FixedGenderFromBiGender.Contains(species)) // Nincada -> Shedinja loses gender causing 'false', edge case
Refactor split gender breeding logic Inherit Levelup moves & hidden ability (gen5) issues addressed
2017-09-15 01:52:31 +00:00
return true;
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
var pi = PKX.Personal[species];
if (!pi.Genderless && !pi.OnlyMale)
Refactor split gender breeding logic Inherit Levelup moves & hidden ability (gen5) issues addressed
2017-09-15 01:52:31 +00:00
return true;
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
if (MixedGenderBreeding.Contains(species))
Refactor split gender breeding logic Inherit Levelup moves & hidden ability (gen5) issues addressed
2017-09-15 01:52:31 +00:00
return true;
return false;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactor level-evolution checks slightly Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred
2017-08-29 01:12:57 +00:00
public static int GetLowestLevel(PKM pkm, int startLevel)
Add getLowestLevel check, optional level param Multiple methods can now override the appropriate level checks with a defined level
2016-12-01 06:06:41 +00:00
{
Refactor level-evolution checks slightly Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred
2017-08-29 01:12:57 +00:00
if (startLevel == -1)
startLevel = 100;
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
var table = EvolutionTree.GetEvolutionTree(pkm, pkm.Format);
Refactor level-evolution checks slightly Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred
2017-08-29 01:12:57 +00:00
int count = 1;
for (int i = 100; i >= startLevel; i--)
Add getLowestLevel check, optional level param Multiple methods can now override the appropriate level checks with a defined level
2016-12-01 06:06:41 +00:00
{
Misc simplifications cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method
2018-07-04 16:15:20 +00:00
var evos = table.GetValidPreEvolutions(pkm, maxLevel: i, minLevel: startLevel, skipChecks: true);
de-linq some evolution dexlevel fetch use shared IList interface instead of IEnumerable
2018-04-18 02:56:43 +00:00
if (evos.Count < count) // lost an evolution, prior level was minimum current level
Refactor level-evolution checks slightly Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred
2017-08-29 01:12:57 +00:00
return evos.Max(evo => evo.Level) + 1;
de-linq some evolution dexlevel fetch use shared IList interface instead of IEnumerable
2018-04-18 02:56:43 +00:00
count = evos.Count;
Add getLowestLevel check, optional level param Multiple methods can now override the appropriate level checks with a defined level
2016-12-01 06:06:41 +00:00
}
Refactor level-evolution checks slightly Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred
2017-08-29 01:12:57 +00:00
return startLevel;
Add getLowestLevel check, optional level param Multiple methods can now override the appropriate level checks with a defined level
2016-12-01 06:06:41 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static bool GetCanLearnMachineMove(PKM pkm, int move, int generation, GameVersion version = GameVersion.Any)
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
{
Refactoring Relocate Evolution Chain logic minor reorg of check arguments for nesting / grouping
2018-06-20 00:14:22 +00:00
return GetValidMoves(pkm, version, EvolutionChain.GetValidPreEvolutions(pkm), generation, Machine: true).Contains(move);
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static bool GetCanRelearnMove(PKM pkm, int move, int generation, GameVersion version = GameVersion.Any)
Add Memory 21 None of my database mons even had this memory :\
2016-05-10 01:19:31 +00:00
{
Refactoring Relocate Evolution Chain logic minor reorg of check arguments for nesting / grouping
2018-06-20 00:14:22 +00:00
return GetValidMoves(pkm, version, EvolutionChain.GetValidPreEvolutions(pkm), generation, LVL: true, Relearn: true).Contains(move);
Cleanup Commit the rest of the code why github
2016-05-10 02:24:52 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static bool GetCanKnowMove(PKM pkm, int move, int generation, GameVersion version = GameVersion.Any)
Cleanup Commit the rest of the code why github
2016-05-10 02:24:52 +00:00
{
Enhance IEncounterable list summarization separates by type (wild, egg, etc) then groups by generation, listing the locations and games that can obtain it in that location
2019-03-20 05:05:13 +00:00
if (pkm.Species == 235)
return !InvalidSketch.Contains(move);
Refactoring Relocate Evolution Chain logic minor reorg of check arguments for nesting / grouping
2018-06-20 00:14:22 +00:00
return GetValidMoves(pkm, version, EvolutionChain.GetValidPreEvolutions(pkm), generation, LVL: true, Relearn: true, Tutor: true, Machine: true).Contains(move);
Add Memory 21 None of my database mons even had this memory :\
2016-05-10 01:19:31 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
internal static EvoCriteria GetBaseEggSpecies(PKM pkm, int skipOption = 0)
Fix legality issues (#1055) * Added method getBaseEggSpecies to get the base species when the pokemon was an egg, is needed because for format 1 pokemon with egg origin every time getBaseSpecies is called is returning the gen 1 base species obtaining invalid eggmoves and base egg moves Also getBaseEggSpecies was using Evolves1 when format = 1 even when asking for a gen2 egg base species, returning Pikachu egg moves (empty list) instead of Pichu egg moves * Fix ability checking for generation 3 pokemon, likea de Seadra from Issue #1011 pkm.AbilityNumber have a value assuming PID match ability like a generation 4 pokemon but the validation should be ignored if is a generation 3 pokemon with only one ability in generation 3 Also changed the validation for ingame trades with fixed abilities to check only with generation 3 abilities in the case the species has two abilities generation 3, if only one was possible any PID should be valid with the generation 3 ability Encounter Trades Also the check for evolution was wrong, the most evolved species is the first in the evochain, not the last * Fix evolution chains for gen 3 pokemon in format 4 * Fix ability for generation 3 trades. Ability could not change if there were 2 abilities in generation 3, that means it is irrelevant if the pokemon evolved in gen 4-5, the ability number must match the encounter
2017-04-13 15:48:13 +00:00
{
if (pkm.Format == 1)
Refactoring Remove duplication of levelup fetch relocate some stuff to a more appropriate area
2018-06-10 17:44:05 +00:00
return GetBaseSpecies(pkm, generation: 2);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetBaseSpecies(pkm, skipOption);
Fix legality issues (#1055) * Added method getBaseEggSpecies to get the base species when the pokemon was an egg, is needed because for format 1 pokemon with egg origin every time getBaseSpecies is called is returning the gen 1 base species obtaining invalid eggmoves and base egg moves Also getBaseEggSpecies was using Evolves1 when format = 1 even when asking for a gen2 egg base species, returning Pikachu egg moves (empty list) instead of Pichu egg moves * Fix ability checking for generation 3 pokemon, likea de Seadra from Issue #1011 pkm.AbilityNumber have a value assuming PID match ability like a generation 4 pokemon but the validation should be ignored if is a generation 3 pokemon with only one ability in generation 3 Also changed the validation for ingame trades with fixed abilities to check only with generation 3 abilities in the case the species has two abilities generation 3, if only one was possible any PID should be valid with the generation 3 ability Encounter Trades Also the check for evolution was wrong, the most evolved species is the first in the evochain, not the last * Fix evolution chains for gen 3 pokemon in format 4 * Fix ability for generation 3 trades. Ability could not change if there were 2 abilities in generation 3, that means it is irrelevant if the pokemon evolved in gen 4-5, the ability number must match the encounter
2017-04-13 15:48:13 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
internal static EvoCriteria GetBaseSpecies(PKM pkm, int skipOption = 0, int generation = -1)
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
{
Refactoring now that the logic has become more stable, polish away some complexity
2017-07-29 18:54:52 +00:00
int tree = generation != -1 ? generation : pkm.Format;
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
var table = EvolutionTree.GetEvolutionTree(pkm, tree);
add overloads for GetPossible Remove edge case handling for level 2 blissey; updates over the past 2 (yay 2 years of legality checking) can now handle that case without special handling.
2018-05-10 03:37:11 +00:00
int maxSpeciesOrigin = generation != -1 ? GetMaxSpeciesOrigin(generation) : -1;
var evos = table.GetValidPreEvolutions(pkm, maxLevel: 100, maxSpeciesOrigin: maxSpeciesOrigin, skipChecks: true);
Refactoring discards, Array.Find over FirstOrDefault
2018-05-12 15:41:23 +00:00
return GetBaseSpecies(pkm, evos, skipOption);
add overloads for GetPossible Remove edge case handling for level 2 blissey; updates over the past 2 (yay 2 years of legality checking) can now handle that case without special handling.
2018-05-10 03:37:11 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
internal static EvoCriteria GetBaseSpecies(PKM pkm, IReadOnlyList<EvoCriteria> evos, int skipOption = 0) => GetBaseSpecies(pkm.Species, evos, skipOption);
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
private static readonly EvoCriteria Nincada = new EvoCriteria
add overloads for GetPossible Remove edge case handling for level 2 blissey; updates over the past 2 (yay 2 years of legality checking) can now handle that case without special handling.
2018-05-10 03:37:11 +00:00
{
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
Method = (int) EvolutionType.LevelUp,
MinLevel = 20, Level = 20,
RequiresLvlUp = true,
Species = 290, Form = 0,
};
private static readonly EvoCriteria EvoEmpty = new EvoCriteria
{
Method = (int)EvolutionType.None,
Species = 0,
Form = 0,
};
internal static EvoCriteria GetBaseSpecies(int species, IReadOnlyList<EvoCriteria> evos, int skipOption = 0)
{
if (species == (int)Species.Shedinja) // Shedinja
return Nincada; // Nincada
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
// skip n from end, return species if invalid index
int index = evos.Count - 1 - skipOption;
Rework GetBaseSpecies to return EvoCriteria #2452
2019-11-19 04:26:11 +00:00
return (uint)index >= evos.Count ? EvoEmpty : evos[index];
Add encounter slot checking, edge case handling So much information is needed to check a given aspect that it's best to just pass the pk6 around to functions.
2016-02-26 15:52:08 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private static int GetMaxLevelGeneration(PKM pkm)
Create a function to obtain the max and min possible level a given pokemon could have in a given generation
2017-02-16 10:59:07 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return GetMaxLevelGeneration(pkm, pkm.GenNumber);
Create a function to obtain the max and min possible level a given pokemon could have in a given generation
2017-02-16 10:59:07 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private static int GetMaxLevelGeneration(PKM pkm, int generation)
Create a function to obtain the max and min possible level a given pokemon could have in a given generation
2017-02-16 10:59:07 +00:00
{
if (!pkm.InhabitedGeneration(generation))
Tweak level/origin check for moves Valid species/movepools are already determined via the dexlevel and prior methods, no need to check again with current species. edge case: sing froslass from CXD won't check gen3 moves (ie, sing)
2017-06-27 03:30:44 +00:00
return pkm.Met_Level;
Create a function to obtain the max and min possible level a given pokemon could have in a given generation
2017-02-16 10:59:07 +00:00
if (pkm.Format <= 2)
{
if (generation == 1 && FutureEvolutionsGen1_Gen2LevelUp.Contains(pkm.Species))
return pkm.CurrentLevel - 1;
return pkm.CurrentLevel;
}
if (pkm.Species == 700 && generation == 5)
return pkm.CurrentLevel - 1;
Names changed to avoid confusions
2017-03-26 16:45:01 +00:00
if (pkm.Gen3 && pkm.Format > 4 && pkm.Met_Level == pkm.CurrentLevel && FutureEvolutionsGen3_LevelUpGen4.Contains(pkm.Species))
Create a function to obtain the max and min possible level a given pokemon could have in a given generation
2017-02-16 10:59:07 +00:00
return pkm.Met_Level - 1;
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if (!pkm.HasOriginalMetLocation)
return pkm.Met_Level;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
return pkm.CurrentLevel;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
internal static int GetMinLevelEncounter(PKM pkm)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
{
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
// Only for gen 3 pokemon in format 3, after transfer to gen 4 it should return transfer level
Fix for special moves with invalid move list order Fix for minum level for gen 3 pokemon met as egg Temporal fix for pokemon box encounters
2017-03-26 16:05:58 +00:00
if (pkm.Format == 3 && pkm.WasEgg)
return 5;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
// Only for gen 4 pokemon in format 4, after transfer to gen 5 it should return transfer level
Misc tweaks fix roamer3 not setting IVs fix usum z items rightmost pixel getting chopped off use Gen* instead of GenNumber for specific cases (faster) add WasGiftEgg location case for Gen7 remove some unnecessary array allocations
2017-11-18 06:19:23 +00:00
if (pkm.Format == 4 && pkm.Gen4 && pkm.WasEgg)
Fix for Manaphy Egg Gen 4 event encounter - changed trade egg location in mystery gift search - adapted getMinLevelEncounter to take into account gen 4 eggs in gen 4 games - remvoed manaphy for static encounters, is already included in event database - fix no hatching for an egg check for gen 4 manaphy
2017-03-30 18:58:30 +00:00
return 1;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return pkm.HasOriginalMetLocation ? pkm.Met_Level : GetMaxLevelGeneration(pkm);
Create a function to obtain the max and min possible level a given pokemon could have in a given generation
2017-02-16 10:59:07 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc parse settings reorg makes it more centralized for defining parsing settings, maybe can have flags to change severity of certain preferential checks
2018-10-06 02:58:30 +00:00
internal static bool IsCatchRateHeldItem(int rate) => ParseSettings.AllowGen1Tradeback && HeldItems_GSC.Contains((ushort) rate);
Update catch rate related logic #2071
2018-07-25 02:33:42 +00:00
Refactoring Split evolution data specific DexLevel properties from DexLevel use IReadOnlyList instead of IList for covariant collection
2018-06-19 02:10:21 +00:00
private static IEnumerable<int> GetValidMoves(PKM pkm, GameVersion Version, IReadOnlyList<IReadOnlyList<EvoCriteria>> vs, int minLvLG1 = 1, int minLvLG2 = 1, bool LVL = false, bool Relearn = false, bool Tutor = false, bool Machine = false, bool MoveReminder = true, bool RemoveTransferHM = true)
Split move fetch into more flexible methods Allows the use of one method to filter move sources
2016-05-10 02:03:58 +00:00
{
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
var r = new List<int> { 0 };
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if (Relearn && pkm.Format >= 6)
r.AddRange(pkm.RelearnMoves);
Handle bad gennumber indexes Maybe returning 0 for "bad gen" will prevent bad array indexing...
2019-10-19 03:50:38 +00:00
int start = pkm.GenNumber;
if (start < 0)
start = pkm.Format; // be generous instead of returning nothing
for (int gen = start; gen <= pkm.Format; gen++)
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
{
de-linq some evolution dexlevel fetch use shared IList interface instead of IEnumerable
2018-04-18 02:56:43 +00:00
if (vs[gen].Count != 0)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
r.AddRange(GetValidMoves(pkm, Version, vs[gen], gen, minLvLG1: minLvLG1, minLvLG2: minLvLG2, LVL: LVL, Relearn: false, Tutor: Tutor, Machine: Machine, MoveReminder: MoveReminder, RemoveTransferHM: RemoveTransferHM));
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
}
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Cleanup union / count usages remove unnecessary stuff
2017-10-07 04:03:23 +00:00
return r.Distinct();
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
private static IEnumerable<int> GetValidMoves(PKM pkm, GameVersion Version, IReadOnlyList<EvoCriteria> vs, int generation, int minLvLG1 = 1, int minLvLG2 = 1, bool LVL = false, bool Relearn = false, bool Tutor = false, bool Machine = false, bool MoveReminder = true, bool RemoveTransferHM = true)
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
{
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
var r = new List<int> { 0 };
de-linq some evolution dexlevel fetch use shared IList interface instead of IEnumerable
2018-04-18 02:56:43 +00:00
if (vs.Count == 0)
Use the list of evolution chains from every generation to search valid moves from a given pokemon
2017-02-15 22:33:59 +00:00
return r;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int species = pkm.Species;
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Split move fetch into more flexible methods Allows the use of one method to filter move sources
2016-05-10 02:03:58 +00:00
if (FormChangeMoves.Contains(species)) // Deoxys & Shaymin & Giratina (others don't have extra but whatever)
{
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
// These don't evolve, so don't bother iterating for all entries in the evolution chain (should always be count==1).
int formcount;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc qol updates Check max case for level first, then iterate upwards (eliminates inner if) change wc* nature to sbyte (update comparisons, 0xFF too magic-y) use Rand.Next(x) instead of (0, x)
2018-10-28 04:59:31 +00:00
// In gen 3 deoxys has different forms depending on the current game, in the PersonalInfo there is no alternate form info
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
if (pkm.Format == 3 && species == 386)
Fix deoxys forms to get moves in gen3 format, there is no format info for deoxys in the gen 3 personal tables because deoxys have only 1 form available per game
2017-03-30 19:34:48 +00:00
formcount = 4;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
else
formcount = pkm.PersonalInfo.FormeCount;
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Split move fetch into more flexible methods Allows the use of one method to filter move sources
2016-05-10 02:03:58 +00:00
for (int i = 0; i < formcount; i++)
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
r.AddRange(GetMoves(pkm, species, minLvLG1, minLvLG2, vs[0].Level, i, Tutor, Version, LVL, Tutor, Machine, MoveReminder, RemoveTransferHM, generation));
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
if (Relearn)
r.AddRange(pkm.RelearnMoves);
Misc tweaks Remove duplicated SAV pkm set method (byte[] instead of PKM, was unused. All it did was getPKM(decryptPKM(data)).) Tweak Seen/Caught count expression body to use the HasPokeDex bool, as GB(A) games did not use the PokeDex int offset. Things were simpler back then :) Remove unnecessary toarrays fix 3->4 items being deleted even if they were valid be nice and allow held item to transfer 4->5 if it can still be held invert purification values, heart gauge is [-100,0] not [0,100]
2017-03-17 04:20:06 +00:00
return r.Distinct();
Split move fetch into more flexible methods Allows the use of one method to filter move sources
2016-05-10 02:03:58 +00:00
}
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
// Special Type Tutors Availability
bool moveTutor = Tutor || MoveReminder; // Usually true, except when called for move suggestions (no tutored moves)
de-linq some evolution dexlevel fetch use shared IList interface instead of IEnumerable
2018-04-18 02:56:43 +00:00
for (var i = 0; i < vs.Count; i++)
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
{
Refactoring Split evolution data specific DexLevel properties from DexLevel use IReadOnlyList instead of IList for covariant collection
2018-06-19 02:10:21 +00:00
var evo = vs[i];
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
var moves = GetEvoMoves(pkm, Version, vs, generation, minLvLG1, minLvLG2, LVL, Tutor, Machine, MoveReminder, RemoveTransferHM, moveTutor, i, evo);
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
r.AddRange(moves);
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
}
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
Misc fixes Fix volt tackle tutor for pikachu in gen6 (missing parenthesis) fix rb fishing table species list stop performing gen7 checks on pk1s add special move check (do future games have encounters with 2+ special moves)? properly handle amnesiaduck/surfchu still missing ingame trades lol
2017-02-14 06:49:32 +00:00
if (pkm.Format <= 3)
Misc tweaks Remove duplicated SAV pkm set method (byte[] instead of PKM, was unused. All it did was getPKM(decryptPKM(data)).) Tweak Seen/Caught count expression body to use the HasPokeDex bool, as GB(A) games did not use the PokeDex int offset. Things were simpler back then :) Remove unnecessary toarrays fix 3->4 items being deleted even if they were valid be nice and allow held item to transfer 4->5 if it can still be held invert purification values, heart gauge is [-100,0] not [0,100]
2017-03-17 04:20:06 +00:00
return r.Distinct();
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
Include the special moves in the filters of level moves and move reminder to avoid duplicates when executing getValidMoves multiple times Also filter those special moves by generation, to avoid return a gen 5 move when gen 4 is solicitied, even if that only could happen with illegal pokemons
2017-02-15 23:56:54 +00:00
if (LVL)
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
MoveTutor.AddSpecialFormChangeMoves(r, pkm, generation, species);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if (Tutor)
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
MoveTutor.AddSpecialTutorMoves(r, pkm, generation, species);
if (Relearn && generation >= 6)
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
r.AddRange(pkm.RelearnMoves);
Misc tweaks Remove duplicated SAV pkm set method (byte[] instead of PKM, was unused. All it did was getPKM(decryptPKM(data)).) Tweak Seen/Caught count expression body to use the HasPokeDex bool, as GB(A) games did not use the PokeDex int offset. Things were simpler back then :) Remove unnecessary toarrays fix 3->4 items being deleted even if they were valid be nice and allow held item to transfer 4->5 if it can still be held invert purification values, heart gauge is [-100,0] not [0,100]
2017-03-17 04:20:06 +00:00
return r.Distinct();
Split move fetch into more flexible methods Allows the use of one method to filter move sources
2016-05-10 02:03:58 +00:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
private static IEnumerable<int> GetEvoMoves(PKM pkm, GameVersion Version, IReadOnlyList<EvoCriteria> vs, int generation, int minLvLG1, int minLvLG2, bool LVL, bool Tutor, bool Machine, bool MoveReminder, bool RemoveTransferHM, bool moveTutor, int i, EvoCriteria evo)
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
{
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
int minlvlevo1 = GetEvoMoveMinLevel1(pkm, generation, minLvLG1, evo);
int minlvlevo2 = GetEvoMoveMinLevel2(pkm, generation, minLvLG2, evo);
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
var maxLevel = evo.Level;
if (i != 0 && vs[i - 1].RequiresLvlUp) // evolution
++maxLevel; // allow lvlmoves from the level it evolved to the next species
Fix darumaka->darmanitan blizzard move #2416 Looks like the only issues left are: Shedinja Crossover/Bleed locations Static Encounter locations
2019-11-24 06:48:02 +00:00
return GetMoves(pkm, evo.Species, minlvlevo1, minlvlevo2, maxLevel, evo.Form, Tutor, Version, LVL, moveTutor, Machine, MoveReminder, RemoveTransferHM, generation);
Refactoring where!contains -> except relocate special tutor
2018-06-09 23:04:06 +00:00
}
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
/// <summary>
/// Returns the minimum level the move can be learned at based on the species encounter level.
/// </summary>
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
private static int GetEvoMoveMinLevel1(PKM pkm, int generation, int minLvLG1, EvoCriteria evo)
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
{
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
if (generation != 1)
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
return 1;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
// For evolutions, return the lower of the two; current level should legally be >=
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
if (evo.MinLevel > 1)
return Math.Min(pkm.CurrentLevel, evo.MinLevel);
return minLvLG1;
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-27 02:34:27 +00:00
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
private static int GetEvoMoveMinLevel2(PKM pkm, int generation, int minLvLG2, EvoCriteria evo)
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
{
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
if (generation != 2 || ParseSettings.AllowGen2MoveReminder(pkm))
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
return 1;
Misc tweaks showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref
2019-01-21 05:55:28 +00:00
// For evolutions, return the lower of the two; current level should legally be >=
Refactoring Extract trainer pkm origin check to interface extension
2018-07-26 03:40:57 +00:00
if (evo.MinLevel > 1)
return Math.Min(pkm.CurrentLevel, evo.MinLevel);
return minLvLG2;
}
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
private static IEnumerable<int> GetMoves(PKM pkm, int species, int minlvlG1, int minlvlG2, int lvl, int form, bool moveTutor, GameVersion Version, bool LVL, bool specialTutors, bool Machine, bool MoveReminder, bool RemoveTransferHM, int generation)
Legality refactoring continued Finish removing explicit gen6 objects so that multiple generations of information can be checked. Still only supports gen6, but will be much much easier to add in other generations in the future. Tested a few pk6's and the legality checks appear to be functioning the same.
2016-10-24 05:03:19 +00:00
{
Minor updates increase readability, simplifly some expressions relocate hot path for legality report string creation
2019-05-11 17:12:14 +00:00
var r = new List<int>();
Refactoring GetMoves logic can now be expressed concisely with the prior refactoring
2018-06-09 03:37:35 +00:00
if (LVL)
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
r.AddRange(MoveLevelUp.GetMovesLevelUp(pkm, species, minlvlG1, minlvlG2, lvl, form, Version, MoveReminder, generation));
Refactoring GetMoves logic can now be expressed concisely with the prior refactoring
2018-06-09 03:37:35 +00:00
if (Machine)
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
r.AddRange(MoveTechnicalMachine.GetTMHM(pkm, species, form, generation, Version, RemoveTransferHM));
Refactoring GetMoves logic can now be expressed concisely with the prior refactoring
2018-06-09 03:37:35 +00:00
if (moveTutor)
Misc updates parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct
2019-05-11 07:59:07 +00:00
r.AddRange(MoveTutor.GetTutorMoves(pkm, species, form, specialTutors, generation));
Refactoring Remove duplication of levelup fetch relocate some stuff to a more appropriate area
2018-06-10 17:44:05 +00:00
return r.Distinct();
Split move fetch into more flexible methods Allows the use of one method to filter move sources
2016-05-10 02:03:58 +00:00
}
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
internal const GameVersion NONE = GameVersion.Invalid;
internal static readonly LearnVersion LearnNONE = new LearnVersion(-1);
internal static bool HasVisitedB2W2(this PKM pkm) => pkm.InhabitedGeneration(5);
internal static bool HasVisitedORAS(this PKM pkm) => pkm.InhabitedGeneration(6) && (pkm.AO || !pkm.IsUntraded);
internal static bool HasVisitedUSUM(this PKM pkm) => pkm.InhabitedGeneration(7) && (pkm.USUM || !pkm.IsUntraded);
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
internal static bool IsMovesetRestricted(this PKM pkm) => (pkm.GG && pkm.Format == 7) || pkm.IsUntraded;
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Handle gen3->4->5 levelup evochain pruning Gen7 weavile can exist in gen4 as sneasel; existing code had pruned it from gen4. Skip pruning for this case probably overdid the checks but whatever. works. Thanks /u/ThrowawayReddNinja for pointing out this false flagged case with an example!
2018-05-20 17:35:58 +00:00
public static bool HasMetLocationUpdatedTransfer(int originalGeneration, int currentGeneration)
{
if (originalGeneration < 3)
return currentGeneration >= 3;
if (originalGeneration <= 4)
return currentGeneration != originalGeneration;
return false;
}
Flag langid=0 when appropriate only jpn bw ingame trades can lack a languageID. skip language checks for pk1/pk2 as they have no language stored.
2018-05-26 21:40:02 +00:00
public static bool IsValidMissingLanguage(PKM pkm)
{
return pkm.Format == 5 && pkm.BW;
}
Refactoring Relocate fixed OTs to core (iencounterable & checks now reference same values)
2018-06-23 16:49:04 +00:00
public static string GetG1OT_GFMew(int lang) => lang == (int)LanguageID.Japanese ? "ゲーフリ" : "GF";
public static string GetG5OT_NSparkle(int lang) => lang == (int)LanguageID.Japanese ? "Ｎ" : "N";
Update STADIUM ot checks again jp: 1999 if stadium1, 2000 if stadium2 en: 2000 jp: always same OT en: lowercase if stadium2, uppercase if stadium1 https://projectpokemon.org/home/forums/topic/46893-pkhex-bug-stadium-ot-issue/
2018-08-03 14:38:29 +00:00
public static string GetGBStadiumOTName(bool jp, GameVersion s)
{
if (jp)
return "スタジアム";
return s == GameVersion.Stadium2 ? "Stadium" : "STADIUM";
}
public static int GetGBStadiumOTID(bool jp, GameVersion s)
{
if (jp)
return s == GameVersion.Stadium2 ? 2000 : 1999;
return 2000;
}
Add OT name max length checks Closes #2094
2018-08-15 21:58:55 +00:00
Update Ho-Oh mattle check More languages than Italian have a rule-breaking name. Rework checks a bit Flag eggs more accurately Update force hatch to move Link Trade met location to Egg Location fix Ho-oh -> Ho-Oh text strings (correctness is key!)
2018-10-27 23:06:06 +00:00
public static int GetMaxLengthOT(int gen, LanguageID lang)
{
switch (lang)
{
case LanguageID.Korean:
case LanguageID.Japanese: return gen >= 6 ? 6 : 5;
default: return gen >= 6 ? 12 : 7;
}
}
public static int GetMaxLengthNickname(int gen, LanguageID lang)
Add OT name max length checks Closes #2094
2018-08-15 21:58:55 +00:00
{
switch (lang)
{
case LanguageID.Korean:
case LanguageID.Japanese: return gen >= 6 ? 6 : 5;
Lessen string length severity on egg encounters Hatched eggs can have mismatched languages<->OT/Nick restrictions
2018-08-15 22:26:42 +00:00
default: return gen >= 6 ? 12 : 10;
Add OT name max length checks Closes #2094
2018-08-15 21:58:55 +00:00
}
}
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
Fix Static/Gift IV method call (#2310)
2019-05-15 19:07:48 +00:00
public static bool GetIsFixedIVSequenceValidSkipRand(IReadOnlyList<int> IVs, PKM pkm, int max = 31)
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
{
for (int i = 0; i < 6; i++)
{
if ((uint) IVs[i] > max) // random
continue;
if (IVs[i] != pkm.GetIV(i))
return false;
}
return true;
}
public static bool GetIsFixedIVSequenceValidNoRand(IReadOnlyList<int> IVs, PKM pkm)
{
for (int i = 0; i < 6; i++)
{
if (IVs[i] != pkm.GetIV(i))
return false;
}
return true;
}
Reorganization for future changes Moving legality stuff into separate class
2016-02-23 06:52:48 +00:00
}
}
Reference in a new issue Copy permalink