Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-21 01:43:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.WinForms/Controls/PKM Editor/PKMEditor.cs

1711 lines
66 KiB
C#
Raw Normal View History

Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
using System;
using System.Collections.Generic;
using System.Drawing;
using System.Linq;
using System.Windows.Forms;
using PKHeX.Core;
using PKHeX.WinForms.Properties;
using System.ComponentModel;
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
using static PKHeX.Core.MessageStrings;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
namespace PKHeX.WinForms.Controls
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
public partial class PKMEditor : UserControl, IMainEditor
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
public PKMEditor()
{
InitializeComponent();
Legality = new LegalityAnalysis(pkm = new PK7());
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetPKMFormatMode(pkm.Format);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GB_OT.Click += ClickGT;
GB_nOT.Click += ClickGT;
GB_CurrentMoves.Click += ClickMoves;
GB_RelearnMoves.Click += ClickMoves;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
TB_Nickname.Font = FontUtil.GetPKXFont(11);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_OT.Font = (Font)TB_Nickname.Font.Clone();
TB_OTt2.Font = (Font)TB_Nickname.Font.Clone();
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
// Commonly reused Control arrays
Moves = new[] { CB_Move1, CB_Move2, CB_Move3, CB_Move4 };
Relearn = new[] { CB_RelearnMove1, CB_RelearnMove2, CB_RelearnMove3, CB_RelearnMove4 };
PPUps = new[] { CB_PPu1, CB_PPu2, CB_PPu3, CB_PPu4 };
MovePP = new[] { TB_PP1, TB_PP2, TB_PP3, TB_PP4 };
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
Markings = new[] { PB_Mark1, PB_Mark2, PB_Mark3, PB_Mark4, PB_Mark5, PB_Mark6 };
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
ValidationRequired = Moves.Concat(Relearn).Concat(new[]
{
CB_Species, CB_Nature, CB_HeldItem, CB_Ability, // Main Tab
CB_MetLocation, CB_EggLocation, CB_Ball, // Met Tab
}).ToArray();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
relearnPB = new[] { PB_WarnRelearn1, PB_WarnRelearn2, PB_WarnRelearn3, PB_WarnRelearn4 };
movePB = new[] { PB_WarnMove1, PB_WarnMove2, PB_WarnMove3, PB_WarnMove4 };
Add Shiny Leaf editing Closes #1236 pk4/bk4 only, obviously side note, using static events is no-no, designer auto-removed them. just manually reapply (as well to others that used it)
2017-06-18 04:49:14 +00:00
foreach (var c in WinFormsUtil.GetAllControlsOfType(this, typeof(ComboBox)))
c.KeyDown += WinFormsUtil.RemoveDropCB;
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.SetMainEditor(this);
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
LoadShowdownSet = LoadShowdownSetDefault;
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
TID_Trainer.UpdatedID += Update_ID;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
private void UpdateStats() => Stats.UpdateStats();
private void LoadPartyStats(PKM pk) => Stats.LoadPartyStats(pk);
private void SavePartyStats(PKM pk)
{
Stats.SavePartyStats(pk);
pk.Stat_Level = CurrentLevel;
}
public PKM CurrentPKM { get => FieldsInitialized ? PreparePKM() : pkm; set => pkm = value; }
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
public bool ModifyPKM { private get; set; } = true;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
public bool Unicode { get; set; } = true;
public bool HaX { get; set; }
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
public byte[] LastData { private get; set; }
Add basic plugin sys reference PKHeX.Core, main window loads assemblies & initializes providing an ISaveProvider and the menustrip control (to insert controls into) pretty rough but should allow for inserting external control buttons & allowing it to edit the UI a little example: https://github.com/kwsch/PKHeXPluginExample feedback is appreciated
2018-05-13 19:49:26 +00:00
public PKM Data { get => pkm; set => pkm = value; }
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
public PKM pkm { get; private set; }
public bool FieldsInitialized { get; private set; }
public bool FieldsLoaded { get; private set; }
public bool ChangingFields { get; set; }
public int CurrentLevel => Convert.ToInt32((HaX ? MT_Level : TB_Level).Text);
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
private GameVersion origintrack;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private Action GetFieldsfromPKM;
private Func<PKM> GetPKMfromFields;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
private LegalityAnalysis Legality;
private string[] gendersymbols = { "♂", "♀", "-" };
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
private readonly Image mixedHighlight = ImageUtil.ChangeOpacity(Resources.slotSet, 0.5);
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
private static readonly Color InvalidSelectionColor = Color.DarkSalmon;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
public event EventHandler LegalityChanged;
public event EventHandler UpdatePreviewSprite;
public event EventHandler RequestShowdownImport;
public event EventHandler RequestShowdownExport;
public event ReturnSAVEventHandler SaveFileRequested;
Misc tweaks fix bk4 ribbon checks (lacked interface inheritance) change MN -> UM for get blank save (unused in PKHeX solution) prevent inheriting from derived pkm classes
2017-12-16 22:11:41 +00:00
public delegate SaveFile ReturnSAVEventHandler(object sender, EventArgs e);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
private readonly PictureBox[] movePB, relearnPB;
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
private readonly ToolTip Tip3 = new ToolTip(), NatureTip = new ToolTip();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
private SaveFile RequestSaveFile => SaveFileRequested?.Invoke(this, EventArgs.Empty);
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
public bool PKMIsUnsaved => FieldsInitialized && FieldsLoaded && LastData?.Any(b => b != 0) == true && !LastData.SequenceEqual(CurrentPKM.Data);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
public bool IsEmptyOrEgg => CHK_IsEgg.Checked || CB_Species.SelectedIndex == 0;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
private readonly ComboBox[] Moves, Relearn, ValidationRequired, PPUps;
private readonly MaskedTextBox[] MovePP;
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
private readonly PictureBox[] Markings;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
speed up pkm loading slightly PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate
2017-10-26 02:37:31 +00:00
private bool forceValidation;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public PKM PreparePKM(bool click = true)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (click)
speed up pkm loading slightly PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate
2017-10-26 02:37:31 +00:00
{
forceValidation = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
ValidateChildren();
speed up pkm loading slightly PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate
2017-10-26 02:37:31 +00:00
forceValidation = false;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PKM pk = GetPKMfromFields();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return pk?.Clone();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public bool VerifiedPKM()
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (ModifierKeys == (Keys.Control | Keys.Shift | Keys.Alt))
return true; // Override
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
var cb = Array.Find(ValidationRequired, c => c.BackColor == InvalidSelectionColor && c.Items.Count != 0);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (cb != null)
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
tabMain.SelectedTab = WinFormsUtil.FindFirstControlOfType<TabPage>(cb);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
else if (!Stats.Valid)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
tabMain.SelectedTab = Tab_Stats;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
else if (WinFormsUtil.GetIndex(CB_Species) == 0)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
tabMain.SelectedTab = Tab_Main;
else
return true;
System.Media.SystemSounds.Exclamation.Play();
return false;
}
public void InitializeFields()
{
// Now that the ComboBoxes are ready, load the data.
Fix HaX Mode (#1869) - Pass HaX to StatEditor once everything else loads - Fix Hacked Stats enabled check
2018-03-19 15:10:20 +00:00
Stats.SetMainEditor(this);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsInitialized = true;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PopulateFields(pkm);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void SetPKMFormatMode(int Format)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
byte[] extraBytes = new byte[0];
switch (Format)
{
case 1:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK1;
GetPKMfromFields = PreparePK1;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
break;
case 2:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK2;
GetPKMfromFields = PreparePK2;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
break;
case 3:
if (pkm is CK3)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsCK3;
GetPKMfromFields = PrepareCK3;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = CK3.ExtraBytes;
break;
}
if (pkm is XK3)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsXK3;
GetPKMfromFields = PrepareXK3;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = XK3.ExtraBytes;
break;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK3;
GetPKMfromFields = PreparePK3;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = PK3.ExtraBytes;
break;
case 4:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK4;
GetPKMfromFields = PreparePK4;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = PK4.ExtraBytes;
break;
case 5:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK5;
GetPKMfromFields = PreparePK5;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = PK5.ExtraBytes;
break;
case 6:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK6;
GetPKMfromFields = PreparePK6;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = PK6.ExtraBytes;
break;
case 7:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GetFieldsfromPKM = PopulateFieldsPK7;
GetPKMfromFields = PreparePK7;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
extraBytes = PK7.ExtraBytes;
break;
}
// Load Extra Byte List
GB_ExtraBytes.Visible = GB_ExtraBytes.Enabled = extraBytes.Length != 0;
misc loading fix gen1/2 games with new pkm editor no longer cause an exception on init load
2017-05-23 15:28:53 +00:00
CB_ExtraBytes.Items.Clear();
foreach (byte b in extraBytes)
CB_ExtraBytes.Items.Add($"0x{b:X2}");
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (GB_ExtraBytes.Enabled)
CB_ExtraBytes.SelectedIndex = 0;
}
move pkm load compat check to pkmconverter closes #1550 , mgdb/pkmdb throw unconverted files which need conversion; move main file load conversion to a reusable method and have pkmeditor call it on every load. add skip argument to ignore the conversion check (ie if the file is loaded from an undoubtedly same type source).
2017-10-28 21:26:27 +00:00
public void PopulateFields(PKM pk, bool focus = true, bool skipConversionCheck = false) => LoadFieldsFromPKM(pk, focus, skipConversionCheck);
private void LoadFieldsFromPKM(PKM pk, bool focus = true, bool skipConversionCheck = true)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
if (pk == null) { WinFormsUtil.Error(MsgPKMLoadNull); return; }
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (focus)
Tab_Main.Focus();
move pkm load compat check to pkmconverter closes #1550 , mgdb/pkmdb throw unconverted files which need conversion; move main file load conversion to a reusable method and have pkmeditor call it on every load. add skip argument to ignore the conversion check (ie if the file is loaded from an undoubtedly same type source).
2017-10-28 21:26:27 +00:00
if (!skipConversionCheck && !PKMConverter.TryMakePKMCompatible(pk, CurrentPKM, out string c, out pk))
{ WinFormsUtil.Alert(c); return; }
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
bool oldInit = FieldsInitialized;
FieldsInitialized = FieldsLoaded = false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
speed up pkm loading slightly PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate
2017-10-26 02:37:31 +00:00
pkm = pk.Clone();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
try { GetFieldsfromPKM(); }
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
finally { FieldsInitialized = oldInit; }
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.UpdateIVs(null, null);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdatePKRSInfected(null, null);
UpdatePKRSCured(null, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (HaX) // Load original values from pk not pkm
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
MT_Level.Text = (pk.Stat_HPMax != 0 ? pk.Stat_Level : PKX.GetLevel(pk.Species, pk.EXP)).ToString();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_EXP.Text = pk.EXP.ToString();
MT_Form.Text = pk.AltForm.ToString();
if (pk.Stat_HPMax != 0) // stats present
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.LoadPartyStats(pk);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetMarkings();
UpdateLegality();
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
LastData = PreparePKM()?.Data;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void UpdateLegality(LegalityAnalysis la = null, bool skipMoveRepop = false)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Add savegame sensitive pkm legality checking uses the forme count of the savefile (rather than a futureproofed same-gen forme count) Closes #1559
2017-11-07 03:31:24 +00:00
Legality = la ?? new LegalityAnalysis(pkm, RequestSaveFile.Personal);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (!Legality.Parsed || HaX || pkm.Species == 0)
{
PB_WarnMove1.Visible = PB_WarnMove2.Visible = PB_WarnMove3.Visible = PB_WarnMove4.Visible =
PB_WarnRelearn1.Visible = PB_WarnRelearn2.Visible = PB_WarnRelearn3.Visible = PB_WarnRelearn4.Visible = false;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
LegalityChanged?.Invoke(Legality.Valid, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
}
// Refresh Move Legality
for (int i = 0; i < 4; i++)
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
movePB[i].Visible = !Legality.Info?.Moves[i].Valid ?? false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (pkm.Format >= 6)
for (int i = 0; i < 4; i++)
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
relearnPB[i].Visible = !Legality.Info?.Relearn[i].Valid ?? false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (skipMoveRepop)
return;
// Resort moves
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
bool tmp = FieldsLoaded;
FieldsLoaded = false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
var moves = Legality.AllSuggestedMovesAndRelearn;
Refactoring pull out GameStrings add debug output for crystal headbutt trees fix qrpkm item access
2018-05-19 04:35:57 +00:00
var moveList = GameInfo.Strings.MoveDataSource.OrderByDescending(m => moves.Contains(m.Value)).ToList();
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
foreach (var c in Moves)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var index = WinFormsUtil.GetIndex(c);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
c.DataSource = new BindingSource(moveList, null);
c.SelectedValue = index;
if (c.Visible)
c.SelectionLength = 0; // flicker hack
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded |= tmp;
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
LegalityChanged?.Invoke(Legality.Valid, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void UpdateUnicode(string[] symbols)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
gendersymbols = symbols;
if (!Unicode)
{
BTN_Shinytize.Text = "*";
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
TB_Nickname.Font = TB_OT.Font = TB_OTt2.Font = GB_OT.Font;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
else
{
BTN_Shinytize.Text = "☆";
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
TB_Nickname.Font = TB_OT.Font = TB_OTt2.Font = FontUtil.GetPKXFont(11);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
// Switch active gender labels to new if they are active.
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
if (PKX.GetGenderFromString(Label_Gender.Text) < 2)
Label_Gender.Text = gendersymbols[PKX.GetGenderFromString(Label_Gender.Text)];
if (PKX.GetGenderFromString(Label_OTGender.Text) < 2)
Label_OTGender.Text = gendersymbols[PKX.GetGenderFromString(Label_OTGender.Text)];
if (PKX.GetGenderFromString(Label_CTGender.Text) < 2)
Label_CTGender.Text = gendersymbols[PKX.GetGenderFromString(Label_CTGender.Text)];
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
private void UpdateSprite()
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (FieldsLoaded && FieldsInitialized && !forceValidation)
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdatePreviewSprite?.Invoke(this, null);
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// General Use Functions //
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private Color GetGenderColor(int gender)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (gender == 0) // male
return Color.Blue;
if (gender == 1) // female
return Color.Red;
return CB_Species.ForeColor;
}
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
private void SetDetailsOT(ITrainerInfo SAV)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
if (!(SAV.OT?.Length > 0))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
// Get Save Information
TB_OT.Text = SAV.OT;
Label_OTGender.Text = gendersymbols[SAV.Gender & 1];
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Label_OTGender.ForeColor = GetGenderColor(SAV.Gender & 1);
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
TID_Trainer.LoadInfo(SAV);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (SAV.Game >= 0)
CB_GameOrigin.SelectedValue = SAV.Game;
if (SAV.Language >= 0)
CB_Language.SelectedValue = SAV.Language;
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
if (SAV.ConsoleRegion != 0)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
CB_3DSReg.SelectedValue = SAV.ConsoleRegion;
CB_Country.SelectedValue = SAV.Country;
CB_SubRegion.SelectedValue = SAV.SubRegion;
}
Add trashbyte copy for OT import on gen1/2 Closes #1849 NAME_LENGTH is 11 for both gens and the offsets don't vary between languages, so it's a simple fetch.
2018-02-23 06:42:50 +00:00
// Copy OT trash bytes for sensitive games (Gen1/2)
if (SAV is SAV1 s1 && pkm is PK1 p1) p1.OT_Trash = s1.OT_Trash;
else if (SAV is SAV2 s2 && pkm is PK2 p2) p2.OT_Trash = s2.OT_Trash;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateNickname(null, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
private void SetDetailsHT(ITrainerInfo SAV)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
if (!(SAV.OT?.Length > 0))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
if (TB_OTt2.Text.Length > 0)
Label_CTGender.Text = gendersymbols[SAV.Gender & 1];
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void SetForms()
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int species = WinFormsUtil.GetIndex(CB_Species);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (pkm.Format < 4 && species != 201)
{
Label_Form.Visible = CB_Form.Visible = CB_Form.Enabled = false;
return;
}
Use savefile for personalinfo form count BW has forms that aren't present in b2w2; expect the same for usum<->sm splash screen opacity change for fanciness
2017-06-12 01:23:14 +00:00
int count = (RequestSaveFile?.Personal[species] ?? pkm.PersonalInfo).FormeCount;
bool hasForms = count > 1 || new[] { 201, 664, 665, 414 }.Contains(species);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_Form.Enabled = CB_Form.Visible = Label_Form.Visible = hasForms;
if (HaX && pkm.Format >= 4)
Label_Form.Visible = true;
if (!hasForms)
return;
Add rockruff forme list items revert form selection filtering, screwed up scatterbug and other forced-forme lists. behavior works fine without the list filtering
2017-11-10 12:01:36 +00:00
var ds = PKX.GetFormList(species, GameInfo.Strings.types, GameInfo.Strings.forms, gendersymbols, pkm.Format).ToList();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (ds.Count == 1 && string.IsNullOrEmpty(ds[0])) // empty (Alolan Totems)
CB_Form.Enabled = CB_Form.Visible = Label_Form.Visible = false;
else CB_Form.DataSource = ds;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void SetAbilityList()
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (pkm.Format < 3) // no abilities
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (pkm.Format > 3 && FieldsLoaded) // has forms
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
pkm.AltForm = CB_Form.SelectedIndex; // update pkm field for form specific abilities
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
int abil = CB_Ability.SelectedIndex;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
bool tmp = FieldsLoaded;
FieldsLoaded = false;
Relocate some logic to core party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically
2018-03-26 02:05:49 +00:00
InitializeBinding(CB_Ability);
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
CB_Ability.DataSource = GetAbilityList(pkm);
CB_Ability.SelectedIndex = GetSafeIndex(CB_Ability, abil); // restore original index if available
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = tmp;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
private static int GetSafeIndex(ComboBox cb, int index) => Math.Max(0, Math.Min(cb.Items.Count - 1, index));
private static readonly string[] abilIdentifier = { " (1)", " (2)", " (H)" };
private static List<ComboItem> GetAbilityList(PKM pkm)
{
var abils = pkm.PersonalInfo.Abilities;
if (abils[1] == 0 && pkm.Format != 3)
abils[1] = abils[0];
var list = abils.Where(a => a != 0).Select(GetItem).ToList();
if (list.Count == 0)
list.Add(GetItem(0, 0));
return list;
ComboItem GetItem(int ability, int index) => new ComboItem
{
Value = ability,
Text = GameInfo.Strings.abilitylist[ability] + abilIdentifier[index]
};
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void SetIsShiny(object sender)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (sender == TB_PID)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.PID = Util.GetHexValue(TB_PID.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
// Recalculate shininiess
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
bool isShiny = pkm.IsShiny;
// Set the Controls
BTN_Shinytize.Visible = BTN_Shinytize.Enabled = !isShiny;
Label_IsShiny.Visible = isShiny;
// Refresh Markings (for Shiny Star if applicable)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetMarkings();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void SetMarkings()
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
double getOpacity(bool b) => b ? 1 : 0.175;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Image changeOpacity(PictureBox p, double opacity) => opacity == 1 ? p.InitialImage
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
: ImageUtil.ChangeOpacity(p.InitialImage, opacity);
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
var pba = Markings;
var markings = pkm.Markings;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
for (int i = 0; i < pba.Length; i++)
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
pba[i].Image = changeOpacity(pba[i], getOpacity(markings[i] != 0));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
PB_MarkShiny.Image = changeOpacity(PB_MarkShiny, getOpacity(!BTN_Shinytize.Enabled));
PB_MarkCured.Image = changeOpacity(PB_MarkCured, getOpacity(CHK_Cured.Checked));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
PB_MarkPentagon.Image = changeOpacity(PB_MarkPentagon, getOpacity(pkm.Gen6));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Gen7 Markings
if (pkm.Format != 7)
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
PB_MarkAlola.Image = changeOpacity(PB_MarkAlola, getOpacity(pkm.Gen7));
PB_MarkVC.Image = changeOpacity(PB_MarkVC, getOpacity(pkm.VC));
PB_MarkHorohoro.Image = changeOpacity(PB_MarkHorohoro, getOpacity(pkm.Horohoro));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
for (int i = 0; i < pba.Length; i++)
Misc fixes/improvements Reduce memory usage for evo method banlist (static banlist references) Fix gen6 mega evo flag truncation simplify QR encode/decode logic a little Don't apply transparency if transparency is already 100% (skip the loop) Add gen5 wild pid/tid-sid correlation check Fix validation value reset (loading gen3-4 pkm without looking at met tab causes the met location to get reset); fixed by prematurely validating before setting the value Fix gen3 pkm with gen4 contest ribbons in gen4/5 getting flagged incorrectly
2017-08-13 07:21:42 +00:00
if (GetMarkingColor(markings[i], out Color c))
pba[i].Image = ImageUtil.ChangeAllColorTo(pba[i].Image, c);
}
private static bool GetMarkingColor(int markval, out Color c)
{
switch (markval)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Misc fixes/improvements Reduce memory usage for evo method banlist (static banlist references) Fix gen6 mega evo flag truncation simplify QR encode/decode logic a little Don't apply transparency if transparency is already 100% (skip the loop) Add gen5 wild pid/tid-sid correlation check Fix validation value reset (loading gen3-4 pkm without looking at met tab causes the met location to get reset); fixed by prematurely validating before setting the value Fix gen3 pkm with gen4 contest ribbons in gen4/5 getting flagged incorrectly
2017-08-13 07:21:42 +00:00
case 1:
c = Color.FromArgb(000, 191, 255);
return true;
case 2:
c = Color.FromArgb(255, 117, 179);
return true;
default:
c = Color.Black;
return false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
}
Misc fixes/improvements Reduce memory usage for evo method banlist (static banlist references) Fix gen6 mega evo flag truncation simplify QR encode/decode logic a little Don't apply transparency if transparency is already 100% (skip the loop) Add gen5 wild pid/tid-sid correlation check Fix validation value reset (loading gen3-4 pkm without looking at met tab causes the met location to get reset); fixed by prematurely validating before setting the value Fix gen3 pkm with gen4 contest ribbons in gen4/5 getting flagged incorrectly
2017-08-13 07:21:42 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateGender()
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
More generator updates Store 4g giratina held item for enc->pkm legality revise usages of GetSaneGender Rearrange some logic Better handle impossible version encounters (gen4) gen 1-5 done, stuck on 659 - bunnelby egg...?
2018-05-10 00:50:56 +00:00
int Gender = pkm.GetSaneGender();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Label_Gender.Text = gendersymbols[Gender];
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Label_Gender.ForeColor = GetGenderColor(Gender);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void SetCountrySubRegion(ComboBox CB, string type)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
int index = CB.SelectedIndex;
// fix for Korean / Chinese being swapped
string cl = GameInfo.CurrentLanguage + "";
cl = cl == "zh" ? "ko" : cl == "ko" ? "zh" : cl;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
CB.DataSource = Util.GetCBList(type, cl);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (index > 0 && index < CB.Items.Count && FieldsInitialized)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB.SelectedIndex = index;
}
// Prompted Updates of PKM //
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickFriendship(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (ModifierKeys == Keys.Control) // prompt to reset
TB_Friendship.Text = pkm.CurrentFriendship.ToString();
else
TB_Friendship.Text = TB_Friendship.Text == "255" ? pkm.PersonalInfo.BaseFriendship.ToString() : "255";
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickLevel(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (ModifierKeys == Keys.Control)
((MaskedTextBox)sender).Text = "100";
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickGender(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Get Gender Threshold
int gt = pkm.PersonalInfo.Gender;
if (gt == 255 || gt == 0 || gt == 254) // Single gender/genderless
return;
Fix gender handling Closes #1933 if not allowed to be genderless, flag as invalid gender only permit valid genders after genderless is ruled out (both done by checking the low bit)
2018-05-11 01:53:23 +00:00
int newGender = (PKX.GetGenderFromString(Label_Gender.Text) & 1) ^ 1;
Remove old (GF fixed) shiny correlation Transporter was updated
2017-09-06 16:12:56 +00:00
if (pkm.Format <= 2)
Fix gen1/2 shinify/gender change behavior Closes #1488 also fixes female->shinify starters not flipping back to male gender (changingFields was set back to the same value)
2017-09-23 23:50:38 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.SetATKIVGender(newGender);
Fix gen1/2 shinify/gender change behavior Closes #1488 also fixes female->shinify starters not flipping back to male gender (changingFields was set back to the same value)
2017-09-23 23:50:38 +00:00
SetIsShiny(null);
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
else if (pkm.Format <= 4)
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (FieldsLoaded)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.Species = WinFormsUtil.GetIndex(CB_Species);
pkm.Version = WinFormsUtil.GetIndex(CB_GameOrigin);
pkm.Nature = WinFormsUtil.GetIndex(CB_Nature);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
pkm.AltForm = CB_Form.SelectedIndex;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.SetPIDGender(newGender);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_PID.Text = pkm.PID.ToString("X8");
}
pkm.Gender = newGender;
Label_Gender.Text = gendersymbols[pkm.Gender];
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Label_Gender.ForeColor = GetGenderColor(pkm.Gender);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
if (PKX.GetGenderFromString(CB_Form.Text) < 2) // Gendered Forms
CB_Form.SelectedIndex = PKX.GetGenderFromString(Label_Gender.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
UpdatePreviewSprite(Label_Gender, null);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickPPUps(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
bool min = ModifierKeys.HasFlag(Keys.Control);
CB_PPu1.SelectedIndex = !min && WinFormsUtil.GetIndex(CB_Move1) > 0 ? 3 : 0;
CB_PPu2.SelectedIndex = !min && WinFormsUtil.GetIndex(CB_Move2) > 0 ? 3 : 0;
CB_PPu3.SelectedIndex = !min && WinFormsUtil.GetIndex(CB_Move3) > 0 ? 3 : 0;
CB_PPu4.SelectedIndex = !min && WinFormsUtil.GetIndex(CB_Move4) > 0 ? 3 : 0;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickMarking(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
int index = Array.IndexOf(Markings, sender);
pkm.ToggleMarking(index);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetMarkings();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickOT(object sender, EventArgs e) => SetDetailsOT(SaveFileRequested?.Invoke(this, e));
private void ClickCT(object sender, EventArgs e) => SetDetailsHT(SaveFileRequested?.Invoke(this, e));
private void ClickTRGender(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Label lbl = sender as Label;
if (!string.IsNullOrWhiteSpace(lbl?.Text)) // set gender label (toggle M/F)
{
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
int gender = PKX.GetGenderFromString(lbl.Text) ^ 1;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
lbl.Text = gendersymbols[gender];
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
lbl.ForeColor = GetGenderColor(gender);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
}
Add Shiny Leaf editing Closes #1236 pk4/bk4 only, obviously side note, using static events is no-no, designer auto-removed them. just manually reapply (as well to others that used it)
2017-06-18 04:49:14 +00:00
private void ClickBall(object sender, EventArgs e) => CB_Ball.SelectedIndex = 0;
private void ClickShinyLeaf(object sender, EventArgs e) => ShinyLeaf.CheckAll(ModifierKeys != Keys.Control);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickMetLocation(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (HaX)
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm = PreparePKM();
UpdateLegality(skipMoveRepop: true);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (Legality.Valid)
return;
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (!SetSuggestedMetLocation())
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm = PreparePKM();
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickGT(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (!GB_nOT.Visible)
return;
if (sender == GB_OT)
{
pkm.CurrentHandler = 0;
GB_OT.BackgroundImage = mixedHighlight;
GB_nOT.BackgroundImage = null;
}
else if (TB_OTt2.Text.Length > 0)
{
pkm.CurrentHandler = 1;
GB_OT.BackgroundImage = null;
GB_nOT.BackgroundImage = mixedHighlight;
}
TB_Friendship.Text = pkm.CurrentFriendship.ToString();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ClickMoves(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality(skipMoveRepop: true);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (sender == GB_CurrentMoves)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (!SetSuggestedMoves(random: ModifierKeys == Keys.Control))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
}
else if (sender == GB_RelearnMoves)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (!SetSuggestedRelearnMoves())
return;
}
else
{
return;
}
UpdateLegality();
}
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
private bool SetSuggestedMoves(bool random = false, bool silent = false)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
{
Add move rand for batch editor Also add Move Rand & Move Reset to box modify contextmenu
2018-05-20 21:29:13 +00:00
int[] m = pkm.GetMoveSet(random);
Misc simplifications fixes suggestion requests for invalid gameversion pkms
2018-05-28 00:57:45 +00:00
if (m?.Any(z => z != 0) != true)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
{
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (!silent)
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
WinFormsUtil.Alert(MsgPKMSuggestionFormat);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return false;
}
if (pkm.Moves.SequenceEqual(m))
return false;
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (!silent)
{
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
var movestrings = m.Select(v => v >= GameInfo.Strings.movelist.Length ? MsgProgramError : GameInfo.Strings.movelist[v]);
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
string r = string.Join(Environment.NewLine, movestrings);
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
if (DialogResult.Yes != WinFormsUtil.Prompt(MessageBoxButtons.YesNo, MsgPKMSuggestionMoves, r))
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
return false;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Add smart move[] setter Closes #1871 (smart-move setting is also done by batch editor)
2018-03-20 15:35:41 +00:00
pkm.SetMoves(m);
Fix Suggested Move Set (#1866) * Use FieldsLoaded to stop updates
2018-03-19 16:03:27 +00:00
FieldsLoaded = false;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
LoadMoves(pkm);
Fix Suggested Move Set (#1866) * Use FieldsLoaded to stop updates
2018-03-19 16:03:27 +00:00
FieldsLoaded = true;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return true;
}
Refactoring Rewrote showdown set exporting to be much clearer, added auto-fixing of relearn moves when importing showdown set (applies suggested relearn moves) Simplified main form loading routine (from ~160 to ~25 by extracting methods)
2017-06-18 20:02:02 +00:00
private bool SetSuggestedRelearnMoves(bool silent = false)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
{
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (pkm.Format < 6)
return false;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
int[] m = pkm.GetSuggestedRelearnMoves(Legality);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (pkm.RelearnMoves.SequenceEqual(m))
return false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (!silent)
{
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
var movestrings = m.Select(v => v >= GameInfo.Strings.movelist.Length ? MsgProgramError : GameInfo.Strings.movelist[v]);
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
string r = string.Join(Environment.NewLine, movestrings);
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
if (DialogResult.Yes != WinFormsUtil.Prompt(MessageBoxButtons.YesNo, MsgPKMSuggestionRelearn, r))
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
return false;
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
CB_RelearnMove1.SelectedValue = m[0];
CB_RelearnMove2.SelectedValue = m[1];
CB_RelearnMove3.SelectedValue = m[2];
CB_RelearnMove4.SelectedValue = m[3];
return true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
private bool SetSuggestedMetLocation(bool silent = false)
{
var encounter = Legality.GetSuggestedMetInfo();
if (encounter == null || pkm.Format >= 3 && encounter.Location < 0)
{
if (!silent)
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
WinFormsUtil.Alert(MsgPKMSuggestionNone);
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
return false;
}
int level = encounter.Level;
int location = encounter.Location;
Refactor level-evolution checks slightly Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred
2017-08-29 01:12:57 +00:00
int minlvl = Legal.GetLowestLevel(pkm, encounter.LevelMin);
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (minlvl == 0)
minlvl = level;
if (pkm.CurrentLevel >= minlvl && pkm.Met_Level == level && pkm.Met_Location == location)
return false;
if (minlvl < level)
minlvl = level;
if (!silent)
{
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
List<string> suggestion = GetSuggestionMessage(pkm, level, location, minlvl);
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
if (suggestion.Count == 1) // no suggestion
return false;
string suggest = string.Join(Environment.NewLine, suggestion);
if (WinFormsUtil.Prompt(MessageBoxButtons.YesNo, suggest) != DialogResult.Yes)
return false;
}
if (pkm.Format >= 3)
{
TB_MetLevel.Text = level.ToString();
CB_MetLocation.SelectedValue = location;
Unhide language for gen1/2 saves Closes #1349 Add egg memory wiping when ticking as egg, Add egg memory setting when suggesting encounter info. Closes #1350 I'd rather have it this way as to not do cross-tab auto edits that the user may miss.
2017-08-06 03:30:33 +00:00
if (pkm.GenNumber == 6 && pkm.WasEgg && ModifyPKM)
Relocate some logic to core party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically
2018-03-26 02:05:49 +00:00
pkm.SetHatchMemory6();
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
}
if (pkm.CurrentLevel < minlvl)
TB_Level.Text = minlvl.ToString();
return true;
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
public void UpdateIVsGB(bool skipForm)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Better handle g2 unown form changing Closes #1897
2018-04-16 23:01:30 +00:00
if (!FieldsLoaded)
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Label_Gender.Text = gendersymbols[pkm.Gender];
Label_Gender.ForeColor = GetGenderColor(pkm.Gender);
if (pkm.Species == 201 && !skipForm) // Unown
CB_Form.SelectedIndex = pkm.AltForm;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
SetIsShiny(null);
UpdateSprite();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateBall(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PB_Ball.Image = PKMUtil.GetBallSprite(WinFormsUtil.GetIndex(CB_Ball));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateEXPLevel(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (ChangingFields || !FieldsInitialized) return;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
ChangingFields = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (sender == TB_EXP)
{
// Change the Level
uint EXP = Util.ToUInt32(TB_EXP.Text);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int Species = WinFormsUtil.GetIndex(CB_Species);
int Level = PKX.GetLevel(Species, EXP);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (Level == 100)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
EXP = PKX.GetEXP(100, Species);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_Level.Text = Level.ToString();
if (!HaX)
TB_EXP.Text = EXP.ToString();
else if (Level <= 100 && Util.ToInt32(MT_Level.Text) <= 100)
MT_Level.Text = Level.ToString();
}
else
{
// Change the XP
int Level = Util.ToInt32((HaX ? MT_Level : TB_Level).Text);
Update level/egg behavior Similar to how anything higher than 255 is dropped to 100, setting level to 0 will overwrite it to 1. Current level is just a derived property from EXP, so it's just a display property in the editor. Toggling IsEgg for gen4 won't flag as nicknamed. #1257
2017-06-21 05:57:22 +00:00
if (Level <= 0)
TB_Level.Text = "1";
else if (Level > 100)
Tweak level/exp changing events move from validated to textchanged as the user expects the values to live update only use the value-cap on validation if the input is not associated with another control's value this is now consistent with the IV/EV updating stats #1163
2017-05-24 00:46:32 +00:00
{
TB_Level.Text = "100";
if (!HaX)
Level = 100;
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (Level > byte.MaxValue) MT_Level.Text = "255";
if (Level <= 100)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
TB_EXP.Text = PKX.GetEXP(Level, WinFormsUtil.GetIndex(CB_Species)).ToString();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
ChangingFields = false;
if (FieldsLoaded) // store values back
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
pkm.EXP = Util.ToUInt32(TB_EXP.Text);
pkm.Stat_Level = Util.ToInt32((HaX ? MT_Level : TB_Level).Text);
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.UpdateStats();
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateRandomPID(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (pkm.Format < 3)
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (FieldsLoaded)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.PID = Util.GetHexValue(TB_PID.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (sender == Label_Gender)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.SetPIDGender(pkm.Gender);
else if (sender == CB_Nature && pkm.Nature != WinFormsUtil.GetIndex(CB_Nature))
pkm.SetPIDNature(WinFormsUtil.GetIndex(CB_Nature));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
else if (sender == BTN_RerollPID)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.SetPIDGender(pkm.Gender);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
else if (sender == CB_Ability && CB_Ability.SelectedIndex != pkm.PIDAbility && pkm.PIDAbility > -1)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.PID = PKX.GetRandomPID(pkm.Species, pkm.Gender, pkm.Version, pkm.Nature, pkm.Format, (uint)(CB_Ability.SelectedIndex * 0x10001));
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_PID.Text = pkm.PID.ToString("X8");
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetIsShiny(null);
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
Check EC-PID same for gen1/2 transfers Fix PID->EC on gen<3 transfers https://projectpokemon.org/home/forums/topic/43779-about-vc-pokemons-pid-and-encryptionconstant/
2018-02-09 02:47:52 +00:00
if (pkm.Format >= 6 && 3 <= pkm.GenNumber && pkm.GenNumber <= 5)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_EC.Text = TB_PID.Text;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateRandomEC(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (pkm.Format < 6)
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int wIndex = Array.IndexOf(Legal.WurmpleEvolutions, WinFormsUtil.GetIndex(CB_Species));
Fix wurmple evo gen3/4 yeah it was never the lowest 16 bits as every-internet-source claims. 1D9C9130 silcoon => 3716[8] = cascoon (nope) #1330 was correct!
2017-07-17 22:58:09 +00:00
uint EC = wIndex < 0 ? Util.Rand32() : PKX.GetWurmpleEC(wIndex/2);
TB_EC.Text = EC.ToString("X8");
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void Update255_MTB(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (!(sender is MaskedTextBox tb)) return;
if (Util.ToInt32(tb.Text) > byte.MaxValue)
tb.Text = "255";
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateForm(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (CB_Form == sender && FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
pkm.AltForm = CB_Form.SelectedIndex;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.UpdateStats();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Repopulate Abilities if Species Form has different abilities
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetAbilityList();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Gender Forms
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (WinFormsUtil.GetIndex(CB_Species) == 201 && FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (pkm.Format == 3)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.SetPIDUnown3(CB_Form.SelectedIndex);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_PID.Text = pkm.PID.ToString("X8");
}
else if (pkm.Format == 2)
{
int desiredForm = CB_Form.SelectedIndex;
while (pkm.AltForm != desiredForm)
Better handle g2 unown form changing Closes #1897
2018-04-16 23:01:30 +00:00
{
FieldsLoaded = false;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.UpdateRandomIVs(null, null);
Better handle g2 unown form changing Closes #1897
2018-04-16 23:01:30 +00:00
FieldsLoaded = true;
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
}
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
else if (PKX.GetGenderFromString(CB_Form.Text) < 2)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (CB_Form.Items.Count == 2) // actually M/F; Pumpkaboo formes in German are S,M,L,XL
Update form gender update #1982
2018-06-07 01:59:01 +00:00
{
pkm.Gender = CB_Form.SelectedIndex;
UpdateGender();
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Update form gender update #1982
2018-06-07 01:59:01 +00:00
else
UpdateGender();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (ChangingFields)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
ChangingFields = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
MT_Form.Text = CB_Form.SelectedIndex.ToString();
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
ChangingFields = false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateHaXForm(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (ChangingFields)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
ChangingFields = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
int form = pkm.AltForm = Util.ToInt32(MT_Form.Text);
CB_Form.SelectedIndex = CB_Form.Items.Count > form ? form : -1;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
ChangingFields = false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdatePP(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
if (!(sender is ComboBox cb))
return;
int index = Array.IndexOf(Moves, cb);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (index < 0)
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
index = Array.IndexOf(PPUps, cb);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (index < 0)
return;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
int move = WinFormsUtil.GetIndex(Moves[index]);
var ppctrl = PPUps[index];
int ppups = ppctrl.SelectedIndex;
if (move <= 0)
Clear move pp on move deletion closes #1894
2018-04-09 13:10:26 +00:00
{
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
ppctrl.SelectedIndex = 0;
Clear move pp on move deletion closes #1894
2018-04-09 13:10:26 +00:00
MovePP[index].Text = 0.ToString();
}
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
else
MovePP[index].Text = pkm.GetMovePP(move, ppups).ToString();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdatePKRSstrain(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Change the PKRS Days to the legal bounds.
int currentDuration = CB_PKRSDays.SelectedIndex;
CB_PKRSDays.Items.Clear();
foreach (int day in Enumerable.Range(0, CB_PKRSStrain.SelectedIndex % 4 + 2)) CB_PKRSDays.Items.Add(day);
// Set the days back if they're legal, else set it to 1. (0 always passes).
CB_PKRSDays.SelectedIndex = currentDuration < CB_PKRSDays.Items.Count ? currentDuration : 1;
if (CB_PKRSStrain.SelectedIndex != 0) return;
// Never Infected
CB_PKRSDays.SelectedIndex = 0;
CHK_Cured.Checked = false;
CHK_Infected.Checked = false;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdatePKRSdays(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (CB_PKRSDays.SelectedIndex != 0) return;
// If no days are selected
if (CB_PKRSStrain.SelectedIndex == 0)
CHK_Cured.Checked = CHK_Infected.Checked = false; // No Strain = Never Cured / Infected, triggers Strain update
else CHK_Cured.Checked = true; // Any Strain = Cured
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdatePKRSCured(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsInitialized) return;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Cured PokeRus is toggled
if (CHK_Cured.Checked)
{
// Has Had PokeRus
Label_PKRSdays.Visible = CB_PKRSDays.Visible = false;
CB_PKRSDays.SelectedIndex = 0;
Label_PKRS.Visible = CB_PKRSStrain.Visible = true;
CHK_Infected.Checked = true;
// If we're cured we have to have a strain infection.
if (CB_PKRSStrain.SelectedIndex == 0)
CB_PKRSStrain.SelectedIndex = 1;
}
else if (!CHK_Infected.Checked)
{
// Not Infected, Disable the other
Label_PKRS.Visible = CB_PKRSStrain.Visible = false;
CB_PKRSStrain.SelectedIndex = 0;
}
else
{
// Still Infected for a duration
Label_PKRSdays.Visible = CB_PKRSDays.Visible = true;
CB_PKRSDays.SelectedValue = 1;
}
// if not cured yet, days > 0
if (!CHK_Cured.Checked && CHK_Infected.Checked && CB_PKRSDays.SelectedIndex == 0)
CB_PKRSDays.SelectedIndex++;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetMarkings();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdatePKRSInfected(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsInitialized) return;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (CHK_Cured.Checked && !CHK_Infected.Checked) { CHK_Cured.Checked = false; return; }
if (CHK_Cured.Checked) return;
Label_PKRS.Visible = CB_PKRSStrain.Visible = CHK_Infected.Checked;
if (!CHK_Infected.Checked) { CB_PKRSStrain.SelectedIndex = 0; CB_PKRSDays.SelectedIndex = 0; Label_PKRSdays.Visible = CB_PKRSDays.Visible = false; }
Fix pkrs checkbox behavior infecting was incrementing days while the days visibility was hidden https://projectpokemon.org/home/forums/topic/43518-pokerus/?do=findComment&comment=226611
2018-01-25 16:48:49 +00:00
else if (CB_PKRSStrain.SelectedIndex == 0)
{
CB_PKRSStrain.SelectedIndex = CB_PKRSDays.SelectedIndex = 1;
Label_PKRSdays.Visible = CB_PKRSDays.Visible = true;
UpdatePKRSCured(sender, e);
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateCountry(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
interpolation++ no functional change (assumed)
2017-09-30 05:58:25 +00:00
int index;
if (sender is ComboBox c && (index = WinFormsUtil.GetIndex(c)) > 0)
SetCountrySubRegion(CB_SubRegion, $"sr_{index:000}");
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateSpecies(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Get Species dependent information
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (FieldsLoaded)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.Species = WinFormsUtil.GetIndex(CB_Species);
SetAbilityList();
SetForms();
UpdateForm(null, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
// Recalculate EXP for Given Level
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
uint EXP = PKX.GetEXP(pkm.CurrentLevel, pkm.Species);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_EXP.Text = EXP.ToString();
// Check for Gender Changes
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateGender();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// If species changes and no nickname, set the new name == speciesName.
if (!CHK_Nicknamed.Checked)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateNickname(sender, e);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateOriginGame(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
GameVersion Version = (GameVersion)WinFormsUtil.GetIndex(CB_GameOrigin);
Rearrange version changing logic set the new version, then update the controls #1923 ; exist logic overrode rby/gsc to gen7 locations, which didn't trigger the TID view update.
2018-05-05 00:59:04 +00:00
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// check if differs
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
var group = GameUtil.GetMetLocationVersionGroup(Version);
if (group == GameVersion.GSC && pkm.Format >= 7)
group = GameVersion.USUM;
else if (pkm.Format < 3)
group = GameVersion.GSC;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
if (group != origintrack)
ReloadMetLocations(Version);
origintrack = group;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Visibility logic for Gen 4 encounter type; only show for Gen 4 Pokemon.
if (pkm.Format >= 4)
{
Relocate some logic to core party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically
2018-03-26 02:05:49 +00:00
bool g4 = pkm.Gen4;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_EncounterType.Visible = Label_EncounterType.Visible = g4 && pkm.Format < 7;
if (!g4)
CB_EncounterType.SelectedValue = 0;
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
pkm.Version = (int)Version;
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
TID_Trainer.LoadIDValues(pkm);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Rework TID/SID loading Move TID/SID load to after version set (special handling for pk1/pk2 which don't store version, just call manually). Update TID/SID on every gameversion change anyway Rename LoadOTID to LoadOT since it does not deal with ID. Closes #1962
2018-05-24 23:53:51 +00:00
private void ReloadMetLocations(GameVersion Version)
{
InitializeBinding(CB_MetLocation);
InitializeBinding(CB_EggLocation);
var met_list = GameInfo.GetLocationList(Version, pkm.Format, egg: false);
CB_MetLocation.DataSource = new BindingSource(met_list, null);
var egg_list = GameInfo.GetLocationList(Version, pkm.Format, egg: true);
CB_EggLocation.DataSource = new BindingSource(egg_list, null);
// Stretch C/XD met location dropdowns
int width = CB_EggLocation.DropDownWidth;
if (Version == GameVersion.CXD && pkm.Format == 3)
width *= 2;
CB_MetLocation.DropDownWidth = width;
if (FieldsLoaded)
{
SetMarkings(); // Set/Remove the Nativity marking when gamegroup changes too
int metLoc = EncounterSuggestion.GetSuggestedTransferLocation(pkm);
CB_MetLocation.SelectedValue = Math.Max(0, metLoc);
CB_EggLocation.SelectedIndex = CHK_AsEgg.Checked ? 1 : 0; // daycare : none
}
else
{
CB_GameOrigin.Focus(); // hacky validation forcing
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateExtraByteValue(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
if (CB_ExtraBytes.Items.Count == 0 || !(sender is MaskedTextBox mtb))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
// Changed Extra Byte's Value
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
if (Util.ToInt32(mtb.Text) > byte.MaxValue)
mtb.Text = "255";
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
int value = Util.ToInt32(mtb.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
int offset = Convert.ToInt32(CB_ExtraBytes.Text, 16);
pkm.Data[offset] = (byte)value;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateExtraByteIndex(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (CB_ExtraBytes.Items.Count == 0)
return;
// Byte changed, need to refresh the Text box for the byte's value.
TB_ExtraByte.Text = pkm.Data[Convert.ToInt32(CB_ExtraBytes.Text, 16)].ToString();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateNatureModification(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (sender != CB_Nature) return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int nature = WinFormsUtil.GetIndex(CB_Nature);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
string text = Stats.UpdateNatureModification(nature);
NatureTip.SetToolTip(CB_Nature, text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateIsNicknamed(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
pkm.Nickname = TB_Nickname.Text;
if (CHK_Nicknamed.Checked)
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int species = WinFormsUtil.GetIndex(CB_Species);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (species < 1 || species > pkm.MaxSpeciesID)
return;
if (CHK_IsEgg.Checked)
species = 0; // get the egg name.
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (PKX.IsNicknamedAnyLanguage(species, TB_Nickname.Text, pkm.Format))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CHK_Nicknamed.Checked = true;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateNickname(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Add pk1 catchrate refresher to current species Label_Species already has a click event for showdown sets with a modifierkey; add a default behavior which checks for pk1 and if so, sets the catch rate to the current species. Users shouldn't have to look up catch rate values or be responsible for editing them; they are currently handled by the pk1 object. Setting a species ID checks if the catch rate is within the species lineage, and only updates it to the current species if the rate doesn't match any. With this change, the user can force the catchrate to match the current species (then change back to the evo form) instead of having to change the species to a separate lineage that does not have the current (not displayed) catch rate value. Closes #1235
2017-06-17 01:56:17 +00:00
if (sender == Label_Species)
{
switch (ModifierKeys)
{
case Keys.Control: RequestShowdownImport?.Invoke(sender, e); return;
case Keys.Alt: RequestShowdownExport?.Invoke(sender, e); return;
default:
if (pkm is PK1 pk1)
pk1.Catch_Rate = pk1.PersonalInfo.CatchRate;
return;
}
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int lang = WinFormsUtil.GetIndex(CB_Language);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsInitialized || CHK_Nicknamed.Checked)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
// Fetch Current Species and set it as Nickname Text
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
int species = WinFormsUtil.GetIndex(CB_Species);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (species < 1 || species > pkm.MaxSpeciesID)
{ TB_Nickname.Text = ""; return; }
if (CHK_IsEgg.Checked)
species = 0; // get the egg name.
// If name is that of another language, don't replace the nickname
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (sender != CB_Language && species != 0 && !PKX.IsNicknamedAnyLanguage(species, TB_Nickname.Text, pkm.Format))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
TB_Nickname.Text = PKX.GetSpeciesNameGeneration(species, lang, pkm.Format);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (pkm.Format == 1)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
((PK1)pkm).SetNotNicknamed();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (pkm.Format == 2)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
((PK2)pkm).SetNotNicknamed();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateNicknameClick(object sender, MouseEventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
TextBox tb = sender as TextBox ?? TB_Nickname;
// Special Character Form
if (ModifierKeys != Keys.Control)
return;
var SAV = RequestSaveFile;
if (SAV == null) // form did not provide the needed info
return;
if (tb == TB_Nickname)
{
pkm.Nickname = tb.Text;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var d = new TrashEditor(tb, pkm.Nickname_Trash, SAV);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
d.ShowDialog();
tb.Text = d.FinalString;
pkm.Nickname_Trash = d.FinalBytes;
}
else if (tb == TB_OT)
{
pkm.OT_Name = tb.Text;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var d = new TrashEditor(tb, pkm.OT_Trash, SAV);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
d.ShowDialog();
tb.Text = d.FinalString;
pkm.OT_Trash = d.FinalBytes;
}
else if (tb == TB_OTt2)
{
pkm.HT_Name = tb.Text;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var d = new TrashEditor(tb, pkm.HT_Trash, SAV);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
d.ShowDialog();
tb.Text = d.FinalString;
pkm.HT_Trash = d.FinalBytes;
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateNotOT(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (string.IsNullOrWhiteSpace(TB_OTt2.Text))
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ClickGT(GB_OT, null); // Switch CT over to OT.
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Label_CTGender.Text = "";
TB_Friendship.Text = pkm.CurrentFriendship.ToString();
}
else if (string.IsNullOrWhiteSpace(Label_CTGender.Text))
Label_CTGender.Text = gendersymbols[0];
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateIsEgg(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Display hatch counter if it is an egg, Display Friendship if it is not.
Label_HatchCounter.Visible = CHK_IsEgg.Checked && pkm.Format > 1;
Label_Friendship.Visible = !CHK_IsEgg.Checked && pkm.Format > 1;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
pkm.IsEgg = CHK_IsEgg.Checked;
if (CHK_IsEgg.Checked)
{
TB_Friendship.Text = "1";
// If we are an egg, it won't have a met location.
CHK_AsEgg.Checked = true;
GB_EggConditions.Enabled = true;
CAL_MetDate.Value = new DateTime(2000, 01, 01);
// if egg wasn't originally obtained by OT => Link Trade, else => None
bool isTraded = false;
var SAV = SaveFileRequested?.Invoke(this, e);
if (SAV != null)
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
isTraded = SAV.OT != TB_OT.Text || SAV.TID != pkm.TID || SAV.SID != pkm.SID;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_MetLocation.SelectedIndex = isTraded ? 2 : 0;
if (!CHK_Nicknamed.Checked)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
TB_Nickname.Text = PKX.GetSpeciesNameGeneration(0, WinFormsUtil.GetIndex(CB_Language), pkm.Format);
Update level/egg behavior Similar to how anything higher than 255 is dropped to 100, setting level to 0 will overwrite it to 1. Current level is just a derived property from EXP, so it's just a display property in the editor. Toggling IsEgg for gen4 won't flag as nicknamed. #1257
2017-06-21 05:57:22 +00:00
if (pkm.Format != 4) // eggs in gen4 do not have nickname flag
CHK_Nicknamed.Checked = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Unhide language for gen1/2 saves Closes #1349 Add egg memory wiping when ticking as egg, Add egg memory setting when suggesting encounter info. Closes #1350 I'd rather have it this way as to not do cross-tab auto edits that the user may miss.
2017-08-06 03:30:33 +00:00
// Wipe egg memories
if (pkm.Format >= 6 && ModifyPKM)
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
pkm.ClearMemories();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
else // Not Egg
{
if (!CHK_Nicknamed.Checked)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateNickname(null, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_Friendship.Text = pkm.PersonalInfo.BaseFriendship.ToString();
if (CB_EggLocation.SelectedIndex == 0)
{
CAL_EggDate.Value = new DateTime(2000, 01, 01);
CHK_AsEgg.Checked = false;
GB_EggConditions.Enabled = false;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (TB_Nickname.Text == PKX.GetSpeciesNameGeneration(0, WinFormsUtil.GetIndex(CB_Language), pkm.Format))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CHK_Nicknamed.Checked = false;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateNickname(null, null);
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateMetAsEgg(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
GB_EggConditions.Enabled = CHK_AsEgg.Checked;
if (CHK_AsEgg.Checked)
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
CAL_EggDate.Value = DateTime.Now;
CB_EggLocation.SelectedIndex = 1;
return;
}
// Remove egg met data
CHK_IsEgg.Checked = false;
CAL_EggDate.Value = new DateTime(2000, 01, 01);
CB_EggLocation.SelectedValue = 0;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateShinyPID(object sender, EventArgs e)
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
{
var ShinyPID = pkm.Format <= 2 || ModifierKeys != Keys.Control;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateShiny(ShinyPID);
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateShiny(bool PID)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.PID = Util.GetHexValue(TB_PID.Text);
pkm.Nature = WinFormsUtil.GetIndex(CB_Nature);
Refactoring extract pkm loading routines to smaller methods reduce code duplication (rely on empty setters to ignore some calls) should be much easier to understand the load/save process; the original setup (pk6) was following the structure from 0x00-end, no point still doing that as everything is now abstracted.
2017-10-03 06:13:40 +00:00
pkm.Gender = PKX.GetGenderFromString(Label_Gender.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
pkm.AltForm = CB_Form.SelectedIndex;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.Version = WinFormsUtil.GetIndex(CB_GameOrigin);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (pkm.Format > 2)
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
{
Simplify Shiny SID creation calculates a passing SID and applies random bits to not be too predictable no need to bruteforce
2017-06-03 15:58:30 +00:00
if (PID)
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.SetShinyPID();
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
TB_PID.Text = pkm.PID.ToString("X8");
if (pkm.GenNumber < 6 && TB_EC.Visible)
TB_EC.Text = TB_PID.Text;
}
else
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.SetShinySID();
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
TID_Trainer.UpdateSID();
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
}
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
else
{
Add batch edit pk1/2 .PID=$shiny Closes #1419
2017-08-26 00:44:15 +00:00
pkm.SetShinyIVs();
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.LoadIVs(pkm.IVs);
Stats.UpdateIVs(null, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetIsShiny(null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
UpdatePreviewSprite?.Invoke(this, null);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateTSV(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (pkm.Format < 6)
return;
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
TID_Trainer.UpdateTSV();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.PID = Util.GetHexValue(TB_PID.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Tip3.SetToolTip(TB_PID, $"PSV: {pkm.PSV:d4}");
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void Update_ID(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Trim out nonhex characters
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
TB_PID.Text = Util.GetHexValue(TB_PID.Text).ToString("X8");
TB_EC.Text = Util.GetHexValue(TB_EC.Text).ToString("X8");
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetIsShiny(sender);
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.UpdateIVs(null, null); // If the EC is changed, EC%6 (Characteristic) might be changed.
if (pkm.Format <= 4 && FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = false;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.PID = Util.GetHexValue(TB_PID.Text);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_Nature.SelectedValue = pkm.Nature;
Label_Gender.Text = gendersymbols[pkm.Gender];
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Label_Gender.ForeColor = GetGenderColor(pkm.Gender);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateShadowID(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
FLP_Purification.Visible = NUD_ShadowID.Value > 0;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdatePurification(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CHK_Shadow.Checked = NUD_Purification.Value > 0;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void UpdateShadowCHK(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = false;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
NUD_Purification.Value = CHK_Shadow.Checked ? NUD_Purification.Maximum : 0;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsLoaded = true;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ValidateComboBox(object sender)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsInitialized)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
if (!(sender is ComboBox cb))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Misc simplifications Simplify some pkmeditor logic, pull out togglemarking
2018-05-27 17:24:28 +00:00
if (cb.Text.Length == 0 && cb.Items.Count > 0)
cb.SelectedIndex = 0;
else if (cb.SelectedValue == null)
cb.BackColor = InvalidSelectionColor;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
else
cb.ResetBackColor();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ValidateComboBox(object sender, CancelEventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (!(sender is ComboBox))
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ValidateComboBox(sender);
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
UpdateSprite();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ValidateComboBox2(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsInitialized)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ValidateComboBox(sender, null);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (sender == CB_Ability && pkm.Format >= 6)
TB_AbilityNumber.Text = (1 << CB_Ability.SelectedIndex).ToString();
if (sender == CB_Ability && pkm.Format <= 5 && CB_Ability.SelectedIndex < 2) // not hidden
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateRandomPID(sender, e);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
if (sender == CB_Nature && pkm.Format <= 4)
{
pkm.Nature = CB_Nature.SelectedIndex;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateRandomPID(sender, e);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
if (sender == CB_HeldItem || sender == CB_Ability)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateNatureModification(sender, null);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.UpdateIVs(null, null); // updating Nature will trigger stats to update as well
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ValidateMove(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsInitialized)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ValidateComboBox(sender);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
if (Moves.Contains(sender)) // Move
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdatePP(sender, e);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Legality
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
pkm.Moves = Moves.Select(WinFormsUtil.GetIndex).ToArray();
pkm.RelearnMoves = Relearn.Select(WinFormsUtil.GetIndex).ToArray();
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateLegality(skipMoveRepop: true);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ValidateMovePaint(object sender, DrawItemEventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
if (e.Index < 0) return;
Misc fixes/improvements Reduce memory usage for evo method banlist (static banlist references) Fix gen6 mega evo flag truncation simplify QR encode/decode logic a little Don't apply transparency if transparency is already 100% (skip the loop) Add gen5 wild pid/tid-sid correlation check Fix validation value reset (loading gen3-4 pkm without looking at met tab causes the met location to get reset); fixed by prematurely validating before setting the value Fix gen3 pkm with gen4 contest ribbons in gen4/5 getting flagged incorrectly
2017-08-13 07:21:42 +00:00
var i = (ComboItem)((ComboBox)sender).Items[e.Index];
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
var moves = Legality.AllSuggestedMovesAndRelearn;
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
bool vm = moves?.Contains(i.Value) == true && !HaX;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
bool current = (e.State & DrawItemState.Selected) == DrawItemState.Selected;
Brush tBrush = current ? SystemBrushes.HighlightText : new SolidBrush(e.ForeColor);
Brush brush = current ? SystemBrushes.Highlight : vm ? Brushes.PaleGreen : new SolidBrush(e.BackColor);
e.Graphics.FillRectangle(brush, e.Bounds);
e.Graphics.DrawString(i.Text, e.Font, tBrush, e.Bounds, StringFormat.GenericDefault);
if (current) return;
tBrush.Dispose();
if (!vm)
brush.Dispose();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void ValidateLocation(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ValidateComboBox(sender);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
if (!FieldsLoaded)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
pkm.Met_Location = WinFormsUtil.GetIndex(CB_MetLocation);
pkm.Egg_Location = WinFormsUtil.GetIndex(CB_EggLocation);
UpdateLegality();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
// Secondary Windows for Ribbons/Amie/Memories
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void OpenRibbons(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
new RibbonEditor(pkm).ShowDialog();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void OpenMedals(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
new SuperTrainingEditor(pkm).ShowDialog();
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void OpenHistory(object sender, EventArgs e)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Write back current values
pkm.HT_Name = TB_OTt2.Text;
pkm.OT_Name = TB_OT.Text;
pkm.IsEgg = CHK_IsEgg.Checked;
pkm.CurrentFriendship = Util.ToInt32(TB_Friendship.Text);
new MemoryAmie(pkm).ShowDialog();
TB_Friendship.Text = pkm.CurrentFriendship.ToString();
}
/// <summary>
/// Refreshes the interface for the current PKM format.
/// </summary>
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
/// <param name="sav">Save File context the editor is editing for</param>
/// <param name="pk">Pokémon data to edit</param>
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
public bool ToggleInterface(SaveFile sav, PKM pk)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
if (pk.GetType() != sav.PKMType || pkm.Format < 3)
pk = sav.BlankPKM;
pkm = pk;
ToggleInterface(pkm.Format);
ToggleInterface(pkm.GetType());
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
return FinalizeInterface(sav);
}
private void ToggleInterface(Type t)
{
FLP_Purification.Visible = FLP_ShadowID.Visible = t == typeof(XK3) || t == typeof(CK3);
}
private void ToggleInterface(int gen)
{
FLP_Country.Visible = FLP_SubRegion.Visible = FLP_3DSRegion.Visible = gen >= 6;
Label_EncryptionConstant.Visible = BTN_RerollEC.Visible = TB_EC.Visible = gen >= 6;
GB_nOT.Visible = GB_RelearnMoves.Visible = BTN_Medals.Visible = BTN_History.Visible = gen >= 6;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
PB_MarkPentagon.Visible = gen >= 6;
PB_MarkAlola.Visible = PB_MarkVC.Visible = PB_MarkHorohoro.Visible = gen >= 7;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
FLP_NSparkle.Visible = L_NSparkle.Visible = CHK_NSparkle.Visible = gen == 5;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
CB_Form.Visible = Label_Form.Visible = CHK_AsEgg.Visible = GB_EggConditions.Visible = PB_Mark5.Visible = PB_Mark6.Visible = gen >= 4;
FLP_ShinyLeaf.Visible = L_ShinyLeaf.Visible = ShinyLeaf.Visible = gen == 4;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
DEV_Ability.Enabled = DEV_Ability.Visible = gen > 3 && HaX;
CB_Ability.Visible = !DEV_Ability.Enabled && gen >= 3;
FLP_Nature.Visible = gen >= 3;
FLP_Ability.Visible = gen >= 3;
GB_ExtraBytes.Visible = GB_ExtraBytes.Enabled = gen >= 3;
GB_Markings.Visible = gen >= 3;
BTN_Ribbons.Visible = gen >= 3;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
CB_Form.Enabled = gen >= 3;
Add TrainerID control Now shows tid7/sid7 when gen7+
2018-04-28 16:34:54 +00:00
BTN_RerollPID.Visible = Label_PID.Visible = TB_PID.Visible = gen >= 3;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
FLP_FriendshipForm.Visible = gen >= 2;
FLP_HeldItem.Visible = gen >= 2;
Remove old (GF fixed) shiny correlation Transporter was updated
2017-09-06 16:12:56 +00:00
CHK_IsEgg.Visible = gen >= 2;
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
FLP_PKRS.Visible = FLP_EggPKRSRight.Visible = gen >= 2;
Label_OTGender.Visible = gen >= 2;
Remove old (GF fixed) shiny correlation Transporter was updated
2017-09-06 16:12:56 +00:00
Label_Gender.Visible = gen >= 1;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// HaX override, needs to be after DEV_Ability enabled assignment.
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
TB_AbilityNumber.Visible = gen >= 6 && DEV_Ability.Enabled;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Met Tab
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
FLP_MetDate.Visible = gen >= 4;
FLP_Fateful.Visible = FLP_Ball.Visible = FLP_OriginGame.Visible = gen >= 3;
FLP_MetLocation.Visible = FLP_MetLevel.Visible = gen >= 2;
Show Time of Day for gen2 apparently both controls were hidden also hide encountertype control panel when not applicable (shifts time of day up beneath other controls)
2017-10-21 02:53:38 +00:00
FLP_EncounterType.Visible = gen >= 4 && gen <= 6;
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
FLP_TimeOfDay.Visible = gen == 2;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Simplify conteststat editor usage make consistent with interface names
2018-06-03 05:04:32 +00:00
Contest.ToggleInterface(pkm, gen);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Stats.ToggleInterface(gen);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
CenterSubEditors();
}
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
private bool FinalizeInterface(SaveFile sav)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
bool init = FieldsInitialized;
FieldsInitialized = FieldsLoaded = false;
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
bool TranslationRequired = false;
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
PopulateFilteredDataSources(sav);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PopulateFields(pkm);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsInitialized |= init;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// SAV Specific Limits
TB_OT.MaxLength = pkm.OTLength;
TB_OTt2.MaxLength = pkm.OTLength;
TB_Nickname.MaxLength = pkm.NickLength;
// Hide Unused Tabs
if (pkm.Format == 1 && tabMain.TabPages.Contains(Tab_Met))
tabMain.TabPages.Remove(Tab_Met);
else if (pkm.Format != 1 && !tabMain.TabPages.Contains(Tab_Met))
{
tabMain.TabPages.Insert(1, Tab_Met);
TranslationRequired = true;
}
// Common HaX Interface
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
MT_Level.Enabled = MT_Level.Visible = MT_Form.Enabled = MT_Form.Visible = HaX;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
TB_Level.Visible = !HaX;
// Setup PKM Preparation/Extra Bytes
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetPKMFormatMode(pkm.Format);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// pk2 save files do not have an Origin Game stored. Prompt the met location list to update.
if (pkm.Format == 2)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
UpdateOriginGame(null, null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
return TranslationRequired;
}
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
private void CenterSubEditors()
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
// Recenter PKM SubEditors
FLP_PKMEditors.Location = new Point((Tab_OTMisc.Width - FLP_PKMEditors.Width) / 2, FLP_PKMEditors.Location.Y);
}
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Loading Setup
public void TemplateFields(PKM template)
{
if (template != null)
Fix misc problems flag undistributed gen3 events fix gen3 string writing (resized then expanded yields 00, missing terminator), closes #1204 fix stackoverflow, fix pkmeditor template loading save prompt, closes #1207
2017-06-09 03:57:30 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PopulateFields(template);
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
LastData = null;
Fix misc problems flag undistributed gen3 events fix gen3 string writing (resized then expanded yields 00, missing terminator), closes #1204 fix stackoverflow, fix pkmeditor template loading save prompt, closes #1207
2017-06-09 03:57:30 +00:00
return;
}
misc loading fix gen1/2 games with new pkm editor no longer cause an exception on init load
2017-05-23 15:28:53 +00:00
if (CB_GameOrigin.Items.Count > 0)
CB_GameOrigin.SelectedIndex = 0;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_Move1.SelectedValue = 1;
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
var info = new SimpleTrainerInfo{Language = Math.Max(0, WinFormsUtil.GetIndex(CB_Language))};
Apply default language if none Closes #1920
2018-05-01 01:48:21 +00:00
if (info.Language == 0)
Add 3 more advanced sorters Primary->Secondary typing Generation->Version Base Stat Total
2018-05-01 04:20:28 +00:00
info.Language = (int)LanguageID.English;
Add default trainer info use in pkmeditor and utilize
2018-03-29 01:52:50 +00:00
SetDetailsOT(info);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_Ball.SelectedIndex = Math.Min(0, CB_Ball.Items.Count - 1);
CAL_MetDate.Value = CAL_EggDate.Value = DateTime.Today;
CB_Species.SelectedValue = pkm.MaxSpeciesID;
CHK_Nicknamed.Checked = false;
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
LastData = null;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
public void EnableDragDrop(DragEventHandler enter, DragEventHandler drop)
{
AllowDrop = true;
DragDrop += drop;
foreach (TabPage tab in tabMain.TabPages)
{
tab.AllowDrop = true;
tab.DragEnter += enter;
tab.DragDrop += drop;
}
}
Refactoring pull out ability list generating refactor showdown set to an Action that can be overwritten from elsewhere
2017-12-22 06:55:33 +00:00
// ReSharper disable once FieldCanBeMadeReadOnly.Global
public Action<ShowdownSet> LoadShowdownSet;
private void LoadShowdownSetDefault(ShowdownSet Set)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
var pk = PreparePKM();
pk.ApplySetDetails(Set);
PopulateFields(pk);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
public void ChangeLanguage(SaveFile sav, PKM pk)
{
// Force an update to the met locations
Simplification invalid/unknown usages were incorrectly interchangable; dex-sets were looking at Unknown which was impossible for some cases. only use GameVersion.Unknown as a temp placeholder for later resolution by the user.
2018-03-12 01:07:48 +00:00
origintrack = GameVersion.Invalid;
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
bool alreadyInit = FieldsInitialized;
FieldsInitialized = false;
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
InitializeLanguage(sav);
CenterSubEditors();
PopulateFields(pk); // put data back in form
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
FieldsInitialized |= alreadyInit;
Refactoring reduce cross-class chatter, simplifly large methods to smaller pieces some speed improvements
2017-06-19 05:27:40 +00:00
}
public void FlickerInterface()
{
tabMain.SelectedTab = Tab_Met; // parent tab of CB_GameOrigin
tabMain.SelectedTab = Tab_Main; // first tab
}
private void InitializeLanguage(SaveFile SAV)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
ComboBox[] cbs =
{
CB_Country, CB_SubRegion, CB_3DSReg, CB_Language, CB_Ball, CB_HeldItem, CB_Species, DEV_Ability,
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
CB_Nature, CB_EncounterType, CB_GameOrigin,
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
};
Relocate some logic to core party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically
2018-03-26 02:05:49 +00:00
foreach (var cb in cbs)
InitializeBinding(cb);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Set the various ComboBox DataSources up with their allowed entries
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetCountrySubRegion(CB_Country, "countries");
CB_3DSReg.DataSource = Util.GetUnsortedCBList("regions3ds");
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
CB_EncounterType.DataSource = Util.GetCBList(GameInfo.Strings.encountertypelist, new[] { 0 }, Legal.Gen4EncounterTypes);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_Nature.DataSource = new BindingSource(GameInfo.NatureDataSource, null);
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
// Sub editors
Stats.InitializeDataSources();
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PopulateFilteredDataSources(SAV);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void PopulateFilteredDataSources(SaveFile SAV)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Refactoring pull out GameStrings add debug output for crystal headbutt trees fix qrpkm item access
2018-05-19 04:35:57 +00:00
GameInfo.Strings.SetItemDataSource(SAV.Version, SAV.Generation, SAV.MaxItemID, SAV.HeldItems, HaX);
Restrict data sources per savefile not pkm pkm is not restricted from ORAS (etc) values when on an XY (etc) save file; use the save file maxes and indication values. no reference to the pkm anymore! Closes #1546
2017-10-25 04:06:21 +00:00
if (SAV.Generation > 1)
CB_HeldItem.DataSource = new BindingSource(GameInfo.ItemDataSource.Where(i => i.Value <= SAV.MaxItemID).ToList(), null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var languages = Util.GetUnsortedCBList("languages");
Remove KOR language from gen3 selection add flag for non japanese lang gen3 eggs Closes #1747
2018-01-07 06:43:48 +00:00
if (SAV.Generation == 3)
languages.RemoveAll(l => l.Value >= (int)LanguageID.Korean);
else if (SAV.Generation < 7)
languages.RemoveAll(l => l.Value > (int)LanguageID.Korean);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
CB_Language.DataSource = languages;
Restrict data sources per savefile not pkm pkm is not restricted from ORAS (etc) values when on an XY (etc) save file; use the save file maxes and indication values. no reference to the pkm anymore! Closes #1546
2017-10-25 04:06:21 +00:00
CB_Ball.DataSource = new BindingSource(GameInfo.BallDataSource.Where(b => b.Value <= SAV.MaxBallID).ToList(), null);
CB_Species.DataSource = new BindingSource(GameInfo.SpeciesDataSource.Where(s => s.Value <= SAV.MaxSpeciesID).ToList(), null);
DEV_Ability.DataSource = new BindingSource(GameInfo.AbilityDataSource.Where(a => a.Value <= SAV.MaxAbilityID).ToList(), null);
Refactoring Extract game value limits Rearrange GameVersion util logic extensions add better gameversion fetch for generator (equivalent to pkmeditor)
2018-06-15 23:00:28 +00:00
var gamelist = GameUtil.GetVersionsWithinRange(SAV, SAV.Generation).ToList();
CB_GameOrigin.DataSource = new BindingSource(GameInfo.VersionDataSource.Where(g => gamelist.Contains((GameVersion)g.Value)).ToList(), null);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Set the Move ComboBoxes too..
Refactoring pull out GameStrings add debug output for crystal headbutt trees fix qrpkm item access
2018-05-19 04:35:57 +00:00
GameInfo.Strings.MoveDataSource = (HaX ? GameInfo.HaXMoveDataSource : GameInfo.LegalMoveDataSource).Where(m => m.Value <= SAV.MaxMoveID).ToList(); // Filter Z-Moves if appropriate
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
foreach (var cb in Moves.Concat(Relearn))
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Relocate some logic to core party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically
2018-03-26 02:05:49 +00:00
InitializeBinding(cb);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
cb.DataSource = new BindingSource(GameInfo.MoveDataSource, null);
}
}
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
private static List<string> GetSuggestionMessage(PKM pkm, int level, int location, int minlvl)
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
{
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
var suggestion = new List<string> { MsgPKMSuggestionStart };
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
if (pkm.Format >= 3)
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
{
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
var met_list = GameInfo.GetLocationList((GameVersion)pkm.Version, pkm.Format, egg: false);
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
var locstr = met_list.Find(loc => loc.Value == location).Text;
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
suggestion.Add($"{MsgPKMSuggestionMetLocation} {locstr}");
suggestion.Add($"{MsgPKMSuggestionMetLevel} {level}");
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
}
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
if (pkm.CurrentLevel < minlvl)
Extract main window strings to translatable class Similar to LegalityCheckStrings no resource files yet, will generate those tomorrow(?) some strings are not translatable (useless gen6 passerby export text), not really worth
2018-04-06 04:25:18 +00:00
suggestion.Add($"{MsgPKMSuggestionLevel} {minlvl}");
Refactoring WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator
2018-03-11 02:03:09 +00:00
return suggestion;
Relocate pkm stat controls to separate usercontrol splits the logic up change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
2018-02-27 05:22:35 +00:00
}
Relocate some logic to core party stats set when setting a slot to a save file simplify set/delete slotchange duplicate logic suggest better met locations beyond VC transfers hatching a gen6 egg applies memories automatically
2018-03-26 02:05:49 +00:00
private static void InitializeBinding(ListControl cb)
{
cb.DisplayMember = nameof(ComboItem.Text);
cb.ValueMember = nameof(ComboItem.Value);
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
}
Reference in a new issue Copy permalink