Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-19 08:53:28 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Moves/MoveLevelUp.cs

547 lines
23 KiB
C#
Raw Normal View History

Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
using System;
using System.Collections.Generic;
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
using static PKHeX.Core.Legal;
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
using static PKHeX.Core.GameVersion;
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
namespace PKHeX.Core
{
Expose move source classes for api purposes Not guaranteeing the method signature will be stable forever, but allows people to reference the public methods inside. Closes #3056
2020-10-27 16:25:33 +00:00
public static class MoveLevelUp
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Add move/enc/loc references
2018-11-12 06:49:17 +00:00
private static readonly LearnLookup
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
LearnLA = new(PersonalTable.LA, LevelUpLA, PLA),
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
LearnBDSP = new(PersonalTable.BDSP, LevelUpBDSP, BDSP),
Target type'd new
2020-12-22 01:17:56 +00:00
LearnSWSH = new(PersonalTable.SWSH, LevelUpSWSH, SWSH),
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnSM = new(PersonalTable.SM, LevelUpSM, SM),
Target type'd new
2020-12-22 01:17:56 +00:00
LearnUSUM = new(PersonalTable.USUM, LevelUpUSUM, USUM),
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnGG = new(PersonalTable.GG, LevelUpGG, Gen7b),
LearnXY = new(PersonalTable.XY, LevelUpXY, XY),
LearnAO = new(PersonalTable.AO, LevelUpAO, ORAS),
LearnBW = new(PersonalTable.BW, LevelUpBW, BW),
Target type'd new
2020-12-22 01:17:56 +00:00
LearnB2W2 = new(PersonalTable.B2W2, LevelUpB2W2, B2W2),
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnDP = new(PersonalTable.DP, LevelUpDP, DP),
LearnPt = new(PersonalTable.Pt, LevelUpPt, Pt),
Target type'd new
2020-12-22 01:17:56 +00:00
LearnHGSS = new(PersonalTable.HGSS, LevelUpHGSS, HGSS),
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnRSE = new(PersonalTable.RS, LevelUpRS, RSE),
LearnFRLG = new(PersonalTable.LG, LevelUpLG, FRLG),
LearnGS = new(PersonalTable.GS, LevelUpGS, GS),
LearnC = new(PersonalTable.C, LevelUpC, C),
LearnRB = new(PersonalTable.RB, LevelUpRB, RB),
LearnY = new(PersonalTable.Y, LevelUpY, YW);
public static LearnVersion GetIsLevelUpMove(PKM pkm, int species, int form, int maxLevel, int generation, int move, int minlvlG1, int minlvlG2, GameVersion version = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
HOME 2.0.0: Handle conversion behavior & restrictions (#3506) * Revises legality checks to account for traveling between the three game islands (PLA/BDSP/SWSH) * Adds conversion mechanisms between the three formats, as well as flexible conversion options to backfill missing data (thanks GameFreak/ILCA for opting for lossy conversion instead of updating the games). * Adds API abstractions for HOME data storage format (EKH/PKH format 1, aka EH1/PH1). * Revises some APIs for better usage: - `PKM` now exposes a `Context` to indicate the isolation context for legality purposes. - Some method signatures have changed to accept `Context` or `GameVersion` instead of a vague `int` for Generation. - Evolution History is now tracked in the Legality parse for specific contexts, rather than only per generation.
2022-05-31 04:43:52 +00:00
var restrict = pkm.IsMovesetRestricted();
if (restrict.IsRestricted)
version = restrict.Game;
Add move/enc/loc references
2018-11-12 06:49:17 +00:00
Use new switch statements
2020-12-24 01:14:38 +00:00
return generation switch
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
1 => GetIsLevelUp1(species, form, move, maxLevel, minlvlG1, version),
Use new switch statements
2020-12-24 01:14:38 +00:00
2 when move > MaxMoveID_1 && pkm.LearnMovesNew2Disallowed() => LearnNONE,
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
2 => GetIsLevelUp2(species, form, move, maxLevel, minlvlG2, version, pkm.Korean),
3 => GetIsLevelUp3(species, form, move, maxLevel, version),
4 => GetIsLevelUp4(species, form, move, maxLevel, version),
5 => GetIsLevelUp5(species, form, move, maxLevel, version),
6 => GetIsLevelUp6(species, form, move, maxLevel, version),
Permit Gen7b for GO even if location doesn't match Feeling like the Move fetching needs to shift away from Generation too.
2022-06-08 03:15:32 +00:00
7 => GetIsLevelUp7(species, form, move, (pkm.LGPE || pkm.GO) ? (GameVersion)pkm.Version : version), // move reminder can give any move 1-100
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
8 => GetIsLevelUp8(species, form, move, maxLevel, version),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => LearnNONE,
Use new switch statements
2020-12-24 01:14:38 +00:00
};
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
internal static LearnVersion GetIsLevelUp1(int species, int form, int move, int maxLevel, int minLevel, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (move > MaxMoveID_1)
return LearnNONE;
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
switch (ver)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
case Any: case RBY:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var first = LearnRB.GetIsLevelUpG1(species, form, move, maxLevel, minLevel);
var second = LearnY.GetIsLevelUpG1(species, form, move, maxLevel, minLevel);
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
if (!first.IsLevelUp)
return second;
if (!second.IsLevelUp)
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
return first;
Refactoring continued simplification core.cs is pretty much the following: misc one-off junk moveset fetch encounter table fetch evo chain fetch might eventually move things around a bit further for cleanliness so that misc meta junk is the only thing that remains in core.
2018-06-19 04:56:30 +00:00
return first.Level > second.Level ? second : first;
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case RD or BU or GN or RB:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnRB.GetIsLevelUpG1(species, form, move, maxLevel, minLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case YW:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnY.GetIsLevelUpG1(species, form, move, maxLevel, minLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
return LearnNONE;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp2(int species, int form, int move, int maxLevel, int minLevel, GameVersion ver = Any, bool korean = false)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
// No Korean Crystal
switch (ver)
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
case Any: case GSC:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var first = LearnGS.GetIsLevelUpMin(species, move, maxLevel, minLevel, form);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (first.IsLevelUp || korean)
return first;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnC.GetIsLevelUpMin(species, move, maxLevel, minLevel, form);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
Rename Silver SV->SI SV will likely be the lump for SCarlet and VIolet
2022-02-27 19:16:12 +00:00
case GD or SI or GS:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnGS.GetIsLevelUpMin(species, move, maxLevel, minLevel, form);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case C when !korean:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnC.GetIsLevelUpMin(species, move, maxLevel, minLevel, form);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return LearnNONE;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp3(int species, int form, int move, int lvlLevel, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (species == (int)Species.Deoxys)
Minor clean variable swaps, simplifications
2021-08-20 20:42:25 +00:00
return GetIsLevelUp3Deoxys(form, move, lvlLevel, ver);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
// Emerald level up tables are equal to R/S level up tables
switch (ver)
{
case Any:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var first = LearnRSE.GetIsLevelUp(species, form, move, lvlLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (first.IsLevelUp)
return first;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnFRLG.GetIsLevelUp(species, form, move, lvlLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case R or S or E or RS or RSE:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnRSE.GetIsLevelUp(species, form, move, lvlLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case FR or LG or FRLG:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnFRLG.GetIsLevelUp(species, form, move, lvlLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return LearnNONE;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp4(int species, int form, int move, int maxLevel, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
switch (ver)
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
case Any: case DPPt:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var first = LearnDP.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (first.IsLevelUp)
return first;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var second = LearnPt.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (second.IsLevelUp)
return second;
if (ver == DPPt) // stop here
return LearnNONE;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnHGSS.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case D or P or DP:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnDP.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Pt:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnPt.GetIsLevelUp(species, form, move, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case HG or SS or HGSS:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnHGSS.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return LearnNONE;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp5(int species, int form, int move, int maxLevel, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
switch (ver)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Any:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var first = LearnBW.GetIsLevelUp(species, form, move, maxLevel);
Comments: forme->form
2021-07-26 21:14:39 +00:00
if (first.IsLevelUp && species != 646) // Kyurem moves are same for both versions, but form movepool not present.
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
return first;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnB2W2.GetIsLevelUp(species, form, move, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case B or W or BW:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnBW.GetIsLevelUp(species, form, move, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case B2 or W2 or B2W2:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnB2W2.GetIsLevelUp(species, form, move, maxLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
return LearnNONE;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp6(int species, int form, int move, int maxLevel, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
switch (ver)
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Any:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var first = LearnXY.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (first.IsLevelUp)
return first;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnAO.GetIsLevelUp(species, form, move, maxLevel);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case X or Y or XY:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnXY.GetIsLevelUp(species, form, move, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case OR or AS or ORAS:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnAO.GetIsLevelUp(species, form, move, maxLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
return LearnNONE;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp7(int species, int form, int move, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
switch (ver)
{
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case GP or GE or GG or GO:
Add move/enc/loc references
2018-11-12 06:49:17 +00:00
return LearnGG.GetIsLevelUp(species, form, move);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Any:
Remove unreachable/const logic Earlier compares result in some logic being unnecessary The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
2020-06-28 03:44:14 +00:00
if (species > MaxSpeciesID_7_USUM)
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
return LearnNONE;
Remove unreachable/const logic Earlier compares result in some logic being unnecessary The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
2020-06-28 03:44:14 +00:00
var first = LearnUSUM.GetIsLevelUp(species, form, move);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (first.IsLevelUp)
return first;
Remove unreachable/const logic Earlier compares result in some logic being unnecessary The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
2020-06-28 03:44:14 +00:00
if (species > MaxSpeciesID_7)
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
return LearnNONE;
Remove unreachable/const logic Earlier compares result in some logic being unnecessary The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
2020-06-28 03:44:14 +00:00
return LearnSM.GetIsLevelUp(species, form, move);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case SN or MN or SM:
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (species > MaxSpeciesID_7)
return LearnNONE;
return LearnSM.GetIsLevelUp(species, form, move);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case US or UM or USUM:
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
if (species > MaxSpeciesID_7_USUM)
return LearnNONE;
return LearnUSUM.GetIsLevelUp(species, form, move);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
return LearnNONE;
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static LearnVersion GetIsLevelUp8(int species, int form, int move, int maxLevel, GameVersion ver = Any)
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
{
switch (ver)
{
case Any:
Update go slot list yield and move fetch
2020-11-19 05:34:40 +00:00
case GO:
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case SW or SH or SWSH:
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
if (species > MaxSpeciesID_8)
return LearnNONE;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnSWSH.GetIsLevelUp(species, form, move, maxLevel);
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
case PLA:
if (species > MaxSpeciesID_8a)
return LearnNONE;
return LearnLA.GetIsLevelUp(species, form, move, maxLevel);
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
case BD or SP or BDSP:
if (species > MaxSpeciesID_8b)
return LearnNONE;
return LearnBDSP.GetIsLevelUp(species, form, move, maxLevel);
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
}
return LearnNONE;
}
Minor clean variable swaps, simplifications
2021-08-20 20:42:25 +00:00
private static LearnVersion GetIsLevelUp3Deoxys(int form, int move, int lvl, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Minor clean variable swaps, simplifications
2021-08-20 20:42:25 +00:00
var moveset = GetDeoxysLearn3(form, ver);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
if (moveset == null)
return LearnNONE;
var lv = moveset.GetLevelLearnMove(move);
if (lv >= 0 && lv <= lvl)
return new LearnVersion(lv, GetDeoxysGameVersion3(form));
return LearnNONE;
}
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
private static GameVersion GetDeoxysGameVersion3(int form) => form switch
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
0 => RS,
1 => FR,
2 => LG,
3 => E,
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => Invalid,
Use more expression return style Reduces indentation & bracketing, a bit more concise
2021-01-02 01:08:49 +00:00
};
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
private static Learnset? GetDeoxysLearn3(int form, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
use some explicit dex numbers as enum
2019-06-01 17:22:49 +00:00
const int index = (int)Species.Deoxys;
Minor clean variable swaps, simplifications
2021-08-20 20:42:25 +00:00
if (ver != Any && Gen3.Contains(ver))
return GameData.GetLearnsets(ver)[index];
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Minor clean variable swaps, simplifications
2021-08-20 20:42:25 +00:00
return form switch
{
0 => LevelUpRS[index], // Normal
1 => LevelUpFR[index], // Attack
2 => LevelUpLG[index], // Defense
3 => LevelUpE[index], // Speed
_ => null,
};
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
public static IEnumerable<int> GetMovesLevelUp(PKM pkm, int species, int form, int maxLevel, int minlvlG1, int minlvlG2, GameVersion version, bool MoveReminder, int generation)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
HOME 2.0.0: Handle conversion behavior & restrictions (#3506) * Revises legality checks to account for traveling between the three game islands (PLA/BDSP/SWSH) * Adds conversion mechanisms between the three formats, as well as flexible conversion options to backfill missing data (thanks GameFreak/ILCA for opting for lossy conversion instead of updating the games). * Adds API abstractions for HOME data storage format (EKH/PKH format 1, aka EH1/PH1). * Revises some APIs for better usage: - `PKM` now exposes a `Context` to indicate the isolation context for legality purposes. - Some method signatures have changed to accept `Context` or `GameVersion` instead of a vague `int` for Generation. - Evolution History is now tracked in the Legality parse for specific contexts, rather than only per generation.
2022-05-31 04:43:52 +00:00
var restrict = pkm.IsMovesetRestricted();
if (restrict.IsRestricted)
version = restrict.Game;
Minor refactoring Change Ability array to IReadOnlyList, add method to check ability index in personal data Suppress some message warnings Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue. Simplify pk5 conversion
2020-09-06 17:53:13 +00:00
return generation switch
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
1 => GetMovesLevelUp1(species, form, maxLevel, minlvlG1, version),
2 => GetMovesLevelUp2(species, form, maxLevel, minlvlG2, pkm.Korean, pkm.LearnMovesNew2Disallowed(), version),
3 => GetMovesLevelUp3(species, form, maxLevel, version),
4 => GetMovesLevelUp4(species, form, maxLevel, version),
5 => GetMovesLevelUp5(species, form, maxLevel, version),
6 => GetMovesLevelUp6(species, form, maxLevel, version),
Permit Gen7b for GO even if location doesn't match Feeling like the Move fetching needs to shift away from Generation too.
2022-06-08 03:15:32 +00:00
7 => GetMovesLevelUp7(species, form, maxLevel, MoveReminder, pkm.LGPE || pkm.GO ? (GameVersion)pkm.Version : version),
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
8 => GetMovesLevelUp8(species, form, maxLevel, version),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
_ => Array.Empty<int>(),
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
};
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
Misc tweaks Add more direct legality analysis constructors evo count is >= 1 fix invalid test message disallow gen2 moves if transferred from gen1 use ^1 instead of len-1 for netcore test project
2020-01-17 07:22:54 +00:00
private static bool LearnMovesNew2Disallowed(this PKM pkm) => pkm.Format == 1 || (pkm.Format >= 7 && pkm.VC1);
Reject moves introduced by gsc in pk1/vc1 cases Closes #2005 (no tutor moves are new moves, just beam moves)
2018-06-15 01:52:43 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
internal static List<int> GetMovesLevelUp1(int species, int form, int maxLevel, int minLevel, GameVersion ver = Any)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp1(new List<int>(), ver, species, form, maxLevel, minLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp2(int species, int form, int maxLevel, int minLevel, bool korean, bool removeNewGSCMoves, GameVersion ver = Any)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
var moves = AddMovesLevelUp2(new List<int>(), ver, species, form, maxLevel, minLevel, korean);
Reject moves introduced by gsc in pk1/vc1 cases Closes #2005 (no tutor moves are new moves, just beam moves)
2018-06-15 01:52:43 +00:00
if (removeNewGSCMoves)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
moves.RemoveAll(m => m > MaxMoveID_1);
return moves;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp3(int species, int form, int maxLevel, GameVersion ver = Any)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp3(new List<int>(), ver, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp4(int species, int form, int maxLevel, GameVersion ver = Any)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp4(new List<int>(), ver, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp5(int species, int form, int maxLevel, GameVersion ver = Any)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp5(new List<int>(), ver, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp6(int species, int form, int maxLevel, GameVersion ver = Any)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp6(new List<int>(), ver, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp7(int species, int form, int maxLevel, bool MoveReminder, GameVersion ver = Any)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp7(new List<int>(), ver, species, form, maxLevel, MoveReminder);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> GetMovesLevelUp8(int species, int form, int maxLevel, GameVersion ver = Any)
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return AddMovesLevelUp8(new List<int>(), ver, species, form, maxLevel);
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
}
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
private static List<int> AddMovesLevelUp1(List<int> moves, GameVersion ver, int species, int form, int max, int min)
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
{
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
switch (ver)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Any: case RBY:
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
LearnRB.AddMoves1(moves, species, form, max, min);
return LearnY.AddMoves1(moves, species, form, max, min);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case RD or BU or GN or RB:
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
return LearnRB.AddMoves1(moves, species, form, max, min);
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case YW:
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
return LearnY.AddMoves1(moves, species, form, max, min);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
return moves;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
private static List<int> AddMovesLevelUp2(List<int> moves, GameVersion ver, int species, int form, int max, int min, bool korean)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
switch (ver)
{
case Any: case GSC:
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
LearnGS.AddMoves(moves, species, form, max, min);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (korean)
return moves;
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
return LearnC.AddMoves(moves, species, form, max, min);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
Rename Silver SV->SI SV will likely be the lump for SCarlet and VIolet
2022-02-27 19:16:12 +00:00
case GD or SI or GS:
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
return LearnGS.AddMoves(moves, species, form, max, min);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
case C when !korean:
Add altform permissive checks for gen1/2 Should always be zero, but necessary for regional variant evolutions needing to be excluded #2018 (not fixed yet)
2018-06-18 04:54:04 +00:00
return LearnC.AddMoves(moves, species, form, max, min);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
return moves;
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> AddMovesLevelUp3(List<int> moves, GameVersion ver, int species, int form, int maxLevel)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (species == (int)Species.Deoxys)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
var learn = GetDeoxysLearn3(form, ver);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
if (learn != null)
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
moves.AddRange(learn.GetMoves(maxLevel));
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return moves;
}
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
// Emerald level up tables are equal to R/S level up tables
switch (ver)
{
case Any:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnRSE.AddMoves(moves, species, form, maxLevel);
return LearnFRLG.AddMoves(moves, species, form, maxLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case R or S or E or RS or RSE:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnRSE.AddMoves(moves, species, form, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case FR or LG or FRLG:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnFRLG.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return moves;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> AddMovesLevelUp4(List<int> moves, GameVersion ver, int species, int form, int maxLevel)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
switch (ver)
{
case Any: case DPPt:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnDP.AddMoves(moves, species, form, maxLevel);
LearnPt.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (ver == DPPt) // stop here
return moves;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnHGSS.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case D or P or DP:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnDP.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
case Pt:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnPt.AddMoves(moves, species, form, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case HG or SS or HGSS:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnHGSS.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return moves;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> AddMovesLevelUp5(List<int> moves, GameVersion ver, int species, int form, int maxLevel)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
switch (ver)
{
case Any:
Comments: forme->form
2021-07-26 21:14:39 +00:00
if (species != 646) // Kyurem moves are same for both versions, but form movepool not present.
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnBW.AddMoves(moves, species, form, maxLevel);
return LearnB2W2.AddMoves(moves, species, form, maxLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case B or W or BW:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnBW.AddMoves(moves, species, form, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case B2 or W2 or B2W2:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnB2W2.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
return moves;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> AddMovesLevelUp6(List<int> moves, GameVersion ver, int species, int form, int maxLevel)
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
{
switch (ver)
{
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Any:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnXY.AddMoves(moves, species, form, maxLevel);
return LearnAO.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case X or Y or XY:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnXY.AddMoves(moves, species, form, maxLevel);
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case AS or OR or ORAS:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnAO.AddMoves(moves, species, form, maxLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
return moves;
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> AddMovesLevelUp7(List<int> moves, GameVersion ver, int species, int form, int maxLevel, bool reminder)
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
{
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
if (reminder)
maxLevel = 100; // Move reminder can teach any level in movepool now!
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
switch (ver)
{
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case GP or GE or GG or GO:
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnGG.AddMoves(moves, species, form, maxLevel);
Add move/enc/loc references
2018-11-12 06:49:17 +00:00
Split GetIsLevelUp to individual versions static the GameVersion reference as we're excessively using it in the switch cases, for clearer reading
2018-06-13 05:15:06 +00:00
case Any:
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (species > MaxSpeciesID_7_USUM)
return moves;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnUSUM.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (species > MaxSpeciesID_7)
return moves;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnSM.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case SN or MN or SM:
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (species > MaxSpeciesID_7)
return moves;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnSM.AddMoves(moves, species, form, maxLevel);
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case US or UM or USUM:
Tidy up MoveLevelUp use the Learn objects from prior commits for adding a range of moves
2018-06-14 05:03:58 +00:00
if (species > MaxSpeciesID_7_USUM)
return moves;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
LearnUSUM.AddMoves(moves, species, form, maxLevel);
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
break;
}
return moves;
}
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
private static List<int> AddMovesLevelUp8(List<int> moves, GameVersion ver, int species, int form, int maxLevel)
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
// Move reminder can NOT teach any level like Gen7
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
switch (ver)
{
case Any:
Update go slot list yield and move fetch
2020-11-19 05:34:40 +00:00
case GO:
Condense some switch expressions Should be it for now; exhaustively searched for all that made sense to change
2020-12-25 18:58:33 +00:00
case SW or SH or SWSH:
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
if (species > MaxSpeciesID_8)
return moves;
Move min level check for gen1/2 closer to move adder Check per-evolution min level rather than basing it on the original encounter data. Correctly parses stuff like a captured level 23 Nidorina that immediately evolves into Nidoqueen, then learns Body Slam. Passing zero is better than passing 1, as 0 requires no value pushing. tidy up method signatures in MoveLevelUp so that species is followed by form, and the lookups are textually aligned. Clarify "maxLevel" instead of max/lvl, same as min.
2021-07-23 04:25:15 +00:00
return LearnSWSH.AddMoves(moves, species, form, maxLevel);
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
case PLA:
if (species > MaxSpeciesID_8a)
return moves;
return LearnLA.AddMoves(moves, species, form, maxLevel);
Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) Big thanks to @SciresM @sora10pls @Lusamine @architdate @ReignOfComputer for testing and contributing code / test cases. Can't add co-authors from the PR menu :( Builds will fail because azure pipelines not yet updated with net6.
2021-11-20 02:23:49 +00:00
case BD or SP or BDSP:
if (species > MaxSpeciesID_8b)
return moves;
return LearnBDSP.AddMoves(moves, species, form, maxLevel);
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
}
return moves;
}
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
public static int[] GetEncounterMoves(PKM pk, int level, GameVersion version)
{
Add missing learn/personal references for pairs Closes #2019
2018-06-18 03:49:03 +00:00
if (version <= 0)
version = (GameVersion)pk.Version;
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
return GetEncounterMoves(pk.Species, pk.Form, level, version);
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
}
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
private static int[] GetEncounterMoves1(int species, int level, GameVersion version)
{
var learn = GameData.GetLearnsets(version);
var table = GameData.GetPersonal(version);
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
var index = table.GetFormIndex(species, 0);
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
var lvl0 = (int[])((PersonalInfoG1) table[index]).Moves.Clone();
Use IndexOf instead of FindIndex when possible
2021-01-16 20:47:02 +00:00
int start = Math.Max(0, Array.IndexOf(lvl0, 0));
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
learn[index].SetEncounterMoves(level, lvl0, start);
return lvl0;
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
}
Misc style & minor tweaks Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes
2018-08-03 03:11:42 +00:00
Refactoring remove some unneeded logic moves in gen1/2 can be reordered, sequence match should be intersect (full) contains match.
2018-06-19 02:57:32 +00:00
private static int[] GetEncounterMoves2(int species, int level, GameVersion version)
{
var learn = GameData.GetLearnsets(version);
var table = GameData.GetPersonal(version);
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
var index = table.GetFormIndex(species, 0);
Refactoring remove some unneeded logic moves in gen1/2 can be reordered, sequence match should be intersect (full) contains match.
2018-06-19 02:57:32 +00:00
var lvl0 = learn[species].GetEncounterMoves(1);
Use IndexOf instead of FindIndex when possible
2021-01-16 20:47:02 +00:00
int start = Math.Max(0, Array.IndexOf(lvl0, 0));
Refactoring remove some unneeded logic moves in gen1/2 can be reordered, sequence match should be intersect (full) contains match.
2018-06-19 02:57:32 +00:00
Update PKHeX.Core abstractions with latest logic Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com> Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2022-02-05 01:35:15 +00:00
learn[index].SetEncounterMoves(level, lvl0, start);
return lvl0;
Refactoring remove some unneeded logic moves in gen1/2 can be reordered, sequence match should be intersect (full) contains match.
2018-06-19 02:57:32 +00:00
}
Add special handling for gen1 encounter move fetch Begin splitting of GetMovesLevelUp per-gen into per-version
2018-06-13 01:35:56 +00:00
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
public static int[] GetEncounterMoves(int species, int form, int level, GameVersion version)
{
Refactoring remove some unneeded logic moves in gen1/2 can be reordered, sequence match should be intersect (full) contains match.
2018-06-19 02:57:32 +00:00
if (RBY.Contains(version))
return GetEncounterMoves1(species, level, version);
if (GSC.Contains(version))
return GetEncounterMoves2(species, level, version);
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
var learn = GameData.GetLearnsets(version);
var table = GameData.GetPersonal(version);
Unify concepts with different names AltForm & Form & Forme => Form GenNumber & Generation => Generation Extract out SpeciesForm interface, and re-add IGeneration For those using PKHeX as a dependency, this should be a pretty straightforward manual replacement... GenNumber and AltForm should be quick find-replace`s.
2020-12-11 04:42:30 +00:00
var index = table.GetFormIndex(species, form);
Refactoring fix b2w2 egg base levelup reference (not bw, b2w2!), doesn't really matter much except for better indication (possibly?) remove some unnecessary linq ToArray() calls continue relocating code out of Core
2018-06-11 00:55:03 +00:00
return learn[index].GetEncounterMoves(level);
}
Refactoring pull out some move data fetching to separate class add methods to quickly fetch if the move is learnable via that method eventual plan is this: replace 'fetch all possible moves then look within' move validation with: 'peek if learnable, and get info how' move validation advantages: - returns game the move was learned in and the level (if appropriate) - infinitely less object creation (garbage collection) - only looks for a given move, doesn't have to fetch everything before checking - faster than full fetch, can be made even faster by optimizing lookups. subject to change :)
2018-06-09 03:10:41 +00:00
}
}
Reference in a new issue Copy permalink