Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2025-02-18 14:28:33 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Verifiers/NHarmoniaVerifier.cs

50 lines
1.7 KiB
C#
Raw Normal View History

Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 10:49:11 -07:00
using static PKHeX.Core.LegalityCheckStrings;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
namespace PKHeX.Core
{
Misc simplifications / xmldoc
2018-07-01 19:17:37 -07:00
/// <summary>
/// Verifies the <see cref="PK5.NPokémon"/> data.
/// </summary>
public sealed class NHarmoniaVerifier : Verifier
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
{
protected override CheckIdentifier Identifier => CheckIdentifier.Trainer;
public override void Verify(LegalityAnalysis data)
{
var pkm = data.pkm;
Minor clean
2021-01-10 18:15:33 -08:00
bool checksRequired = data.EncounterMatch is EncounterStatic5N;
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
if (pkm is PK5 pk5)
{
bool has = pk5.NPokémon;
if (checksRequired && !has)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 14:11:12 -07:00
data.AddLine(GetInvalid(LG5SparkleRequired, CheckIdentifier.Fateful));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
if (!checksRequired && has)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 14:11:12 -07:00
data.AddLine(GetInvalid(LG5SparkleInvalid, CheckIdentifier.Fateful));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
}
if (!checksRequired)
return;
Add OT gender check for N's Pokemon Closes #3110 ty @FeralFalcon !
2020-12-23 18:03:05 -08:00
if (pkm.OT_Gender != 0)
Mark EncounterSlot/Static types as immutable record types
2020-12-23 20:40:59 -08:00
data.AddLine(GetInvalid(LG5OTGenderN, CheckIdentifier.Trainer));
Reduce linq usage reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset
2018-07-01 10:49:11 -07:00
if (pkm.IVTotal != 30*6)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 14:11:12 -07:00
data.AddLine(GetInvalid(LG5IVAll30, CheckIdentifier.IVs));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
if (!VerifyNsPKMOTValid(pkm))
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 14:11:12 -07:00
data.AddLine(GetInvalid(LG5ID_N, CheckIdentifier.Trainer));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
if (pkm.IsShiny)
Update legality check message string style V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK
2018-09-01 14:11:12 -07:00
data.AddLine(GetInvalid(LG5PIDShinyN, CheckIdentifier.Shiny));
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
}
Respacening Style guidelines, handle a bunch of files no functional change
2018-07-26 19:34:27 -07:00
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
private static bool VerifyNsPKMOTValid(PKM pkm)
{
if (pkm.TID != 00002 || pkm.SID != 00000)
return false;
var ot = pkm.OT_Name;
if (ot.Length != 1)
return false;
Relocate N OT logic Make Legal.cs not care about encounter data :)
2020-10-06 20:09:14 -07:00
var c = EncounterStatic5N.GetOT(pkm.Language);
Rework secondary check flow Checks.cs initially started out small, but over the years it has grown to handle multiple types of checks. With all these checks next to eachother, it's hard to see the overall groups. Splitting them up (potentially further?) allows for more focused maintenance & understanding. Not sure if I'm happy with the overall bandaids used (checks no longer done within LegalityAnalysis so variable repointing is excessively used), but I'm happier the way it is now compared to the huge Checks.cs
2018-06-23 22:00:01 -07:00
return c == ot;
}
}
}
Reference in a new issue Copy permalink