Mirrors/yewprint
2
0
Fork 0
mirror of https://github.com/yewprint/yewprint synced 2025-02-16 12:08:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove Hash from the HtmlSelect (#109)

Browse source
This commit is contained in:
Yohan Boogaert 2021-06-03 13:21:44 +02:00 • committed by GitHub
parent 357e0fefde
commit 21864240a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
yewprint-doc/src/html_select/example.rs
View file

@ -1,5 +1,5 @@
use yew::prelude::*;
use yewprint::HtmlSelect;
use yewprint::{HtmlSelect, Text};
pub struct Example {
props: ExampleProps,
@ -61,12 +61,13 @@ impl Component for Example {
onchange=self.link.callback(|x| x)
title=format!("Selected: {:?}", self.log_level)
/>
<Text>{format!("Selected: {:?}", self.log_level)}</Text>
</div>
}
}
}
#[derive(Debug, Clone, Copy, Hash, PartialEq)]
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum LogLevel {
Trace,
Debug,

25
yewprint/src/html_select.rs
View file

@ -1,9 +1,7 @@
use crate::{Icon, IconName};
use std::collections::hash_map::DefaultHasher;
use std::hash::{Hash, Hasher};
use yew::prelude::*;
pub struct HtmlSelect<T: Clone + PartialEq + Hash + 'static> {
pub struct HtmlSelect<T: Clone + PartialEq + 'static> {
props: HtmlSelectProps<T>,
link: ComponentLink<Self>,
}
@ -24,14 +22,14 @@ pub struct HtmlSelectProps<T: Clone + PartialEq + 'static> {
pub title: Option<String>,
#[prop_or_default]
pub onchange: Callback<T>,
pub options: Vec<(T, String)>,
#[prop_or_default]
pub value: Option<T>,
pub options: Vec<(T, String)>,
#[prop_or_default]
pub class: Classes,
}
impl<T: Clone + PartialEq + Hash + 'static> Component for HtmlSelect<T> {
impl<T: Clone + PartialEq + 'static> Component for HtmlSelect<T> {
type Message = ChangeData;
type Properties = HtmlSelectProps<T>;
@ -74,14 +72,9 @@ impl<T: Clone + PartialEq + Hash + 'static> Component for HtmlSelect<T> {
.as_ref()
.map(|x| value == x)
.unwrap_or_default();
let value = {
let mut hasher = DefaultHasher::new();
value.hash(&mut hasher);
hasher.finish()
};
html! {
<option selected=selected value=value.to_string()>
<option selected=selected>
{label}
</option>
}
@ -102,16 +95,8 @@ impl<T: Clone + PartialEq + Hash + 'static> Component for HtmlSelect<T> {
<select
disabled=self.props.disabled
onchange={self.link.callback(|x| x)}
value={
self.props.value
.as_ref()
.map(|value| {
let mut hasher = DefaultHasher::new();
value.hash(&mut hasher);
hasher.finish().to_string()
})
}
title={self.props.title.clone()}
value={"".to_string()}
>
{option_children}
</select>