cleanup of various warnings from clangd (#3682)

* cleanup of various warnings from clangs
* lfrfid_debug: cast fixes
* subghz: binraw: round->roundf
* furi: thread: updated internal stack size variable to size_t
* github: fail faster on unsuccessful build
* unit_tests: double trouble

.clangd

@@ -5,6 +5,10 @@ CompileFlags:
     Remove: 
         - -mword-relocations
 
+Diagnostics:
+    ClangTidy:
+        FastCheckFilter: None
+
 ---
 
 If:

.github/workflows/unit_tests.yml

@@ -64,6 +64,6 @@ jobs:
           python3 scripts/testing/units.py ${{steps.device.outputs.flipper}}
 
       - name: 'Check GDB output'
-        if: failure()
+        if: failure() && steps.flashing.outcome == 'success'
         run: |
           ./fbt gdb_trace_all SWD_TRANSPORT_SERIAL=2A0906016415303030303032 LIB_DEBUG=1 FIRMWARE_APP_SET=unit_tests FORCE=1

applications/debug/accessor/scene/accessor_scene_start.cpp

@@ -1,7 +1,6 @@
 #include "../accessor_app.h"
 #include "../accessor_view_manager.h"
 #include "../accessor_event.h"
-#include "callback_connector.h"
 #include "accessor_scene_start.h"
 
 void AccessorSceneStart::on_enter(AccessorApp* app) {

applications/debug/battery_test_app/views/battery_info.c

@@ -68,7 +68,7 @@ static void draw_battery(Canvas* canvas, BatteryInfoModel* data, int x, int y) {
             drain_current > HIGH_DRAIN_CURRENT_THRESHOLD ? "mA!" : "mA");
     } else if(drain_current != 0) {
         snprintf(header, 20, "...");
-    } else if(data->charging_voltage < 4.2) {
+    } else if(data->charging_voltage < 4.2f) {
         // Non-default battery charging limit, mention it
         snprintf(emote, sizeof(emote), "Charged!");
         snprintf(header, sizeof(header), "Limited to");

applications/debug/display_test/display_test.c

@@ -1,5 +1,3 @@
-#include "display_test.h"
-
 #include <furi_hal.h>
 #include <furi.h>
 

applications/debug/display_test/display_test.h

@@ -1 +0,0 @@
-#pragma once

applications/debug/lfrfid_debug/views/lfrfid_debug_view_tune.c

@@ -34,8 +34,8 @@ static void lfrfid_debug_view_tune_draw_callback(Canvas* canvas, void* _model) {
     canvas_set_color(canvas, ColorBlack);
 
     char buffer[TEMP_STR_LEN + 1];
-    double freq = ((float)SystemCoreClock / ((float)model->ARR + 1));
+    double freq = ((double)SystemCoreClock / (model->ARR + 1));
-    double duty = ((float)model->CCR + 1) / ((float)model->ARR + 1) * 100.0f;
+    double duty = (double)((model->CCR + 1) * 100) / (model->ARR + 1);
     snprintf(
         buffer,
         TEMP_STR_LEN,

applications/debug/subghz_test/scenes/subghz_test_scene.c

@@ -1,4 +1,4 @@
-#include "../subghz_test_app_i.h"
+#include "../subghz_test_app_i.h" // IWYU pragma: keep
 
 // Generate scene on_enter handlers array
 #define ADD_SCENE(prefix, name, id) prefix##_scene_##name##_on_enter,

applications/debug/subghz_test/subghz_test_app_i.c

@@ -1,5 +1,3 @@
-#include "subghz_test_app_i.h"
-
 #include <furi.h>
 
 #define TAG "SubGhzTest"

applications/debug/subghz_test/views/subghz_test_carrier.c

@@ -1,5 +1,4 @@
 #include "subghz_test_carrier.h"
-#include "../subghz_test_app_i.h"
 #include "../helpers/subghz_test_frequency.h"
 #include <lib/subghz/devices/cc1101_configs.h>
 
@@ -74,7 +73,7 @@ void subghz_test_carrier_draw(Canvas* canvas, SubGhzTestCarrierModel* model) {
             sizeof(buffer),
             "RSSI: %ld.%ld dBm",
             (int32_t)(model->rssi),
-            (int32_t)fabs(model->rssi * 10) % 10);
+            (int32_t)fabsf(model->rssi * 10.f) % 10);
         canvas_draw_str(canvas, 0, 42, buffer);
     } else {
         canvas_draw_str(canvas, 0, 42, "TX");

applications/debug/subghz_test/views/subghz_test_packet.c

@@ -1,5 +1,4 @@
 #include "subghz_test_packet.h"
-#include "../subghz_test_app_i.h"
 #include "../helpers/subghz_test_frequency.h"
 #include <lib/subghz/devices/cc1101_configs.h>
 
@@ -123,7 +122,7 @@ static void subghz_test_packet_draw(Canvas* canvas, SubGhzTestPacketModel* model
             sizeof(buffer),
             "RSSI: %ld.%ld dBm",
             (int32_t)(model->rssi),
-            (int32_t)fabs(model->rssi * 10) % 10);
+            (int32_t)fabsf(model->rssi * 10.0f) % 10);
         canvas_draw_str(canvas, 0, 53, buffer);
     } else {
         canvas_draw_str(canvas, 0, 53, "TX");

applications/debug/subghz_test/views/subghz_test_static.c

@@ -1,9 +1,7 @@
 #include "subghz_test_static.h"
-#include "../subghz_test_app_i.h"
 #include "../helpers/subghz_test_frequency.h"
 #include <lib/subghz/devices/cc1101_configs.h>
 
-#include <math.h>
 #include <furi.h>
 #include <furi_hal.h>
 #include <input/input.h>

applications/debug/unit_tests/tests/bit_lib/bit_lib_test.c

@@ -1,5 +1,5 @@
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <bit_lib/bit_lib.h>
 
 MU_TEST(test_bit_lib_increment_index) {

applications/debug/unit_tests/tests/bt/bt_test.c

@@ -1,6 +1,6 @@
 #include <furi.h>
 #include <furi_hal.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #include <bt/bt_service/bt_keys_storage.h>
 #include <storage/storage.h>

applications/debug/unit_tests/tests/compress/compress_test.c

@@ -1,4 +1,4 @@
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #include <toolbox/compress.h>
 

applications/debug/unit_tests/tests/datetime/datetimelib_test.c

@@ -1,5 +1,5 @@
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #include <datetime/datetime.h>
 

applications/debug/unit_tests/tests/dialogs_file_browser_options/dialogs_file_browser_options.c

@@ -1,6 +1,6 @@
 #include <dialogs/dialogs.h>
 
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 MU_TEST(test_dialog_file_browser_set_basic_options_should_init_all_fields) {
     mu_assert(

applications/debug/unit_tests/tests/dirwalk/dirwalk_test.c

@@ -1,4 +1,4 @@
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <furi.h>
 #include <m-dict.h>
 #include <toolbox/dir_walk.h>

applications/debug/unit_tests/tests/expansion/expansion_test.c

@@ -1,4 +1,4 @@
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #include <furi.h>
 #include <furi_hal_random.h>

applications/debug/unit_tests/tests/flipper_format/flipper_format_test.c

@@ -2,7 +2,7 @@
 #include <flipper_format/flipper_format.h>
 #include <flipper_format/flipper_format_i.h>
 #include <toolbox/stream/stream.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #define TEST_DIR TEST_DIR_NAME "/"
 #define TEST_DIR_NAME EXT_PATH("unit_tests_tmp")

applications/debug/unit_tests/tests/flipper_format_string/flipper_format_string_test.c

@@ -3,7 +3,7 @@
 #include <flipper_format/flipper_format_i.h>
 #include <toolbox/stream/stream.h>
 #include <storage/storage.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 static const char* test_filetype = "Flipper Format test";
 static const uint32_t test_version = 666;

applications/debug/unit_tests/tests/float_tools/float_tools_test.c

@@ -1,7 +1,7 @@
 #include <float.h>
 #include <float_tools.h>
 
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 MU_TEST(float_tools_equal_test) {
     mu_check(float_is_equal(FLT_MAX, FLT_MAX));

applications/debug/unit_tests/tests/furi/furi_memmgr_test.c

@@ -1,4 +1,4 @@
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>

applications/debug/unit_tests/tests/furi/furi_pubsub_test.c

@@ -1,7 +1,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 const uint32_t context_value = 0xdeadbeef;
 const uint32_t notify_value_0 = 0x12345678;

applications/debug/unit_tests/tests/furi/furi_record_test.c

@@ -1,7 +1,5 @@
-#include <stdio.h>
-#include <string.h>
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #define TEST_RECORD_NAME "test/holding"
 

applications/debug/unit_tests/tests/furi/furi_test.c

@@ -1,7 +1,6 @@
-#include <stdio.h>
 #include <furi.h>
 #include <furi_hal.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 // v2 tests
 void test_furi_create_open(void);

applications/debug/unit_tests/tests/furi_hal/furi_hal_tests.c

@@ -1,11 +1,9 @@
-#include "furi_hal_rtc.h"
 #include <stdint.h>
 #include <stdio.h>
 #include <furi.h>
 #include <furi_hal.h>
 #include <lp5562_reg.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
-#include <stdlib.h>
 
 #define DATA_SIZE 4
 #define EEPROM_ADDRESS 0b10101000

applications/debug/unit_tests/tests/furi_hal_crypto/furi_hal_crypto_tests.c

@@ -1,7 +1,6 @@
-#include <stdio.h>
 #include <furi.h>
 #include <furi_hal.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 static const uint8_t key_ctr_1[32] = {
     0x77, 0x6B, 0xEF, 0xF2, 0x85, 0x1D, 0xB0, 0x6F, 0x4C, 0x8A, 0x05, 0x42, 0xC8, 0x69, 0x6F, 0x6C,

applications/debug/unit_tests/tests/furi_string/furi_string_test.c

@@ -1,5 +1,5 @@
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 static void test_setup(void) {
 }

applications/debug/unit_tests/tests/infrared/infrared_test.c

@@ -2,7 +2,7 @@
 #include <flipper_format.h>
 #include <infrared.h>
 #include <common/infrared_common_i.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #define IR_TEST_FILES_DIR EXT_PATH("unit_tests/infrared/")
 #define IR_TEST_FILE_PREFIX "test_"

applications/debug/unit_tests/tests/lfrfid/lfrfid_protocols.c

@@ -1,5 +1,5 @@
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <toolbox/protocols/protocol_dict.h>
 #include <lfrfid/protocols/lfrfid_protocols.h>
 #include <toolbox/pulse_protocols/pulse_glue.h>

applications/debug/unit_tests/tests/manifest/manifest.c

@@ -1,5 +1,5 @@
-#include <furi.c>
+#include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <update_util/resources/manifest.h>
 
 #define TAG "Manifest"

applications/debug/unit_tests/tests/nfc/nfc_test.c

@@ -24,7 +24,7 @@
 #include <toolbox/keys_dict.h>
 #include <nfc/nfc.h>
 
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #define TAG "NfcTest"
 

applications/debug/unit_tests/tests/power/power_test.c

@@ -1,6 +1,6 @@
 #include <furi.h>
 #include <furi_hal.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 static void power_test_deinit(void) {
     // Try to reset to default charge voltage limit
@@ -13,46 +13,47 @@ MU_TEST(test_power_charge_voltage_limit_exact) {
     //
     // This test may need adapted if other charge controllers are used in the future.
     for(uint16_t charge_mv = 3840; charge_mv <= 4208; charge_mv += 16) {
-        float charge_volt = (float)charge_mv / 1000.0f;
+        float charge_volt = (float)charge_mv / 1000;
         furi_hal_power_set_battery_charge_voltage_limit(charge_volt);
-        mu_assert_double_eq(charge_volt, furi_hal_power_get_battery_charge_voltage_limit());
+        mu_assert_double_eq(
+            (double)charge_volt, (double)furi_hal_power_get_battery_charge_voltage_limit());
     }
 }
 
 MU_TEST(test_power_charge_voltage_limit_floating_imprecision) {
     // 4.016f should act as 4.016 V, even with floating point imprecision
     furi_hal_power_set_battery_charge_voltage_limit(4.016f);
-    mu_assert_double_eq(4.016f, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(4.016, (double)furi_hal_power_get_battery_charge_voltage_limit());
 }
 
 MU_TEST(test_power_charge_voltage_limit_inexact) {
     // Charge voltage limits that are not power of 16mV get truncated down
     furi_hal_power_set_battery_charge_voltage_limit(3.841f);
-    mu_assert_double_eq(3.840, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(3.840, (double)furi_hal_power_get_battery_charge_voltage_limit());
 
     furi_hal_power_set_battery_charge_voltage_limit(3.900f);
-    mu_assert_double_eq(3.888, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(3.888, (double)furi_hal_power_get_battery_charge_voltage_limit());
 
     furi_hal_power_set_battery_charge_voltage_limit(4.200f);
-    mu_assert_double_eq(4.192, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(4.192, (double)furi_hal_power_get_battery_charge_voltage_limit());
 }
 
 MU_TEST(test_power_charge_voltage_limit_invalid_clamped) {
     // Out-of-range charge voltage limits get clamped to 3.840 V and 4.208 V
     furi_hal_power_set_battery_charge_voltage_limit(3.808f);
-    mu_assert_double_eq(3.840, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(3.840, (double)furi_hal_power_get_battery_charge_voltage_limit());
     furi_hal_power_set_battery_charge_voltage_limit(1.0f);
-    mu_assert_double_eq(3.840, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(3.840, (double)furi_hal_power_get_battery_charge_voltage_limit());
 
     // NOTE: Intentionally picking a small increment above 4.208 V to reduce the risk of an
     // unhappy battery if this fails.
     furi_hal_power_set_battery_charge_voltage_limit(4.240f);
-    mu_assert_double_eq(4.208, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(4.208, (double)furi_hal_power_get_battery_charge_voltage_limit());
     // Likewise, picking a number that the uint8_t wraparound in the driver would result in a
     // VREG value under 23 if this test fails.
     // E.g. (uint8_t)((8105-3840)/16) -> 10
     furi_hal_power_set_battery_charge_voltage_limit(8.105f);
-    mu_assert_double_eq(4.208, furi_hal_power_get_battery_charge_voltage_limit());
+    mu_assert_double_eq(4.208, (double)furi_hal_power_get_battery_charge_voltage_limit());
 }
 
 MU_TEST_SUITE(test_power_suite) {

applications/debug/unit_tests/tests/protocol_dict/protocol_dict_test.c

@@ -1,5 +1,5 @@
 #include <furi.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <toolbox/protocols/protocol_dict.h>
 
 typedef enum {

applications/debug/unit_tests/tests/rpc/rpc_test.c

@@ -17,7 +17,7 @@
 #include <lib/toolbox/path.h>
 
 #include <m-list.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #include <protobuf_version.h>
 #include <pb.h>

applications/debug/unit_tests/tests/storage/storage_test.c

@@ -1,4 +1,4 @@
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <furi.h>
 #include <storage/storage.h>
 

applications/debug/unit_tests/tests/stream/stream_test.c

@@ -4,7 +4,7 @@
 #include <toolbox/stream/file_stream.h>
 #include <toolbox/stream/buffered_file_stream.h>
 #include <storage/storage.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 static const char* stream_test_data = "I write differently from what I speak, "
                                       "I speak differently from what I think, "

applications/debug/unit_tests/tests/subghz/subghz_test.c

@@ -1,6 +1,6 @@
 #include <furi.h>
 #include <furi_hal.h>
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 #include <lib/subghz/receiver.h>
 #include <lib/subghz/transmitter.h>
 #include <lib/subghz/subghz_keystore.h>

applications/debug/unit_tests/tests/varint/varint_test.c

@@ -1,7 +1,7 @@
 #include <furi.h>
 #include <furi_hal.h>
 
-#include "../test.h"
+#include "../test.h" // IWYU pragma: keep
 
 #include <toolbox/varint.h>
 #include <toolbox/profiler.h>

applications/main/archive/helpers/archive_apps.c

@@ -1,4 +1,3 @@
-#include "archive_files.h"
 #include "archive_apps.h"
 #include "archive_browser.h"
 

applications/main/archive/helpers/archive_browser.c

@@ -7,7 +7,6 @@
 #include <core/log.h>
 #include <gui/modules/file_browser_worker.h>
 #include <flipper_application/flipper_application.h>
-#include <math.h>
 
 static void
     archive_folder_open_cb(void* context, uint32_t item_cnt, int32_t file_idx, bool is_root) {

applications/main/archive/scenes/archive_scene_browser.c

@@ -1,6 +1,5 @@
 #include "../archive_i.h"
 #include "../helpers/archive_files.h"
-#include "../helpers/archive_apps.h"
 #include "../helpers/archive_favorites.h"
 #include "../helpers/archive_browser.h"
 #include "../views/archive_browser_view.h"

applications/main/archive/scenes/archive_scene_delete.c

@@ -1,5 +1,4 @@
 #include "../archive_i.h"
-#include "../helpers/archive_favorites.h"
 #include "../helpers/archive_files.h"
 #include "../helpers/archive_apps.h"
 #include "../helpers/archive_browser.h"

applications/main/archive/views/archive_browser_view.c

@@ -1,7 +1,6 @@
 #include "assets_icons.h"
 #include "toolbox/path.h"
 #include <furi.h>
-#include "../archive_i.h"
 #include "archive_browser_view.h"
 #include "../helpers/archive_browser.h"
 

applications/main/bad_usb/scenes/bad_usb_scene_config.c

@@ -1,5 +1,4 @@
 #include "../bad_usb_app_i.h"
-#include "furi_hal_power.h"
 
 enum SubmenuIndex {
     ConfigIndexKeyboardLayout,

applications/main/bad_usb/scenes/bad_usb_scene_config_layout.c

@@ -1,5 +1,4 @@
 #include "../bad_usb_app_i.h"
-#include "furi_hal_power.h"
 #include <storage/storage.h>
 
 static bool bad_usb_layout_select(BadUsbApp* bad_usb) {

applications/main/gpio/views/gpio_usb_uart.c

@@ -1,7 +1,8 @@
+#include "gpio_usb_uart.h"
 #include "../usb_uart_bridge.h"
-#include "../gpio_app_i.h"
 #include <furi_hal.h>
 #include <gui/elements.h>
+#include <assets_icons.h>
 
 struct GpioUsbUart {
     View* view;

applications/main/infrared/scenes/infrared_scene_universal_ac.c

@@ -1,4 +1,4 @@
-#include "../infrared_app_i.h"
+#include "../infrared_app_i.h" // IWYU pragma: keep
 
 #include "common/infrared_scene_universal_common.h"
 

applications/main/nfc/helpers/protocol_support/mf_ultralight/mf_ultralight.c

@@ -167,7 +167,7 @@ bool nfc_scene_read_on_event_mf_ultralight(NfcApp* instance, SceneManagerEvent e
     if(event.type == SceneManagerEventTypeCustom) {
         if(event.event == NfcCustomEventCardDetected) {
             nfc_unlock_helper_card_detected_handler(instance);
-        } else if((event.event == NfcCustomEventPollerIncomplete)) {
+        } else if(event.event == NfcCustomEventPollerIncomplete) {
             notification_message(instance->notifications, &sequence_semi_success);
             scene_manager_next_scene(instance->scene_manager, NfcSceneReadSuccess);
             dolphin_deed(DolphinDeedNfcReadSuccess);

applications/main/nfc/plugins/supported_cards/troika.c

@@ -7,7 +7,6 @@
 #include <bit_lib/bit_lib.h>
 #include <nfc/protocols/mf_classic/mf_classic_poller_sync.h>
 #include "../../api/mosgortrans/mosgortrans_util.h"
-#include "furi_hal_rtc.h"
 
 #define TAG "Troika"
 

applications/main/subghz/helpers/subghz_frequency_analyzer_worker.c

@@ -49,7 +49,7 @@ static uint32_t subghz_frequency_analyzer_worker_expRunningAverageAdaptive(
     float k;
     float newValFloat = newVal;
     // the sharpness of the filter depends on the absolute value of the difference
-    if(fabs(newValFloat - instance->filVal) > 500000)
+    if(fabsf(newValFloat - instance->filVal) > 500000.f)
         k = 0.9;
     else
         k = 0.03;

applications/main/subghz/helpers/subghz_threshold_rssi.c

@@ -1,6 +1,6 @@
 #include "subghz_threshold_rssi.h"
+#include "../views/subghz_read_raw.h"
 #include <float_tools.h>
-#include "../subghz_i.h"
 
 #define TAG "SubGhzThresholdRssi"
 #define THRESHOLD_RSSI_LOW_COUNT 10

applications/main/subghz/helpers/subghz_txrx.c

@@ -1,4 +1,4 @@
-#include "subghz_txrx_i.h"
+#include "subghz_txrx_i.h" // IWYU pragma: keep
 
 #include <lib/subghz/protocols/protocol_items.h>
 #include <applications/drivers/subghz/cc1101_ext/cc1101_ext_interconnect.h>

applications/main/subghz/helpers/subghz_txrx_create_protocol_key.c

@@ -1,4 +1,4 @@
-#include "subghz_txrx_i.h"
+#include "subghz_txrx_i.h" // IWYU pragma: keep
 #include "subghz_txrx_create_protocol_key.h"
 #include <lib/subghz/transmitter.h>
 #include <lib/subghz/protocols/protocol_items.h>

applications/main/subghz/scenes/subghz_scene_delete_success.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 #include "../helpers/subghz_custom_event.h"
 
 void subghz_scene_delete_success_popup_callback(void* context) {

applications/main/subghz/scenes/subghz_scene_frequency_analyzer.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 #include "../views/subghz_frequency_analyzer.h"
 
 void subghz_scene_frequency_analyzer_callback(SubGhzCustomEvent event, void* context) {

applications/main/subghz/scenes/subghz_scene_radio_setting.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 #include <lib/toolbox/value_index.h>
 #include <applications/drivers/subghz/cc1101_ext/cc1101_ext_interconnect.h>
 #include <lib/subghz/devices/cc1101_int/cc1101_int_interconnect.h>

applications/main/subghz/scenes/subghz_scene_read_raw.c

@@ -2,7 +2,7 @@
 #include "../views/subghz_read_raw.h"
 #include <dolphin/dolphin.h>
 #include <lib/subghz/protocols/raw.h>
-#include <lib/toolbox/path.h>
+#include <toolbox/path.h>
 
 #define RAW_FILE_NAME "Raw_signal_"
 #define TAG "SubGhzSceneReadRaw"

applications/main/subghz/scenes/subghz_scene_region_info.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 
 #include <furi_hal_region.h>
 

applications/main/subghz/scenes/subghz_scene_saved_menu.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 
 enum SubmenuIndex {
     SubmenuIndexEmulate,

applications/main/subghz/scenes/subghz_scene_show_error.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 #include "../helpers/subghz_custom_event.h"
 
 static const NotificationSequence subghs_sequence_sd_error = {

applications/main/subghz/scenes/subghz_scene_show_error_sub.c

@@ -1,4 +1,4 @@
-#include "../subghz_i.h"
+#include "../subghz_i.h" // IWYU pragma: keep
 #include "../helpers/subghz_custom_event.h"
 
 void subghz_scene_show_error_sub_popup_callback(void* context) {

applications/main/subghz/subghz_i.c

@@ -2,7 +2,6 @@
 
 #include "assets_icons.h"
 #include "subghz/types.h"
-#include <math.h>
 #include <furi.h>
 #include <furi_hal.h>
 #include <input/input.h>
@@ -10,7 +9,6 @@
 #include <notification/notification.h>
 #include <notification/notification_messages.h>
 #include <flipper_format/flipper_format.h>
-#include "views/receiver.h"
 
 #include <flipper_format/flipper_format_i.h>
 #include <lib/toolbox/stream/stream.h>

applications/main/subghz/views/receiver.c

@@ -1,7 +1,6 @@
 #include "receiver.h"
-#include "../subghz_i.h"
-#include <math.h>
 
+#include "types.h"
 #include <input/input.h>
 #include <gui/elements.h>
 #include <assets_icons.h>

applications/main/subghz/views/subghz_frequency_analyzer.c

@@ -1,7 +1,5 @@
 #include "subghz_frequency_analyzer.h"
-#include "../subghz_i.h"
 
-#include <math.h>
 #include <furi.h>
 #include <furi_hal.h>
 #include <input/input.h>

applications/main/subghz/views/subghz_read_raw.c

@@ -1,7 +1,5 @@
 #include "subghz_read_raw.h"
-#include "../subghz_i.h"
 
-#include <math.h>
 #include <furi.h>
 #include <furi_hal.h>
 #include <input/input.h>
@@ -72,7 +70,7 @@ void subghz_read_raw_add_data_rssi(SubGhzReadRAW* instance, float rssi, bool tra
     if(rssi < SUBGHZ_RAW_THRESHOLD_MIN) {
         u_rssi = 0;
     } else {
-        u_rssi = (uint8_t)((rssi - SUBGHZ_RAW_THRESHOLD_MIN) / 2.7);
+        u_rssi = (uint8_t)((rssi - SUBGHZ_RAW_THRESHOLD_MIN) / 2.7f);
     }
 
     with_view_model(
@@ -272,7 +270,7 @@ void subghz_read_raw_draw_threshold_rssi(Canvas* canvas, SubGhzReadRAWModel* mod
 
     if(model->raw_threshold_rssi > SUBGHZ_RAW_THRESHOLD_MIN) {
         uint8_t x = 118;
-        y -= (uint8_t)((model->raw_threshold_rssi - SUBGHZ_RAW_THRESHOLD_MIN) / 2.7);
+        y -= (uint8_t)((model->raw_threshold_rssi - SUBGHZ_RAW_THRESHOLD_MIN) / 2.7f);
 
         uint8_t width = 3;
         for(uint8_t i = 0; i < x; i += width * 2) {

applications/main/subghz/views/transmitter.c

@@ -1,6 +1,6 @@
 #include "transmitter.h"
-#include "../subghz_i.h"
 
+#include <assets_icons.h>
 #include <input/input.h>
 #include <gui/elements.h>
 

applications/main/u2f/u2f.c

@@ -1,5 +1,4 @@
 #include "u2f.h"
-#include "u2f_hid.h"
 #include "u2f_data.h"
 
 #include <furi.h>

applications/services/cli/cli_vcp.c

@@ -1,7 +1,7 @@
+#include "cli_i.h" // IWYU pragma: keep
 #include <furi_hal_usb_cdc.h>
 #include <furi_hal.h>
 #include <furi.h>
-#include "cli_i.h"
 
 #define TAG "CliVcp"
 

applications/services/desktop/animations/animation_storage.c

@@ -8,7 +8,6 @@
 
 #include "animation_manager.h"
 #include "animation_storage.h"
-#include "animation_storage_i.h"
 #include <assets_dolphin_internal.h>
 #include <assets_dolphin_blocking.h>
 

applications/services/desktop/animations/views/bubble_animation_view.c

@@ -1,6 +1,5 @@
 
 #include "../animation_manager.h"
-#include "../animation_storage.h"
 #include "bubble_animation_view.h"
 
 #include <furi_hal.h>

applications/services/desktop/helpers/pin.c

@@ -7,8 +7,6 @@
 #include <furi_hal.h>
 #include <gui/gui.h>
 
-#include "../desktop_i.h"
-
 static const NotificationSequence sequence_pin_fail = {
     &message_display_backlight_on,
 

applications/services/desktop/scenes/desktop_scene_lock_menu.c

@@ -8,9 +8,7 @@
 #include "../desktop_i.h"
 #include <desktop/desktop_settings.h>
 #include "../views/desktop_view_lock_menu.h"
-#include "desktop_scene_i.h"
 #include "desktop_scene.h"
-#include "../helpers/pin.h"
 
 #define TAG "DesktopSceneLock"
 

applications/services/desktop/scenes/desktop_scene_locked.c

@@ -9,7 +9,6 @@
 #include "../helpers/pin.h"
 #include "../animations/animation_manager.h"
 #include "../views/desktop_events.h"
-#include "../views/desktop_view_pin_input.h"
 #include "../views/desktop_view_locked.h"
 #include "desktop_scene.h"
 #include "desktop_scene_i.h"

applications/services/desktop/scenes/desktop_scene_main.c

@@ -8,7 +8,6 @@
 #include "../views/desktop_events.h"
 #include "../views/desktop_view_main.h"
 #include "desktop_scene.h"
-#include "desktop_scene_i.h"
 
 #define TAG "DesktopSrv"
 

applications/services/desktop/scenes/desktop_scene_pin_input.c

@@ -8,12 +8,10 @@
 
 #include "../desktop.h"
 #include "../desktop_i.h"
-#include "../animations/animation_manager.h"
 #include "../views/desktop_events.h"
 #include "../views/desktop_view_pin_input.h"
 #include "../helpers/pin.h"
 #include "desktop_scene.h"
-#include "desktop_scene_i.h"
 
 #define WRONG_PIN_HEADER_TIMEOUT 3000
 #define INPUT_PIN_VIEW_TIMEOUT 15000

applications/services/desktop/scenes/desktop_scene_pin_timeout.c

@@ -5,7 +5,6 @@
 #include "../desktop_i.h"
 #include "../views/desktop_view_pin_timeout.h"
 #include "desktop_scene.h"
-#include "desktop_scene_i.h"
 
 static void desktop_scene_pin_timeout_callback(void* context) {
     Desktop* desktop = (Desktop*)context;

applications/services/desktop/views/desktop_view_lock_menu.c

@@ -126,8 +126,8 @@ bool desktop_lock_menu_input_callback(InputEvent* event, void* context) {
         update);
 
     if(event->key == InputKeyOk) {
-        if((idx == DesktopLockMenuIndexLock)) {
+        if(idx == DesktopLockMenuIndexLock) {
-            if((event->type == InputTypeShort)) {
+            if(event->type == InputTypeShort) {
                 lock_menu->callback(DesktopLockMenuEventLock, lock_menu->context);
             }
         } else if(idx == DesktopLockMenuIndexStealth) {

applications/services/desktop/views/desktop_view_main.c

@@ -6,7 +6,6 @@
 #include <input/input.h>
 #include <dolphin/dolphin.h>
 
-#include "../desktop_i.h"
 #include "desktop_view_main.h"
 
 struct DesktopMainView {

applications/services/desktop/views/desktop_view_slideshow.c

@@ -3,9 +3,7 @@
 #include <gui/elements.h>
 
 #include "desktop_view_slideshow.h"
-#include "../desktop_i.h"
 #include "../helpers/slideshow.h"
-#include "../helpers/slideshow_filename.h"
 
 #define DESKTOP_SLIDESHOW_POWEROFF_SHORT 5000
 #define DESKTOP_SLIDESHOW_POWEROFF_LONG (60 * 60 * 1000)

applications/services/desktop/views/desktop_view_slideshow.h

@@ -4,6 +4,7 @@
 
 #include "desktop_events.h"
 #include "../helpers/slideshow_filename.h"
+#include <storage/storage.h>
 
 #define SLIDESHOW_FS_PATH INT_PATH(SLIDESHOW_FILE_NAME)
 

applications/services/dialogs/dialogs.c

@@ -1,5 +1,4 @@
 #include "dialogs/dialogs_message.h"
-#include "dialogs_i.h"
 #include <toolbox/api_lock.h>
 #include "dialogs_module_file_browser.h"
 #include "dialogs_module_message.h"

applications/services/dialogs/dialogs_api.c

@@ -1,5 +1,4 @@
 #include "dialogs_message.h"
-#include "dialogs_i.h"
 #include <toolbox/api_lock.h>
 #include <assets_icons.h>
 #include <storage/storage.h>

applications/services/dialogs/dialogs_module_file_browser.c

@@ -1,5 +1,4 @@
-#include "dialogs_i.h"
+#include "dialogs_message.h"
-
 #include <gui/modules/file_browser.h>
 #include <toolbox/api_lock.h>
 

applications/services/dialogs/dialogs_module_message.c

@@ -1,4 +1,6 @@
-#include "dialogs_i.h"
+#include "dialogs.h"
+#include "dialogs_message.h"
+#include <gui/view_holder.h>
 #include <toolbox/api_lock.h>
 #include <gui/modules/dialog_ex.h>
 

applications/services/dolphin/dolphin.c

@@ -1,7 +1,6 @@
-#include "dolphin/dolphin.h"
+#include "dolphin.h"
-#include "dolphin/helpers/dolphin_state.h"
+#include "helpers/dolphin_state.h"
 #include "dolphin_i.h"
-#include "projdefs.h"
 #include <furi_hal.h>
 #include <stdint.h>
 #include <furi.h>

applications/services/dolphin/helpers/dolphin_state.c

@@ -6,7 +6,6 @@
 #include <storage/storage.h>
 #include <furi.h>
 #include <furi_hal.h>
-#include <math.h>
 #include <toolbox/saved_struct.h>
 
 #define TAG "DolphinState"

applications/services/gui/elements.c

@@ -9,7 +9,6 @@
 #include <gui/icon_animation_i.h>
 
 #include <furi.h>
-#include "canvas_i.h"
 
 #include <math.h>
 #include <string.h>

applications/services/gui/icon.c

@@ -1,5 +1,5 @@
 #include "icon.h"
-#include "icon_i.h"
+#include "icon_i.h" // IWYU pragma: keep
 #include <furi.h>
 
 #include <furi.h>

applications/services/gui/icon_animation.c

@@ -1,5 +1,5 @@
 #include "icon_animation_i.h"
-#include "icon_i.h"
+#include "icon_i.h" // IWYU pragma: keep
 
 #include <furi.h>
 

applications/services/gui/modules/button_panel.c

@@ -39,7 +39,7 @@ typedef struct ButtonItem {
     void* callback_context;
 } ButtonItem;
 
-ARRAY_DEF(ButtonArray, ButtonItem*, M_PTR_OPLIST);
+ARRAY_DEF(ButtonArray, ButtonItem*, M_PTR_OPLIST); // NOLINT
 #define M_OPL_ButtonArray_t() ARRAY_OPLIST(ButtonArray, M_PTR_OPLIST)
 ARRAY_DEF(ButtonMatrix, ButtonArray_t);
 #define M_OPL_ButtonMatrix_t() ARRAY_OPLIST(ButtonMatrix, M_OPL_ButtonArray_t())

applications/services/gui/modules/widget.c

@@ -3,7 +3,7 @@
 #include <furi.h>
 #include <m-array.h>
 
-ARRAY_DEF(ElementArray, WidgetElement*, M_PTR_OPLIST);
+ARRAY_DEF(ElementArray, WidgetElement*, M_PTR_OPLIST); // NOLINT
 
 struct Widget {
     View* view;

applications/services/notification/notification_app_api.c

@@ -1,7 +1,6 @@
 #include <furi.h>
 #include <furi_hal.h>
 #include "notification.h"
-#include "notification_messages.h"
 #include "notification_app.h"
 
 void notification_message(NotificationApp* app, const NotificationSequence* sequence) {

applications/services/power/power_service/power.c

@@ -13,7 +13,7 @@ void power_draw_battery_callback(Canvas* canvas, void* context) {
 
     if(power->info.gauge_is_ok) {
         canvas_draw_box(canvas, 2, 2, (power->info.charge + 4) / 5, 4);
-        if(power->info.voltage_battery_charge_limit < 4.2) {
+        if(power->info.voltage_battery_charge_limit < 4.2f) {
             // Battery charge voltage limit is modified, indicate with cross pattern
             canvas_invert_color(canvas);
             uint8_t battery_bar_width = (power->info.charge + 4) / 5;

applications/services/rpc/rpc.c

@@ -1,4 +1,3 @@
-#include "profiles/serial_profile.h"
 #include "rpc_i.h"
 
 #include <pb.h>

applications/services/rpc/rpc_desktop.c

@@ -1,7 +1,6 @@
 #include "flipper.pb.h"
 #include "rpc_i.h"
 #include <desktop/desktop.h>
-#include "desktop.pb.h"
 
 #define TAG "RpcDesktop"
 

applications/services/storage/storage_external_api.c

@@ -1,7 +1,7 @@
 #include <core/log.h>
 #include <core/record.h>
 #include "storage.h"
-#include "storage_i.h"
+#include "storage_i.h" // IWYU pragma: keep
 #include "storage_message.h"
 #include <toolbox/stream/file_stream.h>
 #include <toolbox/dir_walk.h>

applications/settings/desktop_settings/scenes/desktop_settings_scene_pin_disable.c

@@ -1,4 +1,3 @@
-#include <stdint.h>
 #include <core/check.h>
 #include <gui/scene_manager.h>
 #include <gui/modules/popup.h>

applications/settings/desktop_settings/scenes/desktop_settings_scene_pin_setup_done.c

@@ -1,7 +1,6 @@
 #include <furi.h>
 #include <notification/notification.h>
 #include <notification/notification_messages.h>
-#include <stdint.h>
 #include <gui/scene_manager.h>
 #include <gui/view_dispatcher.h>