mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-28 07:31:15 +00:00
ffb02942fa
So far we have a convoluted #ifdef mesh that guards the early AXP PMIC setup in board.c. That combination of &&, || and negations is very hard to read, maintain and especially to extend. Fortunately we have those same conditions already modelled in the Kconfig file, so they are actually redundant. On top of that the real reason we have those preprocessor guards in the first place is about the symbols that are *conditionally* defined: without #ifdefs the build would break because of them being undefined for many boards. To simplify this, just change the guards to actually look at the symbols needed, so CONFIG_AXP_xxx_VOLT instead of CONFIG_AXPyyy_POWER. This drastically improves the readability of this code, and makes adding PMIC support a pure Kconfig matter. Doing this revealed one bug in Kconfig: there is no axp_set_dcdc4() for the AXP818, even though CONFIG_AXP_DCDC4_VOLT includes that PMIC. Since the AXP818 wasn't included when calling axp_set_dcdc4() in board.c, this wasn't an issue, but becomes one now, so also remove the AXP818 from the DCDC4 Kconfig symbol. Signed-off-by: Andre Przywara <andre.przywara@arm.com> |
||
|---|---|---|
| .. | ||
| acpi_pmc | ||
| domain | ||
| pmic | ||
| regulator | ||
| axp152.c | ||
| axp209.c | ||
| axp221.c | ||
| axp305.c | ||
| axp809.c | ||
| axp818.c | ||
| exynos-tmu.c | ||
| Kconfig | ||
| Makefile | ||
| mt6323.c | ||
| palmas.c | ||
| power_core.c | ||
| power_dialog.c | ||
| power_fsl.c | ||
| power_i2c.c | ||
| power_spi.c | ||
| sy8106a.c | ||
| tps6586x.c | ||
| twl4030.c | ||
| twl6030.c | ||