mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-16 16:23:14 +00:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
56 lines
1.2 KiB
C
56 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* (C) Copyright 2009
|
|
* Vipin Kumar, ST Micoelectronics, vipin.kumar@st.com.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <miiphy.h>
|
|
#include <net.h>
|
|
#include <netdev.h>
|
|
#include <nand.h>
|
|
#include <asm/io.h>
|
|
#include <linux/mtd/fsmc_nand.h>
|
|
#include <asm/mach-types.h>
|
|
#include <asm/arch/hardware.h>
|
|
#include <asm/arch/spr_defs.h>
|
|
#include <asm/arch/spr_misc.h>
|
|
|
|
static struct nand_chip nand_chip[CONFIG_SYS_MAX_NAND_DEVICE];
|
|
|
|
int board_init(void)
|
|
{
|
|
return spear_board_init(MACH_TYPE_SPEAR600);
|
|
}
|
|
|
|
/*
|
|
* board_nand_init - Board specific NAND initialization
|
|
* @nand: mtd private chip structure
|
|
*
|
|
* Called by nand_init_chip to initialize the board specific functions
|
|
*/
|
|
|
|
void board_nand_init()
|
|
{
|
|
struct misc_regs *const misc_regs_p =
|
|
(struct misc_regs *)CONFIG_SPEAR_MISCBASE;
|
|
struct nand_chip *nand = &nand_chip[0];
|
|
|
|
#if defined(CONFIG_NAND_FSMC)
|
|
if (!(readl(&misc_regs_p->auto_cfg_reg) & MISC_NANDDIS))
|
|
fsmc_nand_init(nand);
|
|
#endif
|
|
return;
|
|
}
|
|
|
|
int board_eth_init(struct bd_info *bis)
|
|
{
|
|
int ret = 0;
|
|
|
|
#if defined(CONFIG_ETH_DESIGNWARE)
|
|
u32 interface = PHY_INTERFACE_MODE_MII;
|
|
if (designware_initialize(CONFIG_SPEAR_ETHBASE, interface) >= 0)
|
|
ret++;
|
|
#endif
|
|
return ret;
|
|
}
|