mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-14 08:57:58 +00:00
366aad4d97
In (first) breaking and (then) fixing the rkspi tool, I realised that the calculation of the required padding (for the header-size and the 2K-in-every-4K SPI layout) was not as self-explainatory as it could have been. This change rewrites the code (using new, common functions in rkcommon.c) and adds verbose in-line comments to ensure that we won't fall into the same pit in the future... Tested on the RK3399 (with has a boot0-style payload) with SD/MMC and SPI. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Acked-by: Simon Glass <sjg@chromium.org>
122 lines
3 KiB
C
122 lines
3 KiB
C
/*
|
|
* (C) Copyright 2015 Google, Inc
|
|
* Written by Simon Glass <sjg@chromium.org>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*
|
|
* See README.rockchip for details of the rkspi format
|
|
*/
|
|
|
|
#include "imagetool.h"
|
|
#include <image.h>
|
|
#include <rc4.h>
|
|
#include "mkimage.h"
|
|
#include "rkcommon.h"
|
|
|
|
enum {
|
|
RKSPI_SECT_LEN = RK_BLK_SIZE * 4,
|
|
};
|
|
|
|
static int rkspi_verify_header(unsigned char *buf, int size,
|
|
struct image_tool_params *params)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void rkspi_print_header(const void *buf)
|
|
{
|
|
}
|
|
|
|
static void rkspi_set_header(void *buf, struct stat *sbuf, int ifd,
|
|
struct image_tool_params *params)
|
|
{
|
|
int sector;
|
|
unsigned int size;
|
|
int ret;
|
|
|
|
size = params->orig_file_size;
|
|
ret = rkcommon_set_header(buf, size, params);
|
|
debug("size %x\n", size);
|
|
if (ret) {
|
|
/* TODO(sjg@chromium.org): This method should return an error */
|
|
printf("Warning: SPL image is too large (size %#x) and will "
|
|
"not boot\n", size);
|
|
}
|
|
|
|
/*
|
|
* Spread the image out so we only use the first 2KB of each 4KB
|
|
* region. This is a feature of the SPI format required by the Rockchip
|
|
* boot ROM. Its rationale is unknown.
|
|
*/
|
|
for (sector = size / RKSPI_SECT_LEN - 1; sector >= 0; sector--) {
|
|
debug("sector %u\n", sector);
|
|
memmove(buf + sector * RKSPI_SECT_LEN * 2,
|
|
buf + sector * RKSPI_SECT_LEN,
|
|
RKSPI_SECT_LEN);
|
|
memset(buf + sector * RKSPI_SECT_LEN * 2 + RKSPI_SECT_LEN,
|
|
'\0', RKSPI_SECT_LEN);
|
|
}
|
|
}
|
|
|
|
static int rkspi_extract_subimage(void *buf, struct image_tool_params *params)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int rkspi_check_image_type(uint8_t type)
|
|
{
|
|
if (type == IH_TYPE_RKSPI)
|
|
return EXIT_SUCCESS;
|
|
else
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
/*
|
|
* The SPI payload needs to be padded out to make space for odd half-sector
|
|
* layout used in flash (i.e. only the first 2K of each 4K sector is used).
|
|
*/
|
|
static int rkspi_vrec_header(struct image_tool_params *params,
|
|
struct image_type_params *tparams)
|
|
{
|
|
int padding = rkcommon_vrec_header(params, tparams, 2048);
|
|
/*
|
|
* The file size has not been adjusted at this point (our caller will
|
|
* eventually add the header/padding to the file_size), so we need to
|
|
* add up the header_size, file_size and padding ourselves.
|
|
*/
|
|
int padded_size = tparams->header_size + params->file_size + padding;
|
|
|
|
/*
|
|
* We need to store the original file-size (i.e. before padding), as
|
|
* imagetool does not set this during its adjustment of file_size.
|
|
*/
|
|
params->orig_file_size = padded_size;
|
|
|
|
/*
|
|
* Converting to the SPI format (i.e. splitting each 4K page into two
|
|
* 2K subpages and then padding these 2K pages up to take a complete
|
|
* 4K sector again) will will double the image size.
|
|
*
|
|
* Thus we return the padded_size as an additional padding requirement
|
|
* (be sure to add this to the padding returned from the common code).
|
|
*/
|
|
return padded_size + padding;
|
|
}
|
|
|
|
/*
|
|
* rk_spi parameters
|
|
*/
|
|
U_BOOT_IMAGE_TYPE(
|
|
rkspi,
|
|
"Rockchip SPI Boot Image support",
|
|
0,
|
|
NULL,
|
|
rkcommon_check_params,
|
|
rkspi_verify_header,
|
|
rkspi_print_header,
|
|
rkspi_set_header,
|
|
rkspi_extract_subimage,
|
|
rkspi_check_image_type,
|
|
NULL,
|
|
rkspi_vrec_header
|
|
);
|