mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-08 22:24:32 +00:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| MAINTAINERS | ||
| Makefile | ||
| mpc8323erdb.c | ||
| README | ||
Freescale MPC8323ERDB Board ----------------------------------------- 1. Memory Map The memory map looks like this: 0x0000_0000 0x03ff_ffff DDR 64M 0x8000_0000 0x8fff_ffff PCI MEM 256M 0x9000_0000 0x9fff_ffff PCI_MMIO 256M 0xe000_0000 0xe00f_ffff IMMR 1M 0xd000_0000 0xd3ff_ffff PCI IO 64M 0xfe00_0000 0xfeff_ffff NOR FLASH (CS0) 16M 2. Compilation Assuming you're using BASH (or similar) as your shell: export CROSS_COMPILE=your-cross-compiler-prefix- make distclean make MPC8323ERDB_config make 3. Downloading and Flashing Images 3.1 Reflash U-Boot Image using U-Boot N.b, have an alternate means of programming the flash available if the new U-Boot doesn't boot. First try a: tftpboot $loadaddr $uboot to make sure that the TFTP load will succeed before an erase goes ahead and wipes out your current firmware. Then do a: run tftpflash which is a shorter version of the manual sequence: tftp $loadaddr u-boot.bin protect off fe000000 +$filesize erase fe000000 +$filesize cp.b $loadaddr fe000000 $filesize To keep your old U-Boot's environment variables, do a: saveenv prior to resetting the board. 3.2 Downloading and Booting Linux Kernel Ensure that all networking-related environment variables are set properly (including ipaddr, serverip, gatewayip (if needed), netmask, ethaddr, eth1addr, rootpath (if using NFS root), fdtfile, and bootfile). Then, do one of the following, depending on whether you want an NFS root or a ramdisk root: run nfsboot or run ramboot 4 Notes The console baudrate for MPC8323ERDB is 115200bps.