u-boot/arch/arm/include/asm/arch-exynos
Doug Anderson 306f527eff Exynos: Fix L2 cache timings on Exynos5420 and Exynos5800
It was found that the L2 cache timings that we had before could cause
freezes and hangs.  We should make things more robust with better
timings.  Currently the production ChromeOS kernel applies these
timings, but it's nice to fixup firmware too (and upstream probably
won't take our kernel hacks).

This also provides a big cleanup of the L2 cache init code avoiding
some duplication.  The way things used to work:
* low_power_start() was installed by the SPL (both at boot and resume
  time) and left resident in iRAM for the kernel to use when bringing
  up additional CPUs.  It used configure_l2_ctlr() and
  configure_l2_actlr() when it detected it was on an A15.  This was
  needed (despite the L2 cache registers being shared among all A15s)
  because we might have been the first man in after the whole A15
  cluster was shutdown.
* secondary_cores_configure() was called on at boot time and at resume
  time.  Strangely this called configure_l2_ctlr() but not
  configure_l2_actlr() which was almost certainly wrong.  Given that
  we'll call both (see next bullet) later in the boot process it
  didn't matter for normal boot, but I guess this is how L2 cache
  settings got set on 5420/5800 (but not 5250?) at resume time.
* exynos5_set_l2cache_params() was called as part of cache enablement.
  This should happen at boot time (normally in the SPL except for USB
  boot where it happens in main U-Boot).

Note that the old code wasn't setting ECC/parity in the cache
enablement code but we happened to get it anyway because we'd call
secondary_cores_configure() at boot time.  For resume time we'd get it
anyway when the 2nd A15 core came up.

Let's make this a whole lot simpler.  Now we always set these
parameters in the same place for all boots and use the same code for
setting up secondary CPUs.

Intended net effects of this change (other than cleanup):
* Timings go from before:
    data: 0 cycle setup, 3 cycles (0x2) latency
    tag:  0 cycle setup, 3 cycles (0x2) latency
  after:
    data: 1 cycle setup, 4 cycles (0x3) latency
    tag:  1 cycle setup, 4 cycles (0x3) latency
* L2ACTLR is properly initted on 5420/5800 in all cases.

One note is that we're still relying on luck to keep low_power_start()
working.  The compiler is being nice and not storing anything on the
stack.

Another note is that on its own this patch won't help to fix cache
settings in an RW U-Boot update where we still have the RO SPL.  The
plan for that is:
* Have RW U-Boot re-init the cache right before calling the kernel
  (after it has turned the L2 cache off).  This is why the functions
  are in a header file instead of lowlevel_init.c.

* Have the kernel save the L2 cache settings of the boot CPU and apply
  them to all other CPUs.  We get a little lucky here because the old
  code was using "|=" to modify the registers and all of the bits that
  it's setting are also present in the new settings (!).  That means
  that when the 2nd CPU in the A15 cluster comes up it doesn't
  actually mess up the settings of the 1st CPU in the A15 cluster.  An
  alternative option is to have the kernel write its own
  low_power_start() code.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
2015-02-28 18:03:46 +09:00
..
adc.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
board.h arm:exynos: add common DTS file for exynos 4 2014-03-12 19:54:59 +09:00
clk.h Exynos542x: Add and enable get_periph_rate support 2015-02-13 17:23:06 +09:00
clock.h Exynos5420: Add clock initialization for 5420 2013-12-30 16:50:34 +09:00
cpu.h Exynos542x: CPU: Power down all secondary cores 2015-02-28 18:03:46 +09:00
dmc.h DMC: Exynos5: Enable update mode for DREX controller 2014-11-17 19:03:38 +09:00
dp.h Coding Style cleanup: remove trailing white space 2013-10-14 16:06:53 -04:00
dp_info.h Coding Style cleanup: remove trailing white space 2013-10-14 16:06:53 -04:00
dsim.h Coding Style cleanup: remove trailing white space 2013-10-14 16:06:53 -04:00
dwmmc.h MMC: DWMMC: Correct the CLKDIV register value 2014-02-07 17:42:26 +02:00
ehci.h arm: odroid: usb: add support for usb host including ethernet 2014-11-17 19:33:22 +09:00
fb.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
gpio.h Exynos5800: Introduce new proid for Exynos5800 2014-11-17 19:03:38 +09:00
i2s-regs.h Sound: I2S: Replacing I2S1 with I2S0 channel. 2013-09-24 09:10:33 -04:00
mipi_dsim.h video:mipidsim:fdt: Add DT support for mipi dsim driver 2014-03-12 19:54:59 +09:00
mmc.h drivers:mmc:sdhci: enable support for DT 2014-03-12 19:54:59 +09:00
periph.h exynos: pinmux: remove unnecessary define 2014-02-05 15:37:56 +09:00
pinmux.h exynos5: pinmux: check flag for i2c config 2015-01-29 17:10:00 -07:00
power.h arm: odroid: enable/disable usb host phy for exynos4412 2014-11-17 19:33:21 +09:00
pwm.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
pwm_backlight.h Coding Style cleanup: remove trailing white space 2013-10-14 16:06:53 -04:00
sound.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
spi.h exynos: spl: Add a custom spi copy function 2013-12-03 15:26:33 +09:00
spl.h arch:exynos: boot mode: add get_boot_mode(), code cleanup 2014-09-05 13:58:49 +09:00
sromc.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
sys_proto.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
system.h Exynos: Fix L2 cache timings on Exynos5420 and Exynos5800 2015-02-28 18:03:46 +09:00
tmu.h power: exynos-tmu: fix warnings and clean up code 2013-06-13 17:53:37 +09:00
tzpc.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
uart.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
watchdog.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
xhci-exynos.h USB: XHCI: Add xHCI host controller support for Exynos5 2013-10-20 23:42:38 +02:00