mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-10 23:24:38 +00:00
d64b9cdcd4
The __of_translate_address routine translates an address from the device tree into a CPU physical address. A note in the description of the routine explains that the crossing of any level with since inherited from IBM. This does not happen for Texas Instruments, or at least for the beaglebone device tree. Without this patch, in fact, the translation into physical addresses of the registers contained in the am33xx-clocks.dtsi nodes would not be possible. They all have a parent with #size-cells = <0>. The CONFIG_OF_TRANSLATE_ZERO_SIZE_CELLS symbol makes translation possible even in the case of crossing levels with #size-cells = <0>. The patch acts conservatively on address translation, except for removing a check within the of_translate_one function in the drivers/core/of_addr.c file: + ranges = of_get_property(parent, rprop, &rlen); - if (ranges == NULL && !of_empty_ranges_quirk(parent)) { - debug("no ranges; cannot translate\n"); - return 1; - } if (ranges == NULL || rlen == 0) { offset = of_read_number(addr, na); memset(addr, 0, pna * 4); debug("empty ranges; 1:1 translation\n"); There are two reasons: 1 The function of_empty_ranges_quirk always returns false, invalidating the following if statement in case of null ranges. Therefore one of the two checks is useless. 2 The implementation of the of_translate_one function found in the common/fdt_support.c file has removed this check while keeping the one about the 1:1 translation. The patch adds a test and modifies a check for the correctness of an address in the case of enabling translation also for zero size cells. The added test checks translations of addresses generated by nodes of a device tree similar to those you can find in the files am33xx.dtsi and am33xx-clocks.dtsi for which the patch was created. The patch was also tested on a beaglebone black board. The addresses generated for the registers of the loaded drivers are those specified by the AM335x reference manual. Signed-off-by: Dario Binacchi <dariobin@libero.it> Tested-by: Dario Binacchi <dariobin@libero.it> Reviewed-by: Simon Glass <sjg@chromium.org> |
||
---|---|---|
.. | ||
cmd | ||
dm | ||
env | ||
fs | ||
image | ||
lib | ||
log | ||
optee | ||
overlay | ||
py | ||
stdint | ||
trace | ||
bloblist.c | ||
bootm.c | ||
cmd_ut.c | ||
command_ut.c | ||
common.sh | ||
compression.c | ||
Kconfig | ||
Makefile | ||
nokia_rx51_test.sh | ||
print_ut.c | ||
README | ||
run | ||
str_ut.c | ||
time_ut.c | ||
unicode_ut.c | ||
ut.c |
Testing in U-Boot ================= U-Boot has a large amount of code. This file describes how this code is tested and what tests you should write when adding a new feature. Running tests ------------- To run most tests on sandbox, type this: make check in the U-Boot directory. Note that only the pytest suite is run using this command. Some tests take ages to run. To run just the quick ones, type this: make qcheck Sandbox ------- U-Boot can be built as a user-space application (e.g. for Linux). This allows test to be executed without needing target hardware. The 'sandbox' target provides this feature and it is widely used in tests. Pytest Suite ------------ Many tests are available using the pytest suite, in test/py. This can run either on sandbox or on real hardware. It relies on the U-Boot console to inject test commands and check the result. It is slower to run than C code, but provides the ability to unify lots of tests and summarise their results. You can run the tests on sandbox with: ./test/py/test.py --bd sandbox --build This will produce HTML output in build-sandbox/test-log.html See test/py/README.md for more information about the pytest suite. tbot ---- Tbot provides a way to execute tests on target hardware. It is intended for trying out both U-Boot and Linux (and potentially other software) on a number of boards automatically. It can be used to create a continuous test environment. See http://www.tbot.tools for more information. Ad-hoc tests ------------ There are several ad-hoc tests which run outside the pytest environment: test/fs - File system test (shell script) test/image - FIT and legacy image tests (shell script and Python) test/stdint - A test that stdint.h can be used in U-Boot (shell script) trace - Test for the tracing feature (shell script) TODO: Move these into pytest. When to write tests ------------------- If you add code to U-Boot without a test you are taking a risk. Even if you perform thorough manual testing at the time of submission, it may break when future changes are made to U-Boot. It may even break when applied to mainline, if other changes interact with it. A good mindset is that untested code probably doesn't work and should be deleted. You can assume that the Pytest suite will be run before patches are accepted to mainline, so this provides protection against future breakage. On the other hand there is quite a bit of code that is not covered with tests, or is covered sparingly. So here are some suggestions: - If you are adding a new uclass, add a sandbox driver and a test that uses it - If you are modifying code covered by an existing test, add a new test case to cover your changes - If the code you are modifying has not tests, consider writing one. Even a very basic test is useful, and may be picked up and enhanced by others. It is much easier to add onto a test - writing a new large test can seem daunting to most contributors. Future work ----------- Converting existing shell scripts into pytest tests.