mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-08 14:14:32 +00:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
77 lines
1.8 KiB
C
77 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright 2004 Freescale Semiconductor.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <linux/libfdt.h>
|
|
#include <fdt_support.h>
|
|
#include "cadmus.h"
|
|
|
|
#if defined(CONFIG_OF_BOARD_SETUP)
|
|
#if defined(CONFIG_PCI) && !defined(CONFIG_DM_PCI)
|
|
static void cds_pci_fixup(void *blob)
|
|
{
|
|
int node;
|
|
const char *path;
|
|
int len, slot, i;
|
|
u32 *map = NULL, *piccells = NULL;
|
|
int off, cells;
|
|
|
|
node = fdt_path_offset(blob, "/aliases");
|
|
if (node >= 0) {
|
|
path = fdt_getprop(blob, node, "pci0", NULL);
|
|
if (path) {
|
|
node = fdt_path_offset(blob, path);
|
|
if (node >= 0) {
|
|
map = fdt_getprop_w(blob, node, "interrupt-map", &len);
|
|
}
|
|
/* Each item in "interrupt-map" property is translated with
|
|
* following cells:
|
|
* PCI #address-cells, PCI #interrupt-cells,
|
|
* PIC address, PIC #address-cells, PIC #interrupt-cells.
|
|
*/
|
|
cells = fdt_getprop_u32_default(blob, path, "#address-cells", 1);
|
|
cells += fdt_getprop_u32_default(blob, path, "#interrupt-cells", 1);
|
|
off = fdt_node_offset_by_phandle(blob, fdt32_to_cpu(*(map+cells)));
|
|
if (off <= 0)
|
|
return;
|
|
cells += 1;
|
|
piccells = (u32 *)fdt_getprop(blob, off, "#address-cells", NULL);
|
|
if (piccells == NULL)
|
|
return;
|
|
cells += *piccells;
|
|
piccells = (u32 *)fdt_getprop(blob, off, "#interrupt-cells", NULL);
|
|
if (piccells == NULL)
|
|
return;
|
|
cells += *piccells;
|
|
}
|
|
}
|
|
|
|
if (map) {
|
|
len /= sizeof(u32);
|
|
|
|
slot = get_pci_slot();
|
|
|
|
for (i=0;i<len;i+=cells) {
|
|
/* We rotate the interrupt pins so that the mapping
|
|
* changes depending on the slot the carrier card is in.
|
|
*/
|
|
map[3] = ((map[3] + slot - 2) % 4) + 1;
|
|
map+=cells;
|
|
}
|
|
}
|
|
}
|
|
#endif
|
|
|
|
int ft_board_setup(void *blob, struct bd_info *bd)
|
|
{
|
|
ft_cpu_setup(blob, bd);
|
|
#if defined(CONFIG_PCI) && !defined(CONFIG_DM_PCI)
|
|
ft_pci_setup(blob, bd);
|
|
cds_pci_fixup(blob);
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
#endif
|