u-boot/test
Mario Six e8d5291824 core: ofnode: Fix translation for #size-cells == 0
Commit 286ede6 ("drivers: core: Add translation in live tree case") made
dev_get_addr always use proper bus translations for addresses read from
the device tree. But this leads to problems with certain busses, e.g.
I2C busses, which run into an error during translation, and hence stop
working.

It turns out that of_translate_address() and fdt_translate_address()
stop the address translation with an error when they're asked to
translate addresses for busses where #size-cells == 0 (comment from
drivers/core/of_addr.c):

 * Note: We consider that crossing any level with #size-cells == 0 to mean
 * that translation is impossible (that is we are not dealing with a value
 * that can be mapped to a cpu physical address). This is not really specified
 * that way, but this is traditionally the way IBM at least do things

To fix this case, we check in both the live-tree and non-live tree-case,
whether the bus of the device whose address is about to be translated
has size-cell size zero. If this is the case, we just read the address
as a plain integer and return it, and only apply bus translations if the
size-cell size if greater than zero.

Signed-off-by: Mario Six <mario.six@gdsys.cc>
Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
Reported-by: Martin Fuzzey <mfuzzey@parkeon.com>
Fixes: 286ede6 ("drivers: core: Add translation in live tree case")
Reviewed-by: Simon Glass <sjg@chromium.org>
2018-04-01 22:19:10 +08:00
..
dm core: ofnode: Fix translation for #size-cells == 0 2018-04-01 22:19:10 +08:00
env test: Add a command function for test execution 2017-12-02 18:32:58 -05:00
fs fs-test: Add test for a filename using '..' to go back to the root 2017-10-06 11:28:19 -04:00
image test: Move the FIT test into the correct place 2017-08-13 15:17:36 -04:00
log log: Add a test command 2017-12-07 15:17:00 -05:00
overlay test: overlay: Use cmd_ut_category() 2017-12-02 18:32:58 -05:00
py test/py: add spi_flash tests 2018-03-22 16:32:20 -04:00
stdint test: Add a simple test to detected warnings with uint64_t, uintptr_t 2014-10-27 11:04:01 -04:00
trace trace: Improve the trace test number recognition 2016-02-26 08:53:10 -07:00
cmd_ut.c test: compression: Convert to unit test framework 2017-12-04 09:58:20 -05:00
command_ut.c env: Rename getenv/_f() to env_get() 2017-08-16 08:30:24 -04:00
common.sh test: Add a test for command repeat 2014-09-24 18:30:28 -04:00
compression.c test: compression: Convert to unit test framework 2017-12-04 09:58:20 -05:00
Kconfig tests: Introduce DT overlay tests 2016-08-20 11:35:07 -04:00
Makefile log: Add a test command 2017-12-07 15:17:00 -05:00
print_ut.c vsprintf.c: correct printing of a NULL device path 2018-01-28 21:37:13 +01:00
README tools/tbot: update README 2017-06-12 08:38:44 -04:00
run test: Set the DTC environment variable 2018-01-15 18:29:21 -07:00
time_ut.c test: dm: Move the time test over to the ut command 2015-05-21 09:16:17 -04:00
ut.c test: Record and silence console in tests 2015-11-19 20:27:51 -07:00

Testing in U-Boot
=================

U-Boot has a large amount of code. This file describes how this code is
tested and what tests you should write when adding a new feature.


Running tests
-------------

To run most tests on sandbox, type this:

    test/run

in the U-Boot directory. Note that only the pytest suite is run using this
command.


Sandbox
-------
U-Boot can be built as a user-space application (e.g. for Linux). This
allows test to be executed without needing target hardware. The 'sandbox'
target provides this feature and it is widely used in tests.


Pytest Suite
------------

Many tests are available using the pytest suite, in test/py. This can run
either on sandbox or on real hardware. It relies on the U-Boot console to
inject test commands and check the result. It is slower to run than C code,
but provides the ability to unify lots of tests and summarise their results.

You can run the tests on sandbox with:

	./test/py/test.py --bd sandbox --build

This will produce HTML output in build-sandbox/test-log.html

See test/py/README.md for more information about the pytest suite.


tbot
----

Tbot provides a way to execute tests on target hardware. It is intended for
trying out both U-Boot and Linux (and potentially other software) on a
number of boards automatically. It can be used to create a continuous test
environment. See http://www.tbot.tools for more information.


Ad-hoc tests
------------

There are several ad-hoc tests which run outside the pytest environment:

   test/fs	- File system test (shell script)
   test/image	- FIT and legacy image tests (shell script and Python)
   test/stdint	- A test that stdint.h can be used in U-Boot (shell script)
   trace	- Test for the tracing feature (shell script)

TODO: Move these into pytest.


When to write tests
-------------------

If you add code to U-Boot without a test you are taking a risk. Even if you
perform thorough manual testing at the time of submission, it may break when
future changes are made to U-Boot. It may even break when applied to mainline,
if other changes interact with it. A good mindset is that untested code
probably doesn't work and should be deleted.

You can assume that the Pytest suite will be run before patches are accepted
to mainline, so this provides protection against future breakage.

On the other hand there is quite a bit of code that is not covered with tests,
or is covered sparingly. So here are some suggestions:

- If you are adding a new uclass, add a sandbox driver and a test that uses it
- If you are modifying code covered by an existing test, add a new test case
  to cover your changes
- If the code you are modifying has not tests, consider writing one. Even a
  very basic test is useful, and may be picked up and enhanced by others. It
  is much easier to add onto a test - writing a new large test can seem
  daunting to most contributors.


Future work
-----------

Converting existing shell scripts into pytest tests.