mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-04 18:41:03 +00:00
bc8e8fe40b
when enable PMIC rk808,the system will halt at very
early stage,log is shown as bellow.
INFO: plat_rockchip_pmu_init(1211): pd status 3e
INFO: BL31: Initializing runtime services
INFO: BL31: Preparing for EL3 exit to normal world
INFO: Entry point address = 0x200000
INFO: SPSR = 0x3c9
time 44561b, 0 (<<----Just stop here)
It's caused by the absence of "{ }" in syscon_rk3399.c
,which will lead to memory overflow like below.According
to Sysmap file ,we can find the function buck_get_value
of rk808 is just follow the compatible struct,the pointer
"of_match" point to "buck_get_value",but it is not a
struct and don't have member of compatible, In this case,
system crash. So,on the face, it looks like that rk808 is
guilty.but he is really innocent.
while (of_match->compatible) { <<----------
if (!strcmp(of_match->compatible, compat)) {
*of_idp = of_match;
return 0;
}
of_match++;
}
Signed-off-by: Eric Gao <eric.gao@rock-chips.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Tested-by: Kever Yang <kever.yang@rock-chips.com>
62 lines
1.6 KiB
C
62 lines
1.6 KiB
C
/*
|
|
* (C) Copyright 2016 Rockchip Electronics Co., Ltd
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <syscon.h>
|
|
#include <asm/arch/clock.h>
|
|
|
|
static const struct udevice_id rk3399_syscon_ids[] = {
|
|
{ .compatible = "rockchip,rk3399-grf", .data = ROCKCHIP_SYSCON_GRF },
|
|
{ .compatible = "rockchip,rk3399-pmugrf", .data = ROCKCHIP_SYSCON_PMUGRF },
|
|
{ .compatible = "rockchip,rk3399-pmusgrf", .data = ROCKCHIP_SYSCON_PMUSGRF },
|
|
{ .compatible = "rockchip,rk3399-cic", .data = ROCKCHIP_SYSCON_CIC },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(syscon_rk3399) = {
|
|
.name = "rk3399_syscon",
|
|
.id = UCLASS_SYSCON,
|
|
.of_match = rk3399_syscon_ids,
|
|
};
|
|
|
|
#if CONFIG_IS_ENABLED(OF_PLATDATA)
|
|
static int rk3399_syscon_bind_of_platdata(struct udevice *dev)
|
|
{
|
|
dev->driver_data = dev->driver->of_match->data;
|
|
debug("syscon: %s %d\n", dev->name, (uint)dev->driver_data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
U_BOOT_DRIVER(rockchip_rk3399_grf) = {
|
|
.name = "rockchip_rk3399_grf",
|
|
.id = UCLASS_SYSCON,
|
|
.of_match = rk3399_syscon_ids,
|
|
.bind = rk3399_syscon_bind_of_platdata,
|
|
};
|
|
|
|
U_BOOT_DRIVER(rockchip_rk3399_pmugrf) = {
|
|
.name = "rockchip_rk3399_pmugrf",
|
|
.id = UCLASS_SYSCON,
|
|
.of_match = rk3399_syscon_ids + 1,
|
|
.bind = rk3399_syscon_bind_of_platdata,
|
|
};
|
|
|
|
U_BOOT_DRIVER(rockchip_rk3399_pmusgrf) = {
|
|
.name = "rockchip_rk3399_pmusgrf",
|
|
.id = UCLASS_SYSCON,
|
|
.of_match = rk3399_syscon_ids + 2,
|
|
.bind = rk3399_syscon_bind_of_platdata,
|
|
};
|
|
|
|
U_BOOT_DRIVER(rockchip_rk3399_cic) = {
|
|
.name = "rockchip_rk3399_cic",
|
|
.id = UCLASS_SYSCON,
|
|
.of_match = rk3399_syscon_ids + 3,
|
|
.bind = rk3399_syscon_bind_of_platdata,
|
|
};
|
|
#endif
|