u-boot/board/cm-bf537e
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
cm-bf537e.c Blackfin: kill off useless initdram() usage 2010-01-17 09:17:26 -05:00
config.mk Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
flash.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
gpio_cfi_flash.c Blackfin: fix typos in gpio comments 2009-08-23 17:33:41 -04:00
gpio_cfi_flash.h Blackfin: cm-bf537e: new board port 2009-06-14 20:01:05 -04:00
Makefile Blackfin: unify u-boot linker scripts 2009-06-14 20:01:14 -04:00