mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-23 11:33:32 +00:00
d17ab6e128
Calling 'nvme scan' followed by 'nvme detail' crashes U-Boot on Turris
Omnia with the following error:
undefined instruction
pc : [<0a000000>] lr : [<7ff80bfc>]
reloc pc : [<8a8c0000>] lr : [<00840bfc>]
sp : 7fb2b908 ip : 0000002a fp : 02000000
r10: 04000000 r9 : 7fb2fed0 r8 : e1000000
r7 : 0c000000 r6 : 03000000 r5 : 06000000 r4 : 01000000
r3 : 7fb30928 r2 : 7fb30928 r1 : 00000000 r0 : 00000000
Flags: nZCv IRQs off FIQs off Mode SVC_32
Code: 0f0fb4f0 0f0fb4f0 0f0fb4f0 0f0fb4f0 (f0f04b0f)
Resetting CPU ...
This happens when nvme_print_info() tries to return to the caller. It
looks like this error is caused by trying to allocate 8 KiB of memory
on the stack by the two uses of ALLOC_CACHE_ALIGN_BUFFER().
Use malloc_cache_aligned() to allocate this memory dynamically instead.
This fixes 'nvme detail' on Turris Omnia.
Note that similar change was applied to file drivers/nvme/nvme.c in past by
commit 2f83481dff
("nvme: use page-aligned buffer for identify command").
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <marek.behun@nic.cz>
146 lines
3.9 KiB
C
146 lines
3.9 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2017 NXP Semiconductors
|
|
* Copyright (C) 2017 Bin Meng <bmeng.cn@gmail.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <errno.h>
|
|
#include <memalign.h>
|
|
#include <nvme.h>
|
|
#include "nvme.h"
|
|
|
|
static void print_optional_admin_cmd(u16 oacs, int devnum)
|
|
{
|
|
printf("Blk device %d: Optional Admin Command Support:\n",
|
|
devnum);
|
|
printf("\tNamespace Management/Attachment: %s\n",
|
|
oacs & 0x08 ? "yes" : "no");
|
|
printf("\tFirmware Commit/Image download: %s\n",
|
|
oacs & 0x04 ? "yes" : "no");
|
|
printf("\tFormat NVM: %s\n",
|
|
oacs & 0x02 ? "yes" : "no");
|
|
printf("\tSecurity Send/Receive: %s\n",
|
|
oacs & 0x01 ? "yes" : "no");
|
|
}
|
|
|
|
static void print_optional_nvm_cmd(u16 oncs, int devnum)
|
|
{
|
|
printf("Blk device %d: Optional NVM Command Support:\n",
|
|
devnum);
|
|
printf("\tReservation: %s\n",
|
|
oncs & 0x10 ? "yes" : "no");
|
|
printf("\tSave/Select field in the Set/Get features: %s\n",
|
|
oncs & 0x08 ? "yes" : "no");
|
|
printf("\tWrite Zeroes: %s\n",
|
|
oncs & 0x04 ? "yes" : "no");
|
|
printf("\tDataset Management: %s\n",
|
|
oncs & 0x02 ? "yes" : "no");
|
|
printf("\tWrite Uncorrectable: %s\n",
|
|
oncs & 0x01 ? "yes" : "no");
|
|
}
|
|
|
|
static void print_format_nvme_attributes(u8 fna, int devnum)
|
|
{
|
|
printf("Blk device %d: Format NVM Attributes:\n", devnum);
|
|
printf("\tSupport Cryptographic Erase: %s\n",
|
|
fna & 0x04 ? "yes" : "No");
|
|
printf("\tSupport erase a particular namespace: %s\n",
|
|
fna & 0x02 ? "No" : "Yes");
|
|
printf("\tSupport format a particular namespace: %s\n",
|
|
fna & 0x01 ? "No" : "Yes");
|
|
}
|
|
|
|
static void print_format(struct nvme_lbaf *lbaf)
|
|
{
|
|
u8 str[][10] = {"Best", "Better", "Good", "Degraded"};
|
|
|
|
printf("\t\tMetadata Size: %d\n", le16_to_cpu(lbaf->ms));
|
|
printf("\t\tLBA Data Size: %d\n", 1 << lbaf->ds);
|
|
printf("\t\tRelative Performance: %s\n", str[lbaf->rp & 0x03]);
|
|
}
|
|
|
|
static void print_formats(struct nvme_id_ns *id, struct nvme_ns *ns)
|
|
{
|
|
int i;
|
|
|
|
printf("Blk device %d: LBA Format Support:\n", ns->devnum);
|
|
|
|
for (i = 0; i < id->nlbaf; i++) {
|
|
printf("\tLBA Foramt %d Support: ", i);
|
|
if (i == ns->flbas)
|
|
printf("(current)\n");
|
|
else
|
|
printf("\n");
|
|
print_format(id->lbaf + i);
|
|
}
|
|
}
|
|
|
|
static void print_data_protect_cap(u8 dpc, int devnum)
|
|
{
|
|
printf("Blk device %d: End-to-End Data", devnum);
|
|
printf("Protect Capabilities:\n");
|
|
printf("\tAs last eight bytes: %s\n",
|
|
dpc & 0x10 ? "yes" : "No");
|
|
printf("\tAs first eight bytes: %s\n",
|
|
dpc & 0x08 ? "yes" : "No");
|
|
printf("\tSupport Type3: %s\n",
|
|
dpc & 0x04 ? "yes" : "No");
|
|
printf("\tSupport Type2: %s\n",
|
|
dpc & 0x02 ? "yes" : "No");
|
|
printf("\tSupport Type1: %s\n",
|
|
dpc & 0x01 ? "yes" : "No");
|
|
}
|
|
|
|
static void print_metadata_cap(u8 mc, int devnum)
|
|
{
|
|
printf("Blk device %d: Metadata capabilities:\n", devnum);
|
|
printf("\tAs part of a separate buffer: %s\n",
|
|
mc & 0x02 ? "yes" : "No");
|
|
printf("\tAs part of an extended data LBA: %s\n",
|
|
mc & 0x01 ? "yes" : "No");
|
|
}
|
|
|
|
int nvme_print_info(struct udevice *udev)
|
|
{
|
|
struct nvme_ns *ns = dev_get_priv(udev);
|
|
struct nvme_dev *dev = ns->dev;
|
|
struct nvme_id_ctrl *ctrl;
|
|
struct nvme_id_ns *id;
|
|
int ret = 0;
|
|
|
|
ctrl = memalign(dev->page_size, sizeof(struct nvme_id_ctrl));
|
|
if (!ctrl)
|
|
return -ENOMEM;
|
|
|
|
if (nvme_identify(dev, 0, 1, (dma_addr_t)(long)ctrl)) {
|
|
ret = -EIO;
|
|
goto free_ctrl;
|
|
}
|
|
|
|
print_optional_admin_cmd(le16_to_cpu(ctrl->oacs), ns->devnum);
|
|
print_optional_nvm_cmd(le16_to_cpu(ctrl->oncs), ns->devnum);
|
|
print_format_nvme_attributes(ctrl->fna, ns->devnum);
|
|
|
|
id = memalign(dev->page_size, sizeof(struct nvme_id_ns));
|
|
if (!id) {
|
|
ret = -ENOMEM;
|
|
goto free_ctrl;
|
|
}
|
|
|
|
if (nvme_identify(dev, ns->ns_id, 0, (dma_addr_t)(long)id)) {
|
|
ret = -EIO;
|
|
goto free_id;
|
|
}
|
|
|
|
print_formats(id, ns);
|
|
print_data_protect_cap(id->dpc, ns->devnum);
|
|
print_metadata_cap(id->mc, ns->devnum);
|
|
|
|
free_id:
|
|
free(id);
|
|
free_ctrl:
|
|
free(ctrl);
|
|
return ret;
|
|
}
|