mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-14 23:33:00 +00:00
3e4fcfa4bc
Currently when booting the kernel on i.MX8 U-Boot hangs in an
endless loop when switching off dma, connectivity or lsio power
domains during device removal. It hapens first when removing
gpio0 (gpio@5d080000) device, here its power domain device
'lsio_gpio0' is obtained for switching off power. Since the
obtained 'lsio_gpio0' device is removed afterwards, its power
domain is also switched off and here the parent power domain
device 'lsio_power_domain' is optained for switching off the
power. Thereafter, when the obtained 'lsio_power_domain' is
removed, device_remove() removes its first child 'lsio_gpio0'.
During this child removal the 'lsio_power_domain' device is
obtained again for switching and when removing it later,
the same child removal is repeated, so we are stuck in an
endless loop. Below is a snippet from dm tree on i.MX8QXP
for better illustration of the DM devices relationship:
Class Index Probed Driver Name
-----------------------------------------------------------
root 0 [ + ] root_driver root_driver
...
simple_bus 0 [ + ] generic_simple_bus |-- imx8qx-pm
power_doma 0 [ + ] imx8_power_domain | |-- lsio_power_domain
power_doma 1 [ + ] imx8_power_domain | | |-- lsio_gpio0
power_doma 2 [ + ] imx8_power_domain | | |-- lsio_gpio1
Do not remove a power domain device if it is a parent of the
currently controlled device.
Fixes: 52edfed65d
("dm: core: device: switch off power domain after device removal")
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Reported-by: Oliver Graute <oliver.graute@gmail.com>
Reported-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Tested-by: Fabio Estevam <festevam@gmail.com>
167 lines
4 KiB
C
167 lines
4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2016, NVIDIA CORPORATION.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <malloc.h>
|
|
#include <power-domain.h>
|
|
#include <power-domain-uclass.h>
|
|
#include <dm/device-internal.h>
|
|
|
|
static inline struct power_domain_ops *power_domain_dev_ops(struct udevice *dev)
|
|
{
|
|
return (struct power_domain_ops *)dev->driver->ops;
|
|
}
|
|
|
|
static int power_domain_of_xlate_default(struct power_domain *power_domain,
|
|
struct ofnode_phandle_args *args)
|
|
{
|
|
debug("%s(power_domain=%p)\n", __func__, power_domain);
|
|
|
|
if (args->args_count != 1) {
|
|
debug("Invalid args_count: %d\n", args->args_count);
|
|
return -EINVAL;
|
|
}
|
|
|
|
power_domain->id = args->args[0];
|
|
|
|
return 0;
|
|
}
|
|
|
|
int power_domain_get_by_index(struct udevice *dev,
|
|
struct power_domain *power_domain, int index)
|
|
{
|
|
struct ofnode_phandle_args args;
|
|
int ret;
|
|
struct udevice *dev_power_domain;
|
|
struct power_domain_ops *ops;
|
|
|
|
debug("%s(dev=%p, power_domain=%p)\n", __func__, dev, power_domain);
|
|
|
|
ret = dev_read_phandle_with_args(dev, "power-domains",
|
|
"#power-domain-cells", 0, index,
|
|
&args);
|
|
if (ret) {
|
|
debug("%s: dev_read_phandle_with_args failed: %d\n",
|
|
__func__, ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = uclass_get_device_by_ofnode(UCLASS_POWER_DOMAIN, args.node,
|
|
&dev_power_domain);
|
|
if (ret) {
|
|
debug("%s: uclass_get_device_by_ofnode failed: %d\n",
|
|
__func__, ret);
|
|
return ret;
|
|
}
|
|
ops = power_domain_dev_ops(dev_power_domain);
|
|
|
|
power_domain->dev = dev_power_domain;
|
|
if (ops->of_xlate)
|
|
ret = ops->of_xlate(power_domain, &args);
|
|
else
|
|
ret = power_domain_of_xlate_default(power_domain, &args);
|
|
if (ret) {
|
|
debug("of_xlate() failed: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = ops->request(power_domain);
|
|
if (ret) {
|
|
debug("ops->request() failed: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int power_domain_get(struct udevice *dev, struct power_domain *power_domain)
|
|
{
|
|
return power_domain_get_by_index(dev, power_domain, 0);
|
|
}
|
|
|
|
int power_domain_free(struct power_domain *power_domain)
|
|
{
|
|
struct power_domain_ops *ops = power_domain_dev_ops(power_domain->dev);
|
|
|
|
debug("%s(power_domain=%p)\n", __func__, power_domain);
|
|
|
|
return ops->rfree(power_domain);
|
|
}
|
|
|
|
int power_domain_on(struct power_domain *power_domain)
|
|
{
|
|
struct power_domain_ops *ops = power_domain_dev_ops(power_domain->dev);
|
|
|
|
debug("%s(power_domain=%p)\n", __func__, power_domain);
|
|
|
|
return ops->on(power_domain);
|
|
}
|
|
|
|
int power_domain_off(struct power_domain *power_domain)
|
|
{
|
|
struct power_domain_ops *ops = power_domain_dev_ops(power_domain->dev);
|
|
|
|
debug("%s(power_domain=%p)\n", __func__, power_domain);
|
|
|
|
return ops->off(power_domain);
|
|
}
|
|
|
|
#if (CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA))
|
|
static int dev_power_domain_ctrl(struct udevice *dev, bool on)
|
|
{
|
|
struct power_domain pd;
|
|
int i, count, ret = 0;
|
|
|
|
count = dev_count_phandle_with_args(dev, "power-domains",
|
|
"#power-domain-cells");
|
|
for (i = 0; i < count; i++) {
|
|
ret = power_domain_get_by_index(dev, &pd, i);
|
|
if (ret)
|
|
return ret;
|
|
if (on)
|
|
ret = power_domain_on(&pd);
|
|
else
|
|
ret = power_domain_off(&pd);
|
|
}
|
|
|
|
/*
|
|
* For platforms with parent and child power-domain devices
|
|
* we may not run device_remove() on the power-domain parent
|
|
* because it will result in removing its children and switching
|
|
* off their power-domain parent. So we will get here again and
|
|
* again and will be stuck in an endless loop.
|
|
*/
|
|
if (!on && dev_get_parent(dev) == pd.dev &&
|
|
device_get_uclass_id(dev) == UCLASS_POWER_DOMAIN)
|
|
return ret;
|
|
|
|
/*
|
|
* power_domain_get() bound the device, thus
|
|
* we must remove it again to prevent unbinding
|
|
* active devices (which would result in unbind
|
|
* error).
|
|
*/
|
|
if (count > 0 && !on)
|
|
device_remove(pd.dev, DM_REMOVE_NORMAL);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int dev_power_domain_on(struct udevice *dev)
|
|
{
|
|
return dev_power_domain_ctrl(dev, true);
|
|
}
|
|
|
|
int dev_power_domain_off(struct udevice *dev)
|
|
{
|
|
return dev_power_domain_ctrl(dev, false);
|
|
}
|
|
#endif
|
|
|
|
UCLASS_DRIVER(power_domain) = {
|
|
.id = UCLASS_POWER_DOMAIN,
|
|
.name = "power_domain",
|
|
};
|