mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-21 02:33:07 +00:00
6f5edbaf93
sandbox_scmi_devices_ctx() may return NULL. We should not dereference this value in sandbox_scmi_devices_remove(). The problem was indicated by 'gcc-11 -fanalyzer'. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Simon Glass <sjg@chromium.org>
116 lines
2.7 KiB
C
116 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2020, Linaro Limited
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <clk.h>
|
|
#include <dm.h>
|
|
#include <malloc.h>
|
|
#include <reset.h>
|
|
#include <asm/io.h>
|
|
#include <asm/scmi_test.h>
|
|
#include <dm/device_compat.h>
|
|
|
|
/*
|
|
* Simulate to some extent a SCMI exchange.
|
|
* This drivers gets SCMI resources and offers API function to the
|
|
* SCMI test sequence manipulate the resources, currently clock
|
|
* and reset controllers.
|
|
*/
|
|
|
|
#define SCMI_TEST_DEVICES_CLK_COUNT 3
|
|
#define SCMI_TEST_DEVICES_RD_COUNT 1
|
|
|
|
/*
|
|
* struct sandbox_scmi_device_priv - Storage for device handles used by test
|
|
* @clk: Array of clock instances used by tests
|
|
* @reset_clt: Array of the reset controller instances used by tests
|
|
* @devices: Resources exposed by sandbox_scmi_devices_ctx()
|
|
*/
|
|
struct sandbox_scmi_device_priv {
|
|
struct clk clk[SCMI_TEST_DEVICES_CLK_COUNT];
|
|
struct reset_ctl reset_ctl[SCMI_TEST_DEVICES_RD_COUNT];
|
|
struct sandbox_scmi_devices devices;
|
|
};
|
|
|
|
struct sandbox_scmi_devices *sandbox_scmi_devices_ctx(struct udevice *dev)
|
|
{
|
|
struct sandbox_scmi_device_priv *priv = dev_get_priv(dev);
|
|
|
|
if (priv)
|
|
return &priv->devices;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static int sandbox_scmi_devices_remove(struct udevice *dev)
|
|
{
|
|
struct sandbox_scmi_devices *devices = sandbox_scmi_devices_ctx(dev);
|
|
int ret = 0;
|
|
size_t n;
|
|
|
|
if (!devices)
|
|
return 0;
|
|
|
|
for (n = 0; n < SCMI_TEST_DEVICES_RD_COUNT; n++) {
|
|
int ret2 = reset_free(devices->reset + n);
|
|
|
|
if (ret2 && !ret)
|
|
ret = ret2;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int sandbox_scmi_devices_probe(struct udevice *dev)
|
|
{
|
|
struct sandbox_scmi_device_priv *priv = dev_get_priv(dev);
|
|
int ret;
|
|
size_t n;
|
|
|
|
priv->devices = (struct sandbox_scmi_devices){
|
|
.clk = priv->clk,
|
|
.clk_count = SCMI_TEST_DEVICES_CLK_COUNT,
|
|
.reset = priv->reset_ctl,
|
|
.reset_count = SCMI_TEST_DEVICES_RD_COUNT,
|
|
};
|
|
|
|
for (n = 0; n < SCMI_TEST_DEVICES_CLK_COUNT; n++) {
|
|
ret = clk_get_by_index(dev, n, priv->devices.clk + n);
|
|
if (ret) {
|
|
dev_err(dev, "%s: Failed on clk %zu\n", __func__, n);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
for (n = 0; n < SCMI_TEST_DEVICES_RD_COUNT; n++) {
|
|
ret = reset_get_by_index(dev, n, priv->devices.reset + n);
|
|
if (ret) {
|
|
dev_err(dev, "%s: Failed on reset %zu\n", __func__, n);
|
|
goto err_reset;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_reset:
|
|
for (; n > 0; n--)
|
|
reset_free(priv->devices.reset + n - 1);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct udevice_id sandbox_scmi_devices_ids[] = {
|
|
{ .compatible = "sandbox,scmi-devices" },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(sandbox_scmi_devices) = {
|
|
.name = "sandbox-scmi_devices",
|
|
.id = UCLASS_MISC,
|
|
.of_match = sandbox_scmi_devices_ids,
|
|
.priv_auto = sizeof(struct sandbox_scmi_device_priv),
|
|
.remove = sandbox_scmi_devices_remove,
|
|
.probe = sandbox_scmi_devices_probe,
|
|
};
|