mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-21 02:33:07 +00:00
725cf89512
At the moment, the U-Boot serial_msm driver does not initialize the UART_DM_DMEN register with the required value. Usually this does not cause any problems, because there is Qualcomm's LK bootloader running before U-Boot which initializes the register with the correct value. It's important that this register is initialized correctly, because the U-Boot driver does not make use of the BAM/DMA or single character mode functionality of the UART controller. A different bootloader before U-Boot might initialize the register differently. For example, on DragonBoard 410c U-Boot can also be installed to the "aboot" partition (replacing LK entirely). In this case U-Boot is loaded directly by SBL, which seems to use the single-character mode for some reason. In single character mode there is always just one char in the FIFO, instead of the 4 characters expected by msm_serial_fetch(). It also causes issues with "earlycon" later in the Linux kernel, which tries to output 4 chars at once, but only the first char will be written. This causes early UART log in Linux to be corrupted like this: [ 00ano:ameoi .Q1B[ 00ac _idaM00080oo'ahani-lcle._20). 15NdNii 5 SPMSJ20:U2 [ 00rkoolmsamel [ 00Fw ]elamletopsioble [ 00ore instead of [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd030] [ 0.000000] Machine model: Qualcomm Technologies, Inc. APQ 8016 SBC [ 0.000000] earlycon: msm_serial_dm0 at MMIO 0x00000000078b0000 (options '') [ 0.000000] printk: bootconsole [msm_serial_dm0] enabled Make sure to initialize UART_DM_DMEN correctly to fix this issue when loading U-Boot directly after SBL (instead of through LK). There is no functional difference when loading U-Boot through LK since LK also initializes UART_DM_DMEN to 0x0. [1] [1]: https://git.linaro.org/landing-teams/working/qualcomm/lk.git/tree/platform/msm_shared/uart_dm.c?h=dragonboard410c-LA.BR.1.2.7-03810-8x16.0-linaro3#n203 Cc: Ramon Fried <rfried.dev@gmail.com> Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
251 lines
6.6 KiB
C
251 lines
6.6 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Qualcomm UART driver
|
|
*
|
|
* (C) Copyright 2015 Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
|
|
*
|
|
* UART will work in Data Mover mode.
|
|
* Based on Linux driver.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <clk.h>
|
|
#include <dm.h>
|
|
#include <errno.h>
|
|
#include <malloc.h>
|
|
#include <serial.h>
|
|
#include <watchdog.h>
|
|
#include <asm/global_data.h>
|
|
#include <asm/io.h>
|
|
#include <linux/compiler.h>
|
|
#include <dm/pinctrl.h>
|
|
|
|
/* Serial registers - this driver works in uartdm mode*/
|
|
|
|
#define UARTDM_DMRX 0x34 /* Max RX transfer length */
|
|
#define UARTDM_DMEN 0x3C /* DMA/data-packing mode */
|
|
#define UARTDM_NCF_TX 0x40 /* Number of chars to TX */
|
|
|
|
#define UARTDM_RXFS 0x50 /* RX channel status register */
|
|
#define UARTDM_RXFS_BUF_SHIFT 0x7 /* Number of bytes in the packing buffer */
|
|
#define UARTDM_RXFS_BUF_MASK 0x7
|
|
#define UARTDM_MR1 0x00
|
|
#define UARTDM_MR2 0x04
|
|
#define UARTDM_CSR 0xA0
|
|
|
|
#define UARTDM_SR 0xA4 /* Status register */
|
|
#define UARTDM_SR_RX_READY (1 << 0) /* Word is the receiver FIFO */
|
|
#define UARTDM_SR_TX_EMPTY (1 << 3) /* Transmitter underrun */
|
|
#define UARTDM_SR_UART_OVERRUN (1 << 4) /* Receive overrun */
|
|
|
|
#define UARTDM_CR 0xA8 /* Command register */
|
|
#define UARTDM_CR_CMD_RESET_ERR (3 << 4) /* Clear overrun error */
|
|
#define UARTDM_CR_CMD_RESET_STALE_INT (8 << 4) /* Clears stale irq */
|
|
#define UARTDM_CR_CMD_RESET_TX_READY (3 << 8) /* Clears TX Ready irq*/
|
|
#define UARTDM_CR_CMD_FORCE_STALE (4 << 8) /* Causes stale event */
|
|
#define UARTDM_CR_CMD_STALE_EVENT_DISABLE (6 << 8) /* Disable stale event */
|
|
|
|
#define UARTDM_IMR 0xB0 /* Interrupt mask register */
|
|
#define UARTDM_ISR 0xB4 /* Interrupt status register */
|
|
#define UARTDM_ISR_TX_READY 0x80 /* TX FIFO empty */
|
|
|
|
#define UARTDM_TF 0x100 /* UART Transmit FIFO register */
|
|
#define UARTDM_RF 0x140 /* UART Receive FIFO register */
|
|
|
|
#define UART_DM_CLK_RX_TX_BIT_RATE 0xCC
|
|
#define MSM_BOOT_UART_DM_8_N_1_MODE 0x34
|
|
#define MSM_BOOT_UART_DM_CMD_RESET_RX 0x10
|
|
#define MSM_BOOT_UART_DM_CMD_RESET_TX 0x20
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
struct msm_serial_data {
|
|
phys_addr_t base;
|
|
unsigned chars_cnt; /* number of buffered chars */
|
|
uint32_t chars_buf; /* buffered chars */
|
|
uint32_t clk_bit_rate; /* data mover mode bit rate register value */
|
|
};
|
|
|
|
static int msm_serial_fetch(struct udevice *dev)
|
|
{
|
|
struct msm_serial_data *priv = dev_get_priv(dev);
|
|
unsigned sr;
|
|
|
|
if (priv->chars_cnt)
|
|
return priv->chars_cnt;
|
|
|
|
/* Clear error in case of buffer overrun */
|
|
if (readl(priv->base + UARTDM_SR) & UARTDM_SR_UART_OVERRUN)
|
|
writel(UARTDM_CR_CMD_RESET_ERR, priv->base + UARTDM_CR);
|
|
|
|
/* We need to fetch new character */
|
|
sr = readl(priv->base + UARTDM_SR);
|
|
|
|
if (sr & UARTDM_SR_RX_READY) {
|
|
/* There are at least 4 bytes in fifo */
|
|
priv->chars_buf = readl(priv->base + UARTDM_RF);
|
|
priv->chars_cnt = 4;
|
|
} else {
|
|
/* Check if there is anything in fifo */
|
|
priv->chars_cnt = readl(priv->base + UARTDM_RXFS);
|
|
/* Extract number of characters in UART packing buffer*/
|
|
priv->chars_cnt = (priv->chars_cnt >>
|
|
UARTDM_RXFS_BUF_SHIFT) &
|
|
UARTDM_RXFS_BUF_MASK;
|
|
if (!priv->chars_cnt)
|
|
return 0;
|
|
|
|
/* There is at least one charcter, move it to fifo */
|
|
writel(UARTDM_CR_CMD_FORCE_STALE,
|
|
priv->base + UARTDM_CR);
|
|
|
|
priv->chars_buf = readl(priv->base + UARTDM_RF);
|
|
writel(UARTDM_CR_CMD_RESET_STALE_INT,
|
|
priv->base + UARTDM_CR);
|
|
writel(0x7, priv->base + UARTDM_DMRX);
|
|
}
|
|
|
|
return priv->chars_cnt;
|
|
}
|
|
|
|
static int msm_serial_getc(struct udevice *dev)
|
|
{
|
|
struct msm_serial_data *priv = dev_get_priv(dev);
|
|
char c;
|
|
|
|
if (!msm_serial_fetch(dev))
|
|
return -EAGAIN;
|
|
|
|
c = priv->chars_buf & 0xFF;
|
|
priv->chars_buf >>= 8;
|
|
priv->chars_cnt--;
|
|
|
|
return c;
|
|
}
|
|
|
|
static int msm_serial_putc(struct udevice *dev, const char ch)
|
|
{
|
|
struct msm_serial_data *priv = dev_get_priv(dev);
|
|
|
|
if (!(readl(priv->base + UARTDM_SR) & UARTDM_SR_TX_EMPTY) &&
|
|
!(readl(priv->base + UARTDM_ISR) & UARTDM_ISR_TX_READY))
|
|
return -EAGAIN;
|
|
|
|
writel(UARTDM_CR_CMD_RESET_TX_READY, priv->base + UARTDM_CR);
|
|
|
|
writel(1, priv->base + UARTDM_NCF_TX);
|
|
writel(ch, priv->base + UARTDM_TF);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int msm_serial_pending(struct udevice *dev, bool input)
|
|
{
|
|
if (input) {
|
|
if (msm_serial_fetch(dev))
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct dm_serial_ops msm_serial_ops = {
|
|
.putc = msm_serial_putc,
|
|
.pending = msm_serial_pending,
|
|
.getc = msm_serial_getc,
|
|
};
|
|
|
|
static int msm_uart_clk_init(struct udevice *dev)
|
|
{
|
|
uint clk_rate = fdtdec_get_uint(gd->fdt_blob, dev_of_offset(dev),
|
|
"clock-frequency", 115200);
|
|
uint clkd[2]; /* clk_id and clk_no */
|
|
int clk_offset;
|
|
struct udevice *clk_dev;
|
|
struct clk clk;
|
|
int ret;
|
|
|
|
ret = fdtdec_get_int_array(gd->fdt_blob, dev_of_offset(dev), "clock",
|
|
clkd, 2);
|
|
if (ret)
|
|
return ret;
|
|
|
|
clk_offset = fdt_node_offset_by_phandle(gd->fdt_blob, clkd[0]);
|
|
if (clk_offset < 0)
|
|
return clk_offset;
|
|
|
|
ret = uclass_get_device_by_of_offset(UCLASS_CLK, clk_offset, &clk_dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
clk.id = clkd[1];
|
|
ret = clk_request(clk_dev, &clk);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = clk_set_rate(&clk, clk_rate);
|
|
clk_free(&clk);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void uart_dm_init(struct msm_serial_data *priv)
|
|
{
|
|
writel(priv->clk_bit_rate, priv->base + UARTDM_CSR);
|
|
writel(0x0, priv->base + UARTDM_MR1);
|
|
writel(MSM_BOOT_UART_DM_8_N_1_MODE, priv->base + UARTDM_MR2);
|
|
writel(MSM_BOOT_UART_DM_CMD_RESET_RX, priv->base + UARTDM_CR);
|
|
writel(MSM_BOOT_UART_DM_CMD_RESET_TX, priv->base + UARTDM_CR);
|
|
|
|
/* Make sure BAM/single character mode is disabled */
|
|
writel(0x0, priv->base + UARTDM_DMEN);
|
|
}
|
|
static int msm_serial_probe(struct udevice *dev)
|
|
{
|
|
int ret;
|
|
struct msm_serial_data *priv = dev_get_priv(dev);
|
|
|
|
/* No need to reinitialize the UART after relocation */
|
|
if (gd->flags & GD_FLG_RELOC)
|
|
return 0;
|
|
|
|
ret = msm_uart_clk_init(dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
pinctrl_select_state(dev, "uart");
|
|
uart_dm_init(priv);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int msm_serial_of_to_plat(struct udevice *dev)
|
|
{
|
|
struct msm_serial_data *priv = dev_get_priv(dev);
|
|
|
|
priv->base = dev_read_addr(dev);
|
|
if (priv->base == FDT_ADDR_T_NONE)
|
|
return -EINVAL;
|
|
|
|
priv->clk_bit_rate = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev),
|
|
"bit-rate", UART_DM_CLK_RX_TX_BIT_RATE);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct udevice_id msm_serial_ids[] = {
|
|
{ .compatible = "qcom,msm-uartdm-v1.4" },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(serial_msm) = {
|
|
.name = "serial_msm",
|
|
.id = UCLASS_SERIAL,
|
|
.of_match = msm_serial_ids,
|
|
.of_to_plat = msm_serial_of_to_plat,
|
|
.priv_auto = sizeof(struct msm_serial_data),
|
|
.probe = msm_serial_probe,
|
|
.ops = &msm_serial_ops,
|
|
};
|