mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-24 13:43:28 +00:00
6da11cc81e
When copying the name of a stdio device we must ensure that it is NUL
terminated before passing it to strcmp() to avoid a buffer overrun.
Truncating the name field leads to failure to deregister a stdio device.
When copying we must ensure that the name field sizes match.
Addresses-Coverity-ID: 350462 String not null terminated
Fixes: 5294e97832 ("stdio: extend "name" to 32 symbols")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
110 lines
2.8 KiB
C
110 lines
2.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* (C) Copyright 2000
|
|
* Paolo Scaffardi, AIRVENT SAM s.p.a - RIMINI(ITALY), arsenio@tin.it
|
|
*/
|
|
|
|
#ifndef _STDIO_DEV_H_
|
|
#define _STDIO_DEV_H_
|
|
|
|
#include <stdio.h>
|
|
#include <linux/list.h>
|
|
|
|
/*
|
|
* STDIO DEVICES
|
|
*/
|
|
|
|
#define DEV_FLAGS_INPUT 0x00000001 /* Device can be used as input console */
|
|
#define DEV_FLAGS_OUTPUT 0x00000002 /* Device can be used as output console */
|
|
#define DEV_FLAGS_DM 0x00000004 /* Device priv is a struct udevice * */
|
|
#define STDIO_NAME_LEN 32
|
|
|
|
int stdio_file_to_flags(const int file);
|
|
|
|
/* Device information */
|
|
struct stdio_dev {
|
|
int flags; /* Device flags: input/output/system */
|
|
int ext; /* Supported extensions */
|
|
char name[STDIO_NAME_LEN]; /* Device name */
|
|
|
|
/* GENERAL functions */
|
|
|
|
int (*start)(struct stdio_dev *dev); /* To start the device */
|
|
int (*stop)(struct stdio_dev *dev); /* To stop the device */
|
|
|
|
/* OUTPUT functions */
|
|
|
|
/* To put a char */
|
|
void (*putc)(struct stdio_dev *dev, const char c);
|
|
/* To put a string (accelerator) */
|
|
void (*puts)(struct stdio_dev *dev, const char *s);
|
|
#ifdef CONFIG_CONSOLE_FLUSH_SUPPORT
|
|
/* To flush output queue */
|
|
void (*flush)(struct stdio_dev *dev);
|
|
#define STDIO_DEV_ASSIGN_FLUSH(dev, flush_func) ((dev)->flush = (flush_func))
|
|
#else
|
|
#define STDIO_DEV_ASSIGN_FLUSH(dev, flush_func)
|
|
#endif
|
|
|
|
/* INPUT functions */
|
|
|
|
/* To test if a char is ready... */
|
|
int (*tstc)(struct stdio_dev *dev);
|
|
int (*getc)(struct stdio_dev *dev); /* To get that char */
|
|
|
|
/* Other functions */
|
|
|
|
void *priv; /* Private extensions */
|
|
struct list_head list;
|
|
};
|
|
|
|
/*
|
|
* VARIABLES
|
|
*/
|
|
extern struct stdio_dev *stdio_devices[];
|
|
extern char *stdio_names[MAX_FILES];
|
|
|
|
/*
|
|
* PROTOTYPES
|
|
*/
|
|
int stdio_register(struct stdio_dev *dev);
|
|
int stdio_register_dev(struct stdio_dev *dev, struct stdio_dev **devp);
|
|
|
|
/**
|
|
* stdio_init_tables() - set up stdio tables ready for devices
|
|
*
|
|
* This does not add any devices, but just prepares stdio for use.
|
|
*/
|
|
int stdio_init_tables(void);
|
|
|
|
/**
|
|
* stdio_add_devices() - Add stdio devices to the table
|
|
*
|
|
* This makes calls to all the various subsystems that use stdio, to make
|
|
* them register with stdio.
|
|
*/
|
|
int stdio_add_devices(void);
|
|
|
|
/**
|
|
* stdio_deregister_dev() - deregister the device "devname".
|
|
*
|
|
* @dev: Stdio device to deregister
|
|
* @force: true to force deregistration even if in use
|
|
*
|
|
* returns 0 on success, -EBUSY if device is assigned
|
|
*/
|
|
int stdio_deregister_dev(struct stdio_dev *dev, int force);
|
|
struct list_head *stdio_get_list(void);
|
|
struct stdio_dev *stdio_get_by_name(const char *name);
|
|
struct stdio_dev *stdio_clone(struct stdio_dev *dev);
|
|
|
|
int drv_lcd_init(void);
|
|
int drv_video_init(void);
|
|
int drv_keyboard_init(void);
|
|
int drv_usbtty_init(void);
|
|
int drv_usbacm_init(void);
|
|
int drv_nc_init(void);
|
|
int drv_jtag_console_init(void);
|
|
int cbmemc_init(void);
|
|
|
|
#endif
|