mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-19 17:53:08 +00:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| MAINTAINERS | ||
| Makefile | ||
| mx6q_4x_mt41j128.cfg | ||
| ot1200.c | ||
| ot1200_spl.c | ||
| README | ||
U-Boot for the Bachmann electronic GmbH OT1200 devices There are two different versions of the base board, which differ in the way ethernet is done. The variant detection is done during runtime based on the address of the found phy. - "mr" variant FEC is connected directly to an ethernet switch (KSZ8895). The ethernet port is always up and auto-negotiation is not possible. - normal variant FEC is connected to a normal phy and auto-negotiation is possible. The variant name is part of the dtb file name loaded by u-boot. This make is possible to boot the linux kernel and make use variant specific devicetree (fixed-phy link). In order to support different display resoltuions/sizes the OT1200 devices are making use of EDID data stored in an i2c EEPROM.