mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-07 05:34:28 +00:00
1630853085
With P2SB the initial BAR (base-address register) is set up by TPL and this is used unchanged right through U-Boot. At present the reading of this address is split between the ofdata() and probe() methods. There are a few problems that are unique to the p2sb. One is that its children need to call pcr_read32(), etc. which needs to have the p2sb address correct. Also some of its children are pinctrl devices and pinctrl is used when any device is probed. So p2sb really needs to get its base address set up in ofdata_to_platdata(), before it is probed. Another point is that reading the p2sb BAR will not work if the p2sb is hidden. The FSP-S seems to hide it, presumably to avoid confusing PCI enumeration. Reading ofdata in ofdata_to_platdata() is the correct place anyway, so this is easy to fix. Move the code into one place and use the early-regs property in all cases for simplicity and to avoid needing to probe any PCI devices just to read the BAR. Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com> Tested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
159 lines
3.8 KiB
C
159 lines
3.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Primary-to-Sideband Bridge
|
|
*
|
|
* Copyright 2019 Google LLC
|
|
*/
|
|
|
|
#define LOG_CATEGORY UCLASS_P2SB
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <dt-structs.h>
|
|
#include <p2sb.h>
|
|
#include <spl.h>
|
|
#include <asm/pci.h>
|
|
|
|
struct p2sb_platdata {
|
|
#if CONFIG_IS_ENABLED(OF_PLATDATA)
|
|
struct dtd_intel_p2sb dtplat;
|
|
#endif
|
|
ulong mmio_base;
|
|
pci_dev_t bdf;
|
|
};
|
|
|
|
/* PCI config space registers */
|
|
#define HPTC_OFFSET 0x60
|
|
#define HPTC_ADDR_ENABLE_BIT BIT(7)
|
|
|
|
/* High Performance Event Timer Configuration */
|
|
#define P2SB_HPTC 0x60
|
|
#define P2SB_HPTC_ADDRESS_ENABLE BIT(7)
|
|
|
|
/*
|
|
* ADDRESS_SELECT ENCODING_RANGE
|
|
* 0 0xfed0 0000 - 0xfed0 03ff
|
|
* 1 0xfed0 1000 - 0xfed0 13ff
|
|
* 2 0xfed0 2000 - 0xfed0 23ff
|
|
* 3 0xfed0 3000 - 0xfed0 33ff
|
|
*/
|
|
#define P2SB_HPTC_ADDRESS_SELECT_0 (0 << 0)
|
|
#define P2SB_HPTC_ADDRESS_SELECT_1 (1 << 0)
|
|
#define P2SB_HPTC_ADDRESS_SELECT_2 (2 << 0)
|
|
#define P2SB_HPTC_ADDRESS_SELECT_3 (3 << 0)
|
|
|
|
/*
|
|
* p2sb_early_init() - Enable decoding for HPET range
|
|
*
|
|
* This is needed by FSP-M which uses the High Precision Event Timer.
|
|
*
|
|
* @dev: P2SB device
|
|
* @return 0 if OK, -ve on error
|
|
*/
|
|
static int p2sb_early_init(struct udevice *dev)
|
|
{
|
|
struct p2sb_platdata *plat = dev_get_platdata(dev);
|
|
pci_dev_t pdev = plat->bdf;
|
|
|
|
/*
|
|
* Enable decoding for HPET memory address range.
|
|
* HPTC_OFFSET(0x60) bit 7, when set the P2SB will decode
|
|
* the High Performance Timer memory address range
|
|
* selected by bits 1:0
|
|
*/
|
|
pci_x86_write_config(pdev, HPTC_OFFSET, HPTC_ADDR_ENABLE_BIT,
|
|
PCI_SIZE_8);
|
|
|
|
/* Enable PCR Base address in PCH */
|
|
pci_x86_write_config(pdev, PCI_BASE_ADDRESS_0, plat->mmio_base,
|
|
PCI_SIZE_32);
|
|
pci_x86_write_config(pdev, PCI_BASE_ADDRESS_1, 0, PCI_SIZE_32);
|
|
|
|
/* Enable P2SB MSE */
|
|
pci_x86_write_config(pdev, PCI_COMMAND, PCI_COMMAND_MASTER |
|
|
PCI_COMMAND_MEMORY, PCI_SIZE_8);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int p2sb_spl_init(struct udevice *dev)
|
|
{
|
|
/* Enable decoding for HPET. Needed for FSP global pointer storage */
|
|
dm_pci_write_config(dev, P2SB_HPTC, P2SB_HPTC_ADDRESS_SELECT_0 |
|
|
P2SB_HPTC_ADDRESS_ENABLE, PCI_SIZE_8);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int p2sb_ofdata_to_platdata(struct udevice *dev)
|
|
{
|
|
struct p2sb_uc_priv *upriv = dev_get_uclass_priv(dev);
|
|
struct p2sb_platdata *plat = dev_get_platdata(dev);
|
|
|
|
#if !CONFIG_IS_ENABLED(OF_PLATDATA)
|
|
int ret;
|
|
u32 base[2];
|
|
|
|
ret = dev_read_u32_array(dev, "early-regs", base, ARRAY_SIZE(base));
|
|
if (ret)
|
|
return log_msg_ret("Missing/short early-regs", ret);
|
|
plat->mmio_base = base[0];
|
|
/* TPL sets up the initial BAR */
|
|
if (spl_phase() == PHASE_TPL) {
|
|
plat->bdf = pci_get_devfn(dev);
|
|
if (plat->bdf < 0)
|
|
return log_msg_ret("Cannot get p2sb PCI address",
|
|
plat->bdf);
|
|
}
|
|
upriv->mmio_base = plat->mmio_base;
|
|
#else
|
|
plat->mmio_base = plat->dtplat.early_regs[0];
|
|
plat->bdf = pci_ofplat_get_devfn(plat->dtplat.reg[0]);
|
|
upriv->mmio_base = plat->mmio_base;
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int p2sb_probe(struct udevice *dev)
|
|
{
|
|
if (spl_phase() == PHASE_TPL)
|
|
return p2sb_early_init(dev);
|
|
else if (spl_phase() == PHASE_SPL)
|
|
return p2sb_spl_init(dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int p2sb_child_post_bind(struct udevice *dev)
|
|
{
|
|
#if !CONFIG_IS_ENABLED(OF_PLATDATA)
|
|
struct p2sb_child_platdata *pplat = dev_get_parent_platdata(dev);
|
|
int ret;
|
|
u32 pid;
|
|
|
|
ret = dev_read_u32(dev, "intel,p2sb-port-id", &pid);
|
|
if (ret)
|
|
return ret;
|
|
pplat->pid = pid;
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct udevice_id p2sb_ids[] = {
|
|
{ .compatible = "intel,p2sb" },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(p2sb_drv) = {
|
|
.name = "intel_p2sb",
|
|
.id = UCLASS_P2SB,
|
|
.of_match = p2sb_ids,
|
|
.probe = p2sb_probe,
|
|
.ofdata_to_platdata = p2sb_ofdata_to_platdata,
|
|
.platdata_auto_alloc_size = sizeof(struct p2sb_platdata),
|
|
.per_child_platdata_auto_alloc_size =
|
|
sizeof(struct p2sb_child_platdata),
|
|
.child_post_bind = p2sb_child_post_bind,
|
|
};
|