mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-17 10:18:38 +00:00
f27bc8afd5
On systems that use CONFIG_OF_LIVE, the "ofnode" type is defined as const struct device_node *np, while on the flat DT systems it is defined as a long of_offset into gd->fdt_blob. It is desirable that the fixed PHY driver uses the higher-level ofnode abstraction instead of parsing gd->fdt_blob directly, because that enables it to work on live OF systems. The fixed PHY driver has used a nasty hack since its introduction in commitdb40c1aa1c("drivers/net/phy: add fixed-phy / fixed-link support"), which is to pass the long gd->fdt_blob offset inside int phydev->addr (a value that normally holds the MDIO bus address at which the PHY responds). Even ignoring the fact that the types were already mismatched leading to a potential truncation (flat OF offset was supposed to be a long and not an int), we really cannot extend this hack any longer, because there's no way an int will hold the other representation of ofnode, the struct device_node *np. So we unfortunately need to do the right thing, which is to use the framework introduced by Grygorii Strashko in commiteef0b8a930("net: phy: add ofnode node to struct phy_device"). This will populate phydev->node for the fixed PHY. Note that phydev->node will not be valid in the probe function, since that is called synchronously from phy_device_create and we really have no way of passing the ofnode directly through the phy_device_create API. So we do what other drivers do too: we move the OF parsing logic from the .probe to the .config method of the PHY driver. The new function will be called at phy_config() time. I do believe I've converted all the possible call paths for creating a PHY with PHY_FIXED_ID, so there is really no reason to maintain compatibility with the old logic of retrieving a flat OF tree offset from phydev->addr. We just pass 0 to phydev->addr now. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Tested-by: Bin Meng <bmeng.cn@gmail.com> Message-Id: <20210216224804.3355044-2-olteanv@gmail.com> [bmeng: keep fixedphy_probe(); update mdio-uclass.c to handle fixed phy] Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
91 lines
1.9 KiB
C
91 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Fixed-Link phy
|
|
*
|
|
* Copyright 2017 Bernecker & Rainer Industrieelektronik GmbH
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <common.h>
|
|
#include <malloc.h>
|
|
#include <phy.h>
|
|
#include <dm.h>
|
|
#include <fdt_support.h>
|
|
#include <asm/global_data.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
int fixedphy_probe(struct phy_device *phydev)
|
|
{
|
|
/* fixed-link phy must not be reset by core phy code */
|
|
phydev->flags |= PHY_FLAG_BROKEN_RESET;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int fixedphy_config(struct phy_device *phydev)
|
|
{
|
|
ofnode node = phy_get_ofnode(phydev);
|
|
struct fixed_link *priv;
|
|
u32 val;
|
|
|
|
if (!ofnode_valid(node))
|
|
return -EINVAL;
|
|
|
|
/* check for mandatory properties within fixed-link node */
|
|
val = ofnode_read_u32_default(node, "speed", 0);
|
|
if (val != SPEED_10 && val != SPEED_100 && val != SPEED_1000 &&
|
|
val != SPEED_2500 && val != SPEED_10000) {
|
|
printf("ERROR: no/invalid speed given in fixed-link node!");
|
|
return -EINVAL;
|
|
}
|
|
|
|
priv = malloc(sizeof(*priv));
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
memset(priv, 0, sizeof(*priv));
|
|
|
|
phydev->priv = priv;
|
|
|
|
priv->link_speed = val;
|
|
priv->duplex = ofnode_read_bool(node, "full-duplex");
|
|
priv->pause = ofnode_read_bool(node, "pause");
|
|
priv->asym_pause = ofnode_read_bool(node, "asym-pause");
|
|
|
|
return 0;
|
|
}
|
|
|
|
int fixedphy_startup(struct phy_device *phydev)
|
|
{
|
|
struct fixed_link *priv = phydev->priv;
|
|
|
|
phydev->asym_pause = priv->asym_pause;
|
|
phydev->pause = priv->pause;
|
|
phydev->duplex = priv->duplex;
|
|
phydev->speed = priv->link_speed;
|
|
phydev->link = 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int fixedphy_shutdown(struct phy_device *phydev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static struct phy_driver fixedphy_driver = {
|
|
.uid = PHY_FIXED_ID,
|
|
.mask = 0xffffffff,
|
|
.name = "Fixed PHY",
|
|
.features = PHY_GBIT_FEATURES | SUPPORTED_MII,
|
|
.probe = fixedphy_probe,
|
|
.config = fixedphy_config,
|
|
.startup = fixedphy_startup,
|
|
.shutdown = fixedphy_shutdown,
|
|
};
|
|
|
|
int phy_fixed_init(void)
|
|
{
|
|
phy_register(&fixedphy_driver);
|
|
return 0;
|
|
}
|