mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-18 18:59:44 +00:00
80cfc6c692
The expected sequence to close the device 1/ Load key in DDR with any supported load command 2/ Update OTP with key: STM32MP> stm32key read <addr> At this point the device is able to perform image authentication but non-authenticated images can still be used and executed. So it is the last moment to test boot with signed binary and check that the ROM code accepts them. 3/ Close the device: only signed binary will be accepted !! STM32MP> stm32key close Warning: Programming these OTP is an irreversible operation! This may brick your system if the HASH of key is invalid This command should be deactivated by default in real product. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
269 lines
5.9 KiB
C
269 lines
5.9 KiB
C
// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
|
|
/*
|
|
* Copyright (C) 2019, STMicroelectronics - All Rights Reserved
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <command.h>
|
|
#include <console.h>
|
|
#include <log.h>
|
|
#include <misc.h>
|
|
#include <dm/device.h>
|
|
#include <dm/uclass.h>
|
|
|
|
/* Closed device : bit 6 of OPT0*/
|
|
#define STM32_OTP_CLOSE_ID 0
|
|
#define STM32_OTP_CLOSE_MASK BIT(6)
|
|
|
|
/* HASH of key: 8 OTPs, starting with OTP24) */
|
|
#define STM32_OTP_HASH_KEY_START 24
|
|
#define STM32_OTP_HASH_KEY_SIZE 8
|
|
|
|
static int get_misc_dev(struct udevice **dev)
|
|
{
|
|
int ret;
|
|
|
|
ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(stm32mp_bsec), dev);
|
|
if (ret)
|
|
log_err("Can't find stm32mp_bsec driver\n");
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void read_hash_value(u32 addr)
|
|
{
|
|
int i;
|
|
|
|
printf("Read KEY at 0x%x\n", addr);
|
|
for (i = 0; i < STM32_OTP_HASH_KEY_SIZE; i++) {
|
|
printf("OTP value %i: %x\n", STM32_OTP_HASH_KEY_START + i,
|
|
__be32_to_cpu(*(u32 *)addr));
|
|
addr += 4;
|
|
}
|
|
}
|
|
|
|
static int read_hash_otp(bool print, bool *locked, bool *closed)
|
|
{
|
|
struct udevice *dev;
|
|
int i, word, ret;
|
|
int nb_invalid = 0, nb_zero = 0, nb_lock = 0;
|
|
u32 val, lock;
|
|
bool status;
|
|
|
|
ret = get_misc_dev(&dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
for (i = 0, word = STM32_OTP_HASH_KEY_START; i < STM32_OTP_HASH_KEY_SIZE; i++, word++) {
|
|
ret = misc_read(dev, STM32_BSEC_OTP(word), &val, 4);
|
|
if (ret != 4)
|
|
val = ~0x0;
|
|
ret = misc_read(dev, STM32_BSEC_LOCK(word), &lock, 4);
|
|
if (ret != 4)
|
|
lock = -1;
|
|
if (print)
|
|
printf("OTP HASH %i: %x lock : %d\n", word, val, lock);
|
|
if (val == ~0x0)
|
|
nb_invalid++;
|
|
else if (val == 0x0)
|
|
nb_zero++;
|
|
if (lock == 1)
|
|
nb_lock++;
|
|
}
|
|
|
|
word = STM32_OTP_CLOSE_ID;
|
|
ret = misc_read(dev, STM32_BSEC_OTP(word), &val, 4);
|
|
if (ret != 4)
|
|
val = 0x0;
|
|
ret = misc_read(dev, STM32_BSEC_LOCK(word), &lock, 4);
|
|
if (ret != 4)
|
|
lock = -1;
|
|
|
|
status = (val & STM32_OTP_CLOSE_MASK) == STM32_OTP_CLOSE_MASK;
|
|
if (closed)
|
|
*closed = status;
|
|
if (print)
|
|
printf("OTP %d: closed status: %d lock : %d\n", word, status, lock);
|
|
|
|
status = (nb_lock == STM32_OTP_HASH_KEY_SIZE);
|
|
if (locked)
|
|
*locked = status;
|
|
if (!status && print)
|
|
printf("Hash of key is not locked!\n");
|
|
|
|
if (nb_invalid == STM32_OTP_HASH_KEY_SIZE) {
|
|
if (print)
|
|
printf("Hash of key is invalid!\n");
|
|
return -EINVAL;
|
|
}
|
|
if (nb_zero == STM32_OTP_HASH_KEY_SIZE) {
|
|
if (print)
|
|
printf("Hash of key is free!\n");
|
|
return -ENOENT;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int fuse_hash_value(u32 addr, bool print)
|
|
{
|
|
struct udevice *dev;
|
|
u32 word, val;
|
|
int i, ret;
|
|
|
|
ret = get_misc_dev(&dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
for (i = 0, word = STM32_OTP_HASH_KEY_START;
|
|
i < STM32_OTP_HASH_KEY_SIZE;
|
|
i++, word++, addr += 4) {
|
|
val = __be32_to_cpu(*(u32 *)addr);
|
|
if (print)
|
|
printf("Fuse OTP %i : %x\n", word, val);
|
|
|
|
ret = misc_write(dev, STM32_BSEC_OTP(word), &val, 4);
|
|
if (ret != 4) {
|
|
log_err("Fuse OTP %i failed\n", word);
|
|
return ret;
|
|
}
|
|
/* on success, lock the OTP for HASH key */
|
|
val = 1;
|
|
ret = misc_write(dev, STM32_BSEC_LOCK(word), &val, 4);
|
|
if (ret != 4) {
|
|
log_err("Lock OTP %i failed\n", word);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int confirm_prog(void)
|
|
{
|
|
puts("Warning: Programming fuses is an irreversible operation!\n"
|
|
" This may brick your system.\n"
|
|
" Use this command only if you are sure of what you are doing!\n"
|
|
"\nReally perform this fuse programming? <y/N>\n");
|
|
|
|
if (confirm_yesno())
|
|
return 1;
|
|
|
|
puts("Fuse programming aborted\n");
|
|
return 0;
|
|
}
|
|
|
|
static int do_stm32key_read(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
|
|
{
|
|
u32 addr;
|
|
|
|
if (argc == 1) {
|
|
read_hash_otp(true, NULL, NULL);
|
|
return CMD_RET_SUCCESS;
|
|
}
|
|
|
|
addr = simple_strtoul(argv[1], NULL, 16);
|
|
if (!addr)
|
|
return CMD_RET_USAGE;
|
|
|
|
read_hash_value(addr);
|
|
|
|
return CMD_RET_SUCCESS;
|
|
}
|
|
|
|
static int do_stm32key_fuse(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
|
|
{
|
|
u32 addr;
|
|
bool yes = false, lock, closed;
|
|
|
|
if (argc < 2)
|
|
return CMD_RET_USAGE;
|
|
|
|
if (argc == 3) {
|
|
if (strcmp(argv[1], "-y"))
|
|
return CMD_RET_USAGE;
|
|
yes = true;
|
|
}
|
|
|
|
addr = simple_strtoul(argv[argc - 1], NULL, 16);
|
|
if (!addr)
|
|
return CMD_RET_USAGE;
|
|
|
|
if (read_hash_otp(!yes, &lock, &closed) != -ENOENT) {
|
|
printf("Error: can't fuse again the OTP\n");
|
|
return CMD_RET_FAILURE;
|
|
}
|
|
|
|
if (lock || closed) {
|
|
printf("Error: invalid OTP configuration (lock=%d, closed=%d)\n", lock, closed);
|
|
return CMD_RET_FAILURE;
|
|
}
|
|
|
|
if (!yes && !confirm_prog())
|
|
return CMD_RET_FAILURE;
|
|
|
|
if (fuse_hash_value(addr, !yes))
|
|
return CMD_RET_FAILURE;
|
|
|
|
printf("Hash key updated !\n");
|
|
|
|
return CMD_RET_SUCCESS;
|
|
}
|
|
|
|
static int do_stm32key_close(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
|
|
{
|
|
bool yes, lock, closed;
|
|
struct udevice *dev;
|
|
u32 val;
|
|
int ret;
|
|
|
|
yes = false;
|
|
if (argc == 2) {
|
|
if (strcmp(argv[1], "-y"))
|
|
return CMD_RET_USAGE;
|
|
yes = true;
|
|
}
|
|
|
|
ret = read_hash_otp(!yes, &lock, &closed);
|
|
if (ret) {
|
|
if (ret == -ENOENT)
|
|
printf("Error: OTP not programmed!\n");
|
|
return CMD_RET_FAILURE;
|
|
}
|
|
|
|
if (closed) {
|
|
printf("Error: already closed!\n");
|
|
return CMD_RET_FAILURE;
|
|
}
|
|
|
|
if (!lock)
|
|
printf("Warning: OTP not locked!\n");
|
|
|
|
if (!yes && !confirm_prog())
|
|
return CMD_RET_FAILURE;
|
|
|
|
ret = get_misc_dev(&dev);
|
|
if (ret)
|
|
return CMD_RET_FAILURE;
|
|
|
|
val = STM32_OTP_CLOSE_MASK;
|
|
ret = misc_write(dev, STM32_BSEC_OTP(STM32_OTP_CLOSE_ID), &val, 4);
|
|
if (ret != 4) {
|
|
printf("Error: can't update OTP\n");
|
|
return CMD_RET_FAILURE;
|
|
}
|
|
|
|
printf("Device is closed !\n");
|
|
|
|
return CMD_RET_SUCCESS;
|
|
}
|
|
|
|
static char stm32key_help_text[] =
|
|
"read [<addr>]: Read the hash stored at addr in memory or in OTP\n"
|
|
"stm32key fuse [-y] <addr> : Fuse hash stored at addr in OTP\n"
|
|
"stm32key close [-y] : Close the device, the hash stored in OTP\n";
|
|
|
|
U_BOOT_CMD_WITH_SUBCMDS(stm32key, "Fuse ST Hash key", stm32key_help_text,
|
|
U_BOOT_SUBCMD_MKENT(read, 2, 0, do_stm32key_read),
|
|
U_BOOT_SUBCMD_MKENT(fuse, 3, 0, do_stm32key_fuse),
|
|
U_BOOT_SUBCMD_MKENT(close, 2, 0, do_stm32key_close));
|